| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-08-18 | |||
| 15:00:26 | sean-k-mooney | stephenfin: the xml will be different depeing on what vnic type your dealing with by the way | |
| 15:01:05 | sean-k-mooney | vnic_type=direct use <interface type=hostdev> with a source address and top level address | |
| 15:01:35 | sean-k-mooney | vnic_type=macvtap use <interface type=direct> with a source netdev and top level address | |
| 15:01:38 | stephenfin | there's our incomplete mock https://github.com/openstack/nova/blob/master/nova/tests/unit/virt/libvirt/fakelibvirt.py#L1132-L1140 | |
| 15:02:07 | sean-k-mooney | vnic_type=direct-physical uses <hostdev> with two addresses | |
| 15:02:41 | sean-k-mooney | stephenfin: well its not incomplete | |
| 15:02:51 | sean-k-mooney | stephenfin: we dont set the adress elements | |
| 15:02:56 | sean-k-mooney | stephenfin: libvirt adds them | |
| 15:03:10 | sean-k-mooney | so for unit tests that actully correct | |
| 15:03:43 | stephenfin | Fair | |
| 15:03:52 | sean-k-mooney | that said you can poroably just add the address element and increment the pci address for each device | |
| 15:04:04 | sean-k-mooney | i dont think that matters too much | |
| 15:04:06 | openstackgerrit | Luigi Toscano proposed openstack/python-novaclient master: zuul functional job: drop the custom playbooks https://review.opendev.org/746649 | |
| 15:05:06 | sean-k-mooney | stephenfin: if it helps with the functial tests and its not too intrusive you might as well make it emulate the populated behvior we see when w read it back | |
| 15:32:44 | mnaser | lyarwood: i jinxed it, it's broken -- python3-rbd : Depends: librbd1 (>= 14.2.11-1bionic) but 12.2.13-0ubuntu0.18.04.2 is to be installed | |
| 15:54:40 | sean-k-mooney | stephenfin: just passed zull https://review.opendev.org/#/c/728037/ when you have time to re+2 | |
| 16:14:28 | stephenfin | sean-k-mooney: done | |
| 16:30:23 | sean-k-mooney | stephenfin: thanks :) | |
| 16:44:29 | openstackgerrit | Douglas Mendizábal proposed openstack/nova master: Fix indentation nits https://review.opendev.org/746765 | |
| 17:58:05 | openstackgerrit | Merged openstack/nova master: Remove six.PY2 and six.PY3 https://review.opendev.org/726512 | |
| 17:58:13 | openstackgerrit | Merged openstack/nova master: Remove six.add_metaclass https://review.opendev.org/726565 | |
| 17:58:24 | openstackgerrit | Merged openstack/nova master: Remove six.reraise https://review.opendev.org/726898 | |
| 19:03:23 | lyarwood | stephenfin: still about? | |
| 19:03:53 | lyarwood | stephenfin: https://review.opendev.org/#/c/746210/ can you yank that out of the gate and I'll address the style nits | |
| 19:05:27 | lyarwood | hmm actually if I just push another PS that should do it | |
| 19:10:48 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Do not reference VIR_ERR_DEVICE_MISSING when libvirt is < v4.1.0 https://review.opendev.org/746210 | |
| 19:12:49 | lyarwood | ^ melwitt / dansmith / stephenfin ; ^ dropped the newline stuff, something to talk about at the PTG anyway as we've landed lots of this from stephenfin already this cycle :) | |
| 19:13:25 | lyarwood | there doesn't appear to be a pep8 rule for this btw so I'm not sure how we'd enforce this either way | |
| 19:44:15 | openstackgerrit | Lee Yarwood proposed openstack/nova master: DNM zuul: Enable [glance]/allowed_direct_url_schemes within nova-ceph-multistore https://review.opendev.org/743220 | |
| 20:22:05 | iurygregory | hey nova folks =) in ironic we are trying to create specific flavors (according to the boot_option that is set on capabilities) and I'm facing some problems with No valid host since nova filters doesn't match https://zuul.opendev.org/t/openstack/build/65e4cb538b7149d48f0942e8639b9bb3/log/controller/logs/screen-n-sch.txt#864 any ideas on how I can solve this? =) | |
| 20:22:34 | iurygregory | I have the feeling I need to do something on tempest to make it work but I have no idea what it would be =) (metadata didn't work) , https://review.opendev.org/741445 | |
| 20:23:07 | iurygregory | in this one https://review.opendev.org/741886 I'm testing the changes from tempest | |
| 20:51:22 | sean-k-mooney | iurygregory: what did the flavor look like | |
| 20:52:06 | sean-k-mooney | "cpu_arch"="$ironic_node_arch" | |
| 20:52:10 | sean-k-mooney | that is proaby the issue | |
| 20:52:26 | sean-k-mooney | that has no prifix so the compute capablity filter will match on it | |
| 20:52:43 | sean-k-mooney | using un namespaced extra specs is discuraged | |
| 20:53:11 | sean-k-mooney | it should not be done if usign either the compute capablity filter or aggreate instance extra specs filter | |
| 20:55:43 | sean-k-mooney | iurygregory: did you add the capablites to the host. can you point to them in any of the logs | |
| 20:56:06 | sean-k-mooney | it just looks like they dont match but there is very little to go on | |
| 21:06:35 | openstackgerrit | Douglas Mendizábal proposed openstack/nova stable/train: Allow TLS ciphers/protocols to be configurable for console proxies https://review.opendev.org/746798 | |
| 21:12:12 | iurygregory | shummm | |
| 21:12:19 | iurygregory | let me check here sean-k-mooney | |
| 21:12:52 | iurygregory | we are creating the flavors in https://review.opendev.org/#/c/741886/9/devstack/lib/ironic | |
| 21:13:21 | sean-k-mooney | yep but where are you setting the capablities on the compute nodes | |
| 21:13:28 | sean-k-mooney | i assume that is done via ironic | |
| 21:13:32 | iurygregory | the additional thing is that now our flavors will have the capabilities:boot_option=local/netboot | |
| 21:13:50 | iurygregory | we also set in the ironic node | |
| 21:13:52 | sean-k-mooney | right which will enable the computecablities filter | |
| 21:13:54 | iurygregory | so it would match | |
| 21:14:28 | sean-k-mooney | can you show in the logs that they are being set | |
| 21:16:05 | sean-k-mooney | https://zuul.opendev.org/t/openstack/build/65e4cb538b7149d48f0942e8639b9bb3/log/controller/logs/devstacklog.txt#30847 | |
| 21:16:17 | openstackgerrit | Douglas Mendizábal proposed openstack/nova stable/stein: Allow TLS ciphers/protocols to be configurable for console proxies https://review.opendev.org/746800 | |
| 21:16:25 | sean-k-mooney | iurygregory: uefi is beeing set | |
| 21:17:07 | iurygregory | sean-k-mooney, this job is with uefi | |
| 21:17:09 | sean-k-mooney | iurygregory: but i dont see the boot_option | |
| 21:17:16 | iurygregory | oh O.o | |
| 21:18:15 | sean-k-mooney | https://zuul.opendev.org/t/openstack/build/65e4cb538b7149d48f0942e8639b9bb3/log/controller/logs/devstacklog.txt#31101 | |
| 21:18:37 | sean-k-mooney | that is the only use of capabilities:boot_option=netboot | |
| 21:19:02 | iurygregory | oh it's because tempest was suposed to update ... | |
| 21:19:22 | iurygregory | with the patch https://review.opendev.org/#/c/741445/23/ironic_tempest_plugin/tests/scenario/baremetal_manager.py | |
| 21:19:36 | iurygregory | I thought this was working o.o | |
| 21:20:35 | sean-k-mooney | the ironic_tempest_plugin was installed form pip | |
| 21:20:47 | sean-k-mooney | https://zuul.opendev.org/t/openstack/build/65e4cb538b7149d48f0942e8639b9bb3/log/controller/logs/devstacklog.txt#32985-32988 | |
| 21:20:50 | sean-k-mooney | i think | |
| 21:21:24 | sean-k-mooney | actully maybe not | |
| 21:21:39 | sean-k-mooney | iurygregory: what repo is this job defined in | |
| 21:21:42 | sean-k-mooney | ironic? | |
| 21:21:53 | iurygregory | sean-k-mooney, yeah | |
| 21:22:11 | sean-k-mooney | im wondiering it it listed as a require_project | |
| 21:22:22 | sean-k-mooney | withiout that depends-on does not work | |
| 21:22:46 | iurygregory | it does have Depends-On | |
| 21:22:58 | iurygregory | ironic has Depends-On on the ironic-tempest-plugin change | |
| 21:23:12 | iurygregory | tempest https://review.opendev.org/#/c/741445 ironic https://review.opendev.org/#/c/741886 | |
| 21:23:18 | sean-k-mooney | yep but yyou need to add https://github.com/openstack/ironic/blob/master/zuul.d/ironic-jobs.yaml#L13 to the job or it does not work | |
| 21:23:26 | sean-k-mooney | in this case its there | |
| 21:25:36 | sean-k-mooney | so this plugin is being instealled in the tempet virtual env | |
| 21:25:39 | sean-k-mooney | https://zuul.opendev.org/t/openstack/build/65e4cb538b7149d48f0942e8639b9bb3/log/controller/logs/devstacklog.txt#32903-32924 | |
| 21:26:08 | iurygregory | yeah, seems like tempest is not updating the node with the boot_option... | |
| 21:26:16 | sean-k-mooney | i think its correctly installing it tox -evenv-tempest -- pip install -c /tmp/tempest_u_c_m.37WJbEB0sa /opt/stack/ironic-tempest-plugin | |
| 21:26:28 | sean-k-mooney | that using the version cloned by zuul | |
| 21:28:25 | sean-k-mooney | iurygregory: have you defiend the required tempest config options | |
| 21:28:26 | iurygregory | yeah the version installed is correct (at least the logs shows "23adec07f1d5998951fe841cd68989c6d85f7d98 Update basic_ops" | |
| 21:28:55 | iurygregory | yeah, I checked the config and it does look correct | |
| 21:30:04 | iurygregory | I double checked with the job-output.txt the flavors are correct | |
| 21:30:08 | sean-k-mooney | https://zuul.opendev.org/t/openstack/build/65e4cb538b7149d48f0942e8639b9bb3/log/controller/logs/tempest_conf.txt#141-144 | |
| 21:30:10 | iurygregory | uuid etc | |
| 21:30:24 | sean-k-mooney | so ya it looks like they are set correctly | |
| 21:31:18 | sean-k-mooney | so this is what is ment to set the caps https://review.opendev.org/#/c/741445/23/ironic_tempest_plugin/tests/scenario/baremetal_manager.py@205 | |
| 21:32:46 | sean-k-mooney | https://review.opendev.org/#/c/741445/23/ironic_tempest_plugin/tests/scenario/baremetal_manager.py@174 | |
| 21:32:54 | sean-k-mooney | by default it does not set teh caps | |
| 21:33:14 | iurygregory | yeah, but the test sends True | |
| 21:33:42 | iurygregory | https://review.opendev.org/#/c/741445/23/ironic_tempest_plugin/tests/scenario/test_baremetal_basic_ops.py@208 | |
| 21:33:45 | sean-k-mooney | yes https://review.opendev.org/#/c/741445/23/ironic_tempest_plugin/tests/scenario/test_baremetal_basic_ops.py@208 | |
| 21:34:08 | iurygregory | at least it should send =) | |
| 21:35:13 | sean-k-mooney | does the compute capablity filter requrie all cap to be requested | |
| 21:35:45 | iurygregory | this information I don't know =) | |
| 21:36:15 | sean-k-mooney | i was wonderinf it the default falvor was failing but no | |
| 21:36:26 | sean-k-mooney | the only failing tests are teh new ones | |
| 21:36:46 | sean-k-mooney | well actully | |