| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-08-18 | |||
| 14:49:21 | stephenfin | interface_dev is the lxml.etree representation of http://paste.openstack.org/show/796916/ | |
| 14:50:10 | stephenfin | so '.find('address') should read '.find('source/address')' (or whatever the correct incantation is), no? | |
| 14:50:44 | sean-k-mooney | stephenfin: let me check the libvirt docs | |
| 14:51:34 | sean-k-mooney | <interface type='bridge'> | |
| 14:51:36 | sean-k-mooney | <source bridge='br1'/> | |
| 14:51:38 | sean-k-mooney | <target dev='vnet7'/> | |
| 14:51:40 | sean-k-mooney | <mac address="00:11:22:33:44:55"/> | |
| 14:51:42 | sean-k-mooney | </interface> | |
| 14:51:44 | sean-k-mooney | addrss is in the mac eleemnt for linux bridge too | |
| 14:53:31 | sean-k-mooney | oh that is proably looking up the device by pci adress? | |
| 14:53:40 | stephenfin | yeah, this is PCI address | |
| 14:53:49 | sean-k-mooney | the target pci adress? | |
| 14:54:00 | sean-k-mooney | something like this <address type='pci' domain='0' bus='0' slot='4' function='0' multifunction='on'/> | |
| 14:54:06 | stephenfin | yup | |
| 14:54:25 | stephenfin | The comment says "Save off the hw address and MTU presented to the guest since that can't change during live migration." | |
| 14:54:35 | stephenfin | but the place it's getting the hw address from seems wrong :-\ | |
| 14:54:54 | sean-k-mooney | the hardware adress normaly means mac address | |
| 14:55:17 | sean-k-mooney | interface_nodes = xml_doc.findall('./devices/interface') | |
| 14:55:28 | sean-k-mooney | so ya that looking for an address element in the interface | |
| 14:55:39 | sean-k-mooney | but they could be saving the guest pci address | |
| 14:55:53 | sean-k-mooney | this is populated by libvirt | |
| 14:56:00 | sean-k-mooney | let me check a vm quickly | |
| 14:56:13 | stephenfin | ah, so there are multiple address. Okay, that makes sense. | |
| 14:56:19 | stephenfin | *address elements | |
| 14:56:35 | sean-k-mooney | yes there is a top level one for the target adress to present the device in the guest | |
| 14:56:47 | sean-k-mooney | and then a sub elemen inside the source element which is the host address | |
| 14:57:02 | stephenfin | and parsing code for it here https://github.com/openstack/nova/blob/master/nova/virt/libvirt/config.py#L1891-L1893 | |
| 14:57:08 | stephenfin | so bad mocks again | |
| 14:57:39 | sean-k-mooney | http://paste.openstack.org/show/796917/ | |
| 14:57:45 | sean-k-mooney | that is what an ovs interface looks like | |
| 14:58:05 | sean-k-mooney | if needed i can stack my sriov host but it will looke more or less the same | |
| 14:58:36 | sean-k-mooney | its getting the element as line 11 | |
| 14:59:30 | stephenfin | sean-k-mooney++ ta | |
| 14:59:36 | stephenfin | definitely bad mocks so | |
| 15:00:26 | sean-k-mooney | stephenfin: the xml will be different depeing on what vnic type your dealing with by the way | |
| 15:01:05 | sean-k-mooney | vnic_type=direct use <interface type=hostdev> with a source address and top level address | |
| 15:01:35 | sean-k-mooney | vnic_type=macvtap use <interface type=direct> with a source netdev and top level address | |
| 15:01:38 | stephenfin | there's our incomplete mock https://github.com/openstack/nova/blob/master/nova/tests/unit/virt/libvirt/fakelibvirt.py#L1132-L1140 | |
| 15:02:07 | sean-k-mooney | vnic_type=direct-physical uses <hostdev> with two addresses | |
| 15:02:41 | sean-k-mooney | stephenfin: well its not incomplete | |
| 15:02:51 | sean-k-mooney | stephenfin: we dont set the adress elements | |
| 15:02:56 | sean-k-mooney | stephenfin: libvirt adds them | |
| 15:03:10 | sean-k-mooney | so for unit tests that actully correct | |
| 15:03:43 | stephenfin | Fair | |
| 15:03:52 | sean-k-mooney | that said you can poroably just add the address element and increment the pci address for each device | |
| 15:04:04 | sean-k-mooney | i dont think that matters too much | |
| 15:04:06 | openstackgerrit | Luigi Toscano proposed openstack/python-novaclient master: zuul functional job: drop the custom playbooks https://review.opendev.org/746649 | |
| 15:05:06 | sean-k-mooney | stephenfin: if it helps with the functial tests and its not too intrusive you might as well make it emulate the populated behvior we see when w read it back | |
| 15:32:44 | mnaser | lyarwood: i jinxed it, it's broken -- python3-rbd : Depends: librbd1 (>= 14.2.11-1bionic) but 12.2.13-0ubuntu0.18.04.2 is to be installed | |
| 15:54:40 | sean-k-mooney | stephenfin: just passed zull https://review.opendev.org/#/c/728037/ when you have time to re+2 | |
| 16:14:28 | stephenfin | sean-k-mooney: done | |
| 16:30:23 | sean-k-mooney | stephenfin: thanks :) | |
| 16:44:29 | openstackgerrit | Douglas Mendizábal proposed openstack/nova master: Fix indentation nits https://review.opendev.org/746765 | |
| 17:58:05 | openstackgerrit | Merged openstack/nova master: Remove six.PY2 and six.PY3 https://review.opendev.org/726512 | |
| 17:58:13 | openstackgerrit | Merged openstack/nova master: Remove six.add_metaclass https://review.opendev.org/726565 | |
| 17:58:24 | openstackgerrit | Merged openstack/nova master: Remove six.reraise https://review.opendev.org/726898 | |
| 19:03:23 | lyarwood | stephenfin: still about? | |
| 19:03:53 | lyarwood | stephenfin: https://review.opendev.org/#/c/746210/ can you yank that out of the gate and I'll address the style nits | |
| 19:05:27 | lyarwood | hmm actually if I just push another PS that should do it | |
| 19:10:48 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Do not reference VIR_ERR_DEVICE_MISSING when libvirt is < v4.1.0 https://review.opendev.org/746210 | |
| 19:12:49 | lyarwood | ^ melwitt / dansmith / stephenfin ; ^ dropped the newline stuff, something to talk about at the PTG anyway as we've landed lots of this from stephenfin already this cycle :) | |
| 19:13:25 | lyarwood | there doesn't appear to be a pep8 rule for this btw so I'm not sure how we'd enforce this either way | |
| 19:44:15 | openstackgerrit | Lee Yarwood proposed openstack/nova master: DNM zuul: Enable [glance]/allowed_direct_url_schemes within nova-ceph-multistore https://review.opendev.org/743220 | |
| 20:22:05 | iurygregory | hey nova folks =) in ironic we are trying to create specific flavors (according to the boot_option that is set on capabilities) and I'm facing some problems with No valid host since nova filters doesn't match https://zuul.opendev.org/t/openstack/build/65e4cb538b7149d48f0942e8639b9bb3/log/controller/logs/screen-n-sch.txt#864 any ideas on how I can solve this? =) | |
| 20:22:34 | iurygregory | I have the feeling I need to do something on tempest to make it work but I have no idea what it would be =) (metadata didn't work) , https://review.opendev.org/741445 | |
| 20:23:07 | iurygregory | in this one https://review.opendev.org/741886 I'm testing the changes from tempest | |
| 20:51:22 | sean-k-mooney | iurygregory: what did the flavor look like | |
| 20:52:06 | sean-k-mooney | "cpu_arch"="$ironic_node_arch" | |
| 20:52:10 | sean-k-mooney | that is proaby the issue | |
| 20:52:26 | sean-k-mooney | that has no prifix so the compute capablity filter will match on it | |
| 20:52:43 | sean-k-mooney | using un namespaced extra specs is discuraged | |
| 20:53:11 | sean-k-mooney | it should not be done if usign either the compute capablity filter or aggreate instance extra specs filter | |
| 20:55:43 | sean-k-mooney | iurygregory: did you add the capablites to the host. can you point to them in any of the logs | |
| 20:56:06 | sean-k-mooney | it just looks like they dont match but there is very little to go on | |
| 21:06:35 | openstackgerrit | Douglas Mendizábal proposed openstack/nova stable/train: Allow TLS ciphers/protocols to be configurable for console proxies https://review.opendev.org/746798 | |
| 21:12:12 | iurygregory | shummm | |
| 21:12:19 | iurygregory | let me check here sean-k-mooney | |
| 21:12:52 | iurygregory | we are creating the flavors in https://review.opendev.org/#/c/741886/9/devstack/lib/ironic | |
| 21:13:21 | sean-k-mooney | yep but where are you setting the capablities on the compute nodes | |
| 21:13:28 | sean-k-mooney | i assume that is done via ironic | |
| 21:13:32 | iurygregory | the additional thing is that now our flavors will have the capabilities:boot_option=local/netboot | |
| 21:13:50 | iurygregory | we also set in the ironic node | |
| 21:13:52 | sean-k-mooney | right which will enable the computecablities filter | |
| 21:13:54 | iurygregory | so it would match | |
| 21:14:28 | sean-k-mooney | can you show in the logs that they are being set | |
| 21:16:05 | sean-k-mooney | https://zuul.opendev.org/t/openstack/build/65e4cb538b7149d48f0942e8639b9bb3/log/controller/logs/devstacklog.txt#30847 | |
| 21:16:17 | openstackgerrit | Douglas Mendizábal proposed openstack/nova stable/stein: Allow TLS ciphers/protocols to be configurable for console proxies https://review.opendev.org/746800 | |
| 21:16:25 | sean-k-mooney | iurygregory: uefi is beeing set | |
| 21:17:07 | iurygregory | sean-k-mooney, this job is with uefi | |
| 21:17:09 | sean-k-mooney | iurygregory: but i dont see the boot_option | |
| 21:17:16 | iurygregory | oh O.o | |
| 21:18:15 | sean-k-mooney | https://zuul.opendev.org/t/openstack/build/65e4cb538b7149d48f0942e8639b9bb3/log/controller/logs/devstacklog.txt#31101 | |
| 21:18:37 | sean-k-mooney | that is the only use of capabilities:boot_option=netboot | |
| 21:19:02 | iurygregory | oh it's because tempest was suposed to update ... | |
| 21:19:22 | iurygregory | with the patch https://review.opendev.org/#/c/741445/23/ironic_tempest_plugin/tests/scenario/baremetal_manager.py | |
| 21:19:36 | iurygregory | I thought this was working o.o | |
| 21:20:35 | sean-k-mooney | the ironic_tempest_plugin was installed form pip | |
| 21:20:47 | sean-k-mooney | https://zuul.opendev.org/t/openstack/build/65e4cb538b7149d48f0942e8639b9bb3/log/controller/logs/devstacklog.txt#32985-32988 | |
| 21:20:50 | sean-k-mooney | i think | |
| 21:21:24 | sean-k-mooney | actully maybe not | |