| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-08-07 | |||
| 13:45:28 | gmann | thanks gibi or all the reviews on policy work and updating FIP one. | |
| 13:45:46 | gibi | gmann: thanks for proposing these patches | |
| 13:46:41 | sean-k-mooney | mnaser: the vaule in the service catalog will have to point to the ha proxy ip | |
| 13:46:43 | gmann | gibi: I will do the audit of some TODO/cleanup if there us any by Monday/Tuesday and then we can mark that BP complete. | |
| 13:47:08 | mnaser | sean-k-mooney: so i guess i just have to put in credentials in there the same way that the [neutron] section is filled out with a username/pw/etc? | |
| 13:47:09 | sean-k-mooney | mnaser: you cant list the mupltile api service in the catalonge and get teh same loadbalncing behavior | |
| 13:47:13 | gibi | gmann: cool. thanks | |
| 13:47:40 | mnaser | sean-k-mooney: right, but in my case, we use k8s and the internal api endpoint will always forward to one of the three pods running glance (serviceip) | |
| 13:48:02 | sean-k-mooney | ah ok ya that works | |
| 13:48:22 | mnaser | it would be nice if we can have one section that nova uses for all services | |
| 13:48:37 | mnaser | for those deployments where it makes sense | |
| 13:48:38 | sean-k-mooney | then i think ya you just need to set the auth values but not set the api url | |
| 13:49:00 | mnaser | what's interesting is my current glance section actually has no credentials, only api_servers | |
| 13:49:04 | sean-k-mooney | you might be able to abuse service user for that | |
| 13:49:08 | mnaser | so i wonder where the credentials is being used | |
| 13:49:42 | sean-k-mooney | most of the time it would use the users token and not need them | |
| 13:49:53 | sean-k-mooney | for neutron we do some admin only api calls which need it | |
| 13:50:04 | mnaser | oh yes you're right, i forgot about that | |
| 13:50:21 | sean-k-mooney | for glance i did not think we did but maybe we do for multiple locations | |
| 13:50:46 | mnaser | i think that uses the service_user codebase, | |
| 13:51:02 | sean-k-mooney | i think the rbd direct url/ multi location stuff is either admin only or configurable | |
| 13:51:13 | mnaser | you can configure glance to expose the url | |
| 13:51:18 | mnaser | so i think its not necessarily | |
| 13:51:39 | sean-k-mooney | so what i was suggesting with service_user was | |
| 13:51:54 | sean-k-mooney | if you did not set any other admin auth tokens | |
| 13:52:11 | sean-k-mooney | im not sure if setting service_user config options would be enough | |
| 13:52:20 | sean-k-mooney | if you use the same admin user for all services that is | |
| 13:52:38 | sean-k-mooney | i have never really checked if that would work. | |
| 13:53:04 | mnaser | sean-k-mooney: im actually hoping for a world where we deploy services using app credentials | |
| 13:53:08 | mnaser | based off the main 'admin' user | |
| 13:53:11 | mnaser | essentially its the same thing anyways | |
| 13:55:19 | sean-k-mooney | mnaser: that technical shoudl already work right | |
| 13:55:57 | sean-k-mooney | when you create app creds dont you get a new user name and passward you could use | |
| 13:56:06 | sean-k-mooney | or do you jsut get a bearer token | |
| 13:56:21 | sean-k-mooney | its been quite a while since i looked at them | |
| 13:57:43 | sean-k-mooney | but ya that would be quite nice if it coudl be made to work | |
| 13:58:50 | sean-k-mooney | mnaser: https://docs.openstack.org/keystoneauth/latest/authentication-plugins.html | |
| 13:59:05 | mnaser | sean-k-mooney: it actually should 100% work :) | |
| 13:59:11 | mnaser | keystoneauth does support it yeah | |
| 14:07:09 | openstackgerrit | Stephen Finucane proposed openstack/nova master: compute: Add type hints for resize functions https://review.opendev.org/745341 | |
| 14:07:09 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Don't unset Instance.old_flavor, new_flavor until necessary https://review.opendev.org/744958 | |
| 14:07:09 | openstack | bug 1879878 in OpenStack Compute (nova) "VM become Error after confirming resize with Error info CPUUnpinningInvalid on source node " [Medium,In progress] https://launchpad.net/bugs/1879878 - Assigned to Stephen Finucane (stephenfinucane) | |
| 14:07:09 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Add reproducer for bug #1879878 https://review.opendev.org/744950 | |
| 14:31:22 | lyarwood | elod: https://review.opendev.org/#/q/topic:bug/1889108+status:open - would you have anytime to look at this today | |
| 14:31:52 | lyarwood | elod: I'm including a number of func test refactors here as I'd like to keep things sane going back to stable/train | |
| 14:37:54 | openstackgerrit | Merged openstack/nova master: Add test coverage of tenant networks policies https://review.opendev.org/742765 | |
| 14:38:01 | openstackgerrit | Merged openstack/nova master: Introduce scope_types in tenant networks policy https://review.opendev.org/742766 | |
| 14:38:10 | openstackgerrit | Merged openstack/nova master: Add new default roles in tenant networks policies https://review.opendev.org/742771 | |
| 14:38:27 | openstackgerrit | Merged openstack/nova master: Add test coverage of security_groups policies https://review.opendev.org/742726 | |
| 14:38:34 | openstackgerrit | Merged openstack/nova master: Introduce scope_types in security_groups policy https://review.opendev.org/742757 | |
| 14:40:55 | elod | lyarwood: sure, looking! | |
| 14:41:14 | lyarwood | elod: thanks! :) | |
| 15:24:31 | gibi | I'm wrapping up my week now. I'll be on PTO during the next two weeks. See you around 24th! | |
| 15:53:07 | openstackgerrit | Merged openstack/nova master: Add new default roles in security_groups policies https://review.opendev.org/742763 | |
| 15:53:14 | openstackgerrit | Merged openstack/nova master: Pass the actual target in security_groups policy https://review.opendev.org/742764 | |
| 15:53:21 | openstackgerrit | Merged openstack/nova master: Add test coverage of networks policies https://review.opendev.org/742558 | |
| 15:53:32 | openstackgerrit | Merged openstack/nova master: Introduce scope_types in networks policy https://review.opendev.org/742561 | |
| 15:53:51 | openstackgerrit | Merged openstack/nova master: Add test coverage of volumes policies https://review.opendev.org/742773 | |
| 15:53:58 | openstackgerrit | Merged openstack/nova master: Introduce scope_types in volumes policy https://review.opendev.org/742774 | |
| 15:58:06 | openstackgerrit | Merged openstack/nova master: Add new default roles in volumes policies https://review.opendev.org/742777 | |
| 16:10:23 | elod | lyarwood: all good and +2'd :] | |
| 16:29:54 | openstackgerrit | Merged openstack/nova master: Add test coverage of hosts policies https://review.opendev.org/743013 | |
| 17:14:15 | openstackgerrit | Elancheran S proposed openstack/nova master: Removes the delta file once image is extracted https://review.opendev.org/734421 | |
| 17:18:28 | openstackgerrit | Merged openstack/nova master: Introduce scope_types in hosts policy https://review.opendev.org/743014 | |
| 17:19:56 | lyarwood | elod: thanks :) | |
| 17:26:29 | smcginnis | Anyone know if the AOE and DISCO libvirt volume drivers are still used/supported? | |
| 17:26:39 | smcginnis | They were both dropped from Cinder a long, long time ago. | |
| 17:27:00 | smcginnis | I was looking at cleaning up some remnants in os-brick, but it looks like there is still some code present in nova. | |
| 17:31:29 | sean-k-mooney | smcginnis: if they were droped form cinder then its dead code | |
| 17:31:42 | lyarwood | I think they are only in nova because they were in cinder and os-brick so rm -rf away | |
| 17:31:51 | lyarwood | yeah | |
| 17:32:47 | sean-k-mooney | smcginnis: nova only uses os-brick for cinder volumes. if the cinder backend is remvoe then the nova code is nolonger useful in general unlesss the code is shared | |
| 17:33:17 | sean-k-mooney | also wehn i see AOE i think fo Age of Empires | |
| 17:34:02 | lyarwood | same haha | |
| 17:35:13 | melwitt | Area Of Effect | |
| 17:41:39 | lyarwood | ^_^ | |
| 17:43:55 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: migrate testing to ubuntu focal https://review.opendev.org/738126 | |
| 17:54:27 | openstackgerrit | Merged openstack/nova master: Add new default roles in hosts policies https://review.opendev.org/743015 | |
| 17:54:33 | openstackgerrit | Merged openstack/nova master: Add test coverage of extensions policies https://review.opendev.org/743045 | |
| 18:01:24 | lyarwood | melwitt: https://review.opendev.org/#/q/topic:bug/1889108+status:open - would you mind taking a look at that today if you have time | |
| 18:01:43 | melwitt | lyarwood: sure thing | |
| 18:02:55 | lyarwood | thanks | |
| 18:06:12 | smcginnis | sean-k-mooney, lyarwood: Thanks, sounds good. | |
| 18:06:38 | smcginnis | Do you think it needs to go through a deprecation cycle in nova? Or since it's just dead code anyway, all clear to just clean it out? | |
| 18:08:11 | lyarwood | smcginnis: I think we can just remove it tbh | |
| 18:09:26 | smcginnis | Sounds good. I'll put up something to do that. Then we can see if anyone has any objects on the patch. | |
| 18:09:33 | lyarwood | smcginnis: the only way of loading these volume drivers is through cinder providing connection_info with driver_volume_type set to aoe or disco https://github.com/openstack/nova/blob/09ed4c21db5005b1c699a87bfb0e7cb051553342/nova/virt/libvirt/driver.py#L1593-L1597 | |
| 18:09:56 | lyarwood | smcginnis: if the c-vol drivers are dead then that can't happen | |
| 18:09:57 | smcginnis | Ah, that's how that works. Thanks, I've never dug into the nova side of these things. | |
| 18:10:07 | smcginnis | So this really has been dead code for quite awhile then. | |
| 18:10:12 | lyarwood | yup | |
| 18:11:18 | lyarwood | smcginnis: actually thinking about it they were dropped more than a release ago from cinder right? | |
| 18:11:42 | smcginnis | Yeah. Like Ocata for some. | |
| 18:11:45 | lyarwood | ha | |
| 18:11:49 | lyarwood | okay rm -rf away sorry | |
| 18:12:31 | smcginnis | There might be more than those two, but if there's anything I see that hasn't been gone since at least Stein, I'll leave it for later cleanup. | |
| 18:15:26 | lyarwood | smcginnis: are the removals from cinder tracked anywhere outside of the releasenotes btw? Like an easy to read support table or something | |
| 18:16:24 | smcginnis | We've started just marking them as unsupported, so there haven't been any new removals for at least a cycle now. | |
| 18:16:39 | smcginnis | I think we did document the older ones though. Let me see if I can find that. | |
| 18:17:01 | smcginnis | Probably incomplete though. I had to dig a bit to even figure out what the AOE connector was. | |