Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-08-06
16:09:23 sean-k-mooney gibi: i the neutron docs are confusing on the ip allocation policy. i think i saw one place refecne that neutorn would do it automaticlly but i know when it was first added it needed to be set manually
16:10:08 gibi sean-k-mooney: I don't have my mutlisegment test env working so I cannot check right now but as far as I remember I had to set it manually
16:12:32 sean-k-mooney ok nova does not actully support multisegment prodier netwroks correctly
16:12:49 sean-k-mooney if you try to use them it will fail in at least two cases
16:12:52 sean-k-mooney sriov
16:13:12 sean-k-mooney and if one host has 2 phsynets it wont work right
16:13:41 sean-k-mooney also numa_aware_vswitch or anything that depens on the phsynet wont work properly
16:13:58 sean-k-mooney but ya that as seperate problem
16:15:32 gibi I guess I never tried with two physnets then
16:17:47 sean-k-mooney gibi: we just grap the first physnet form the list in nova
16:18:30 sean-k-mooney so if a network has more then one phsynet then there is no guarenttee that it will be correct.
16:19:41 sean-k-mooney the current hack that existsi assuem that we will have at most 1 provider network and 1 tunnel network but not multipele provider networks
16:23:40 gibi would it make sense to have two provide segment in the same network?
16:40:10 sean-k-mooney yes that is what the routed provider netwrok feature in neturon is for
16:40:19 sean-k-mooney it uses physnets to map hosts to segments
16:40:31 sean-k-mooney there is no other way to map host to segments that i have found
16:58:29 openstackgerrit Ghanshyam Mann proposed openstack/os-vif master: [goal] migrate testing to ubuntu focal https://review.opendev.org/738130
16:59:25 gmann sean-k-mooney: ^^ need re Approved
16:59:37 sean-k-mooney already done
16:59:44 gmann thanks
17:00:43 sean-k-mooney gmann: also nova core technically are os-vif cores although we bacsically just ask you to use your judgement. if you feel comfortably approving you can if not then you dont have too :)
17:00:54 sean-k-mooney os-vif review is totally optional
17:02:06 gmann sean-k-mooney: sure. as long as you are on irc (which is always :p) i am ok to bother you
17:03:24 sean-k-mooney yep happy to be pinged about os-vif
17:05:04 sean-k-mooney oh i got the github "Arctic Code Vault Contributor" badge :) that is cool now in 1000 year peopel will see my terrible code and be equally stumped as we are now to how that ever worked :)
17:05:15 sean-k-mooney https://archiveprogram.github.com/
17:05:55 sean-k-mooney i wonder what version of nova the archived
17:07:47 sean-k-mooney oh it was master from 02/02/2020
17:08:17 sean-k-mooney huh that a pallandrome im sure they did that intentionally
17:08:48 gibi ohh, that was my brithday too :)
17:11:07 sean-k-mooney nice
17:52:54 lyarwood \o
17:54:43 openstackgerrit Merged openstack/nova-specs master: Routed network scheduling spec https://review.opendev.org/733703
18:49:00 lyarwood does anyone know what the file paths for file backed memory look like in Nova?
18:49:11 lyarwood is it specific to the instance?
18:55:36 sean-k-mooney lyarwood: yes they are
18:55:44 sean-k-mooney they are generated by libvirt
18:55:49 lyarwood wonderful
18:55:53 sean-k-mooney with one per numa node
18:56:01 sean-k-mooney the are in the instance directory
18:56:17 sean-k-mooney why do you ask
18:56:35 sean-k-mooney thats one per guest numa node by the way
18:56:50 lyarwood oh no reason
18:57:15 sean-k-mooney there si a libvirt config option memory_backing_dir that you can set to chooese where to put them
19:14:38 artom stephenfin, so you're saying you'll edit out the typing stuff when you backport https://review.opendev.org/#/c/744958/ ?
19:14:49 artom I mean, I'd have done it right away by doing 2 patches, but w/e works
19:16:00 stephenfin artom: Yup, though only because I have to for Train (it's not Python 3-only)
19:16:39 stephenfin If it was, I'd leave them since they're a noop until mypy is enabled for that file (via mypy-files.txt)
19:17:13 artom stephenfin, ack, I'll remove my -1 then. I still don't fully get the problem/fix though :P
19:17:18 stephenfin a second patch is also doable, but I find the type hints help understand what's getting passed around
19:17:22 stephenfin I'm replying with that now
19:17:35 artom Yeah, I can understand that (the typing hints helping)
19:19:21 stephenfin artom: comments left. Let me know if that makes sense
19:20:56 artom stephenfin, ah, I think I get it - we don't "delta" the usage, we rebuild it from scratch every time. So if a certain migration/instance doesn't get counted as "tracked", it'll effectively unpin its PCPUs
19:21:11 stephenfin Yup, exactly
19:21:48 artom OK, great, so that's 1 hour to understand the concept.
19:21:53 artom Now to review the actual code :P
19:22:02 artom Need to pick up food first though
19:22:30 stephenfin TBH, that whole periodic task feels racy and generally wrong to me, but it does state that it's intention is to blow everything away and start from scratch so...
19:22:55 stephenfin yet another thing to add my "tech debt I really need to get back to" list, I guess
19:23:09 artom It's definitely not the first race in there
19:23:49 artom See: https://review.opendev.org/#/c/684409/
19:23:57 stephenfin For sure. I decided not to start listing the related bugs of the related bugs, because it started getting ridiculous
19:24:19 stephenfin concurrency is hard
19:24:30 artom Yeah, chill with that, you trying to one-up George RR Martin or something?
19:26:43 stephenfin Try to write an explanation for https://review.opendev.org/744021 (with other nova devs that don't have this specific libvirt CPU pinning knowledge in mind) and let me know how you get on :P
19:44:54 sean-k-mooney stephenfin: speaking about racy periodics
19:45:40 sean-k-mooney its possible that we have a race between them starting in general on inital boot and the compute agent looking up it compute node uuid or maybe even creating the compute node record
19:46:41 sean-k-mooney i say its posible becuase im expecting a bug to be filed for http://pastebin.test.redhat.com/891237
19:47:23 sean-k-mooney and that is my working theory on how we could be trying to update a compute node recored with a compute_node_id of none
19:49:14 sean-k-mooney oh but that one does not have have startup set....
19:49:17 sean-k-mooney https://github.com/openstack/nova/blob/9ecefeb836964c52a5a2969b15c82b11c51d32ab/nova/compute/manager.py#L9723
19:49:56 sean-k-mooney and it gets the compute nodes at the start https://github.com/openstack/nova/blob/9ecefeb836964c52a5a2969b15c82b11c51d32ab/nova/compute/manager.py#L9697-L9700
19:50:09 sean-k-mooney well that theroy did not last long
19:52:47 sean-k-mooney oh i did not read that write it was trying to insert a default consturced/empty pci deivcie object
19:54:26 sean-k-mooney tommorows problem
#openstack-nova - 2020-08-07
02:04:38 openstackgerrit Brin Zhang proposed openstack/nova master: [Trivial] Remove wrong format_message() conversion https://review.opendev.org/744280
04:07:02 openstackgerrit Tony Su proposed openstack/nova master: Provider Config File: Function to further validate and retrieve configs https://review.opendev.org/676029
04:07:03 openstackgerrit Tony Su proposed openstack/nova master: Provider Config File: Enable loading and merging of provider configs https://review.opendev.org/693460
04:07:03 openstackgerrit Tony Su proposed openstack/nova master: Provider Config File: Functions to merge provider configs to provider tree https://review.opendev.org/676522
04:47:44 openstackgerrit Luyao Zhong proposed openstack/nova master: track error migrations in resource tracker https://review.opendev.org/745281
04:47:44 openstackgerrit Luyao Zhong proposed openstack/nova master: introduce a new driver interface 'cleanup_instance' https://review.opendev.org/714653
04:47:45 openstackgerrit Luyao Zhong proposed openstack/nova master: track orphans in resource tracker https://review.opendev.org/745282
06:59:00 openstackgerrit Luyao Zhong proposed openstack/nova master: track error migrations in resource tracker https://review.opendev.org/745281
06:59:01 openstackgerrit Luyao Zhong proposed openstack/nova master: track orphans in resource tracker https://review.opendev.org/745282
07:11:40 gibi good morning
07:38:10 tony_su stephenfin: gibi: alex_xu: new provider-config-file patches uploaded change log 1) all comments except one in the last patch relected in code or answered 2) add docstring for each test case
07:39:05 tony_su unfortunately, so far I don't know how to use nova-manage command to help provider config.
07:42:02 tony_su stephenfin: does it mean we need to upgrade nova-manage command to offer some new option to validate the validity of provider.yaml file?
07:42:43 tony_su for this comment https://review.opendev.org/#/c/693460/35/doc/source/admin/managing-resource-providers.rst@205
07:52:01 stephenfin tony_su: Yeah, exactly. I'm thinking we simply add a command (e.g. 'nova-manage placement validate-schema $SCHEMA') that attempts to load the provided schema and provides an error code and message if it's not valid
07:53:49 tony_su Must we do it this time or can we do it later? I am not fairly faimiliar with nova-manage command and I dont' know how long it can be done.
07:54:17 tony_su I am a little bit worried we will miss Victoria if do so.
08:40:52 gibi tony_su, stephenfin: I'm fine handling the nova-manage part as an addition on top of the series as I don't consider that as a blocker for the feature to merge. Let's focuse on merging what is ready (I know I should spend some time reviewing that series too).
09:07:53 openstackgerrit Stephen Finucane proposed openstack/os-vif master: mypy: Add type annotations https://review.opendev.org/745162
09:07:54 openstackgerrit Stephen Finucane proposed openstack/os-vif master: mypy: Extend type annotations to 'vif_plug_noop' https://review.opendev.org/745163
09:31:11 tony_su gibi: stephenfin has been doing great, detailed review for each patch. your review can still effectively speedup our progress...
09:36:55 kashyap lyarwood: Can you remind me, please: does Nova stash 'host-capabilities' somewhere?
09:37:14 kashyap It does, IIRC
09:38:07 lyarwood kashyap: hmm I know we grab them at startup

Earlier   Later