| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-08-06 | |||
| 10:02:40 | stephenfin | I could, though the change ID allows you to click through to the original change | |
| 10:03:52 | kashyap | Yeah, I see the value; but recall: we also have to bear in mind the "guy working from the woods" w/ no internet connection :-) - all needed info present w/ no clicking required | |
| 10:05:33 | kashyap | I'd personally put it in the commit body. But I let you decide here. | |
| 10:19:37 | sean-k-mooney | stephenfin: they are on the same topic so at least in gerrit its easy to find | |
| 10:20:30 | sean-k-mooney | oh you are folding back in the funcion | |
| 10:20:36 | sean-k-mooney | ya makes sense | |
| 10:27:18 | sean-k-mooney | stephenfin: by the way you realise that mypy support ducktyping | |
| 10:27:50 | stephenfin | I do. What's the context? | |
| 10:28:09 | sean-k-mooney | your responce to melwitt about not using mypy in tests | |
| 10:28:22 | sean-k-mooney | so ducktyping would not be an issue | |
| 10:28:27 | sean-k-mooney | mock proably would be | |
| 10:28:46 | stephenfin | It would if the code expects a Instance object and we're passing a dict or a string | |
| 10:28:50 | sean-k-mooney | but if we create a local class and implement the same interface it would pass | |
| 10:28:52 | stephenfin | which we do in placement | |
| 10:28:54 | stephenfin | *places | |
| 10:29:11 | stephenfin | Possibly, but that would be so much work | |
| 10:29:20 | sean-k-mooney | i know | |
| 10:29:41 | sean-k-mooney | i just mean if the thing we pass ducktypes to the real thing it will pass | |
| 10:29:55 | sean-k-mooney | if it does not we proably should not be passing it now :) | |
| 10:30:37 | sean-k-mooney | im hoping we ill graduly stop passing incorrect types in tests | |
| 10:30:56 | sean-k-mooney | im not going to hold my breath but i can hope | |
| 10:33:15 | openstackgerrit | Merged openstack/nova master: Lookup nic feature by PCI address https://review.opendev.org/739131 | |
| 10:33:27 | sean-k-mooney | :) | |
| 10:44:15 | mlycka | Hello, would anyone be kind enough to advise me on how one would go about getting a freeze exception for a spec? | |
| 10:46:00 | gibi | mlycka: what is the spec in question? | |
| 10:46:23 | gibi | mlycka: in general we will make decisions about spec freeze exception request on the today's nova meeting | |
| 10:46:29 | mlycka | gibi: https://review.opendev.org/#/c/702810/ | |
| 10:46:55 | mlycka | I was told by a Mr. Yarwood to go ahead and ask for an exception | |
| 10:48:18 | lyarwood | \o ./me waves | |
| 10:48:31 | sean-k-mooney | mlycka: johnthetubaguy still had some concerns about why we are now taking a different approch then was previously apporved | |
| 10:48:58 | gibi | mlycka, lyarwood: does the sync - async problem was resolved in the spec? | |
| 10:50:25 | mlycka | gibi: I think the idea was to treat is as sync for now and see where that gets us. The spec allows for a change later on during implementation. | |
| 10:51:35 | gibi | mlycka: I will add it to the meeting agenda. but we would need johnthetubaguy and Groka to check your answers to their questions as now we have -1s on the patch | |
| 10:52:11 | mlycka | gibi: Right right, thank you. Should I contact them directly or are they likely to be present in the meeting? | |
| 10:52:38 | lyarwood | mlycka: well the os-server-external-events API that you're using is async so I don't see how this could ever be sync tbh | |
| 10:52:55 | sean-k-mooney | that api is not for enduser to invoke | |
| 10:53:01 | sean-k-mooney | its for other services | |
| 10:53:15 | lyarwood | and that's also a valid point that I missed | |
| 10:53:20 | gibi | mlycka: given that it is summer I don't think they will get back to the spec today or tomorrow | |
| 10:53:21 | mlycka | Yeah, I think a separate endpoint is probably the way to go. | |
| 10:53:43 | sean-k-mooney | mlycka: quiesing a vm shoudl be a server action | |
| 10:53:59 | sean-k-mooney | as would undoing it | |
| 10:54:08 | sean-k-mooney | like pause and unpause | |
| 10:54:24 | mlycka | sean-k-mooney: What do you mean? Yeah, it would have to be done by the VM. | |
| 10:54:42 | sean-k-mooney | https://docs.openstack.org/api-ref/compute/#servers-run-an-action-servers-action | |
| 10:55:13 | sean-k-mooney | i mean you should be extending /servers/{server_id}/action | |
| 10:57:05 | mlycka | Okay, that doesn't sound unreasonable. Any objections? | |
| 10:57:32 | sean-k-mooney | i object to you using the event api :) but other then that no :) | |
| 10:58:58 | mlycka | Sure, makes sense. I won't have the time change the spec today, but I should be able to get to it tomorrow | |
| 10:59:58 | lyarwood | mlycka: would you also be able to start posting code for this? | |
| 11:00:25 | mlycka | lyarwood: I mean, not tomorrow but yeah, by next week I could start producing code. | |
| 11:00:35 | lyarwood | kk | |
| 11:03:13 | sean-k-mooney | mlycka: by the way the fact you used the service only external events api is proably why peopel assume this is only for use with cinder | |
| 11:04:01 | mlycka | sean-k-mooney: Might be. I think I misunderstood the use of that endpoint when I first found out about it. | |
| 11:04:27 | sean-k-mooney | ya that is why we have the warning https://docs.openstack.org/api-ref/compute/?expanded=add-associate-floating-ip-addfloatingip-action-deprecated-detail#create-external-events-os-server-external-events | |
| 11:05:34 | mlycka | Yep yep, clearly a reading comprehension failure on my part. | |
| 11:21:43 | openstackgerrit | sean mooney proposed openstack/os-vif master: support pyroute2 0.5.13 https://review.opendev.org/744809 | |
| 11:24:42 | openstackgerrit | sean mooney proposed openstack/nova stable/train: catch libvirt exception when nodedev not found. https://review.opendev.org/745116 | |
| 12:35:43 | artom | Dammit, we never updated the emulator thread policy flavor extra spec docs following the CPU resources patches: https://docs.openstack.org/nova/ussuri/user/flavors.html | |
| 12:36:05 | artom | (Scroll down to Emulator threads policy) | |
| 12:36:26 | sean-k-mooney | artom: well its still technically correct | |
| 12:36:37 | sean-k-mooney | artom: it just does not mention that the second half is only true | |
| 12:36:43 | sean-k-mooney | if you use vcpu_pin_set | |
| 12:36:43 | artom | Only if cpu_dedicated_set isn't also set | |
| 12:36:53 | sean-k-mooney | correct | |
| 12:37:15 | artom | And what's the point of documenting the old legacy behavior | |
| 12:37:21 | sean-k-mooney | vcpu_pin_set is deprecated not removed and we default to the legacy behavior | |
| 12:37:31 | artom | I suppose | |
| 12:37:42 | artom | Still, stuff is definitely missing | |
| 12:37:55 | sean-k-mooney | stephen can update it when he removes vcpu_pin_set in a few weeks | |
| 12:38:49 | sean-k-mooney | i guess you could update them to make it clear for train and ussuri before that | |
| 12:39:12 | sean-k-mooney | but its not going to be very useful on master since it wont matter when victoria is released | |
| 12:43:06 | artom | True | |
| 12:43:47 | sean-k-mooney | i guess you could look at it as motivation | |
| 12:43:57 | sean-k-mooney | if you want to impove it better do it quick before its gone | |
| 12:46:02 | artom | I need waaaay stronger motivation than that :P | |
| 12:46:21 | artom | Improving something only for it to disappear is not motivating :) | |
| 12:46:45 | artom | I realize that taken to the extreme I've just endorsed nihilism, but... | |
| 12:50:39 | openstackgerrit | sean mooney proposed openstack/nova master: remove deprecated schduler filters https://review.opendev.org/744800 | |
| 13:10:48 | lyarwood | can I just edit https://wiki.openstack.org/wiki/Meetings/Nova with agenda items for todays meeting? | |
| 13:14:11 | stephenfin | lyarwood: yup | |
| 13:15:12 | lyarwood | stephenfin: cool done thanks | |
| 13:37:00 | openstackgerrit | Merged openstack/nova master: compute: As cellsv1 is no more fold _detach_volume back into detach_volume https://review.opendev.org/731506 | |
| 13:43:26 | artom | stephenfin, we're not proposing bauzas's routed networks scheduling spec for exception? | |
| 13:43:45 | sean-k-mooney | i would have expected bauzas to do that | |
| 13:44:05 | artom | PTO | |
| 13:44:18 | sean-k-mooney | oh then yes we should | |
| 13:44:35 | sean-k-mooney | he was hoping that gibi would readd his +2 on monday | |
| 13:44:43 | sean-k-mooney | i think | |
| 13:45:17 | artom | I don't recall anyone except stephenfin being +2 | |
| 13:45:19 | kashyap | lyarwood: Hey, do you remember: when you cold-migrate an instance, will it in the end do a 'rebuild' on the destination? (/me goes to check the code) | |
| 13:45:27 | gibi | sean-k-mooney: ohh, I missed that | |
| 13:45:33 | sean-k-mooney | artom: gibi was +2 on v4 | |
| 13:46:11 | sean-k-mooney | gibi: we were ment to ping you to remind you, bauzas asked us too since he is on PTO | |
| 13:46:45 | sean-k-mooney | i mean we can still request an exception it technically needs one | |
| 13:46:50 | gibi | I will check it shortly and if I'm OK with it then I will ask for an exception on the todays meeting | |
| 13:55:16 | lyarwood | kashyap: resize | |
| 13:55:46 | lyarwood | kashyap: https://github.com/openstack/nova/blob/9ecefeb836964c52a5a2969b15c82b11c51d32ab/nova/api/openstack/compute/migrate_server.py#L76-L77 | |
| 13:57:58 | artom | lyarwood, could you revisit https://review.opendev.org/#/c/729763/11 when you get a chance? I didn't actually address any of your feedback, but hopefully my reasons make sense to you | |
| 13:58:10 | artom | stephenfin, ^^ same request, though I did fix the nit | |