Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-07-30
18:14:16 sean-k-mooney i kind of feel like i shoudl ask for one but its also a 6 line patch so it also feels like over kill
18:14:18 sean-k-mooney https://review.opendev.org/#/c/743950/2
18:15:11 openstack Launchpad bug 1851587 in OpenStack Compute (nova) "HypervisorUnavailable error leaks compute host fqdn to non-admin users" [Undecided,In progress] - Assigned to Harshavardhan Metla (harsha24)
18:15:11 sean-k-mooney it is for a public security hardening bug however https://bugs.launchpad.net/nova/+bug/1851587 which is why i think operator might care to see it in a release note
18:28:00 openstackgerrit Harshavardhan Metla proposed openstack/nova master: Moved the quoted section https://review.opendev.org/737215
19:16:01 openstackgerrit Merged openstack/nova stable/ussuri: Handle multiple 'vcpusched' elements during live migrate https://review.opendev.org/743804
19:16:46 openstackgerrit Lee Yarwood proposed openstack/nova stable/train: Handle multiple 'vcpusched' elements during live migrate https://review.opendev.org/743805
22:18:54 openstackgerrit sean mooney proposed openstack/nova master: Lookup nic feature by PCI address https://review.opendev.org/739131
22:49:31 openstackgerrit Ghanshyam Mann proposed openstack/os-vif master: [goal] migrate testing to ubuntu focal https://review.opendev.org/738130
23:16:14 openstackgerrit Merged openstack/nova master: libvirt: Remove blockjob.end == 0 workaround resolved in libvirt v2.3.0 https://review.opendev.org/729596
23:16:21 openstackgerrit Merged openstack/nova master: compute: Validate a BDMs disk_bus when provided https://review.opendev.org/724842
23:40:00 openstackgerrit Merged openstack/nova master: func: Add live migration rollback volume attachment tests https://review.opendev.org/743534
23:40:08 openstack bug 1889108 in OpenStack Compute (nova) "failures during driver.pre_live_migration remove source attachments during rollback" [High,In progress] https://launchpad.net/bugs/1889108 - Assigned to Lee Yarwood (lyarwood)
23:40:08 openstackgerrit Merged openstack/nova master: Add regression tests for bug #1889108 https://review.opendev.org/743289
#openstack-nova - 2020-07-31
00:30:05 rambo_li If anyone can help me review the https://review.opendev.org/#/c/739349/, thank you very much!
02:38:44 openstackgerrit Merged openstack/nova stable/train: Handle multiple 'vcpusched' elements during live migrate https://review.opendev.org/743805
06:27:50 openstackgerrit Harshavardhan Metla proposed openstack/nova master: Raising a failure in case of 403 https://review.opendev.org/735068
06:36:28 openstackgerrit Harshavardhan Metla proposed openstack/nova master: Moved the quoted section https://review.opendev.org/737215
08:05:03 nightmare_unreal hello can someone leave their comment on this ticket. https://review.opendev.org/#/c/742210/ . Also suggestion on test cases
08:05:04 nightmare_unreal thanks
08:26:10 aarents good morning nova,
08:27:02 aarents lyarwood thanks for review! I fixed the nit on : https://review.opendev.org/#/c/696084/ and https://review.opendev.org/#/c/743708/ , I will be off next week, so I will be able to re-submit only after if needed.
10:00:06 openstackgerrit Harshavardhan Metla proposed openstack/nova master: Raising a failure in case of 403 https://review.opendev.org/735068
10:59:44 lyarwood aarents: ack I'll take a look today
11:20:35 songwenping_ bauzas: hi, i test create server with vgpu, and encounter error with "Verify all devices in group 71 are bound to vfio-<bus> or pci-stub and not already in use". Do you have any idea?
11:21:53 jsuchome lyarwood: hi, me again ... anything else we need for that rbd-download job? besides https://review.opendev.org/#/c/743220/
11:30:07 openstackgerrit Takashi Natsume proposed openstack/python-novaclient master: Remove unused code https://review.opendev.org/744136
12:03:29 lyarwood melwitt: thanks for the master reviews btw, https://review.opendev.org/#/c/743493/ is ready for stable/queens btw if you have time today.
12:05:39 openstackgerrit Stephen Finucane proposed openstack/nova master: hardware: Reject requests for no hyperthreads on hosts with HT https://review.opendev.org/744021
12:05:39 openstack bug 1889633 in OpenStack Compute (nova) "Pinned instance with thread policy can consume VCPU" [High,In progress] https://launchpad.net/bugs/1889633 - Assigned to Stephen Finucane (stephenfinucane)
12:05:39 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Add reproducer for bug #1889633 https://review.opendev.org/744020
12:05:49 stephenfin sean-k-mooney, artom: ^
12:05:51 stephenfin songwenping_: bauzas is on vacation for the next few weeks, unfortunately :-(
12:06:28 songwenping_ ok. thanks stephenfin.
12:12:19 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove warning filters for legacy Python version https://review.opendev.org/743285
12:12:19 openstackgerrit Stephen Finucane proposed openstack/nova master: trivial: Remove unused attributes https://review.opendev.org/743284
12:20:07 artom stephenfin, small nit on the test patch, but it'd bug me if it went in as is - just comes off as sloppy
12:21:14 stephenfin artom: Hmm, I don't understand the first comment. Can you elaborate?
12:21:25 artom stephenfin, eh?
12:21:35 stephenfin Since we only have 4 CPUs
12:21:51 stephenfin where's that coming from?
12:22:14 artom stephenfin, oh, you kept it as 8
12:22:18 sean-k-mooney we have 8
12:22:21 artom Huh, and the pinning assertion still works?
12:22:25 stephenfin I kept what as 8?
12:22:31 artom 8 CPUs
12:22:43 sean-k-mooney cpu_nodes=2, cpu_sockets=1, cpu_cores=2, cpu_threads=2,
12:22:52 stephenfin oh, right, yeah, that
12:22:53 sean-k-mooney so 8 threads
12:23:00 artom And the pinning assertion that you added will still always be true? It'll deterministic ally pin the first 4 CPUs for a 4-CPU instance?
12:23:09 artom *always pin
12:23:17 sean-k-mooney artom: stephenfin is relying on how we currenlty order the numa nodes
12:23:20 stephenfin artom: I mean, it's an implementation detail but yeah
12:23:41 sean-k-mooney which is to pass them to itertools.permutations in order
12:23:49 sean-k-mooney which will return them in order
12:24:01 sean-k-mooney so asserting 0-4 are pinned will work
12:24:06 sean-k-mooney untill we change that
12:24:34 sean-k-mooney stephenfin: i assume this test will go away once we kill vcpu_pin_set anyway or be updated right
12:24:43 sean-k-mooney since we only need to keep the ones for the new config values
12:24:45 artom OK, I'll leave it up to you then - personally I feel it'd be cleaner not to rely on the implementation, and just give the host 4 CPUs
12:24:46 stephenfin the first one, yes
12:24:48 sean-k-mooney so i think the ordering is fine
12:24:48 artom Or threads
12:25:18 stephenfin no sweat off my back to change, sec
12:25:19 sean-k-mooney so you mean just do cpu_nodes=1
12:25:26 sean-k-mooney and then 0-3
12:26:22 sean-k-mooney stephenfin: the follow up looks fine to me i guess but you still did not add a release note
12:27:19 sean-k-mooney it proably should have one given the upgrade interaction
12:27:48 stephenfin sure, forgot about that
12:31:30 openstackgerrit Stephen Finucane proposed openstack/nova master: hardware: Reject requests for no hyperthreads on hosts with HT https://review.opendev.org/744021
12:31:30 openstack bug 1889633 in OpenStack Compute (nova) "Pinned instance with thread policy can consume VCPU" [High,In progress] https://launchpad.net/bugs/1889633 - Assigned to Stephen Finucane (stephenfinucane)
12:31:30 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Add reproducer for bug #1889633 https://review.opendev.org/744020
12:31:34 stephenfin ta-da
13:01:12 artom lyarwood, can I ask you to look over https://review.opendev.org/#/c/729763/6 when you get a chance?
13:02:17 artom Err, lemme rebase that first
13:06:28 openstackgerrit Artom Lifshitz proposed openstack/nova master: Handle Neutron errors in _post_live_migration() https://review.opendev.org/729763
13:06:28 openstack bug 1879787 in OpenStack Compute (nova) "post_live_migration does not handle Neutron errors" [Medium,In progress] https://launchpad.net/bugs/1879787 - Assigned to Artom Lifshitz (notartom)
13:06:28 openstackgerrit Artom Lifshitz proposed openstack/nova master: Add regression test for bug 1879787 https://review.opendev.org/741230
13:10:04 lyarwood artom: ack can do
13:10:23 openstackgerrit Lee Yarwood proposed openstack/nova stable/ussuri: tests: Define constants in '_IntegratedTestBase' https://review.opendev.org/744158
13:10:24 openstackgerrit Lee Yarwood proposed openstack/nova stable/ussuri: func: Add live migration rollback volume attachment tests https://review.opendev.org/744160
13:10:24 openstackgerrit Lee Yarwood proposed openstack/nova stable/ussuri: func: Add _live_migrate helper to InstanceHelperMixin https://review.opendev.org/744159
13:10:26 openstackgerrit Lee Yarwood proposed openstack/nova stable/ussuri: compute: Don't delete the original attachment during pre LM rollback https://review.opendev.org/744162
13:10:26 openstack bug 1889108 in OpenStack Compute (nova) "failures during driver.pre_live_migration remove source attachments during rollback" [High,In progress] https://launchpad.net/bugs/1889108 - Assigned to Lee Yarwood (lyarwood)
13:10:26 openstackgerrit Lee Yarwood proposed openstack/nova stable/ussuri: Add regression tests for bug #1889108 https://review.opendev.org/744161
13:18:10 lyarwood artom: Ie0852a89fc9423a92baa7c29a8806c0628cae220 - can you rebase it again on that
13:18:50 artom lyarwood, ah, yeah
13:18:54 artom Damn churn
13:19:01 artom But the end state is worth it
13:20:27 lyarwood artom: yeah sorry
13:20:36 lyarwood artom: blame stephenfin for suggesting the fup ;)
13:20:50 artom Oh I blame stephenfin regardless
13:20:57 artom But in this case his OCD is useful ;)
13:30:47 artom lyarwood, btw, in a similar vein, question on https://review.opendev.org/#/c/744159/1/nova/tests/functional/integrated_helpers.py
13:32:34 lyarwood artom: I don't think so
13:32:44 lyarwood artom: we can't squash the two togther
13:32:55 lyarwood artom: as the tests used the original
13:33:05 lyarwood artom: I could backport it once they land
13:33:13 lyarwood artom: and it has landed in master
13:33:52 artom lyarwood, ah, right

Earlier   Later