| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-07-24 | |||
| 09:47:00 | stephenfin | so optparse (or whatever scp is using) is just plain broken | |
| 09:47:10 | stephenfin | but hey, I'm not going to fix it :) | |
| 09:48:25 | gibi | yeah 'grep foo ./ -R' works too | |
| 09:49:48 | gibi | sean-k-mooney: good article https://that.guru/blog/the-numa-scheduling-story-in-nova/ :) | |
| 09:50:25 | bauzas | stephenfin: fyk https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap12.html | |
| 09:50:55 | bauzas | tl;dr: options != operands | |
| 09:51:28 | bauzas | argparse was probably written by Linux geeks who weren't knowing about UNIX :p | |
| 09:51:37 | bauzas | time for a quote | |
| 09:52:43 | bauzas | BSD is what you get when a bunch of UNIX hackers sit down to try to port a UNIX system to the PC. Linux is what you get when a bunch of PC hackers sit down and try to write a UNIX system for the PC | |
| 09:53:45 | tosky | nice as a quote, even though iirc historically incorrect: when BSD started, there were no PC | |
| 09:54:17 | bauzas | that's not coming from me :) | |
| 09:54:43 | bauzas | but I used to play with some BSD OSes in the past, and this pun was very well known | |
| 09:55:19 | bauzas | do people know that 'ps' has a very specific POSIX syntax that people can use indefffrently from the OS ? | |
| 10:08:31 | stephenfin | bauzas: I was taught to use e.g. 'ps aux' which I think is BSD compatible too | |
| 10:09:29 | bauzas | that's correct, and that's the old syntax | |
| 10:09:51 | bauzas | we made it forward compatible | |
| 10:09:57 | bauzas | whoops | |
| 10:10:01 | bauzas | they, not we | |
| 10:10:12 | bauzas | I'm not THAT modest | |
| 10:10:55 | bauzas | tl;dr: options without the dash come from BSD | |
| 10:11:06 | bauzas | and Linux ported them | |
| 10:11:33 | bauzas | but in theory, you *should* always follow the POSIX syntax to be 100% compliant across all platforms | |
| 10:12:35 | bauzas | https://askubuntu.com/questions/484982/what-is-the-difference-between-standard-syntax-and-bsd-syntax | |
| 10:15:27 | bauzas | or slighly better https://man7.org/linux/man-pages/man1/ps.1.html | |
| 11:52:56 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Add helpers for suspend, resume and reboot of server https://review.opendev.org/741285 | |
| 11:52:56 | openstackgerrit | Stephen Finucane proposed openstack/nova master: scheduler: Default request group to None https://review.opendev.org/742651 | |
| 11:52:57 | openstackgerrit | Stephen Finucane proposed openstack/nova master: api: Reject non-spawn operations for vTPM https://review.opendev.org/741500 | |
| 11:52:57 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Pass context, instance to '_create_domain' https://review.opendev.org/741286 | |
| 11:52:58 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Add docs for vTPM support https://review.opendev.org/739213 | |
| 11:52:58 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Add emulated TPM support to Nova https://review.opendev.org/631363 | |
| 11:52:59 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add support for resize and cold migration of emulated TPM files https://review.opendev.org/639934 | |
| 11:52:59 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Don't unset Instance.old_flavor, new_flavor until necessary https://review.opendev.org/741995 | |
| 11:53:00 | openstackgerrit | Stephen Finucane proposed openstack/nova master: privsep: Add support for recursive chown, move_tree operations https://review.opendev.org/742864 | |
| 11:53:00 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add type hints to 'nova.compute.manager' https://review.opendev.org/742863 | |
| 11:53:01 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add type hints to 'nova.virt.libvirt.utils' https://review.opendev.org/742865 | |
| 13:41:04 | openstackgerrit | Elod Illes proposed openstack/nova stable/rocky: compute: Allow snapshots to be created from PAUSED volume backed instances https://review.opendev.org/729177 | |
| 13:48:22 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Handle Neutron errors in _post_live_migration() https://review.opendev.org/729763 | |
| 13:48:22 | openstack | bug 1879787 in OpenStack Compute (nova) "post_live_migration does not handle Neutron errors" [Medium,In progress] https://launchpad.net/bugs/1879787 - Assigned to Artom Lifshitz (notartom) | |
| 13:48:22 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Add regression test for bug 1879787 https://review.opendev.org/741230 | |
| 13:49:02 | openstackgerrit | Merged openstack/nova stable/ussuri: libvirt: Handle VIR_ERR_DEVICE_MISSING when detaching devices https://review.opendev.org/742414 | |
| 13:54:45 | sean-k-mooney | gibi: hi o/ i was away for a funeral this week so just seeing your commnet on the attach/detach patch now. i can take a look at it more closely next week but still pretty burt out today. hopefully ill be less mentally exausted after the weekend | |
| 13:56:28 | sean-k-mooney | so ya i think your right there is a bug related to macvtap detach that is prexisting in the libvirt driver | |
| 13:57:33 | sean-k-mooney | well 2 one its not updating the domain correctly because its not finding the device properly and 2 its not relasing the vf claim because we just dont do that today for sriov detach | |
| 13:58:18 | sean-k-mooney | problem 1 is want prevents the vf mac from being reset and the macvtap being removed on detach | |
| 13:58:19 | gibi | sean-k-mooney: no worries. take your time to recover | |
| 13:58:53 | gibi | sean-k-mooney: I think I've just found the reason of 2 | |
| 13:58:57 | gibi | and I think I can fix it | |
| 13:59:06 | gibi | I will be away next week | |
| 13:59:34 | gibi | so feel free to touch my code or add patches to the series while I'm away and I will continue the weak after | |
| 13:59:48 | sean-k-mooney | what proably makes sense is to have 3 patches. 1 that block detach in the api, then your current one and a final patch for macvtap | |
| 14:00:20 | gibi | yes, make sense to have separate patches for the separate issues | |
| 14:00:58 | sean-k-mooney | we also need a ptach for direct-physical but it is basically the same issue the device lookup fails although it fails for a different reason | |
| 14:01:24 | sean-k-mooney | it filas because the mac is not present rather then the target_dev | |
| 14:01:58 | sean-k-mooney | but its still failing in the same if i belive https://github.com/openstack/nova/blob/4a925cf01ac6ca313ff10c3075a86d65095de299/nova/virt/libvirt/guest.py#L252-L257 | |
| 14:02:27 | gibi | sean-k-mooney: cool. I haven't had time to try direct-physical yet, | |
| 14:03:44 | sean-k-mooney | what i think make sense is to just have 2 code paths. if its an sriov inteface find it by the pci adresss and remove it | |
| 14:03:51 | sean-k-mooney | if not find it by its mac and remove it | |
| 14:05:45 | sean-k-mooney | ill have to look at the code and see if that makes sense in partice however as im not sure if we have the vnic_type or vif type avaiable | |
| 14:06:32 | gibi | the code that searchs for the interface has access to the vif 124: enp129s16f6: <BROADCAST,MULTICAST> mtu 1500 qdisc mq state DOWN group default qlen 1000 | |
| 14:06:39 | gibi | bah | |
| 14:06:53 | gibi | the code that searchs for the interface has access to the vif 124: enp129s16f6: <BROADCAST,MULTICAST> mtu 1500 qdisc mq state DOWN group default qlen 1000 | |
| 14:07:03 | gibi | my copy paste buffer is brokn :/ | |
| 14:07:19 | sean-k-mooney | ok cool | |
| 14:07:28 | gibi | https://github.com/openstack/nova/blob/4a925cf01ac6ca313ff10c3075a86d65095de299/nova/virt/libvirt/guest.py#L252-L257 | |
| 14:07:56 | gibi | nah, this is the place where the matching between the current domain and the vif being detached happens https://github.com/openstack/nova/blob/4a925cf01ac6ca313ff10c3075a86d65095de299/nova/virt/libvirt/guest.py#L252-L257 | |
| 14:09:06 | sean-k-mooney | same link :) i think you ment https://github.com/openstack/nova/blob/4a925cf01ac6ca313ff10c3075a86d65095de299/nova/virt/libvirt/driver.py#L2199 | |
| 14:09:14 | sean-k-mooney | and yes it has the vif | |
| 14:10:03 | stephenfin | lyarwood: Are you the person I need to shout at for nova-ceph-multistore failing? :P | |
| 14:10:22 | sean-k-mooney | so we could add a get_interface_by_pci_address and call that instead for sriov devices. | |
| 14:10:25 | gibi | sean-k-mooney: yes both yours and mine points to the code that causes the failure | |
| 14:10:30 | stephenfin | jk, but heads up I'm seeing a lot of failures on that today. Haven't investigated yet though | |
| 14:12:10 | lyarwood | stephenfin: dansmith introduced it while I was out so no ;) | |
| 14:12:16 | lyarwood | stephenfin: what's up? | |
| 14:12:29 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: [WIP] Support SRIOV interface attach and detach https://review.opendev.org/740995 | |
| 14:12:34 | dansmith | stephenfin: link? | |
| 14:12:44 | sean-k-mooney | stephenfin: its a modifed verion of the previous ceph job | |
| 14:12:59 | stephenfin | dansmith: https://review.opendev.org/#/c/741286/ | |
| 14:13:14 | sean-k-mooney | so the test are the same but the config is slighly different to enable multistore and the image import form copy feature | |
| 14:13:55 | dansmith | stephenfin: thanks will look through it in a sec | |
| 14:14:10 | gibi | sean-k-mooney: https://review.opendev.org/#/c/740995/5/nova/virt/libvirt/guest.py@240 this change fixes the macvtap detach issue in my env, but I agree that the condition might need a refactoring to have two condition one for pci and another for mac | |
| 14:15:28 | sean-k-mooney | gibi: ya so that will work for macvtap but we will still fail for direct-physical | |
| 14:15:42 | gibi | sean-k-mooney: yes, probably, haven't tried | |
| 14:15:57 | sean-k-mooney | interfaces = self.get_all_devices( | |
| 14:16:00 | sean-k-mooney | vconfig.LibvirtConfigGuestInterface) | |
| 14:16:07 | sean-k-mooney | that wont return the direct-physical interfaces | |
| 14:16:31 | sean-k-mooney | since they are not element <interface ...> and use <hostdev ...? | |
| 14:16:41 | gibi | ohh | |
| 14:16:45 | gibi | interesting | |
| 14:16:55 | sean-k-mooney | also they dont have a mac in the host develement | |
| 14:17:33 | sean-k-mooney | libvirt cant passthough a pf with the <interface type=hostdev> only VFs | |
| 14:18:12 | sean-k-mooney | and the hostdev element dose not have a mac either so interface.mac_addr == cfg.mac_addr would fail | |
| 14:18:21 | sean-k-mooney | proably with an attribute error if we got that far | |
| 14:20:21 | dansmith | stephenfin: did you look into those fails at all? looks to me like just novalidhost on at least one of the three failed tests, and it's a conflict from placement during scheduling: | |
| 14:20:36 | dansmith | https://zuul.opendev.org/t/openstack/build/13d8a055ff1b4be0b627205f4d51d50f/log/controller/logs/screen-n-sch.txt#3493 | |
| 14:21:01 | dansmith | meaning, are you sure it's just that job failing more? because that fails way before the point where we get to any of the new (i.e. ceph or multistore) stuff | |
| 14:21:12 | sean-k-mooney | there are traces in the n-cpu log https://zuul.opendev.org/t/openstack/build/13d8a055ff1b4be0b627205f4d51d50f/log/controller/logs/screen-n-cpu.txt#14267-14323 | |
| 14:21:30 | sean-k-mooney | nova.exception.ImageNotFound: Image a549f544-e4e3-4f66-962e-03c1514ee21f could not be found | |
| 14:21:36 | stephenfin | dansmith: Barely. I'm seeing image retrieval failures in n-cpu | |
| 14:21:39 | stephenfin | yeah, those ^ | |
| 14:22:13 | dansmith | hmm, maybe the first test I picked was a rando failure then | |