Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-07-24
09:24:37 openstackgerrit Merged openstack/nova master: tests: Move single use constants to their callers https://review.opendev.org/741280
09:24:46 openstackgerrit Merged openstack/nova master: tests: Define constants in '_IntegratedTestBase' https://review.opendev.org/741281
09:24:55 openstackgerrit Merged openstack/nova master: tests: Remove 'test_servers.ServersTestBase' https://review.opendev.org/741282
09:25:02 openstackgerrit Merged openstack/nova master: tests: Add 'PlacementHelperMixin', 'PlacementInstanceHelperMixin' https://review.opendev.org/741283
09:25:13 openstackgerrit Merged openstack/nova master: tests: Make '_IntegratedTestBase' subclass 'PlacementInstanceHelperMixin' https://review.opendev.org/741284
09:31:04 stephenfin Holy s***, they all merged in one go. No CI failures :O
09:31:11 openstackgerrit Stephen Finucane proposed openstack/nova master: Use compression by default for 'SshDriver' https://review.opendev.org/684393
09:31:54 gibi stephenfin: that was a nice set
09:31:58 stephenfin bauzas, gibi: Can you look at ^ again real quick? Turns out 'scp' cares about the order of arguments. CI caught it for us and will catch it again if it's wrong
09:32:10 stephenfin (from https://zuul.opendev.org/t/openstack/build/7e8c6c6ddaba44e09a90a847dfe6ee46/log/logs/screen-n-cpu.txt)
09:32:10 gibi stephenfin: looking
09:32:14 bauzas ack
09:32:14 stephenfin Thanks
09:32:49 stephenfin It did
09:33:05 bauzas hah
09:33:09 bauzas fwiw https://linux.die.net/man/1/scp
09:33:32 stephenfin I just thought it was intermittent failures and wasn't looking at it often enough to spot the trend :)
09:33:39 stephenfin zuul++
09:34:04 bauzas stephenfin: i don't see any required ordering with scp manpage
09:34:37 stephenfin bauzas: neither did I, but the CI failure is fairly unambiguous
09:34:54 stephenfin probably the implementation of getopt they're using is borked
09:35:04 bauzas in theory, you could also scp -rC
09:35:32 gibi I can reproduce the ordering requirement of scp locally
09:35:50 gibi so the manpage is incomplete :)
09:35:54 bauzas gibi: I honesly never used the -C flag
09:36:14 bauzas like I said, I tend to use tar over nc when I wanted to transfer large files
09:36:23 stephenfin tbf, parsing command line arguments is hard work
09:36:25 bauzas waaaaay more efficient
09:36:40 gibi scp is secure tar + nc is fast, it is a tradeoff :)
09:36:46 stephenfin so broken :-(
09:37:51 stephenfin to the point that click (which is actually awesome) uses the deprecated optparse. Less magical and more reliable, apparently
09:42:17 gibi stephenfin: btw https://that.guru/blog/the-numa-scheduling-story-in-nova/ is a great article that made me think about where and when nova selects the resources to consume
09:42:51 bauzas stephenfin: gibi: that's an argparse bug http://paste.openstack.org/show/796277/
09:42:59 bauzas definitely not scp-related
09:43:04 stephenfin gibi: You can thank sean-k-mooney for most of that. I just spell checked and reorganized :)
09:43:29 stephenfin bauzas: Put '-C' at the end
09:43:36 bauzas oh that
09:43:43 stephenfin the issue isn't with the order of the positionals
09:43:44 bauzas of course, it won't work then
09:43:47 stephenfin options
09:43:55 stephenfin it's with options coming after positionals
09:44:01 bauzas you shock me if you thought it would work :p
09:44:13 stephenfin but it does in many applications!
09:44:21 bauzas but I honestly haven't paid attention at the argparse result :)
09:44:27 openstackgerrit Merged openstack/nova master: trivial: Test object backporting against correct version https://review.opendev.org/742650
09:44:29 bauzas it NEVER worked with scp then :)
09:44:41 bauzas and many BSD commands
09:44:48 bauzas (many many)
09:46:19 stephenfin bauzas: http://paste.openstack.org/show/796278/
09:46:31 stephenfin run that with e.g. 'python test.py 123 MB -b test'
09:46:39 stephenfin it'll work just fine
09:47:00 stephenfin so optparse (or whatever scp is using) is just plain broken
09:47:10 stephenfin but hey, I'm not going to fix it :)
09:48:25 gibi yeah 'grep foo ./ -R' works too
09:49:48 gibi sean-k-mooney: good article https://that.guru/blog/the-numa-scheduling-story-in-nova/ :)
09:50:25 bauzas stephenfin: fyk https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap12.html
09:50:55 bauzas tl;dr: options != operands
09:51:28 bauzas argparse was probably written by Linux geeks who weren't knowing about UNIX :p
09:51:37 bauzas time for a quote
09:52:43 bauzas BSD is what you get when a bunch of UNIX hackers sit down to try to port a UNIX system to the PC. Linux is what you get when a bunch of PC hackers sit down and try to write a UNIX system for the PC
09:53:45 tosky nice as a quote, even though iirc historically incorrect: when BSD started, there were no PC
09:54:17 bauzas that's not coming from me :)
09:54:43 bauzas but I used to play with some BSD OSes in the past, and this pun was very well known
09:55:19 bauzas do people know that 'ps' has a very specific POSIX syntax that people can use indefffrently from the OS ?
10:08:31 stephenfin bauzas: I was taught to use e.g. 'ps aux' which I think is BSD compatible too
10:09:29 bauzas that's correct, and that's the old syntax
10:09:51 bauzas we made it forward compatible
10:09:57 bauzas whoops
10:10:01 bauzas they, not we
10:10:12 bauzas I'm not THAT modest
10:10:55 bauzas tl;dr: options without the dash come from BSD
10:11:06 bauzas and Linux ported them
10:11:33 bauzas but in theory, you *should* always follow the POSIX syntax to be 100% compliant across all platforms
10:12:35 bauzas https://askubuntu.com/questions/484982/what-is-the-difference-between-standard-syntax-and-bsd-syntax
10:15:27 bauzas or slighly better https://man7.org/linux/man-pages/man1/ps.1.html
11:52:56 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Add helpers for suspend, resume and reboot of server https://review.opendev.org/741285
11:52:56 openstackgerrit Stephen Finucane proposed openstack/nova master: scheduler: Default request group to None https://review.opendev.org/742651
11:52:57 openstackgerrit Stephen Finucane proposed openstack/nova master: api: Reject non-spawn operations for vTPM https://review.opendev.org/741500
11:52:57 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Pass context, instance to '_create_domain' https://review.opendev.org/741286
11:52:58 openstackgerrit Stephen Finucane proposed openstack/nova master: docs: Add docs for vTPM support https://review.opendev.org/739213
11:52:58 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Add emulated TPM support to Nova https://review.opendev.org/631363
11:52:59 openstackgerrit Stephen Finucane proposed openstack/nova master: Add support for resize and cold migration of emulated TPM files https://review.opendev.org/639934
11:52:59 openstackgerrit Stephen Finucane proposed openstack/nova master: Don't unset Instance.old_flavor, new_flavor until necessary https://review.opendev.org/741995
11:53:00 openstackgerrit Stephen Finucane proposed openstack/nova master: privsep: Add support for recursive chown, move_tree operations https://review.opendev.org/742864
11:53:00 openstackgerrit Stephen Finucane proposed openstack/nova master: Add type hints to 'nova.compute.manager' https://review.opendev.org/742863
11:53:01 openstackgerrit Stephen Finucane proposed openstack/nova master: Add type hints to 'nova.virt.libvirt.utils' https://review.opendev.org/742865
13:41:04 openstackgerrit Elod Illes proposed openstack/nova stable/rocky: compute: Allow snapshots to be created from PAUSED volume backed instances https://review.opendev.org/729177
13:48:22 openstackgerrit Artom Lifshitz proposed openstack/nova master: Handle Neutron errors in _post_live_migration() https://review.opendev.org/729763
13:48:22 openstack bug 1879787 in OpenStack Compute (nova) "post_live_migration does not handle Neutron errors" [Medium,In progress] https://launchpad.net/bugs/1879787 - Assigned to Artom Lifshitz (notartom)
13:48:22 openstackgerrit Artom Lifshitz proposed openstack/nova master: Add regression test for bug 1879787 https://review.opendev.org/741230
13:49:02 openstackgerrit Merged openstack/nova stable/ussuri: libvirt: Handle VIR_ERR_DEVICE_MISSING when detaching devices https://review.opendev.org/742414
13:54:45 sean-k-mooney gibi: hi o/ i was away for a funeral this week so just seeing your commnet on the attach/detach patch now. i can take a look at it more closely next week but still pretty burt out today. hopefully ill be less mentally exausted after the weekend
13:56:28 sean-k-mooney so ya i think your right there is a bug related to macvtap detach that is prexisting in the libvirt driver
13:57:33 sean-k-mooney well 2 one its not updating the domain correctly because its not finding the device properly and 2 its not relasing the vf claim because we just dont do that today for sriov detach
13:58:18 sean-k-mooney problem 1 is want prevents the vf mac from being reset and the macvtap being removed on detach
13:58:19 gibi sean-k-mooney: no worries. take your time to recover
13:58:53 gibi sean-k-mooney: I think I've just found the reason of 2
13:58:57 gibi and I think I can fix it
13:59:06 gibi I will be away next week
13:59:34 gibi so feel free to touch my code or add patches to the series while I'm away and I will continue the weak after

Earlier   Later