Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-07-22
09:04:41 lyarwood I thought you might :)
09:06:19 gibi stephenfin: OK. we can put the lower ones into a slot
09:09:18 gibi lyarwood: approved https://review.opendev.org/#/c/741561/
09:12:32 lyarwood gibi: thanks
09:15:56 stephenfin I really wish Gerrit had notifications a lá GitHub. Would save me parsing the emails every morning :-\
09:21:34 openstackgerrit Lee Yarwood proposed openstack/nova master: Detach is broken for multi-attached fs-based volumes https://review.opendev.org/741712
09:37:33 openstackgerrit Merged openstack/nova master: hardware: Enable 'hw:cpu_dedicated_mask' for creating a mixed instance https://review.opendev.org/714706
10:00:26 tony_su gibi: just status update for provider-config-file patches. I have updated the first two patches and is now working on the 3rd patch.
10:13:18 gibi tony_su: thanks. i will try to get back those patches soon
10:15:37 openstackgerrit Yingji Sun proposed openstack/nova master: Set different VirtualDevice.key https://review.opendev.org/713565
10:17:19 stephenfin lyarwood: Could you also re-add https://review.opendev.org/742383 to your list?
10:24:42 lyarwood stephenfin: ack
10:27:17 stephenfin ta
10:30:33 stephenfin bauzas: Got an old, pretty trivial patch for you here if you've got time today? https://review.opendev.org/#/c/684393/
10:32:11 bauzas stephenfin: I can take a look
10:42:16 stephenfin bauzas: thanks!
10:43:03 openstackgerrit Stephen Finucane proposed openstack/nova stable/stein: libvirt: Mark e1000e VIF as supported https://review.opendev.org/742390
10:43:23 openstackgerrit Stephen Finucane proposed openstack/nova stable/stein: libvirt: Mark e1000e VIF as supported https://review.opendev.org/742390
11:27:21 openstackgerrit Alex Deiter proposed openstack/nova master: Detach is broken for multi-attached fs-based volumes https://review.opendev.org/741712
11:37:46 openstackgerrit Yingji Sun proposed openstack/nova master: resolve ResourceProviderSyncFailed issue https://review.opendev.org/742398
12:15:24 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.PY2 and six.PY3 https://review.opendev.org/726512
12:15:44 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.add_metaclass https://review.opendev.org/726565
12:16:01 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.reraise https://review.opendev.org/726898
12:16:23 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.moves https://review.opendev.org/727224
12:16:43 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.iteritems/itervalues/iterkeys https://review.opendev.org/727757
12:16:57 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.byte2int/int2byte https://review.opendev.org/727777
12:17:13 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.binary_type/integer_types/string_types https://review.opendev.org/728094
12:23:15 openstackgerrit Balazs Gibizer proposed openstack/nova master: Undeprecate the vmwareapi driver https://review.opendev.org/742407
12:26:35 openstackgerrit Balazs Gibizer proposed openstack/nova master: Undeprecate the vmwareapi driver https://review.opendev.org/742407
12:28:14 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.text_type (1/2) https://review.opendev.org/728109
12:28:51 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.text_type (2/2) https://review.opendev.org/728117
12:29:20 openstackgerrit Takashi Natsume proposed openstack/nova master: objects: Update keypairs when saving an instance https://review.opendev.org/683043
12:39:15 openstackgerrit Merged openstack/nova master: libvirt: Re-enable live snapshot for paused instances https://review.opendev.org/740334
12:41:40 stephenfin gibi: Could you stick https://review.opendev.org/#/c/683043/ on your review queue, please? :)
12:42:32 gibi stephenfin: ack, enqueued
12:52:56 openstackgerrit Merged openstack/nova master: libvirt: Handle VIR_ERR_DEVICE_MISSING when detaching devices https://review.opendev.org/741561
13:06:45 openstackgerrit Lee Yarwood proposed openstack/nova stable/ussuri: libvirt: Handle VIR_ERR_DEVICE_MISSING when detaching devices https://review.opendev.org/742414
13:07:23 openstackgerrit Lee Yarwood proposed openstack/nova stable/train: libvirt: Handle VIR_ERR_DEVICE_MISSING when detaching devices https://review.opendev.org/742415
13:07:44 openstackgerrit Lee Yarwood proposed openstack/nova stable/stein: libvirt: Handle VIR_ERR_DEVICE_MISSING when detaching devices https://review.opendev.org/742416
13:08:05 openstackgerrit Lee Yarwood proposed openstack/nova stable/rocky: libvirt: Handle VIR_ERR_DEVICE_MISSING when detaching devices https://review.opendev.org/742417
13:12:36 openstackgerrit Lee Yarwood proposed openstack/nova stable/queens: libvirt: Remove reference to transient domain when detaching devices https://review.opendev.org/608186
13:12:37 openstackgerrit Lee Yarwood proposed openstack/nova stable/queens: libvirt: Handle VIR_ERR_DEVICE_MISSING when detaching devices https://review.opendev.org/742424
13:12:37 openstackgerrit Lee Yarwood proposed openstack/nova stable/queens: sync_guest_time: use the proper errno https://review.opendev.org/742423
13:21:04 lyarwood bauzas: https://review.opendev.org/#/c/729595/ - would you mind hitting this again?
13:21:14 bauzas ack
13:21:56 lyarwood https://review.opendev.org/#/c/729261/ could also use some additional core review if anyone has bandwidth
13:22:51 lyarwood and https://review.opendev.org/#/c/724842/ both are pretty simple
13:27:35 gibi lyarwood: added to my queue but I will focus on the sriov attach this afternoon so I can get to your patches tomorrow
13:29:21 bauzas lyarwood: stephenfin: gibi: others, honestly, I'd be super happy if we could just provide a commit tag for py3-only changes
13:29:30 bauzas something like "Py3-only"
13:29:41 bauzas so, stable cores looking at it would see it
13:29:56 bauzas I know how this can be difficult to do it every time
13:30:20 bauzas but if people don't think about py3 styling, then I'm pretty sure we will get bugs in say one year
13:30:38 bauzas context https://review.opendev.org/#/c/729595/6/nova/virt/libvirt/guest.py@868
13:30:51 bauzas I totally understand that people want to use py3 styling
13:31:17 bauzas but honestly, if you want to do it, think about backports
13:31:35 gibi bauzas: I would expect that such thing is caught by the unit test on the backported patch
13:31:36 lyarwood stable cores would see this, py2 jobs would bork due to this.
13:32:12 lyarwood also, the py3 style boat has sailed
13:32:20 bauzas gibi: well, for https://review.opendev.org/#/c/729595/6/nova/virt/libvirt/guest.py@868 we don't test it, right?
13:32:23 lyarwood stephenfin has been landing stuff for most of the cycle already
13:32:51 bauzas lyarwood: I don't see how CI can see it : https://review.opendev.org/#/c/729595/6/nova/virt/libvirt/guest.py@868
13:32:53 lyarwood bauzas: that's a DEBUG log in a codepath we hit loads in our tempest tests so that would definitley catch it
13:32:54 bauzas with py3
13:33:03 bauzas py2 rather
13:33:12 lyarwood we log at DEBUG in CI
13:33:19 lyarwood we always run tests that hit that codepath
13:33:22 bauzas again, there will be conditions where some code wouldn't be tested by CI and then we would get bugs
13:34:18 bauzas this is not that I hate py3 styling, I'm just conservative with any change that can be backported, that's it
13:34:26 bauzas for a new feature ? sure.
13:34:57 gibi I would rather improve our test coverage than rely on a manual commit tag
13:36:28 bauzas meh, ok, you're right
13:39:00 bauzas lyarwood: fwiw, given you just told that stein jobs would hit this, I upvoted
13:39:45 bauzas my main concern is, please be explicit when you write py3-styling and be clear whether you already thought about backports
13:39:55 bauzas the better commit msg you write, the easier it would be for reviewers
13:40:09 bauzas that's it, I don't want to rathole about f-strings anymore
13:41:13 lyarwood bauzas: FWIW I have no intention of backporting this, it was more to help debug some failures in master CI that look performance related
13:45:07 gibi bauzas: I agree that better commit message helps
13:45:23 bauzas lyarwood: ack, gtk
13:45:25 bauzas thanks
13:50:30 gibi stephenfin: when the reno patch merges for the use-pcpu-and-vcpu-in-one-instance does it mean that the feature is done?
13:52:19 gibi I'm asking this as there are other patches open but they seem to be good to have not must hav
13:52:21 stephenfin gibi: Yep. The only thing that we don't support after that is requesting PCPU + VCPU via 'resources:' extra specs, which we're deferring since it's (a) low priority and (b) interferes with the NUMA in placement work
13:52:37 gibi OK
13:52:58 gibi then I will mark the bp complete (with a note about the deferred part) after the reno merge
13:53:01 gibi s
13:53:23 gibi thanks for checking it
13:57:00 artom gibi, replied on https://review.opendev.org/#/c/741436/, but you seem to have found the right track on your own :)
13:58:11 gibi artom: thanks. I will check if I can check for vlan
13:58:46 gibi artom: thanks for pointing me to the code that was supposed to clean up the metadata I missed that orignally
13:59:02 artom gibi, it was well hidden. Blame mriedem ;)
13:59:19 gibi :)
13:59:31 artom (For real, it was his idea - performance-wise, it's the good choice. Code-understandability-wise, clearly not so great ;)
14:01:50 gibi artom: as far as I see if I simply remove the tag in vif conditional then the code still don't do any expensive things, jut iterate through instance.device_metadata to find the metadata by vif.address
14:02:18 artom gibi, maybe the easiest way to do it is to do a reverse lookup kind of thing: just loop through the device metadata regardless, and if the mac matches the vif mac, delete that entry.
14:02:27 artom gibi, hah, jiinx
14:02:49 gibi that the baseline code does today
14:02:52 artom IOW, as you said, remove the conditional
14:02:58 gibi https://opendev.org/openstack/nova/src/branch/master/nova/network/neutron.py#L1788
14:03:02 gibi Ok

Earlier   Later