Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-07-17
18:17:06 stephenfin tl;dr: I need access at the virt driver layer to both the old and new flavor when confirming/reverting a resize, and I don't have that at the moment because we're zeroing out those attributes before said calls to virt driver
18:17:20 dansmith am covered up in other stuff (some of which I broke) but .. yeah maybe I can look next week
18:17:32 dansmith yeah
18:17:42 stephenfin I'm planning to just delay that zeroing out 'til after, but I don't know if there'll be knock on effects or not
18:17:53 dansmith yeah
18:18:18 stephenfin seeing as your name is beside all the zeroing out, I figure you're the person to ask :)
18:18:22 stephenfin next week is good though
18:18:56 sean-k-mooney stephenfin: do you want me to take a look at that too or should i start from the begining of the seriese
18:19:34 stephenfin sean-k-mooney: If you can follow the flow of that code, sure :)
18:20:03 stephenfin You can do earlier but this is the only bit I personally consider somewhat tricky now. The rest of the series is mostly wiring up stuff
18:20:11 sean-k-mooney well i have not looke at the code in about 2 months so that is why i was hesitent to jump into the end of the series
18:20:27 sean-k-mooney i think i need to start form the start to understand all the dettails
18:21:31 stephenfin Sure, whatever works. It's big. You can ignore the functional test cleanup patches, obv
18:25:09 dansmith stephenfin: just skimming it looks like a lot is missing from that patch you linked
18:25:18 dansmith like, it doesn't seem to do much of what the tin describes
18:25:38 stephenfin \o/
18:25:39 dansmith like, it removes some exceptions and adds some privsep things that don't otherwise get used
18:25:50 dansmith just wondering if you forgot to git add or something
18:26:03 stephenfin maybe I did
18:26:07 stephenfin checking
18:26:19 dansmith ohh, wait, sorry
18:26:33 dansmith the sorted-last v-for-virt stuff was getting hidden under tests
18:26:34 dansmith sorry
18:26:50 stephenfin ah, yes
18:27:05 stephenfin this is all libvirt-specific so nothing happens higher than that
18:28:19 sean-k-mooney stephenfin: oh am ill respin the backport after ci completes or monday
18:28:34 sean-k-mooney but ya i can just move the not to the commit and list the updated file
18:28:52 stephenfin yup, that ought to do the trick
18:29:30 mnaser sean-k-mooney: could we not use libvirt to set mtu and avoid that privsep call?
18:30:05 mnaser or maybe we already use it? https://www.irccloud.com/pastebin/ho53ZFfZ/
18:30:17 mnaser so that mtu set is.. probably not super useful when we're not doing a hybrid plug
18:31:37 sean-k-mooney we do but its needed when using hybrid plug
18:31:59 sean-k-mooney i dont think we need to do it for non hybrid plug
18:32:18 sean-k-mooney mnaser: that said i really want to stop libvirt doing anything related to networking
18:32:38 mnaser ok so architecturally we want os_vif to do the work
18:32:39 sean-k-mooney mnaser: it casues an unavoidble race
18:32:44 sean-k-mooney yes
18:32:51 mnaser that's a fair point, so mtu stays then i guess
18:33:03 sean-k-mooney https://review.opendev.org/#/c/602432/
18:33:32 openstack Launchpad bug 1734320 in OpenStack Compute (nova) "Eavesdropping private traffic" [Undecided,In progress] - Assigned to sean mooney (sean-k-mooney)
18:33:32 sean-k-mooney your familar with https://bugs.launchpad.net/neutron/+bug/1734320 and https://bugs.launchpad.net/neutron/+bug/1815989
18:33:33 openstack Launchpad bug 1815989 in OpenStack Compute (nova) "OVS drops RARP packets by QEMU upon live-migration causes up to 40s ping pause in Rocky" [Medium,In progress]
18:33:38 mnaser ah yes
18:33:54 mnaser so our lack of control when tap goes up
18:34:32 sean-k-mooney what happens today is os-vif set up the port and the l2 agent start to wire it up
18:34:40 sean-k-mooney then libvirt deletes an recreates it
18:35:10 sean-k-mooney that is only a problem when using contrack firewall
18:35:12 mnaser oh yikes, i thought it was os-vif that was wiring up what libvirt creates (but then that's just a race in another direction too)
18:35:38 sean-k-mooney noop
18:35:49 sean-k-mooney libvirt basicaly does if exist delete and recreate
18:36:12 sean-k-mooney undoing all our careful external event stuff
18:36:56 sean-k-mooney for hybrid plug/iptables-firewall, ovs-dpdk and hardware offload
18:37:06 sean-k-mooney os-vif and neutron work togeter
18:37:31 sean-k-mooney but when you use libvirt in the non hybridg plug case it just breaks everything
18:38:45 sean-k-mooney i really wish i or someone lese had time to finish off https://review.opendev.org/#/c/640258
18:39:02 sean-k-mooney but i dont have time to work on that at the moement
18:40:34 mnaser i share that sentiment :)
18:42:01 sean-k-mooney the main proable is while i got it work 15 months ago i dont follow neutron dev that closely anymore so i would basicaly have to start from scrat to figure out why its not working now
20:01:32 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add test coverage of baremetal nodes policies https://review.opendev.org/741707
20:23:15 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in baremetal node https://review.opendev.org/741709
20:41:19 openstackgerrit Alex Deiter proposed openstack/nova master: Detach is broken for multi-attached fs-based volumes https://review.opendev.org/741712
20:59:24 openstackgerrit Merged openstack/nova stable/ussuri: zuul: remove legacy-tempest-dsvm-neutron-dvr-multinode-full https://review.opendev.org/741590
21:06:18 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in baremetal ndoes policies https://review.opendev.org/741716
21:09:48 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Pass the actual target in baremetal nodes policy https://review.opendev.org/741717
21:18:10 openstackgerrit Luigi Toscano proposed openstack/nova stable/train: zuul: remove legacy-tempest-dsvm-neutron-dvr-multinode-full https://review.opendev.org/741720
21:56:16 openstack bug 1862633 in OpenStack Compute (nova) "unshelve leak allocation if update port fails" [Medium,Fix released] https://launchpad.net/bugs/1862633 - Assigned to Balazs Gibizer (balazs-gibizer)
21:56:16 openstackgerrit Merged openstack/nova stable/pike: Reproduce bug 1862633 https://review.opendev.org/740634
22:43:50 openstackgerrit Alex Deiter proposed openstack/nova master: Detach is broken for multi-attached fs-based volumes https://review.opendev.org/741712
#openstack-nova - 2020-07-18
01:50:48 openstackgerrit Merged openstack/nova stable/rocky: Check cherry-pick hashes in pep8 tox target https://review.opendev.org/741492
02:04:13 openstackgerrit Jeffrey Zhang proposed openstack/nova master: Support inject-nmi action in watchdog https://review.opendev.org/741072
02:46:03 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add test coverage of FIP pools policies https://review.opendev.org/741795
02:55:49 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in FIP pools https://review.opendev.org/741796
03:06:10 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Correct the check_str and pass actual target in FIP pools policy https://review.opendev.org/741797
06:20:52 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add test coverage of FIP policies https://review.opendev.org/741799
14:08:39 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.PY2 and six.PY3 https://review.opendev.org/726512
14:09:05 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.add_metaclass https://review.opendev.org/726565
14:09:15 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.reraise https://review.opendev.org/726898
14:09:27 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.moves https://review.opendev.org/727224
14:09:38 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.iteritems/itervalues/iterkeys https://review.opendev.org/727757
14:09:50 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.byte2int/int2byte https://review.opendev.org/727777
14:10:02 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.binary_type/integer_types/string_types https://review.opendev.org/728094
14:10:18 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.text_type (1/2) https://review.opendev.org/728109
14:10:38 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.text_type (2/2) https://review.opendev.org/728117
17:50:57 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Correct the check_str and pass actual target in FIP pools policy https://review.opendev.org/741797
18:31:33 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Fix FIP policy for admin_or_owner https://review.opendev.org/741811
18:38:54 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add test coverage of FIP policies https://review.opendev.org/741812
18:48:44 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in FIP pools https://review.opendev.org/741796
18:48:54 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Correct the check_str and pass actual target in FIP pools policy https://review.opendev.org/741797
18:48:59 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in FIP policy https://review.opendev.org/741813
#openstack-nova - 2020-07-19
02:31:58 openstackgerrit Wenping Song proposed openstack/nova master: Cyborg shelve/unshelve support https://review.opendev.org/729563
07:28:39 openstackgerrit Wenping Song proposed openstack/nova master: Cyborg shelve/unshelve support https://review.opendev.org/729563
#openstack-nova - 2020-07-20
01:34:47 openstackgerrit Keigo Noha proposed openstack/nova master: Change default num_retries for glance to 3 https://review.opendev.org/740389
01:52:05 openstackgerrit Brin Zhang proposed openstack/nova master: Cyborg shelve/unshelve support https://review.opendev.org/729563
03:01:05 openstackgerrit Tony Su proposed openstack/nova master: Provider Config File: YAML file loading and schema validation https://review.opendev.org/673341
03:01:06 openstackgerrit Tony Su proposed openstack/nova master: Provider Config File: Functions to merge provider configs to provider tree https://review.opendev.org/676522
03:01:06 openstackgerrit Tony Su proposed openstack/nova master: Provider Config File: Function to further validate and retrieve configs https://review.opendev.org/676029
03:01:07 openstackgerrit Tony Su proposed openstack/nova master: Provider Config File: Enable loading and merging of provider configs https://review.opendev.org/693460
05:30:04 openstackgerrit Kevin Zhao proposed openstack/nova master: [WIP] CI: add tempest-integrated-compute-aarch64 job https://review.opendev.org/714439
06:35:17 bauzas good morning Nova
06:39:19 brinzhang_ morning bauzas^

Earlier   Later