| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-07-17 | |||
| 13:52:56 | sean-k-mooney | yep whcih is exactly what we do for numa | |
| 13:53:00 | sean-k-mooney | on rebuild at least | |
| 13:53:32 | sean-k-mooney | but before going down this route | |
| 13:53:39 | sean-k-mooney | do you need to have 2 keys | |
| 13:53:54 | sean-k-mooney | could you not just use the same key for both vtpms | |
| 13:54:09 | stephenfin | that's an interesting point | |
| 13:54:38 | stephenfin | we could indeed, given the owner has changed | |
| 13:54:55 | stephenfin | let me see how that works | |
| 13:55:24 | stephenfin | twas all garbage anyway | |
| 13:55:36 | openstack | bugzilla.redhat.com bug 1782834 in openvswitch "Changing protocols in Bridge table doesn't take effect" [High,New] - Assigned to aconole | |
| 13:55:36 | mnaser | sean-k-mooney: fyi, you might find this interesting -- https://bugzilla.redhat.com/show_bug.cgi?id=1782834 and neutron workaround https://review.opendev.org/#/c/733674/ for ovs 2.12 | |
| 13:55:50 | sean-k-mooney | if that proves difficutl to implement we can use that as justification for blocking and move the two thing you tried into alternitives | |
| 13:57:33 | sean-k-mooney | mnaser: huh that inconveniant | |
| 13:57:53 | sean-k-mooney | mnaser: strangly enough i was asked to look at this patch earlier today | |
| 13:57:55 | sean-k-mooney | https://review.opendev.org/#/c/738551/7/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py@2163 | |
| 13:57:58 | melwitt | lyarwood: sure, will do | |
| 13:58:09 | sean-k-mooney | which is also setting the openflow versions | |
| 14:01:42 | mnaser | ovs-vsctl set bridge br-int protocols=OpenFlow10,OpenFlow11,OpenFlow12,OpenFlow13,OpenFlow14,OpenFlow15 doesn't really fix much | |
| 14:02:45 | mnaser | let me restart the ovs agent after that | |
| 14:31:25 | gibi | stephenfin: regarding vTPM. We can block the resize and rebuild if that result in a loss of vTPM data as a first step. I'm fine with taht | |
| 14:43:11 | gibi | dansmith: hi! I talked to the release team about M2 and it turned out that we don't need a nova release just an os-vif and python-novaclient release and those can be made before M2. So I will propose those lib releases next week and then there is nothing to do at M2 from release perspective | |
| 14:43:37 | dansmith | gibi: I saw, cool, I *definitely* volunteer then :) | |
| 14:43:50 | gibi | cool :) | |
| 14:45:33 | gibi | dansmith: can I ask you to run the weekly meeting on the 30th? | |
| 14:46:14 | dansmith | gibi: yeah | |
| 14:46:46 | gibi | thank you | |
| 14:49:37 | gmann | gibi: zero_downtime upgrade job use zero_downtime/hooks/run_tests.sh which i did not find in git history at all when it was added/remvoed - https://opendev.org/openstack/openstack-zuul-jobs/src/branch/master/playbooks/legacy/grenade-dsvm-neutron-multinode-zero-downtime/run.yaml#L45 | |
| 14:50:08 | gmann | we do not test zero downtime upgrade (i think none of project does) in any other job | |
| 14:51:15 | gmann | so i agree to remove this broken job and if we want/do test zero_downtime in future then we write new job on zuulv3 | |
| 14:51:29 | gibi | gmann: thanks for checking | |
| 14:52:13 | gmann | none of the projects use zero_downtime upgrade TC tag https://governance.openstack.org/tc/reference/tags/assert_supports-zero-downtime-upgrade.html | |
| 14:52:54 | lyarwood | kashyap: https://review.opendev.org/#/c/741561/ - if you have time for a review before leaving for the weekend btw | |
| 14:53:13 | gmann | I will remove(once all stable branch remove the job ) the job definition also from opensatck-zuul-jobs as this job is only used by nova | |
| 14:53:33 | kashyap | lyarwood: Hiya, definitely | |
| 14:54:20 | gibi | gmann: cool | |
| 14:57:45 | kashyap | lyarwood: Looks good; also bonus marks for the nice reproducer write-up! | |
| 14:58:06 | sean-k-mooney | gmann: im not sure that any of the service got to the poitn where they could have contol planes on two differetn versions did they | |
| 14:58:33 | sean-k-mooney | that would be the main issue for nova | |
| 14:59:15 | sean-k-mooney | n an n+1 would expect diffferent db version and potatiall rpcs version so we cannot run both in parralel | |
| 14:59:31 | sean-k-mooney | even if we can upgrade the contoelr indepently of the comptue nodes | |
| 15:06:22 | gmann | sean-k-mooney: is not load balancer should disable n-api on node which is going to be upgraded and redirect request to other api node. once first api node is upgraded then bring up the n-api and disable 2nd api node .. | |
| 15:09:18 | gmann | i mean HAProxy should be disable the request on one api node when we upgrade that so that request can be served from other api node and zero downtime on api service | |
| 15:11:52 | sean-k-mooney | gmann: no that wont work | |
| 15:18:05 | bauzas | gibi: dansmith: fwiw, sorry if I was unclear but i'll be there on week from July 27th to 30th (excluding Friday probably) | |
| 15:18:27 | gibi | bauzas: no worries. It turned out that there is nothing pressing to handle at M2 | |
| 15:18:31 | bauzas | but either way, all good if dansmith can release m-2 and lead the meeting :) | |
| 15:18:36 | gibi | :) | |
| 15:20:58 | sean-k-mooney | gmann: its not just the api its also the conductor and schuler that need to agree on the db schemes and rpc verions | |
| 15:29:25 | openstackgerrit | Balazs Gibizer proposed openstack/nova-specs master: Support SRIOV interface attach and detach https://review.opendev.org/741601 | |
| 15:29:50 | gibi | stephenfin, sean-k-mooney: ^^ fixed up the spec | |
| 15:30:46 | melwitt | lyarwood: commented, there are some odd things in the tests (args passed but not used) and tests that are simulating non-real situations, not sure if that was intended | |
| 15:32:21 | lyarwood | melwitt: ack looking | |
| 15:32:44 | lyarwood | sean-k-mooney: https://review.opendev.org/#/c/728057/ btw, looks like this change blows up when we log anything in ERROR | |
| 15:36:59 | stephenfin | gibi: +2 for me. Seems like a no-brainer if you're able to do the work | |
| 15:37:19 | sean-k-mooney | it does? | |
| 15:37:49 | stephenfin | sean-k-mooney: I thought you were talking to me there for a sec | |
| 15:37:50 | sean-k-mooney | it is not even specific to the error log | |
| 15:38:32 | sean-k-mooney | oh no lyarwood ^ | |
| 15:39:19 | sean-k-mooney | gibi: looking now | |
| 15:40:45 | gibi | stephenfin: I think I can do the work. The WIP patch already works for me in devstack so only automatic testing and documentation is missing. | |
| 15:40:54 | gibi | stephenfin, sean-k-mooney: thanks | |
| 15:40:57 | stephenfin | \o/ | |
| 15:41:28 | lyarwood | sean-k-mooney: yeah I assume py27 doesn't like the filter you provided? | |
| 15:41:34 | sean-k-mooney | gibi: +1 | |
| 15:41:46 | gibi | awesome, thanks | |
| 15:41:46 | sean-k-mooney | lyarwood: ah yes that is possible | |
| 15:42:07 | sean-k-mooney | lyarwood: its a generator expression | |
| 15:42:08 | lyarwood | https://docs.python.org/2/library/logging.html#filter-objects | |
| 15:42:13 | openstackgerrit | Stephen Finucane proposed openstack/nova master: mypy: Add nova.cmd, nova.conf, nova.console https://review.opendev.org/705657 | |
| 15:42:13 | openstackgerrit | Stephen Finucane proposed openstack/nova master: mypy: Add type annotations to 'nova.pci' https://review.opendev.org/676209 | |
| 15:42:14 | openstackgerrit | Stephen Finucane proposed openstack/nova master: rpc: Rework 'get_notifier', 'wrap_exception' https://review.opendev.org/741663 | |
| 15:42:14 | openstackgerrit | Stephen Finucane proposed openstack/nova master: mypy: Add type annotations to top-level modules https://review.opendev.org/705658 | |
| 15:42:15 | melwitt | lyarwood: fyi guh, the ceph job looks like it's been angry on stable branches | |
| 15:42:22 | lyarwood | it needs to be in a filter method | |
| 15:42:22 | sean-k-mooney | return not any(msg in log_record.msg for msg in messages) | |
| 15:42:36 | lyarwood | melwitt: yeah I have a few changes open to look at | |
| 15:42:53 | melwitt | ack | |
| 15:43:56 | stephenfin | sean-k-mooney, lyarwood: Looks like it needs to be a specific class in Python 2? https://docs.python.org/2/library/logging.html#filter | |
| 15:44:02 | stephenfin | https://docs.python.org/2/library/logging.html#filter-objects | |
| 15:44:47 | lyarwood | right | |
| 15:44:53 | stephenfin | actually idk, nothing in the docs by way of versionedchanged admonitions | |
| 15:45:09 | stephenfin | so if it's a change, it's not well documented | |
| 15:45:17 | lyarwood | between 3 and 2? | |
| 15:45:21 | lyarwood | ha | |
| 15:45:51 | sean-k-mooney | stephenfin: ah ok | |
| 15:46:03 | sean-k-mooney | ill go fix that so | |
| 15:46:12 | stephenfin | it might be worth checking what you've done *definitely* works on Python 3 | |
| 15:46:28 | stephenfin | if it does, I'd be game to submit a PR to the Python docs | |
| 15:46:29 | lyarwood | stephenfin: I'm pretty sure we've logged stuff at ERROR in CI ;) | |
| 15:46:57 | lyarwood | stephenfin: oh but you mean actually works | |
| 15:47:04 | sean-k-mooney | https://docs.python.org/3.8/library/logging.html#logging.Filter | |
| 15:47:12 | sean-k-mooney | "You don’t actually need to subclass Filter: you can pass any instance which has a filter method with the same semantics." | |
| 15:47:23 | stephenfin | sean-k-mooney++ Good spot | |
| 15:47:33 | stephenfin | python-docs++ | |
| 15:48:18 | sean-k-mooney | i didnt see that was py3 only | |
| 15:48:25 | sean-k-mooney | but its easy to fix | |
| 15:48:41 | sean-k-mooney | that said i have dinner/breakfast cooking so ill do it in an hour or so | |
| 15:50:36 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Handle VIR_ERR_DEVICE_MISSING when detaching devices https://review.opendev.org/741561 | |
| 15:50:48 | lyarwood | ^ melwitt ; hopefully sorted now thanks again | |
| 15:52:09 | melwitt | lyarwood: I didn't catch you with my latest comment but it's just a thought anyway | |