Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-07-09
12:21:19 stephenfin looking
12:21:43 sean-k-mooney isnt that stephens pathc
12:22:17 gibi sean-k-mooney: the explanation is not from Stephen
12:22:23 sean-k-mooney ah
12:22:44 sean-k-mooney i was like the fact he wrote it proably means he thinks its correct
12:23:03 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.moves https://review.opendev.org/727224
12:23:33 stephenfin gibi: Yeah, so numa_topology is set to None on line 1813 https://review.opendev.org/#/c/714701/12/nova/virt/hardware.py@a1813
12:23:38 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.iteritems/itervalues/iterkeys https://review.opendev.org/727757
12:23:46 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.byte2int/int2byte https://review.opendev.org/727777
12:23:47 stephenfin and it's not set to anything else until it's returned on line 1915
12:23:50 stephenfin in the old code, this is
12:23:54 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.binary_type/integer_types/string_types https://review.opendev.org/728094
12:24:05 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.text_type (1/2) https://review.opendev.org/728109
12:24:16 gibi stephenfin: ack, thanks
12:24:27 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.text_type (2/2) https://review.opendev.org/728117
12:25:10 gibi stephenfin: if you are at it, I have a similar question in https://review.opendev.org/#/c/714703/11/nova/virt/hardware.py@a1148
12:26:20 stephenfin iirc no because it's set by something else later, but let me double check :)
12:26:32 sean-k-mooney that if looks correct to me too by the way
12:26:55 sean-k-mooney although i proably woudl have fliped it and returned none rather then the else
12:27:33 openstackgerrit Merged openstack/nova stable/rocky: Fix os_CODENAME detection and repo refresh during ceph tests https://review.opendev.org/739608
12:30:13 lyarwood \o/
12:30:55 openstackgerrit Wenping Song proposed openstack/nova-specs master: Add no user token when get Cyborg client https://review.opendev.org/740184
12:31:16 stephenfin gibi: I need to pull this down to figure it out, but I'm in the middle of fixing up some vTPM stuff. I'll get to it soon as I'm done with that :)
12:31:45 gibi stephenfin: no worries I can switch from vtpm to the pcpu series in the meantime
12:32:00 gibi I mean the opposite
12:32:43 stephenfin gibi: Cool. This one's the one I'm fixing by the way. I got my logic wrong :( Comments left https://review.opendev.org/#/c/739208/3
12:33:10 stephenfin I'm going to get rid of the '_create_domain_from_guest' function entirely since it's not doing what we think (all it does is resume the guest)
12:33:55 stephenfin that file needs to be broken up asap :(
12:34:03 sean-k-mooney stephenfin: while you are hear quick question about the type annotation, do you only use 'module.classname' for cases where it is not in scope locally where you are using the annotation
12:34:14 sean-k-mooney there is no reason to do that if its in scope correct
12:34:24 stephenfin sean-k-mooney: I have a great answer for that prepared for gibi :D
12:34:38 gibi stephenfin: I missed that logic error too. good catch
12:34:40 stephenfin sean-k-mooney: https://review.opendev.org/#/c/730382/6/nova/virt/libvirt/driver.py@3586
12:34:55 sean-k-mooney i was reading the upstream docs and i cant find any reference to the '' syntax that is why i asked
12:35:09 sean-k-mooney as i would have assume that triggered type inferance and would treat it as a sting
12:35:42 stephenfin Nope, it just prevents Python (the interpreter) from parsing it
12:35:47 stephenfin Only mypy will do so
12:36:00 sean-k-mooney ah ok
12:36:06 stephenfin sean-k-mooney: https://www.python.org/dev/peps/pep-0563/
12:36:07 sean-k-mooney reading your responce now
12:36:49 sean-k-mooney gibi: its relitivly new and still evolving
12:36:51 stephenfin sean-k-mooney: and also https://mypy.readthedocs.io/en/latest/kinds_of_types.html#class-name-forward-references
12:37:20 sean-k-mooney ah i skimed the kinds_of_types section a few mintues ago but missed that
12:37:32 stephenfin Yeah, lots of rough edges. I like what it promises though, plus the fact we can introduce it in stages
12:37:59 sean-k-mooney ah its a forwared refernce that is what i was asking
12:38:35 sean-k-mooney its like when you do struct MyStruct{}; in c/c++ to avoid importing MyStruct.h
12:41:40 sean-k-mooney i almost never write c++ but i watch a tone of talks ans podcasts on c++
12:42:19 sean-k-mooney i hate c but to be honest after 7+ years of python at this point im now coming to like it as much or more then c++
12:42:48 sean-k-mooney type hits certenly remove one of my gripes with python
12:46:35 gibi I wrote c++ last time 7 years ago still I appreciate it as a language. I would go with Rust if I have to choose today
12:48:12 sean-k-mooney i dont like the syntax of rust but i can appreciate some of the design chosies regarding the borrow checker. though the clang based tooling that has been wrrent for c++ is quickly approchign the same level of checking
12:49:08 sean-k-mooney languates that use let to intoduce variables like basic just feel strange to me
12:49:45 sean-k-mooney it took me a very long time to get used to type on the right had side of an identifier too
12:50:47 sean-k-mooney its becomeing the norm now but the reason new lanagues do that is its eaier to write the parser it has nothing to do with human readabilty
12:55:55 gibi stephenfin: you did a nice job splitting up the vtpm series. thank you for that
12:56:36 stephenfin np
12:56:56 stephenfin thanks for the reviews :)
12:57:05 stephenfin be sure to let me know if I can return the favour
12:57:46 gibi sure :)
13:05:37 openstackgerrit Lee Yarwood proposed openstack/nova stable/rocky: Reject boot request for unsupported images https://review.opendev.org/708608
13:05:42 openstack bug 1550919 in OpenStack Compute (nova) rocky "[Libvirt]Evacuate fail may cause disk image be deleted" [Medium,In progress] https://launchpad.net/bugs/1550919 - Assigned to Lee Yarwood (lyarwood)
13:05:42 openstackgerrit Lee Yarwood proposed openstack/nova stable/rocky: Add functional test for bug 1550919 https://review.opendev.org/732707
13:05:52 openstackgerrit Lee Yarwood proposed openstack/nova stable/rocky: libvirt: Don't delete disks on shared storage during evacuate https://review.opendev.org/732708
13:07:24 openstackgerrit Lee Yarwood proposed openstack/nova stable/rocky: compute: Allow snapshots to be created from PAUSED volume backed instances https://review.opendev.org/729177
13:07:39 openstackgerrit Lee Yarwood proposed openstack/nova stable/rocky: libvirt: check job status for VIR_DOMAIN_EVENT_SUSPENDED_MIGRATED event https://review.opendev.org/711233
13:08:55 openstackgerrit Lee Yarwood proposed openstack/nova stable/rocky: Block rebuild when NUMA topology changed https://review.opendev.org/703116
13:08:55 openstackgerrit Lee Yarwood proposed openstack/nova stable/rocky: Remove 'test_cold_migrate_with_physnet_fails' test https://review.opendev.org/703115
13:08:56 openstackgerrit Lee Yarwood proposed openstack/nova stable/rocky: FUP for in-place numa rebuild https://review.opendev.org/703118
13:08:56 openstackgerrit Lee Yarwood proposed openstack/nova stable/rocky: Disable NUMATopologyFilter on rebuild https://review.opendev.org/703117
13:09:29 lyarwood sean-k-mooney: ^ rebased for you btw
13:16:46 sean-k-mooney oh cool thanks
13:37:09 openstackgerrit Huaqiang Wang proposed openstack/nova master: libvirt: apply mixed instance CPU policy https://review.opendev.org/728481
13:37:09 openstackgerrit Huaqiang Wang proposed openstack/nova master: objects: Introduce the 'CPUAllocationPolicy.MIXED' enum https://review.opendev.org/716267
13:37:10 openstackgerrit Huaqiang Wang proposed openstack/nova master: Calculate the CPU usage for mixed instance https://review.opendev.org/716269
13:37:10 openstackgerrit Huaqiang Wang proposed openstack/nova master: Validate CPU pinning configuration for mixed instance https://review.opendev.org/716268
13:37:11 openstackgerrit Huaqiang Wang proposed openstack/nova master: flavor: Enable 'hw:cpu_dedicated_mask' for creating a mixed instance https://review.opendev.org/714706
13:37:11 openstackgerrit Huaqiang Wang proposed openstack/nova master: scheduler: mixed instance CPU resource translating https://review.opendev.org/728482
13:37:12 openstackgerrit Huaqiang Wang proposed openstack/nova master: hardware: create 'mixed' instance for realtime and shared CPUs https://review.opendev.org/728485
13:37:12 openstackgerrit Huaqiang Wang proposed openstack/nova master: compute: bump nova-compute service version for mixed instance https://review.opendev.org/716271
13:37:13 openstackgerrit Huaqiang Wang proposed openstack/nova master: metadata: export the vCPU IDs that are pinning on the host CPUs https://review.opendev.org/688936
13:37:13 openstackgerrit Huaqiang Wang proposed openstack/nova master: hardware: refactor numa_get_constraints https://review.opendev.org/718294
13:37:14 openstackgerrit Huaqiang Wang proposed openstack/nova master: release note: add new features introduces by use-pcpu-and-vcpu-in-one-instance https://review.opendev.org/736997
13:38:11 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Simplify '_create_domain' function https://review.opendev.org/739208
13:38:14 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Add vTPM config support https://review.opendev.org/739209
13:38:15 openstackgerrit Stephen Finucane proposed openstack/nova master: crypto: Add support for creating, destroying vTPM secrets https://review.opendev.org/739211
13:38:15 openstackgerrit Stephen Finucane proposed openstack/nova master: scheduler: Request vTPM trait based on flavor or image https://review.opendev.org/739210
13:38:16 openstackgerrit Stephen Finucane proposed openstack/nova master: Add emulated TPM support to Nova https://review.opendev.org/631363
13:38:16 openstackgerrit Stephen Finucane proposed openstack/nova master: manager: Prevent compute startup on invalid vTPM config https://review.opendev.org/739212
13:38:17 openstackgerrit Stephen Finucane proposed openstack/nova master: Add support for resize and cold migration of emulated TPM files https://review.opendev.org/639934
13:38:18 openstackgerrit Stephen Finucane proposed openstack/nova master: docs: Add docs for vTPM support https://review.opendev.org/739213
13:44:08 openstackgerrit Dan Smith proposed openstack/nova master: DNM: Try to make a glance multistore job https://review.opendev.org/734184
13:48:29 stephenfin gibi: Have effectively rewritten https://review.opendev.org/#/c/739208/ again from learnings on the previous PS. Hopefully it makes sense
13:57:38 openstackgerrit Lee Yarwood proposed openstack/nova master: WIP/DNM zuul: Attempt to migrate and break up the nova-live-migration job https://review.opendev.org/711604
14:12:32 openstackgerrit Merged openstack/nova master: hardware: Invert order of NUMA topology generation https://review.opendev.org/714701
14:56:24 openstackgerrit Ghanshyam Mann proposed openstack/os-vif master: DNM: testing os-vif gate on ubuntu focal https://review.opendev.org/738130
15:11:22 openstackgerrit Merged openstack/nova stable/queens: Fix os_CODENAME detection and repo refresh during ceph tests https://review.opendev.org/740193
15:22:55 openstackgerrit Ghanshyam Mann proposed openstack/nova master: migrate testing to ubuntu focal https://review.opendev.org/738126
15:42:58 openstackgerrit Merged openstack/python-novaclient master: Switch legacy Zuul jobs to native Zuul v3 jobs https://review.opendev.org/725163
15:44:45 openstackgerrit Lee Yarwood proposed openstack/nova stable/stein: Remove stale nested backport from InstancePCIRequests https://review.opendev.org/738199
15:44:48 openstackgerrit Lee Yarwood proposed openstack/nova stable/train: libvirt: Mark e1000e VIF as supported https://review.opendev.org/736962

Earlier   Later