| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-06-25 | |||
| 17:11:58 | sean-k-mooney | if you give a user the the admin role they shoudl be able to add teh project to a private flavor in my view and then other user in the prorject with "member" but not "admin" should be able to use it | |
| 17:12:25 | sean-k-mooney | so i think that bug is invaild yes | |
| 17:13:06 | sean-k-mooney | mriedem: traiged it however so i guess he taught it was valid i need to read the irclogs to see why as the context is not directly in the bug | |
| 17:13:18 | sean-k-mooney | harsha24: ^ | |
| 17:13:46 | sean-k-mooney | harsha24: im sure he had a good reason to make it traiged and therefor valid | |
| 17:15:45 | sean-k-mooney | ok so this i a more subtel bug then it seams looking at http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2019-11-26.log.html#t2019-11-26T16:20:24 | |
| 17:16:00 | harsha24 | I have gone through that irclogs and i have changed the code part which returns true in https://review.opendev.org/#/c/735068/ | |
| 17:16:35 | sean-k-mooney | you mean which raises failure | |
| 17:16:42 | harsha24 | yeah | |
| 17:16:58 | sean-k-mooney | you did not update the comment by the way | |
| 17:17:27 | sean-k-mooney | you are not defaulting to "it's ok" anymore you are raising a failure | |
| 17:19:05 | harsha24 | how to get pass the zuul code review | |
| 17:20:05 | sean-k-mooney | harsha24: are you asking how to get teh code merged | |
| 17:20:22 | sean-k-mooney | harsha24: if so then you need to get peopel to be interested and review the patch | |
| 17:21:13 | sean-k-mooney | an alternitive way to do this would be for nova to use its admin permisison to check if the porject exits in this case | |
| 17:21:29 | sean-k-mooney | im trying to see if that was discussed and discarded before | |
| 17:22:07 | harsha24 | sean-k-mooney you did not update the comment by the way | |
| 17:22:36 | harsha24 | which comment are you mentioning here | |
| 17:22:39 | stephenfin | gmann would be a good person to review that patch also | |
| 17:22:51 | sean-k-mooney | harsha24: https://review.opendev.org/#/c/735068/3/nova/api/openstack/identity.py | |
| 17:23:01 | sean-k-mooney | harsha24: i left a comment on the code review | |
| 17:23:04 | harsha24 | is it ok with the failures in zuul pipeline checks | |
| 17:24:07 | sean-k-mooney | harsha24: you have unit test failure you need to update nova.tests.unit.test_identity.IdentityValidationTest.test_unknown_id | |
| 17:24:10 | sean-k-mooney | for the new behavior | |
| 17:24:30 | sean-k-mooney | so the py36 and py38 failures are correct | |
| 17:25:04 | sean-k-mooney | its the same issue for lower constratins and cover job | |
| 17:25:13 | harsha24 | where do I need to update the test case | |
| 17:25:17 | sean-k-mooney | the grenade job failure are likely not related to your change | |
| 17:25:43 | harsha24 | okay | |
| 17:26:05 | sean-k-mooney | here https://github.com/openstack/nova/blob/master/nova/tests/unit/test_identity.py#L85-L94 | |
| 17:26:25 | gmann | stephenfin: ack, will do after rbac meeting | |
| 17:26:59 | sean-k-mooney | harsha24: you need to replace the self.assertTrue( with self.assertRaises like the test_no_project one above it | |
| 17:27:52 | harsha24 | ok got it Thank you | |
| 17:28:31 | harsha24 | can you review this too https://review.opendev.org/#/c/737215/ | |
| 17:32:51 | sean-k-mooney | harsha24: i added stephenfin to https://review.opendev.org/#/c/737215/1 ill take a look. moving it out of the rdo section into a common section seams resonable but i have not looked to see if we shoudl cross freference it in the old section or not and if its correct in context | |
| 17:33:45 | harsha24 | okay | |
| 17:33:45 | sean-k-mooney | harsha24: so i wont review it fully now but ill review later | |
| 17:34:04 | openstack | Launchpad bug 1700999 in OpenStack Compute (nova) "during nova service install ,an unneeded httpd conf bug fix causes openstack client cli crash" [High,In progress] - Assigned to Harshavardhan Metla (harsha24) | |
| 17:34:04 | sean-k-mooney | im not realy shure how that closes https://bugs.launchpad.net/nova/+bug/1700999 | |
| 17:34:57 | sean-k-mooney | although i see that is what was suggesed in the bug | |
| 17:35:21 | harsha24 | this bug is actually caused by a bug fix of another bug | |
| 17:35:36 | sean-k-mooney | we dont often run true the manual install process so those guids can get out of data pretty quickly | |
| 17:36:41 | harsha24 | So, does this makes the bug invalid and the doc is pretty old ocata release | |
| 17:37:14 | sean-k-mooney | not nessisarly your updating the master doc | |
| 17:37:25 | sean-k-mooney | not the ocata one for what its worth | |
| 17:38:29 | sean-k-mooney | but its been at least 6 years since i manually did an openstack in stall so i can more or less tell you that the install guides are not hevilly tested so its not uncommon for them to be outdated and have bugs like this | |
| 17:40:01 | harsha24 | okay | |
| 17:57:04 | mnasiadka | Hi there | |
| 17:57:33 | mnasiadka | Is there any reason or known bug that nova-compute logs are stuck on "Creating image" while spawning instance? (Train) | |
| 18:19:11 | openstackgerrit | Harshavardhan Metla proposed openstack/nova master: moved the quoted section https://review.opendev.org/738081 | |
| 18:29:27 | openstackgerrit | Harshavardhan Metla proposed openstack/nova master: Raising a failure in case of 403 https://review.opendev.org/735068 | |
| 18:43:51 | sean-k-mooney | mnasiadka: kindof | |
| 18:44:26 | openstack | Launchpad bug 1874032 in OpenStack Compute (nova) "nova-compute become stuck when doing IO on busy file system" [Wishlist,In progress] - Assigned to Alexandre arents (aarents) | |
| 18:44:26 | sean-k-mooney | mnasiadka: https://bugs.launchpad.net/nova/+bug/1874032 https://review.opendev.org/#/c/734776/6 | |
| 18:45:14 | mnasiadka | sean-k-mooney: rather not the case, the disk is not i/o busy | |
| 18:45:14 | sean-k-mooney | mnasiadka: so if you are hitting ^ aarents almost has the fix ready | |
| 18:45:43 | sean-k-mooney | in that case no im not aware of a bug where nova hangs on taking a snapshot | |
| 18:46:30 | mnasiadka | It’s spawning a new vm, not a snapshot... then let me try to do some tracing what is it stuck on... | |
| 18:47:09 | sean-k-mooney | oh "openstack server create image" is how you create a snapshot sorry | |
| 18:47:52 | sean-k-mooney | mnasiadka: so its hangin on actully creating the image on disk are you sueing the default qcow/flat image backend | |
| 18:49:22 | openstack | Launchpad bug 1880828 in OpenStack Bundles "New instance is always in "spawning" status" [Undecided,New] | |
| 18:49:22 | sean-k-mooney | mnasiadka: i assume its not this https://bugs.launchpad.net/nova/+bug/1880828 | |
| 18:53:11 | mnasiadka | sean-k-mooney: in my case it looks like it’s stuck on downloading image, because there’s only disk.info file and no image fragments anywhere | |
| 18:58:45 | openstack | Launchpad bug 1884068 in OpenStack Compute (nova) "Instance stuck in build state when some/one compute node is unreachable" [Undecided,New] | |
| 18:58:45 | sean-k-mooney | gibi: does my last comment #3 on https://bugs.launchpad.net/nova/+bug/1884068 make sense to you? i think we shoudl close that as nto a bug | |
| 18:59:04 | sean-k-mooney | mnasiadka: it would be good to check the glance log then | |
| 18:59:25 | sean-k-mooney | and see if it handeled the requiest properly? | |
| 20:00:40 | mnasiadka | sean-k-mooney: glance says it did, but I don’t trust it ;) | |
| 21:07:51 | mnaser | hmm | |
| 21:08:43 | mnaser | https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L1893 and https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L1941 and https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L1612 and https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L1744 all bomb out prettty hard if placement isn't available | |
| 21:08:55 | mnaser | because json() fails to decode json content and it blows up in very bad ways | |
| 21:10:53 | mnaser | does anyone know if there's a way of checking if the content is json first? | |
| 21:11:06 | mnaser | i could try/except but eh | |
| 21:49:38 | dansmith | mnaser: content-type? | |
| 21:50:11 | dansmith | but try..except around the .json is the python way | |
| 22:04:58 | mriedem | seems like that would be a lot of moles to whack over time, i'm assuming you're getting html back? also, isn't there a retries wrapper on that? | |
| 22:05:18 | mriedem | twould be way down in ksa if there is | |
| 22:09:17 | dansmith | I was just assuming that was coming straight from requests | |
| 22:09:30 | mriedem | else yeah you can check the response headers https://requests.readthedocs.io/en/master/user/quickstart/#response-headers | |
| 22:09:36 | dansmith | but yeah, looks like lots of assuming success there | |
| 22:09:40 | mriedem | `r.headers.get('content-type')` | |
| 22:09:57 | mriedem | i think our stuff uses ksa which wraps requests way down in the bowels | |
| 22:10:07 | dansmith | ack | |
| 22:10:12 | mriedem | and i'm assuming there is a urllib3 Retry wrapper in the mix | |
| 22:10:59 | mriedem | if retries timeout you get a different error, but i've also seen the weirdness where you get back like a 302 with html content assuming `if r:` (truthy) and then blow on on `r.json()` | |
| 23:23:28 | openstackgerrit | Merged openstack/nova master: Plumb image import functionality through our glance module https://review.opendev.org/731550 | |
| #openstack-nova - 2020-06-26 | |||
| 00:49:13 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: DNM: testing nova gate on ubuntu focal https://review.opendev.org/738126 | |
| 01:45:41 | openstackgerrit | Ghanshyam Mann proposed openstack/os-vif master: DNM: testing os-vif gate on ubuntu focal https://review.opendev.org/738130 | |
| 01:48:33 | mnaser | dansmith, mriedem: in my case, i'm getting non-json content (because there's a load balancer infront of placement) | |
| 01:48:36 | mnaser | content-type seems sane though | |
| 02:32:51 | openstackgerrit | Jinsheng Zhang proposed openstack/nova master: Add API to support multiple boot-volumes with boot order selection https://review.opendev.org/737913 | |
| 02:40:09 | gmann | dansmith: melwitt sean-k-mooney elod gibi pep8 job cherry pick script failure was just rebase issue (somehow zuul way of merging the code at runtime did not work for this script). after rebase, script can find all hashes correctly and job pass - https://review.opendev.org/#/c/728057/ | |
| 02:43:37 | sean-k-mooney | gmann: it might be down to the branch name | |
| 02:44:03 | sean-k-mooney | e.g. how zuul create the reiview branch and merges things | |
| 02:44:40 | sean-k-mooney | but glad it worked. | |
| 02:45:36 | gmann | yeah and commit msg is somethings not being picked correctly that is why hashes were not picked by script | |
| 02:48:29 | sean-k-mooney | anyway im going to go to sleep now o/ i was just getting my phone which i left on my desk :) | |
| 03:32:16 | openstackgerrit | Merged openstack/nova master: Raise InstanceMappingNotFound if StaleDataError is encountered https://review.opendev.org/734400 | |
| 03:35:01 | openstackgerrit | Wenping Song proposed openstack/nova master: WIP: Cyborg shelve/unshelve support https://review.opendev.org/729563 | |
| 08:07:08 | openstackgerrit | Jinsheng Zhang proposed openstack/nova master: Add API to support multiple boot-volumes with boot order selection https://review.opendev.org/737913 | |