| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-06-25 | |||
| 00:54:19 | melwitt | gmann: cool.. I'm trying to figure out why the cherry pick validation is failing on that tho | |
| 00:55:04 | gmann | melwitt: its ussuri backport is still not merged - https://review.opendev.org/#/c/736073/ | |
| 00:55:32 | melwitt | ohhhh cool. guh, guess I needed a better error message :P | |
| 01:11:12 | gmann | melwitt: you are right, error message is not right one, this should be the error- https://github.com/openstack/nova/blob/1cae0cd7229207478b70275509aecd778ca69225/tools/check-cherry-picks.sh#L13 | |
| 01:11:54 | melwitt | gmann: similar to that but not exactly -- that error is saying it's not anywhere, but in this case it's on master so it passes by that | |
| 01:12:19 | gmann | i think it is not finding any hashes in line 7 and then only going to check for the stable*only tag - https://github.com/openstack/nova/blob/1cae0cd7229207478b70275509aecd778ca69225/tools/check-cherry-picks.sh#L7 | |
| 01:13:42 | melwitt | yeah... but why I wonder? there's hashes in the commit message | |
| 01:14:00 | gmann | yeah, not sure why. | |
| 01:16:40 | melwitt | when it try it locally it picks up hashes | |
| 01:16:52 | melwitt | (when I run the git show ... manually) | |
| 01:18:09 | gmann | yeah, same i tried and it picked both the hases | |
| 01:18:12 | gmann | hashes | |
| 01:18:26 | melwitt | yeah | |
| 01:19:36 | gmann | its failing same way even all previous branch backport are merged, this one should pass but fail - https://review.opendev.org/#/c/728057/ | |
| 01:20:23 | openstackgerrit | Merged openstack/nova master: objects: Replace 'cpu_pinning_requested' helper https://review.opendev.org/714697 | |
| 01:21:05 | melwitt | uh oh | |
| 01:33:27 | gmann | melwitt: locally i ran full script and got the right error - "Cherry pick hash eedc0b5ff319b3cce42dba4c4720bcb98798e064 not on any master or stable branches" | |
| 01:33:56 | melwitt | oh yeah ok | |
| 01:34:00 | melwitt | weird | |
| 01:34:10 | melwitt | I wonder why it doesn't do that in gate | |
| 01:34:56 | melwitt | and why is that other change failing erroneously. I'm too tired to look right now | |
| 01:36:47 | gmann | yeah, me too. will check in morning. | |
| 01:37:23 | melwitt | +1 | |
| 02:17:04 | openstackgerrit | Jinsheng Zhang proposed openstack/nova stable/rocky: Add API to support multiple boot-volumes with boot order selection https://review.opendev.org/737893 | |
| 03:40:34 | openstackgerrit | Jinsheng Zhang proposed openstack/nova-specs master: Add nova-support-multiple-boot-volume-with-boot-order-selection spec https://review.opendev.org/737897 | |
| 06:53:43 | openstackgerrit | Jinsheng Zhang proposed openstack/nova master: Add API to support multiple boot-volumes with boot order selection https://review.opendev.org/737913 | |
| 06:54:45 | gibi_off | sean-k-mooney, efried: placement data visualizer https://github.com/gibizer/osc-placement-tree | |
| 08:03:32 | openstackgerrit | Jiri Suchomel proposed openstack/nova master: Remove deprecated nova.image.download hook https://review.opendev.org/725338 | |
| 08:04:02 | openstackgerrit | Jiri Suchomel proposed openstack/nova master: Add ability to download Glance images into the libvirt image cache via RBD https://review.opendev.org/574301 | |
| 08:36:26 | openstackgerrit | Elod Illes proposed openstack/nova stable/stein: Check cherry-pick hashes in pep8 tox target https://review.opendev.org/737922 | |
| 10:30:34 | openstackgerrit | Jinsheng Zhang proposed openstack/nova master: Add API to support multiple boot-volumes with boot order selection https://review.opendev.org/737913 | |
| 10:44:13 | sean-k-mooney | gibi: oh nice. i still want to add __iter__ __repr__ and perhaps __getitem__ and __contains__ | |
| 10:44:55 | sean-k-mooney | __getitem__ would allow use ot use pt[uuid_or_name] instead of calling find | |
| 10:45:43 | sean-k-mooney | and __contains__ would allow "if uuid_or_name in pt" instead of calling pt.exists(uuid_or_name) | |
| 10:47:12 | sean-k-mooney | __contains__ is technically provided for free when you add __iter__ but it might be more effiecnt to do it myself | |
| 11:00:12 | gibi | sean-k-mooney: some of those could help with the readability of the code | |
| 11:06:12 | sean-k-mooney | gibi: yep that was the main idea | |
| 11:06:59 | sean-k-mooney | if there is a perfomance boost form any of this that is just a nice benifit but its mainly so i can tree the providertree or provider objects as standard python collections | |
| 11:07:33 | sean-k-mooney | instead of having to figure out what we named the relevent fucntions | |
| 11:08:00 | sean-k-mooney | most/all of the functionality is already there just named differently | |
| 11:15:05 | sean-k-mooney | gibi: im starting on the numa in placment implemantion at the moment and while im not going to commit to this im going to try an take a test driven developemnt appoch. | |
| 11:16:08 | sean-k-mooney | so im going to try and create a libvirt fucntional test that starts with a flat toplogy and converts it to the numa form like we have for pcpus | |
| 11:16:46 | sean-k-mooney | im hoping adding the special fucntion will make implementing the reshape simpelr in the long run | |
| 11:49:20 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Prevent libvirt driver starting on non Linux platform https://review.opendev.org/737508 | |
| 12:19:01 | openstackgerrit | Balazs Gibizer proposed openstack/nova stable/ussuri: Guard against missing image cache directory https://review.opendev.org/737990 | |
| 12:21:06 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Correct reported system memory https://review.opendev.org/733827 | |
| 12:21:07 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Prevent libvirt driver starting on non Linux platform https://review.opendev.org/737508 | |
| 13:15:24 | tobias-urdin | what populates ConsoleAuthToken.host field, I accidentally registered a compute node with the wrong IP configured and can't get console working after that | |
| 13:15:55 | tobias-urdin | the ip in the database compute_nodes is correct, but the generated entries in console_auth_tokens get's the wrong ip | |
| 13:33:10 | openstackgerrit | Stephen Finucane proposed openstack/nova master: mypy: Add nova.cmd, nova.conf, nova.console https://review.opendev.org/705657 | |
| 13:33:10 | openstackgerrit | Stephen Finucane proposed openstack/nova master: mypy: Add type annotations to 'nova.pci' https://review.opendev.org/676209 | |
| 13:33:11 | openstackgerrit | Stephen Finucane proposed openstack/nova master: mypy: Add type annotations to top-level modules https://review.opendev.org/705658 | |
| 13:36:46 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Remove wrappers around ovo mixins https://review.opendev.org/738019 | |
| 13:36:46 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Use imports instead of type aliases https://review.opendev.org/738018 | |
| 13:36:47 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Add type hints https://review.opendev.org/738020 | |
| 14:00:20 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add emulated TPM support to Nova https://review.opendev.org/631363 | |
| 14:00:20 | openstackgerrit | Stephen Finucane proposed openstack/nova master: virt: Add 'context', drop 'network_info' parameters for 'unrescue' https://review.opendev.org/730382 | |
| 14:00:21 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add support for resize and cold migration of emulated TPM files https://review.opendev.org/639934 | |
| 14:07:42 | stephenfin | gibi: I've proposed adding the vTPM work to a runway | |
| 14:08:07 | stephenfin | Still need to do the shelve/unshelve patches but that shouldn't block what's there getting in, IMO | |
| 14:08:43 | openstackgerrit | Merged openstack/nova master: Remove lxml deprecated methods https://review.opendev.org/737472 | |
| 14:18:50 | gibi | stephenfin: thanks! Sure if there are a set of meaningful patches that are ready then it is good for runway | |
| 14:19:04 | gibi | stephenfin: I will look at the queue after my call and move it to the slot | |
| 14:54:34 | bauzas | gibi: I'll need to be off by 6:30pm today so I'll be around the nova meeting by the first 30 mins | |
| 14:54:55 | gibi | bauzas: thanks for the heads up. | |
| 14:55:01 | bauzas | np | |
| 14:55:19 | gibi | bauzas: do you have any important stuff for the libvirt subteam? | |
| 14:58:18 | josephillips | hey guys question is possible add a hw property that came from images after the vm is deployed? | |
| 15:02:58 | josephillips | or where this properties are stored after the deployment | |
| 15:04:05 | aarents | gibi: just to mention that I will need few cyle from dansmith & sean-k-mooney to finilize https://review.opendev.org/#/c/736169/ and https://review.opendev.org/#/c/734776/ in the coming days if possible | |
| 15:05:37 | gibi | aarents: is this related to the libvirt subteam? | |
| 15:06:39 | sean-k-mooney | aarents: is that the paralle snapshot feature | |
| 15:07:00 | aarents | bauzas: not sure of peremiter of libvirt can we consider it is ? | |
| 15:07:03 | sean-k-mooney | ya ill re review those today | |
| 15:07:04 | aarents | sean-k-mooney: yep | |
| 15:07:22 | aarents | sean-k-mooney: thanks | |
| 15:07:52 | sean-k-mooney | bauzas: gibi its not libvirt related it generic across all virt dirvers | |
| 15:08:06 | sean-k-mooney | bauzas: gibi but dont let that stop you reviewing :) | |
| 15:08:24 | aarents | ok | |
| 15:08:46 | bauzas | gibi: aarents: ack, will try to look at both changes | |
| 15:08:57 | bauzas | for the scope of the subteam, this can be large | |
| 15:09:06 | bauzas | I'm not opiniated on it | |
| 15:10:15 | sean-k-mooney | aarents: hehe i have draft comment on the first patch which i just pushed. the relese note comment is the only real one and its just on wording. | |
| 15:11:44 | gibi | aarents: I just wanted to know how this connects to the topic with bauzas. | |
| 15:12:01 | gibi | aarents: feel free to mention this during the meeint | |
| 15:12:02 | gibi | g | |
| 15:12:05 | gibi | meeting | |
| 15:12:31 | gibi | in the Open Discussion part | |
| 15:23:40 | aarents | gibi: Thank you, I cannot attend, I have to pick my daughter from school, nevermind don't spend time on it during meeting, nothing disruptive/blocking | |
| 15:23:50 | aarents | sean-k-mooney: thanks I will check | |
| 15:36:26 | gibi | aarents: OK. thanks | |
| 15:38:02 | dansmith | aarents: just two small things and then I'm +2 | |
| 15:38:16 | dansmith | aarents: if you can get those done when you get back ping me and I'll circle back quickly | |
| 15:45:40 | gibi | nova team meeting starts in 15 minutes on #openstack-meeting-3 | |
| 15:49:49 | dansmith | I might be in and out due to some local distraction, FYI | |
| 15:49:54 | dansmith | not sure there's much for me to say this week | |
| 15:50:12 | bauzas | maybe we can have a short meeting ? | |
| 15:50:21 | dansmith | been recheck grinding my patches in the runway and working on fixing glance and devstack issues so we can have a ceph multistore job | |
| 15:53:20 | dansmith | bauzas: is it hot there? | |
| 15:53:33 | bauzas | i can talk in Celsius, man | |