| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-06-23 | |||
| 14:49:02 | dansmith | but yeah, better than nothing | |
| 14:49:50 | sean-k-mooney | dansmith: does this affct the ablity to boot on a node. i guess if we have that never donwlaod config? | |
| 14:49:59 | sean-k-mooney | otherwise we could fall back right | |
| 14:50:11 | sean-k-mooney | if we cant do an import and just flatten the image | |
| 14:50:22 | dansmith | import and flatten is never the answer | |
| 14:50:41 | sean-k-mooney | well that is what we woudl do today right | |
| 14:50:50 | dansmith | yes | |
| 14:51:00 | dansmith | never the *right* answer I mean :) | |
| 14:51:08 | sean-k-mooney | :) | |
| 14:51:31 | sean-k-mooney | the behavior of the new config option is to treate the need to flatten as an error right | |
| 14:51:35 | sean-k-mooney | leadign to a reshdule | |
| 14:52:05 | dansmith | well, (a) we never reschedule anymore, we consume one of the alternates, but (b) yes, the workaround makes it an error | |
| 14:52:25 | sean-k-mooney | dansmith: sorry yes you are right about the alternive hosts | |
| 14:52:47 | sean-k-mooney | dansmith: although that does cause issues for mutlicreate and anti affinity groups but thats another matter | |
| 14:53:09 | dansmith | we also can't download it and upload it as a new base and add it to the image as a location because... we don't own the image and if we did that as admin, we'd start charging the owner, which is a roundabout way to do what we could already do as admin | |
| 14:53:34 | sean-k-mooney | dansmith: well i was not suggesting uplaoad as a new location | |
| 14:54:01 | sean-k-mooney | i ment jus tdo want we do today download it localy the stream it into the rbd volume | |
| 14:54:24 | sean-k-mooney | which sucks because we loose copy on write | |
| 14:54:29 | dansmith | no, I know, but that is never the right answer.. I'm saying we couldn't make nova do the slightly smarter thing of uploading it as a new base image | |
| 14:54:44 | sean-k-mooney | dansmith: ah right | |
| 14:54:58 | dansmith | import and flatten means you consume N*size for N instances, which defeats the whole point and consumes a lot of expensive storage | |
| 14:55:10 | sean-k-mooney | well i think the image metadat property for allow_multistore_copy=true|false makes sense | |
| 14:55:54 | sean-k-mooney | what would the default be. i would like it to be true but i guess it has to be false if not set | |
| 14:56:52 | dansmith | I'm having a hard time understanding how "public" isn't a good enough flag to use, honestly | |
| 14:57:11 | dansmith | unsure about shared/community, but.. public images for sure seem like they should be copyable | |
| 14:57:14 | sean-k-mooney | i guess its allow_admin_multistore_copy too rather then allow_multistore_copy | |
| 14:57:28 | sean-k-mooney | ya so maybe it coudl be based on visablity | |
| 14:57:36 | sean-k-mooney | e.g. the default | |
| 14:57:53 | sean-k-mooney | so true for public by defualt not sure baout shared or commuity iehter | |
| 14:59:40 | sean-k-mooney | shared i would be tempetd to say false by default and comunnity false would be conservitive but true might make sense | |
| 15:00:00 | sean-k-mooney | dansmith: the other angel to this is geofenceing | |
| 15:00:51 | sean-k-mooney | dansmith: moving it to another store might move it to another geo which may be an export violation altough in the curent case we do that indirectly so not sure it a problem or not | |
| 15:01:33 | dansmith | that's a glance policy enforcement problem separate from this I think | |
| 15:01:58 | sean-k-mooney | ya i think so too | |
| 15:02:37 | sean-k-mooney | ok i better go get some work done. thanks for bring me up to speed o/ | |
| 15:03:39 | dansmith | yup | |
| 16:11:39 | gibi | public announcement: I will be off tomorrow but will be back on Thurstday | |
| 16:12:03 | sean-k-mooney | gibi_off: enjoy | |
| 16:12:42 | gibi_off | sean-k-mooney: thanks | |
| 17:23:35 | sean-k-mooney | efried: not sure if you are about but do you know if there is any reason we have not made provider trees or proviers to be iterable over there childeren? | |
| 17:24:45 | sean-k-mooney | i know that is not stirctly need but it would be nice to be able to pretty print them and it makes some operation nicer | |
| 17:25:43 | efried | Yes, there's a function to iterate over them in order. We use it in the master update_provider_tree loop. | |
| 17:26:09 | sean-k-mooney | efried: oh ok we just did not implement __iter__ | |
| 17:26:24 | efried | I would believe that. | |
| 17:26:28 | efried | It recently came up here: https://review.opendev.org/#/c/719163/18/nova/scheduler/client/report.py | |
| 17:27:17 | sean-k-mooney | that gives use the provider uuids but not the provider objects but ok i was looking at that | |
| 17:28:05 | sean-k-mooney | efried: thanks im trying to think how i will go about the transfroamtion for modeling nuam in placement and i want a nice way to visualise the tree | |
| 17:32:25 | openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Remove '_numa_fit_instance_cell_with_pinning' https://review.opendev.org/714703 | |
| 17:32:25 | openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Invert order of NUMA topology generation https://review.opendev.org/714701 | |
| 17:32:26 | openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Tweak the 'cpu_realtime_mask' handling slightly https://review.opendev.org/461456 | |
| 17:32:26 | openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Allow 'hw:cpu_realtime_mask' to be omitted https://review.opendev.org/737026 | |
| 17:33:08 | efried | I thought gibi_off wrote some kind of tool to prettyprint those trees. | |
| 17:33:17 | sean-k-mooney | maybe | |
| 17:33:37 | efried | I don't have it in front of me, but looking provider_tree.py for that iterator function. | |
| 17:33:53 | efried | It's not __iter__ but I'm pretty sure I made a getter that gives them to you in a predictable order. | |
| 17:33:57 | sean-k-mooney | it looks like its doing a depth frist traversal from the root with childern lexically sorted by uuid | |
| 17:35:05 | sean-k-mooney | efried: ya its fine ill figure it out. i might make it iterable jsut to make it spelper and immperment __repr__ for provier | |
| 17:35:24 | sean-k-mooney | *simpler and implement | |
| 17:51:49 | sean-k-mooney | efried: so ya i just need to add | |
| 17:51:50 | sean-k-mooney | def __iter__(self): | |
| 17:51:53 | sean-k-mooney | for uuid in self.get_provider_uuids(): | |
| 17:51:55 | sean-k-mooney | yield self._find_with_lock(uuid) | |
| 17:52:42 | sean-k-mooney | but i might invert the logic an make get_provier_uuids use the iterator | |
| 17:53:15 | sean-k-mooney | it would avoid the need to call fine_with_lock twice once in get_provier_uuids and then again in the iterator | |
| 17:53:29 | sean-k-mooney | thanks for the pointer | |
| 18:01:16 | efried | sean-k-mooney: feel free to add me to review if you spin up something there. | |
| 18:03:14 | efried | Here's where that thing is used https://github.com/openstack/nova/blob/f1ebc15dfc8ffb7f23b2cb9879f0ca9376931a90/nova/scheduler/client/report.py#L1348-L1349 (and IIRC the reason it was written) | |
| 18:03:50 | efried | so whatever you change, please keep in mind that that ^ is going to run every periodic -- so don't slow it down too much :P | |
| 18:04:36 | sean-k-mooney | ya it should not be any slower | |
| 18:05:17 | sean-k-mooney | but sure ill add you to the review | |
| 18:07:51 | stephenfin | melwitt: could you hit this trivial requirements patch, please https://review.opendev.org/#/c/730960/ ? | |
| 18:25:04 | openstackgerrit | sean mooney proposed openstack/nova master: [WIP] make provider tree and proviers iterable https://review.opendev.org/737594 | |
| 18:25:28 | sean-k-mooney | efried: that is the version where i have not inverted the logic ^ | |
| 18:25:34 | sean-k-mooney | which im testign with http://paste.openstack.org/show/795116/ | |
| 18:29:39 | sean-k-mooney | which if i execute it looks like this http://paste.openstack.org/show/795117/ | |
| 18:31:19 | efried | ++ | |
| 18:32:04 | sean-k-mooney | i should be able to make the provider tee actully do indenting too but that the quick hack for now | |
| 19:22:01 | melwitt | gmann: did you see the author's reply on this patch? https://review.opendev.org/#/c/730960/1//COMMIT_MSG@9 | |
| 19:22:34 | gmann | melwitt: checking | |
| 19:27:09 | gmann | melwitt: i forgot to test it locally and if any things we need to adjust from jsonschema FormatChecker. let me do it and review again. thanks for reminder | |
| 19:27:23 | melwitt | gmann: sweet thanks | |
| 19:29:27 | melwitt | stephenfin: gmann is gonna review ^ again, there was a local test he wanted to do | |
| 20:15:21 | spatel | sean-k-mooney: hey! | |
| #openstack-nova - 2020-06-24 | |||
| 01:54:34 | openstackgerrit | Merged openstack/nova master: Cap jsonschema 3.2.0 as the minimal version https://review.opendev.org/730960 | |
| 02:27:16 | openstackgerrit | Merged openstack/nova master: Guard against missing image cache directory https://review.opendev.org/736964 | |
| 03:01:43 | openstackgerrit | Merged openstack/nova master: hardware: Update and correct typing information https://review.opendev.org/714694 | |
| 03:01:55 | openstackgerrit | Merged openstack/nova master: libvirt: Add typing information https://review.opendev.org/714695 | |
| 03:16:22 | openstackgerrit | Merged openstack/nova master: hardware: Add validation for 'cpu_realtime_mask' https://review.opendev.org/468203 | |
| 03:16:30 | openstackgerrit | Merged openstack/nova master: tests: Split instance NUMA object tests https://review.opendev.org/714696 | |
| 07:23:12 | brinzhang_ | Hello guys, has anyone encountered this problem with "GLib (gthread-posix.c): Unexpected error from C library during 'pthread_key_create': Resource temporarily unavailable. Aborting" | |
| 07:24:48 | brinzhang_ | it was happened when evacuate the instances, deployed the OpenStack R release on Centos7 | |
| 07:29:28 | gibi_off | brinzhang_: is this log from a nova service? Is that service has a task limit in the output of systemctl status ? | |
| 07:30:21 | gibi_off | brinzhang_: https://github.com/systemd/systemd/blob/ddb4b0d3eb57292c38a76f9b977f73cea15448fb/NEWS#L65-L68 | |
| 07:31:34 | brinzhang_ | gibi_off: Do you mean that the number of threads has reached the upper limit? | |
| 07:33:02 | gibi_off | brinzhang_: yeah, that could be a reason | |
| 07:33:30 | brinzhang_ | it's not come from nova service log, it's print by docker | |
| 07:35:26 | gibi_off | check the output of the systemctl status for the docker service | |
| 07:42:07 | brinzhang_ | gibi_off: This problem does not occur every time you evacuate. It happens occasionally, but it has been encountered twice. | |
| 07:43:30 | brinzhang_ | gibi_off: we will try to make the TasksMax setting get bigger, then try to test | |
| 07:43:48 | brinzhang_ | gibi_off: thanks for your advice | |