Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-06-11
16:00:00 jsuchome dansmith: hi, thanks for your latest review, do you want me to reduce that comment about cyclic import or is there anything else?
16:05:12 openstackgerrit Dan Smith proposed openstack/nova master: DNM: Try to make a glance multistore job https://review.opendev.org/734184
16:13:46 openstackgerrit Dan Smith proposed openstack/nova-specs master: Update the testing section of the rbd-glance-multistore spec https://review.opendev.org/735192
16:14:42 dansmith jsuchome: personally I think it should be reduced in line with the other examples I quoted
16:15:01 dansmith jsuchome: I don't remember if there was anything else, but I'll have to circle back next week.. trying to get some stuff done before I disappear tomorrow
16:45:51 sean-k-mooney dansmith: this is the cyborg shelve path fyi https://review.opendev.org/#/c/729563/2
16:46:26 bauzas gibi: fwiw, I'd have loved to volunteer for helping you during your holidays, but I'll be off at the same time
16:46:59 gibi bauzas: ack, thanks
16:47:10 gibi and don't worry
16:57:45 dansmith sean-k-mooney: ack, will try to keep that in mind in the coming weeks
17:01:00 sean-k-mooney i would like to see ci test it first so ill update this https://review.opendev.org/#/c/709641/
17:08:53 gibi 19:08 -ChanServ(ChanServ@services.)- You are not authorized to (de)op gibi on
17:08:56 gibi #openstack-nova.
17:09:12 gibi so I need help to update the challen topic to point to the victori runway etherpad
17:30:43 sean-k-mooney gibi: i think dansmith has op on this channel?
17:31:38 sean-k-mooney hehe
17:31:47 dansmith good?
17:32:04 sean-k-mooney seams to work for me
17:32:22 sean-k-mooney and /topic works so yep
17:34:15 gibi dansmith: thanks
17:44:50 openstackgerrit Dan Smith proposed openstack/nova master: Check cherry-pick hashes in pep8 tox target https://review.opendev.org/735205
17:45:31 dansmith sean-k-mooney: did you have a stable commit with broken hashes in gerrit that is still yet to be fixed?
17:45:34 dansmith would like to use it to test
18:04:39 dansmith sean-k-mooney: ^ ?
18:05:06 sean-k-mooney am im not sure if stephen fixed it
18:05:15 sean-k-mooney ill check
18:05:56 dansmith okay I wasn't sure if you had proposed it or someone else.. I don't see any recent -1ed patches on stable from you
18:06:03 sean-k-mooney https://review.opendev.org/#/c/728057/ was the one i think
18:06:42 dansmith okay that's not the one I was thiking of but yeah I see
18:06:59 sean-k-mooney https://review.opendev.org/#/c/728059/1 will be broken too
18:07:11 sean-k-mooney since it has not been update to pick up stephnes fix
18:08:14 sean-k-mooney also https://review.opendev.org/#/c/703115/
18:08:25 sean-k-mooney again stephen updated it yesterday
18:08:36 dansmith I guess any patch with unmerged cherry picks would technically fail my check
18:08:39 dansmith so maybe that's enough
18:09:18 sean-k-mooney ya basically if you dont wait for the preveious one to merge then it will be broken more then likely
18:09:33 sean-k-mooney well i guess only if you are asked to modify things
18:09:48 dansmith or you don't realize it fails for some other reason
18:09:55 sean-k-mooney ya
18:10:03 dansmith most people don't run tests on their backports, they wait until zuul tells them something is broken
18:11:04 sean-k-mooney ya if i have conflict i run the tests locally i often dont if it cleanly applied
18:11:40 openstackgerrit Dan Smith proposed openstack/nova stable/ussuri: Check cherry-pick hashes in pep8 tox target https://review.opendev.org/735208
18:11:41 dansmith yup
18:11:51 sean-k-mooney it depens on the patch i guess and how much i think its likely to break
18:12:02 dansmith so the backport of my check should fail if it hasn't landed on master yet
18:13:27 sean-k-mooney do you plan to have each stable job just check the new branch
18:13:54 sean-k-mooney e.g. stien checks it merged on train which in trun check ussuri whcih checks master
18:14:04 dansmith I'm just checking that all referenced hashes exist on either master or stable/* which I think is fine
18:14:32 sean-k-mooney ya ok that should work
18:15:11 dansmith if you backport something to stable before it's merged on master, zuul will fail it, which would also help us notice that the backport shouldn't be merged yet
18:15:39 sean-k-mooney so https://review.opendev.org/#/c/735208/1 should fail because https://review.opendev.org/#/c/735205/1 is not merged
18:15:41 dansmith might be too much for some people, but seems like a good idea to me
18:15:46 dansmith right
18:15:58 sean-k-mooney ya i kind of feel like that should be a standard zuul check
18:16:06 dansmith yeah
18:16:16 dansmith we'll see if it works
18:16:34 sean-k-mooney if it does maybe we could extend the merge-check job
18:17:22 sean-k-mooney ok im going to sign off soon. im takeing monday and tuseday off too so ill be back online on wednesday
18:17:46 dansmith cool, enjoy!
18:25:26 openstackgerrit Dan Smith proposed openstack/nova master: Check cherry-pick hashes in pep8 tox target https://review.opendev.org/735205
18:27:04 openstackgerrit Dan Smith proposed openstack/nova stable/ussuri: Check cherry-pick hashes in pep8 tox target https://review.opendev.org/735208
19:39:01 gmann elod: i was just reading log for cherry-pick things and the line you mentioned that "if patch on previous branch is not merged then it does not add cherry-pick from". but it does in both case either backported to all branch at once or one by one once merge in previous branch.
19:43:05 elod gmann: so if a patch has merged on master, and then i cherry-pick it to ussuri, and before it gets merged in ussuri i cherry pick it to stable stein *from* ussuri, you say that the patch in stein will have the 'cherry-picked' lines both from master and ussuri?
19:44:25 gmann elod: i think so but what i did previously was. master patch not merged yet and cherry picked to train, stein and all had 'cherry-piked from'..
19:46:23 elod * s/stein/train/
19:47:10 elod hmmm, I'll check it in the coming days, however I remember that it worked as I wrote
19:48:08 elod but I usually cherry-pick in cli, not via gerrit, so maybe I'm wrong
19:52:46 gmann elod: i remember it does via gerrit where i end up having old commit id in 'cheery picked from' when i updated master patch.
19:53:42 elod gmann: I've cherry-picked a not merged patch from rocky to queens and it did not add the cherry-picked line: https://review.opendev.org/#/c/735222/
19:54:44 elod did it via gerrit ui cherry-pick button
19:56:32 gmann elod: may be doing it from master it does? i did from master.
19:57:42 elod gmann: yes, that's possible. do you have an example from the past days maybe?
19:57:50 gmann let me check
19:58:49 gmann elod: this one, commit id in cherry pick from are wrong there :) - https://review.opendev.org/#/q/I96bb9fcb55f2a4fc3aefa01db70b45740db166c8
20:00:33 gmann dansmith: how did you test your pep8 check? should we backport it and test with https://review.opendev.org/#/c/728059/ ? or any DNM patch on master and backport to ussuri
20:01:54 dansmith gmann: check the backport of the check -- it's self-checking :)
20:02:31 gmann ohk, just saw that
20:02:59 elod gmann: hmm, yes, it seems, if we backport from master, then it adds the cherry-picked line, even if that is not yet merged :S you are right
20:04:16 elod so to avoid this, we have to wait until patch on master gets merged ;)
20:05:47 gmann yeah that is best way and with dansmith proposed pep8 check will be helpful to wait or at least make checky pick from commit id upto date
20:05:55 gmann seems like pdf doc broken again?
20:11:06 dansmith gmann: yeah seems like it
20:11:56 gmann i think we need to stop -vv option.
20:13:46 openstackgerrit Jiri Suchomel proposed openstack/nova master: Add ability to download Glance images into the libvirt image cache via RBD https://review.opendev.org/574301
20:19:59 dansmith gmann: so are you cool with that pep8 backport check?
20:20:47 gmann dansmith: yeah, i am +2. i agree that is helpful.
20:21:52 dansmith sweet, I think so too
20:22:03 gmann i wanted to move that to hacking :) if elod agree from stable backport perspective as general.
20:22:03 dansmith I'm always worried I'm going to approve something on N-2 before N-1
20:22:24 dansmith so this helps that, in addition to the hash change problem
20:22:37 gmann true and i recently forgot to update the commit id when i updated master one later
20:22:40 dansmith gmann: feel free to move it if you want it somewhere other than where I'm calling it from
20:22:51 dansmith gmann: ack, I'm sure I've done that in the past, despite trying to be good about it
20:23:56 melwitt gmann: why do you think -vv is causing the doc build failure? I'm looking at the log and don't yet see why it failed
20:24:20 gmann melwitt: not that, i was confused with echo message of too verbose :).
20:24:26 melwitt https://zuul.opendev.org/t/openstack/build/a678c8c3717d48a2aee415b1eea54a8e/log/sphinx-build-pdf.log#7604
20:24:44 gmann its different problem. i can see lof of LaTeX warning but not sure that leads to error
20:24:53 melwitt yeah same
20:28:57 elod gmann: yes, I think it would be good :)
20:30:15 dansmith elod: I guess we could, on stable, fail if we find no cherry-pick lines, unless the "StableOnly" tag is in the commit message

Earlier   Later