| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-06-08 | |||
| 07:20:36 | bauzas | good morning Nova | |
| 07:30:43 | lvdombrkr | morning nova. is there other ways to inject password except inject_password=true ? | |
| 07:53:55 | gibi | bauzas: good morning | |
| 07:54:26 | gibi | lvdombrkr: you can use cloud init in the guest and you can use the config driver or the metadata service to provide input for cloud init | |
| 07:54:28 | bauzas | first time I don't feel jetlagged or fried after a PTG | |
| 07:55:01 | bauzas | gibi: didn't we deprecated password injection btw. ? | |
| 07:55:04 | gibi | bauzas: I don't miss the jetlag part of the PTG :) | |
| 07:55:26 | bauzas | gibi: next one, we won't have jetlag too | |
| 07:55:27 | bauzas | :) | |
| 07:55:39 | gibi | bauzas: I think we did https://blueprints.launchpad.net/nova/+spec/deprecate-file-injection | |
| 07:55:58 | gibi | ohh this is file injection not password injection | |
| 07:56:42 | lvdombrkr | gibi: thanks for answer. but if i will use metadata, then passwortd will be stored in metadata in plain text, right? | |
| 07:56:51 | bauzas | ah my bad | |
| 07:57:12 | bauzas | I remembered we did deprecated some injection, but like you, it was the wrong way | |
| 07:58:04 | gibi | lvdombrkr: you can inject public keys | |
| 07:58:42 | lvdombrkr | gibi: yes yes about public keys i know, but i need excatly password | |
| 07:58:58 | bauzas | lvdombrkr: question, why can't you use a config tool like Ansible for injecting such things if you don't wanna use the tool we provide ? | |
| 07:59:52 | openstack | Launchpad bug 1882421 in OpenStack Compute (nova) "inject_password fails with python3" [Undecided,In progress] - Assigned to Dr. Jens Harbott (j-harbott) | |
| 07:59:52 | frickler | bauzas: because it is broken? see https://launchpad.net/bugs/1882421 | |
| 08:00:12 | lvdombrkr | bauzas: i want use config you provided (inject_password) but its not working with Centos8 Python3 | |
| 08:00:13 | bauzas | frickler: ah, gtk | |
| 08:00:57 | bauzas | then, I'd recommend to go thru external tools until it's fixed | |
| 08:03:29 | bauzas | frickler: I can take a look at your change if you will | |
| 08:03:38 | lvdombrkr | bauzas frickler : thanks for answers. how long time can take fix this? | |
| 08:06:56 | gibi | bauzas, lvdombrkr, frickler: I'm reviewing the fix now (while on a parallel phone meeting so it will take time) | |
| 08:10:29 | lvdombrkr | gibi bauzas frickler: perfect guys, keep me updated please :) | |
| 08:11:16 | gibi | lvdombrkr: sure | |
| 08:13:14 | aarents | good morning nova | |
| 08:13:27 | aarents | gibi: bauzas just FYI, I've made some stupid max attachement contest on a devstack with machine-type q35: | |
| 08:13:28 | gibi | aarents: good morning | |
| 08:13:34 | aarents | nova interface-list 6cc30912-c4ae-493d-8209-e19f16f101bc | grep -c ACTIVE | |
| 08:13:37 | aarents | 220 | |
| 08:13:45 | aarents | it is only possible because I override in code num_pcie_ports.max to 224 instead of 28 (we force max to 28 because of limitation with aarch64/virt), without doing it max attachment on q35 is 24 (28 - 4 reserved) and on pc it is 26, so we are still better on pc than on q35 regarding max attachement with current code. | |
| 08:13:46 | bauzas | aarents: good morning | |
| 08:14:22 | bauzas | that reminds me a bell, but I don't remember exactly what | |
| 08:14:30 | gibi | aarents: so we need to make the num_pcie_ports.max dynamic based on the machine typ | |
| 08:14:33 | gibi | e | |
| 08:14:41 | aarents | gibi: I think | |
| 08:15:06 | bauzas | didn't we had an issue like this that was raised before ? | |
| 08:15:17 | bauzas | or maybe it was for usb devices, I can't recall | |
| 08:17:42 | gibi | bauzas: I don't have memory about it | |
| 08:20:40 | bauzas | frickler: this could help you to understand the distinguo between the bytes and the str types in py3 https://eli.thegreenplace.net/2012/01/30/the-bytesstr-dichotomy-in-python-3 | |
| 08:21:34 | bauzas | frickler: tl;dr you shouldn't explicitely tell a string as byte-coded | |
| 08:31:08 | frickler | bauzas: yes, this is clear, the question for me is, when a function needs bytes, is it better to make the caller supply bytes or have the function convert str arguments to bytes. that happens multiple times in the inject_* code | |
| 08:48:09 | bauzas | frickler: I definitely prefer the latter | |
| 08:48:28 | bauzas | bytes type should only be used when you need | |
| 09:02:20 | bauzas | frickler: I think i found why you need to horribly encode all the strings | |
| 09:03:30 | bauzas | tl;dr: the guestfs import seems to be py3 | |
| 09:03:32 | bauzas | py2* | |
| 09:05:49 | bauzas | that should come from libguestfs not having the py3 bindings | |
| 09:07:35 | frickler | bauzas: well I tested locally on focal with python3-guestfs installed, surely no py2 involved there | |
| 09:08:03 | bauzas | what I don't understand is why you get a bytes-encoded FS | |
| 09:09:13 | frickler | bauzas: I think that's pretty normal, files contain bytes, you'd have to tell guestfs the encoding in order to be able to convert them to strings | |
| 09:10:11 | bauzas | sure, of course | |
| 09:10:38 | bauzas | either way, I'm surprised we need to explicitely encode all the strings | |
| 09:39:25 | gibi | bauzas: I confirm that a py3 devstack setup has the reported byte / str problem with password injection (finally reproduced it) | |
| 09:54:53 | whoami-rajat | hi #openstack-nova i've a query, during reserve_volume call do we have a lock on the volume? if there's a multiattach volume and multiple instances issue reserve request on it then are we secure in that case? | |
| 10:29:07 | sean-k-mooney | stephenfin: small docs review for you https://review.opendev.org/#/c/726936/8 | |
| 10:33:26 | stephenfin | sean-k-mooney: done | |
| 10:37:28 | openstackgerrit | Merged openstack/os-traits master: Switch to newer openstackdocstheme and reno versions https://review.opendev.org/732355 | |
| 10:38:39 | sean-k-mooney | stephenfin: cool thanks | |
| 10:39:16 | sean-k-mooney | bauzas: want to finish the review it will take you 30 seconds https://review.opendev.org/#/c/726936/ | |
| 10:40:04 | sean-k-mooney | stephenfin: did you recongise the name by the way. i think they are a new contiributor | |
| 10:40:18 | stephenfin | I suspect so too | |
| 10:40:26 | stephenfin | Probably someone deploying things and finding the gaps | |
| 10:40:50 | sean-k-mooney | looks like ther other patches were to the sandbox project so ya likely. | |
| 10:41:06 | openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Encrypted Emulated Virtual TPM https://review.opendev.org/728505 | |
| 11:12:36 | stephenfin | bauzas: Can I get you to look at https://review.opendev.org/728505 this week, please? | |
| 11:12:55 | stephenfin | bauzas: I also have a couple of code reviews I'd like some eyes on. Happy to horse trade ;) | |
| 11:52:40 | bauzas | sean-k-mooney: stephenfin: sorry was at lunch | |
| 11:59:28 | bauzas | stephenfin: sure, I wanna do some specs reviews this week anyway | |
| 12:21:15 | openstack | Launchpad bug 1882521 in OpenStack Compute (nova) "Failing device detachments on Focal" [Undecided,New] | |
| 12:21:15 | frickler | so if anyone is interesting in getting devstack testing on focal to proceed, I created this bug report. lyarwood had started to look at it earlier, I don't have enough clue myself, in the end it might be nova, libvirt, qemu, cinder or even tempest is the actual culprit https://bugs.launchpad.net/nova/+bug/1882521 | |
| 12:23:04 | sean-k-mooney | frickler: are there any known blockers right now | |
| 12:23:40 | sean-k-mooney | frickler: ill be setting up a devenv for numa stuff later today and was considering if i should try centos 8 or ubuntu 20.04 instaed of sticking with 18.04 | |
| 12:24:36 | sean-k-mooney | Device detach failed for vdb: Unable to detach the device from the live config. | |
| 12:24:53 | sean-k-mooney | frickler: that looks like its comming from libvirt althoug hi have not looked at the code yet | |
| 12:25:23 | sean-k-mooney | frickler: was the default lvm backend or ceph? | |
| 12:28:02 | frickler | sean-k-mooney: in devstack it is lvm, although I tested locally with ceph and see similar issues. but there's also a different bug for that, one moment | |
| 12:28:03 | kashyap | sean-k-mooney: Hey, do you know of any prior rejected work on memory ballooning? | |
| 12:28:06 | kashyap | ... in Nova | |
| 12:28:37 | frickler | sean-k-mooney: also, I think that those test-failures are blocking for focal, I wouldn't want to merge focal support with them blacklisted | |
| 12:28:49 | sean-k-mooney | not specifcally but i know dansmit is not a fan of nova managing it | |
| 12:29:16 | sean-k-mooney | frickler: oh i ment in terms of me swaping my daily dev env to focal rather then the ci | |
| 12:29:36 | sean-k-mooney | frickler: if i start using it and hit error its more likely that im going to fix them | |
| 12:30:55 | sean-k-mooney | kashyap: i know that at least one user wants us to remove the automatic memory balloan that is added by livirt | |
| 12:31:22 | sean-k-mooney | kashyap: i also know that we are getting asked to consider added memory balloan managemnt downstream | |
| 12:32:58 | frickler | sean-k-mooney: ah, I see, you'd need to use my patch https://review.opendev.org/704831 , apart from the tempest failures it has been running pretty well for me for some months now | |
| 12:34:01 | sean-k-mooney | frickler: cool i was planning on swapping to it for the numa work im starting. the vms i have created are already on it but i had not got as far as stacking yey | |
| 12:34:49 | sean-k-mooney | so if i use that devstack patch it should be good | |
| 12:34:51 | frickler | sean-k-mooney: the ceph thing seems to have been fixed with https://review.opendev.org/725812 , not sure I've tested with that patch in tempest | |
| 12:35:13 | frickler | sean-k-mooney: yes, that would be great, let me know if you find any further issues | |
| 12:36:01 | sean-k-mooney | ill set up the multi node env and before i start modifying code ill try and do a few volume tests i assuem you are hitting the issue locally too? | |
| 12:36:08 | sean-k-mooney | e.g. its not just in the ci | |
| 12:36:43 | frickler | sean-k-mooney: yes, although locally I didn't see it 100%, might be a bit load/memory pressure related | |
| 12:37:21 | sean-k-mooney | hehe its funny but i realised the other day i finally got https://opendev.org/opentack into my muscel memory instead of defaulting to github | |
| 12:38:18 | sean-k-mooney | frickler: so while your here | |
| 12:38:21 | sean-k-mooney | ubuntu@numa-1:/opt/repos/devstack$ python3 -m pip install --user git-review | |
| 12:38:23 | sean-k-mooney | /usr/bin/python3: No module named pip | |
| 12:38:35 | sean-k-mooney | am i imagining things or is pip not part of the standard libary now | |