Posted	Nick	Remark
#openstack-nova - 2020-05-21
08:52:50	lyarwood	gibi: this might be a regression then as I can reproduce this in devstack
08:53:01	gibi	interestign
08:57:37	openstackgerrit	zhufl proposed openstack/nova master: [Trivial]Add missing white spaces between words in log messages https://review.opendev.org/729880
08:58:26	lyarwood	gibi: http://paste.openstack.org/show/793830/ for example
08:59:18	gibi	lyarwood: this part is strange "[stack@localhost devstack]$ sudo virsh undefine 7b0bd9f9-d74f-4c1c-bd27-a4bba44c391e"
08:59:26	gibi	a simple compute host reboot does not undefine the domain
08:59:50	lyarwood	ah true
08:59:56	lyarwood	but it wouldn't change this
08:59:58	lyarwood	I don't think
09:02:21	lyarwood	ah it does
09:02:26	lyarwood	it's SHUTOFF now
09:03:00	gibi	then I guess not finding the domain in libvirt is not handled during the power synch
09:06:32	openstackgerrit	Vladyslav Drok proposed openstack/nova master: Clean up instance on target node if evacuate fails https://review.opendev.org/375623
09:06:51	lyarwood	https://github.com/openstack/nova/blob/bfdca19bb85a1a3d8238af267d3784b7cd3d93ff/nova/compute/manager.py#L9459-L9460 yeah I think it's this
09:08:03	lyarwood	brb
09:09:23	gibi	the code seems to set the NOSTATE intentionally
09:11:15	gibi	and it is there at least for 6 years now
09:18:21	lyarwood	yeah I can see the logic in this but if instance.host == the current host and the instance is ACTIVE we can still mark it as SHUTOFF tbh
09:21:45	gibi	yeah, if libvirt does not know about the domain then we can be pretty sure the VM is not running.
10:00:32	openstackgerrit	Lee Yarwood proposed openstack/nova master: WIP compute: Stop instances with a power_state of NOSTATE on startup https://review.opendev.org/729890
10:37:06	openstackgerrit	Takashi Natsume proposed openstack/nova master: Remove six.PY2 and six.PY3 https://review.opendev.org/726512
10:37:31	openstackgerrit	Takashi Natsume proposed openstack/nova master: Remove six.add_metaclass https://review.opendev.org/726565
11:05:11	openstackgerrit	Harshavardhan Metla proposed openstack/nova master: [Nova] Add reference to Placement installation guide https://review.opendev.org/726936
11:12:09	openstackgerrit	Stephen Finucane proposed openstack/nova master: docs: Use proper headers in nova-manage man page https://review.opendev.org/726191
11:12:10	openstackgerrit	Stephen Finucane proposed openstack/nova master: docs: Rewrite 'nova-manage api_db', 'cell_v2' docs https://review.opendev.org/726192
11:12:10	openstackgerrit	Stephen Finucane proposed openstack/nova master: docs: Rewrite 'nova-manage db' docs to use proper directives https://review.opendev.org/677509
11:12:11	openstackgerrit	Stephen Finucane proposed openstack/nova master: docs: Document options for remaining nova-* commands https://review.opendev.org/726195
11:12:11	openstackgerrit	Stephen Finucane proposed openstack/nova master: docs: Rewrite 'nova-manage placement' docs https://review.opendev.org/726193
11:12:12	openstackgerrit	Stephen Finucane proposed openstack/nova master: docs: Populate "See Also" section with meaningful links https://review.opendev.org/729917
11:12:12	openstackgerrit	Stephen Finucane proposed openstack/nova master: docs: Remove subtitles, metadata from man pages https://review.opendev.org/729916
11:12:13	openstackgerrit	Stephen Finucane proposed openstack/nova master: docs: Add man pages for 'nova-policy' https://review.opendev.org/729918
11:19:42	openstackgerrit	Lee Yarwood proposed openstack/nova master: libvirt: Don't delete disks on shared storage during evacuate https://review.opendev.org/578846
11:22:34	openstackgerrit	Merged openstack/nova stable/ussuri: Reserve DISK_GB resource for the image cache https://review.opendev.org/729523
11:23:52	openstackgerrit	Stephen Finucane proposed openstack/nova master: Remove hooks https://review.opendev.org/728968
11:23:52	openstackgerrit	Stephen Finucane proposed openstack/nova master: hacking: Modify checks for translated logs https://review.opendev.org/728967
11:23:53	openstackgerrit	Stephen Finucane proposed openstack/nova master: libvirt: Remove workaround for unsupported libvirt version https://review.opendev.org/729656
11:33:02	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Remove unused object_compat decorator https://review.opendev.org/729924
11:35:10	openstackgerrit	Merged openstack/os-vif master: Remove egg_info in setup.cfg https://review.opendev.org/727173
11:37:41	openstackgerrit	Takashi Natsume proposed openstack/nova master: Remove six.reraise https://review.opendev.org/726898
11:39:03	openstackgerrit	Takashi Natsume proposed openstack/nova master: Remove six.moves https://review.opendev.org/727224
11:39:18	openstackgerrit	Takashi Natsume proposed openstack/nova master: Remove six.iteritems/itervalues/iterkeys https://review.opendev.org/727757
11:39:35	openstackgerrit	Takashi Natsume proposed openstack/nova master: Remove six.byte2int/int2byte https://review.opendev.org/727777
11:39:53	openstackgerrit	Takashi Natsume proposed openstack/nova master: Remove six.binary_type/integer_types/string_types https://review.opendev.org/728094
11:47:48	openstackgerrit	Lee Yarwood proposed openstack/nova master: libvirt: Don't delete disks on shared storage during evacuate https://review.opendev.org/578846
11:50:41	openstackgerrit	Takashi Natsume proposed openstack/nova master: Remove six.text_type (1/2) https://review.opendev.org/728109
11:53:17	openstackgerrit	Takashi Natsume proposed openstack/nova master: Remove six.text_type (2/2) https://review.opendev.org/728117
12:00:47	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Remove inject_file from compute manager and virt driver https://review.opendev.org/729934
12:36:09	openstackgerrit	Brin Zhang proposed openstack/nova master: WIP: Cyborg suspend/resume support https://review.opendev.org/729945
12:41:57	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Remove compatibility check from migrate_data https://review.opendev.org/729949
13:06:02	openstackgerrit	Wenping Song proposed openstack/nova master: cyborg evacuate support https://review.opendev.org/715326
13:09:24	lvdombrkr	Hello guys. using Kolla-ansible Train + Centos8, trying to enable hugepages, HOSt info : http://paste.openstack.org/raw/793838/
13:09:57	lvdombrkr	creating flavor openstack flavor create hugepage --ram 1024 --disk 10 --vcpus 1 openstack flavor set hugepage --property hw:mem_page_size=1GB
13:10:10	lvdombrkr	but when booting VM get this error in logs
13:10:17	lvdombrkr	Requested instance NUMA topology cannot fit the given host NUMA topology.\n']
13:10:24	lvdombrkr	any clues?
13:11:05	stephenfin	lvdombrkr: compare these
13:11:06	stephenfin	openstack flavor set hugepage --property hw:mem_page_size=1GB
13:11:15	stephenfin	Hugepagesize: 2048 kB
13:11:25	stephenfin	(the latter is from http://paste.openstack.org/raw/793838/)
13:11:57	stephenfin	do this instead
13:12:01	stephenfin	openstack flavor set hugepage --property hw:mem_page_size=2M
13:16:19	lvdombrkr	stephenfin: now i had another error : Invalid memory page size '0' (HTTP 400) (Request-ID: req-338bf619-3a54-45c5-9c59-ad8c1d425e91)
13:16:20	lvdombrkr	http://paste.openstack.org/show/793839/
13:18:49	stephenfin	Ah, apologies. That should have read 'hw:mem_page_size=2MB'
13:18:54	stephenfin	That's a rather confusing error message, btw. Might be worth filing a bug for it.
13:22:39	lvdombrkr	stephenfin: its works with hw:mem_page_size=2MB
13:22:57	lvdombrkr	stephenfin: Thanks in assist!
13:23:18	stephenfin	lvdombrkr: Good to hear. Could you open a bug about that confusing error message? (https://bugs.launchpad.net/nova/) Should be easy to fix
13:28:26	lvdombrkr	stephenfin: sure, will do now
13:28:31	stephenfin	thanks
14:03:54	openstackgerrit	Stephen Finucane proposed openstack/nova master: hardware: Raise useful error for invalid mempage size https://review.opendev.org/729967
14:15:18	openstackgerrit	Lee Yarwood proposed openstack/nova master: libvirt: Don't delete disks on shared storage during evacuate https://review.opendev.org/578846
14:50:12	openstackgerrit	Stephen Finucane proposed openstack/nova master: hardware: Raise useful error for invalid mempage size https://review.opendev.org/729967
14:50:26	stephenfin	real easy bugfix there if anyone fancies a gawk ^
14:59:13	lyarwood	stephenfin: I'll take a look now, would you mind looking at https://review.opendev.org/#/c/729261/ in return?
14:59:35	stephenfin	fair
15:00:58	artom	Hehe, raise from?
15:01:27	stephenfin	artom: lyarwood: http://paste.openstack.org/show/793850/
15:01:38	stephenfin	try that with and without the from and it'll be obvious
15:01:53	stephenfin	tl;dr: we drop the context from the captured exception
15:01:58	lyarwood	TIL
15:02:09	stephenfin	python3++
15:13:59	stephenfin	lyarwood: awkward question left on https://review.opendev.org/#/c/729261/
15:16:43	lyarwood	stephenfin: ack, quick nit on yours otherwise it LGTM
15:23:13	openstackgerrit	Stephen Finucane proposed openstack/nova master: hardware: Raise useful error for invalid mempage size https://review.opendev.org/729967
15:43:21	lyarwood	stephenfin: are we good to use f-string in nova now?
15:43:27	stephenfin	yup
15:43:54	lyarwood	oh wait backports
15:43:57	lyarwood	gah
15:47:29	sean-k-mooney	lyarwood: stephen already has used them i think
15:47:46	sean-k-mooney	lyarwood: im pretty sure we have merged a couple of patches with fstrings
15:47:55	stephenfin	yeah, they're used in the extra spec validator code anyway, though that's not being backported
15:48:11	sean-k-mooney	ya i think that is what i was thinking of
15:48:20	sean-k-mooney	i think i used them for something too
15:48:36	sean-k-mooney	but i think that someting that can be fixed in the backport
15:50:18	gibi	nova meeting will start in 10 minutes on #openstack-meeting-3
15:51:02	lyarwood	yeah my git grep failed to find them but I was sure we had some in the codebase already
15:51:10	lyarwood	for anything that I'm not going to backport back to Queens
15:51:14	lyarwood	I'll use them
15:51:15	sean-k-mooney	gibi: im proably not going to attend as i have a rather annoying headache right now so going to lie down for a bit

Earlier   Later