Posted	Nick	Remark
#openstack-nova - 2020-05-19
15:41:40	openstackgerrit	Ivaylo Mitev proposed openstack/nova master: Faults from cell DB missing in GET /servers/detail https://review.opendev.org/699176
15:49:12	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Reserve DISK_GB resource for the image cache https://review.opendev.org/728439
15:50:21	gibi	dansmith: fixed ^^
15:51:58	dansmith	got it
15:52:14	gibi	thanks
15:57:20	openstack	bug 1869050 in OpenStack Compute (nova) train "migration of anti-affinity server fails due to stale scheduler instance info" [Low,In progress] https://launchpad.net/bugs/1869050 - Assigned to Elod Illes (elod-illes)
15:57:20	openstackgerrit	Merged openstack/nova stable/train: Reproduce bug 1869050 https://review.opendev.org/729162
16:03:56	openstackgerrit	Lee Yarwood proposed openstack/nova master: compute: Do not allow rescue attempts using volume snapshot images https://review.opendev.org/729261
17:22:37	openstackgerrit	Sasha Andonov proposed openstack/nova master: rbd_utils: increase _destroy_volume timeout https://review.opendev.org/705764
17:23:12	openstackgerrit	Lee Yarwood proposed openstack/nova master: Remove deprecated nova.image.download hook https://review.opendev.org/725338
17:23:13	openstackgerrit	Lee Yarwood proposed openstack/nova master: Bring back allowed_direct_url_schemes in support of RBD image download https://review.opendev.org/728095
17:23:13	openstackgerrit	Lee Yarwood proposed openstack/nova master: Add ability to download Glance images into the libvirt image cache via RBD https://review.opendev.org/574301
17:48:35	dansmith	aarents: I'm curious, do you know if/that your image cache is fully populated when you run out of space without any evictable images?
17:49:08	dansmith	aarents: meaning, do you have the cache purge periodic turned on, and know that there's no room in the cache that could be purged if we had something like a "minimum free space" tunable?
17:49:58	dansmith	it doesn't affect the "we're not counting for it at all" problem, but I'm just curious about what your environment looks like in terms of how many instances are booted from distinct images and whether or not those get cleaned up slowly, or at all
17:55:53	sean-k-mooney	dansmith: are you wondering if turning on the cache purge periodic (assuming its off) could help stop the bleeding while we figure out how to adress it more generally
17:56:43	dansmith	sean-k-mooney: we already have an approach that helps aarents' situation acutely, I'm just trying to gather more info about that specific situation for my mental model
17:57:10	sean-k-mooney	ah ok
17:57:26	sean-k-mooney	well hopefully they will be around at some point to respond
18:03:05	melwitt	I'm reviewing the patch now, but curious does the libvirt driver really work on windows ever? was looking at this NOTE https://review.opendev.org/#/c/728439/5/nova/virt/libvirt/imagecache.py@378
18:04:02	sean-k-mooney	technically libvirt can manage hyperv but no i dont think the nova libvirt driver has ever worked on windows
18:04:25	sean-k-mooney	im pretty sure we read sysfs in a cople of places which definetly wont work on windows
18:05:34	sean-k-mooney	that does not make gibi's comment wrong we just dont really have to care that it does not work on windows
18:05:54	melwitt	ack
18:06:08	dansmith	it's more a note for a developer later trying to make it work, which is why it's not included in the CONF or reno
18:06:28	melwitt	heh, that's the exact reason I was wondering
18:07:22	sean-k-mooney	i should proably review the rest of the patch while i have it open.
18:22:35	openstackgerrit	Merged openstack/nova stable/train: Update scheduler instance info at confirm resize https://review.opendev.org/729163
18:22:40	openstackgerrit	Merged openstack/nova stable/queens: Add retry to cinder API calls related to volume detach https://review.opendev.org/726508
18:22:48	openstackgerrit	Merged openstack/nova stable/rocky: Reset the cell cache for database access in Service https://review.opendev.org/720592
18:22:58	openstackgerrit	Merged openstack/nova stable/ussuri: Make quotas respect instance_list_per_project_cells https://review.opendev.org/729086
18:23:09	openstack	bug 1862633 in OpenStack Compute (nova) "unshelve leak allocation if update port fails" [Medium,Fix released] https://launchpad.net/bugs/1862633 - Assigned to Balazs Gibizer (balazs-gibizer)
18:23:09	openstackgerrit	Merged openstack/nova stable/rocky: Reproduce bug 1862633 https://review.opendev.org/713187
18:28:37	openstackgerrit	Dan Smith proposed openstack/nova master: Add admin doc information about image cache resource accounting https://review.opendev.org/729350
18:33:25	openstackgerrit	Merged openstack/nova stable/rocky: Clean up allocation if unshelve fails due to neutron https://review.opendev.org/713196
20:13:45	openstackgerrit	Merged openstack/nova master: Bump hacking min version to 3.1.0 https://review.opendev.org/727589
21:00:50	openstackgerrit	Lee Yarwood proposed openstack/nova master: Don't age swap files in the image cache https://review.opendev.org/641093
22:20:45	openstackgerrit	Merged openstack/nova master: Reserve DISK_GB resource for the image cache https://review.opendev.org/728439
22:30:29	openstackgerrit	Merged openstack/nova master: Fix ut error on Aarch64(And other non-x86 platform) https://review.opendev.org/713163
23:24:40	openstackgerrit	melanie witt proposed openstack/nova master: Add admin doc information about image cache resource accounting https://review.opendev.org/729350
#openstack-nova - 2020-05-20
00:04:48	mriedem	dansmith: question in that docs patch
00:09:14	openstackgerrit	melanie witt proposed openstack/nova master: rbd_utils: increase _destroy_volume timeout https://review.opendev.org/705764
00:26:44	openstackgerrit	Merged openstack/nova stable/train: Revert "nova shared storage: rbd is always shared storage" https://review.opendev.org/726861
03:31:01	openstackgerrit	Qiu Fossen proposed openstack/nova stable/stein: Update scheduler instance info at confirm resize https://review.opendev.org/729505
04:46:03	openstackgerrit	Qiu Fossen proposed openstack/nova-specs master: specify mac for creating instance https://review.opendev.org/700429
04:58:37	openstackgerrit	Merged openstack/nova master: libvirt: Remove MIN_LIBVIRT_MULTIATTACH https://review.opendev.org/710238
06:41:50	openstackgerrit	Qiu Fossen proposed openstack/nova stable/stein: Update scheduler instance info at confirm resize https://review.opendev.org/729505
06:58:57	gibi	good morning nova
07:25:34	openstackgerrit	Balazs Gibizer proposed openstack/nova stable/ussuri: Reserve DISK_GB resource for the image cache https://review.opendev.org/729523
07:33:36	openstackgerrit	Qiu Fossen proposed openstack/nova stable/rocky: Update scheduler instance info at confirm resize https://review.opendev.org/729527
07:51:07	openstack	bug 1869050 in OpenStack Compute (nova) stein "migration of anti-affinity server fails due to stale scheduler instance info" [Low,In progress] https://launchpad.net/bugs/1869050
07:51:07	openstackgerrit	Balazs Gibizer proposed openstack/nova stable/stein: Reproduce bug 1869050 https://review.opendev.org/729530
07:57:02	openstackgerrit	Qiu Fossen proposed openstack/nova stable/stein: Create instance action when burying in cell0 https://review.opendev.org/729531
08:10:21	openstackgerrit	Balazs Gibizer proposed openstack/nova stable/stein: Update scheduler instance info at confirm resize https://review.opendev.org/729538
08:10:50	openstackgerrit	Huaqiang Wang proposed openstack/nova master: Use annotated ddt for test_cpu_policy_constraint https://review.opendev.org/692205
08:13:20	lyarwood	morning \o
08:16:27	openstackgerrit	Wenping Song proposed openstack/nova master: error may occur when filter scheduler with accelerator https://review.opendev.org/722651
08:17:20	gibi	lyarwood: o/
08:19:32	openstackgerrit	Balazs Gibizer proposed openstack/nova stable/queens: Clean up allocation if unshelve fails due to neutron https://review.opendev.org/729540
08:19:32	openstack	bug 1862633 in OpenStack Compute (nova) "unshelve leak allocation if update port fails" [Medium,Fix released] https://launchpad.net/bugs/1862633 - Assigned to Balazs Gibizer (balazs-gibizer)
08:19:32	openstackgerrit	Balazs Gibizer proposed openstack/nova stable/queens: Reproduce bug 1862633 https://review.opendev.org/729539
08:28:22	aarents	good morning
08:29:44	aarents	dansmith, about your yesterday interrogation, Yes we benefit of cache purge, and yes we have host with big cache usage (unremovable) that prevent to put more instance than expected. this is random. we have plenty of case where, for example a customer boot from its big snapshot(not sharable with neighborhood), or we have plenty of small image in cache all 'Debian 9' but because we maintain security
08:29:50	aarents	update frequently on our public image, those image are different. We still have benefit to cache image, sometime a bit less.
08:36:44	openstackgerrit	Lee Yarwood proposed openstack/nova master: Don't age swap files in the image cache https://review.opendev.org/641093
08:43:21	brinzhang	sean-k-mooney, gibi: hi, I have a question. If the ARQs instance in SHELVED (not shelved_offload) state, do we need to delete it's bind arqs info?
08:44:00	brinzhang	when do shelve_instance action
08:46:10	brinzhang	IMO, if the instance in SHELVED status, it should always occupied the arqs resources, we dont delete it's binding arqs when we shelve it, right?
08:53:56	Aditi20	Hi, I have a doubt regarding openstack. Could you please provide me inputs?
08:53:57	Aditi20	is - https://opendev.org/openstack/nova/src/branch/master/nova/virt/libvirt/config.py this file creates libvirt.xml file for instances. And it doesn't have any support for nested-hv currently.
09:12:35	openstackgerrit	Huaqiang Wang proposed openstack/nova master: test_hardware: code formating for multiline construct https://review.opendev.org/728793
09:13:48	openstackgerrit	Lee Yarwood proposed openstack/nova master: Add admin doc information about image cache resource accounting https://review.opendev.org/729350
09:20:07	openstackgerrit	Huaqiang Wang proposed openstack/nova master: Use annotated ddt for test_cpu_policy_constraint https://review.opendev.org/692205
09:29:03	openstackgerrit	Huaqiang Wang proposed openstack/nova master: Use annotated ddt for test_cpu_policy_constraint https://review.opendev.org/692205
09:36:42	sean-k-mooney	brinzhang: no we only delete the ARQs in shelve offload
09:37:18	brinzhang	sean-k-mooney: got it, I talked with alex_xu
09:38:28	brinzhang	sean-k-monney: thanks, I will submit a poc code for unshelve/shelve instance, hope you can review that when you have free time.
09:46:51	sean-k-mooney	my mothewr rang so ill review when im done
09:47:11	openstackgerrit	Jiri Suchomel proposed openstack/nova master: Remove deprecated nova.image.download hook https://review.opendev.org/725338
09:47:12	openstackgerrit	Jiri Suchomel proposed openstack/nova master: Add ability to download Glance images into the libvirt image cache via RBD https://review.opendev.org/574301
09:47:36	brinzhang	sean-k-mooney: thanks ^
09:48:35	openstackgerrit	Huaqiang Wang proposed openstack/nova master: [WIP] Use annotated ddt for test_cpu_policy_constraint https://review.opendev.org/692205
09:48:38	jsuchome	lyarwood: Hi, I've addressed your comments, in some parts we still disagree (same with some dansmith's ones btw)
09:50:48	lyarwood	jsuchome: ack, I'll take a look now
10:13:30	openstackgerrit	Huaqiang Wang proposed openstack/nova master: test_hardware: show test parameter details for causing a test failure https://review.opendev.org/692205
10:47:16	openstackgerrit	Brin Zhang proposed openstack/nova master: WIP: Cyborg shelve/unshelve support https://review.opendev.org/729563
11:08:11	openstackgerrit	Merged openstack/nova master: trivial: Remove remaining '_LE' instances https://review.opendev.org/728963
11:20:10	lyarwood	jsuchome: sorry was side tracked, just updated.
11:20:59	lyarwood	jsuchome: apologies for the mistakes before, I really think we need to break this up a little to make the logic more clear to reviewers
11:26:09	jsuchome	lyarwood: the main part is somewhat confusing, I agree ... I'm not sure though how to make it better
11:26:58	jsuchome	maybe by moving the verification bits into different method...
11:52:28	lyarwood	jsuchome: yeah I think that would be useful
11:53:04	brinzhang_	sean-k-mooney: IMO, you should move https://review.opendev.org/#/c/729563/1/nova/compute/api.py@4041 this common block code to the cyborg as a common function,
11:53:39	sean-k-mooney	yep that is more or less what i was referint too when i commented on your follow up
11:53:41	brinzhang_	sean-mooney: I was rebased on your patch, if I move this that you cannot call it in your patch
11:54:02	sean-k-mooney	i noticed you wer basically doint the same thing and extracting it to a common function we can both use makes sense
11:56:06	sean-k-mooney	brinzhang_: i was also being lazy and suggesting you could refactor my code :P but ill see if i can update it later today
11:56:07	brinzhang	after you update, I will update again, to call the common function ^
11:56:51	brinzhang	sean-k-mooney: ok, if I have time tomorrow, I will do
11:57:25	brinzhang	I am meeting now, after meetting , I will go home today.

Earlier   Later