| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-05-15 | |||
| 00:49:39 | brinzhang | gmann: the hacking verion should change to 3.1.0? | |
| 00:49:42 | brinzhang | right? | |
| 00:50:31 | gmann | brinzhang: yeah in your patch yes as it will fix the code together | |
| 00:50:57 | brinzhang | gmann: ok, update soon | |
| 00:51:53 | melwitt | I wonder if alex_xu is around | |
| 00:56:17 | gmann | melwitt: this should avoid doc failure - https://review.opendev.org/#/c/727943/4 | |
| 00:56:44 | melwitt | gmann: it doesn't because 2.1.1 also fails | |
| 00:57:50 | melwitt | if you look in the docs job build logs, 2.1.1 is installed now | |
| 00:58:05 | openstackgerrit | Brin Zhang proposed openstack/nova master: Bump hacking min version to 3.1.0 https://review.opendev.org/727589 | |
| 00:58:57 | gmann | melwitt: not sure why not complete revert that instead if backlist. PS1 was right revert - https://review.opendev.org/#/c/727943/1/upper-constraints.txt | |
| 01:00:11 | brinzhang | gmann: updated, I just only keep the hacking min version to 3.1.0, i.e. hacking>=3.1.0, please check | |
| 01:18:38 | openstackgerrit | Brin Zhang proposed openstack/nova master: Bump hacking min version to 3.1.0 https://review.opendev.org/727589 | |
| 01:22:11 | brinzhang | gmann: do we need to continue merged hacking 3.0.1 https://review.opendev.org/#/c/727347/? | |
| 01:48:11 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Bump hacking min version to 3.0.1 https://review.opendev.org/727347 | |
| 01:51:08 | melwitt | gmann: lol, what a day huh! | |
| 01:51:31 | melwitt | (gate stuff) | |
| 01:54:04 | gmann | :). I think we made little hurry to release new hacking. | |
| 01:55:49 | gmann | I vote is to move back openstackdocstheme to 2.0.2 as nova, cinder are hitting doc + pep8 and may be more projects but not checked | |
| 01:55:55 | gmann | *my vote | |
| 01:56:40 | gmann | asked in requirement channel, let's see if we can get any other fast way to unblock | |
| 01:56:51 | melwitt | yeah, I lean that way too | |
| 01:57:49 | openstackgerrit | Brin Zhang proposed openstack/nova master: Bump hacking min version to 3.1.0 https://review.opendev.org/727589 | |
| 01:58:23 | gmann | because hacking is blacklist req so it cannot be controlled on single place (g-r side). | |
| 01:58:48 | melwitt | I see | |
| 02:08:37 | openstackgerrit | Brin Zhang proposed openstack/nova master: Bump hacking min version to 3.1.0 https://review.opendev.org/727589 | |
| 02:35:23 | melwitt | gmann: do you plan to depends-on the roll back patch or did you want to try it out some other way? | |
| 02:36:07 | gmann | i can do that. | |
| 02:36:46 | melwitt | or could do a dummy patch | |
| 02:37:01 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Bump hacking min version to 3.0.1 https://review.opendev.org/727347 | |
| 02:37:29 | gmann | melwitt: as it needs to re-run anyways. done ^^ | |
| 02:37:43 | melwitt | yeah, I saw it had already failed the docs job | |
| 02:37:54 | melwitt | cool I'll keep an eye on it | |
| 03:13:50 | openstackgerrit | melanie witt proposed openstack/nova master: Configure latex_engine = 'xelatex' for pdf docs build https://review.opendev.org/727898 | |
| 03:15:02 | melwitt | gmann: oh no, depends-on doesn't work for requirements changes?? | |
| 03:15:05 | melwitt | still failing | |
| 03:15:10 | melwitt | and pulling in 2.1.1 | |
| 03:19:19 | gmann | melwitt: yeah, we need to get requirement revert merge first | |
| 03:19:49 | melwitt | gmann: oh really? depends-on known not to work in this case? I didn't know that, guh | |
| 03:20:17 | melwitt | I thought we were going to be able to test if job passes with the requirement revert | |
| 03:43:18 | gmann | melwitt: left note on this to recheck after req patch merge - https://review.opendev.org/#/c/727347/3 | |
| 03:43:45 | melwitt | gmann: cool, I've re-approved it so it's ready to go | |
| 03:44:16 | gmann | bauzas: stephenfin gibi ^^ whoever wake up early. this is req patch to merge first - https://review.opendev.org/#/c/728335/ | |
| 03:44:21 | gmann | melwitt: thanks. | |
| 03:45:10 | gmann | going to bed... | |
| 03:45:47 | melwitt | k seeya | |
| 06:57:10 | openstackgerrit | Andreas Jaeger proposed openstack/nova master: DNM: Test openstackdocstheme master https://review.opendev.org/728372 | |
| 07:01:18 | gibi | good morning nova | |
| 07:03:13 | gibi | gmann: I see melwitt rechecked it | |
| 07:03:14 | melwitt | gibi: yeah rechecked it just a little while ago, once that lands, our gate should be unblocked. fingers crossed nothing goes wrong | |
| 07:03:20 | gibi | gmann: I'm approving https://blueprints.launchpad.net/nova/+spec/policy-defaults-refresh-deprecated-apis as we agreed about it on yesterday's team meeting | |
| 07:18:51 | bauzas | good Friday Nova | |
| 07:24:33 | bauwser | there it is | |
| 08:05:33 | kashyap | bauwser: /me waves | |
| 08:56:11 | openstackgerrit | Andreas Jaeger proposed openstack/nova master: DNM: Test openstackdocstheme master https://review.opendev.org/728372 | |
| 09:17:13 | lyarwood | stephenfin: https://review.opendev.org/#/c/676208/ - I'm onboard with using mypy just not adding it to the pep8 while it's still optional and not used outside of the libvirt driver. | |
| 09:17:29 | lyarwood | pep8 env* | |
| 09:19:24 | stephenfin | lyarwood: I originally had a separate mypy zuul job and tox target but when I proposed said zuul job against openstack-zuul-jobs, mordred noted that zuul simply integrated it into their pep8 target (or linters, I think they call it) | |
| 09:19:27 | stephenfin | hence why I did it that way | |
| 09:19:34 | stephenfin | where would be better? | |
| 09:25:35 | lyarwood | stephenfin: okay it might not be worth splitting hairs over this but given it's not widely used in openstack/nova yet it seems like overkill to run it everytime we run pep8 | |
| 09:26:00 | lyarwood | stephenfin: I guess zuul is using it as standard across their codebase and that's why they've merged things | |
| 09:27:52 | lyarwood | stephenfin: if gibi and others are cool with it being in the pep8 env then I'll shut up and let it merge :) | |
| 09:29:04 | gibi | stephenfin, lyarwood: is it something that makes tox -e fast8 target significantly slower? | |
| 09:29:35 | stephenfin | it doesn't affect fast8, no | |
| 09:29:46 | stephenfin | and even for pep8, it takes seconds to run | |
| 09:29:55 | lyarwood | with a single file at the moment ;) | |
| 09:30:01 | lyarwood | but yeah it's little to no overhead | |
| 09:30:21 | gibi | pep8 takes minutes so additional seconds does not cause any pain for me | |
| 09:30:30 | gibi | so I'm OK to integrate it to the pep8 target | |
| 09:30:38 | lyarwood | ack thank s gibi | |
| 09:30:40 | stephenfin | three files two commits later! | |
| 09:30:44 | gibi | :D | |
| 09:31:01 | lyarwood | lol, we can always break it out again if it does become an issue | |
| 09:31:19 | gibi | agree ^^ | |
| 09:31:30 | stephenfin | cool | |
| 09:31:36 | brinzhang | stephenfin: do I need to remove this sentence from the commit message? https://review.opendev.org/#/c/727589/8//COMMIT_MSG | |
| 09:31:44 | stephenfin | also, is it just me, or is Gerrit really slow this week? | |
| 09:31:55 | stephenfin | like, 'git review -d foo' takes minutes | |
| 09:31:55 | lyarwood | stephenfin: just you | |
| 09:31:59 | stephenfin | damn | |
| 09:32:23 | stephenfin | the web UI is a-ok, but pulling stuff is taking an age | |
| 09:32:24 | brinzhang | git review -d, I always need minutes | |
| 09:32:39 | lyarwood | I've really not noticed anything tbh | |
| 09:33:07 | stephenfin | brinzhang: you don't need to exclude F811 now, do you? | |
| 09:33:13 | stephenfin | gibi: :O | |
| 09:33:28 | stephenfin | so you manually copy download links? | |
| 09:33:34 | stephenfin | *checkout links | |
| 09:33:57 | gibi | stephenfin: yepp, and I use git push origin HEAD:refs/for/master/my-topic to push things up | |
| 09:34:07 | brinzhang | stephenfin: you mean I should remove F811 from flake8 ignore in tox.ini? | |
| 09:34:36 | stephenfin | brinzhang: I assume so, since you added noqa lines to the "duplicated" functions/methods? | |
| 09:34:47 | stephenfin | That is what F811 is for, right? | |
| 09:34:57 | brinzhang | yes | |
| 09:35:39 | brinzhang | in the future, if someone need to add one function name as the same as before, they also need to add noqa. | |
| 09:35:46 | brinzhang | ok, I will remove F811 from tox | |
| 09:36:22 | brinzhang | gibi: IMO, you can give a guide to use link to submit code, and update code. | |
| 09:36:38 | gibi | stephenfin: I have full control this way | |
| 09:36:51 | brinzhang | I always used 'git review ', it seems slowly always | |
| 09:37:00 | gibi | stephenfin: e.g. I can push patches from a series during interactive rebase | |
| 09:37:22 | stephenfin | gibi: you mean half way through the rebase? | |
| 09:37:46 | gibi | stephenfin: yepp | |