Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-05-13
08:30:15 gibi sean-k-mooney, dansmith: also I replied in the patch https://review.opendev.org/#/c/727261 and will continue investigating turning off the cache today
08:37:08 brinzhang_ gibi: this re-propose spec comes from U release https://review.opendev.org/#/c/719720/, hope you can review again
08:40:50 openstackgerrit Nalini Varshney proposed openstack/nova master: Add migration to make key field type VARBINARY in aggregate_metadata table, https://review.opendev.org/725522
08:43:59 openstackgerrit sean mooney proposed openstack/nova master: Delete ARQs by UUID if Cyborg ARQ bind fails. https://review.opendev.org/716186
08:59:24 sean-k-mooney gibi: we only have prefilters back to rocky
08:59:55 sean-k-mooney gibi: i guess we could backport it that far back.
09:00:23 sean-k-mooney normlaly i a prefilter would be a feature but in this case its a bug so if the stable team is ok with it maybe
09:03:23 sean-k-mooney gibi: the prefilter would result in us over allocating the storage so we also need to srink the allocation on the compute node
09:07:10 sean-k-mooney that said we still need to be careful for rolling updates
09:20:22 openstackgerrit sean mooney proposed openstack/nova master: Delete ARQs by UUID if Cyborg ARQ bind fails. https://review.opendev.org/716186
10:00:37 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Don't delete disks on shared storage during evacuate https://review.opendev.org/578846
10:00:37 openstack bug 1550919 in OpenStack Compute (nova) "[Libvirt]Evacuate fail may cause disk image be deleted" [Medium,In progress] https://launchpad.net/bugs/1550919 - Assigned to Lee Yarwood (lyarwood)
10:00:37 openstackgerrit Lee Yarwood proposed openstack/nova master: Add functional test for bug 1550919 https://review.opendev.org/631294
10:01:00 lyarwood stephenfin: ^ blast from the past, you were pretty happy with this a while ago if you have anytime today to take another look?
10:01:49 stephenfin Sure. I've my head stuck into something rn though so it might be tomorrow
10:02:15 lyarwood ack np
10:34:38 openstackgerrit sean mooney proposed openstack/nova master: Delete ARQs by UUID if Cyborg ARQ bind fails. https://review.opendev.org/716186
10:34:39 openstackgerrit sean mooney proposed openstack/nova master: cyborg evacuate support https://review.opendev.org/715326
10:46:40 sean-k-mooney gibi: procedual question for you. do i need to file a spec for ^ or a blueprint?
10:47:27 sean-k-mooney gibi: the first patch is clearly a bug but i likely wont have time to complete all the other move operation for cyborg this cycle at least not unless we finish the numa in placment work before m1 or m2
10:47:58 sean-k-mooney gibi: so i would like to get rebuild/evacuate merged but not sure ill get much more done in the near term
10:48:45 sean-k-mooney would you be oke tracking rebuild/evacuate via a bug or speclesss blueprint?
10:49:49 gibi sean-k-mooney: re: image cache, I will keep the pre-filter impl independent from the disable cache impl so we can decide about the backport independently
10:50:07 sean-k-mooney gibi: ya i think that makes sense
10:50:29 sean-k-mooney gibi: the disable config option is much simpler to backport but is really just a workaround
10:50:31 gibi sean-k-mooney: about cyborg + evac I think at least a bp is needed for tracking
10:50:52 sean-k-mooney gibi: ok ill file one so
10:51:11 sean-k-mooney for the provider.yaml work im going to copy paste the spec form last cycle and repopose it
10:51:28 gibi sean-k-mooney: provider yaml was re-proposed already
10:51:33 sean-k-mooney oh ok cool
10:51:49 gibi https://review.opendev.org/#/c/725788/
10:52:12 gibi I think tony_su from intel is willing to take it over
10:53:08 sean-k-mooney ok cool. the only feedback that was pending was consolidating the negitive test into a yaml file or the posityve into python so they are consistnet
10:53:49 sean-k-mooney if they can take it over then cool i can spend a little time working on it this cycle if it merges early i.e. if we can get it dont before m1
10:56:34 gibi OK
11:06:06 gibi sean-k-mooney: also it would be nice to check brinzhang_ and the cyborg team about supporting other server operations with cyborg in V. I assume they would like to continue that work so you can join forces
11:08:38 brinzhang_ gibi, sean-k-mooney: if you have some idea that you can add that in https://etherpad.opendev.org/p/cyborg-victoria-goals, that will be discuss in PTG
11:08:42 sean-k-mooney gibi: ya maybe. honestly i dont think its that much work to make it work. its a littel non tivaial but it can be done iteritivly
11:09:23 gibi sean-k-mooney: sure, I'm not talking about evac specially, but all the missing / unsupported server operation in general.
11:09:45 sean-k-mooney brinzhang_: well it was more just completeing the list here https://review.opendev.org/#/c/715326/10/api-guide/source/accelerator-support.rst
11:09:51 huaqiang hi, I have a question I wonder if anyone can give me some comment or deliver a conclusion directly. Does it tolerate to loose some information in a process of 'versioned_object.obj_to_primitive'? especially generating a primitive dict in a lower version number.
11:10:01 sean-k-mooney everything except for live migrate should be doable
11:11:31 sean-k-mooney gibi: ya i was originally planning to submit a patch for each of them im unst unlikely to have time to do that this cycle. that said i might work on it on and off this cycle.
11:11:53 brinzhang_ sean-k-mooney, gibi: yeah, in accelerator-support.rst marked unsuport all need to be consider to support, as sean-k-mooney said except for live migrate
11:12:22 sean-k-mooney brinzhang_: suspend/resume and shelve/unshelve should be fairly simple to do
11:12:42 gibi brinzhang_: do you or the cyborg team will have bandwidth during V to work on adding support for the missing operations?
11:12:45 sean-k-mooney resize/coldmigreate needs a little more work but they are effectvly the same operation
11:13:30 brinzhang_ sean-k-mooney: got it ^
11:14:21 gibi huaqiang: if you generate a lower version dict then you need to drop the fields that was not present in that lower version. So that is a necessary loss of information. Other than that I think we tend to keep the information. I think dansmith is the best person to ask
11:14:47 brinzhang_ gibi: yes, we will, during V we will open block operation asap, but we should talked in PTG,
11:15:42 gibi brinzhang_: OK. Thanks. I just wanted to make sure that you and sean-k-mooney are in sync about who does what in V
11:16:19 sean-k-mooney brinzhang_: there should not be any gaps in cyborg by the way for the remaining ops
11:16:25 sean-k-mooney its all jus nova work
11:17:09 gibi brinzhang_: checked https://review.opendev.org/#/c/719720/ and I left one comment about the password length
11:17:10 sean-k-mooney suspend/resume just need to be exteded to hot unplug the acclerator on suspend and hot plug them on resume like we do for normla pci passtough or sriov devices
11:17:23 brinzhang_ gibi: I follow sean-k-mooney, many operation may I cannt test, because of limit the hard device
11:17:50 gibi brinzhang_: I hope we can add functional test cases for most of it.
11:17:52 sean-k-mooney sheleve need to delete the arq binding in shelve offload and it need to claim(in placmemnt) the acclerateor and bind arques on unshelve
11:18:36 sean-k-mooney gibi: we can test most of it with the fake dirver too
11:18:42 gibi cool
11:19:18 sean-k-mooney we might want to add some extra logging in placese to be extra sure or enhance it slightly so we have something observable
11:19:42 brinzhang_ sean-k-mooney: cool, thanks, I will try to test that scenario
11:20:04 sean-k-mooney e.g. adding or remvoing an xml comment for example instead of doing nothing so we can se the fake device "added" or "removed"
11:22:19 brinzhang_ sean-k-mooney: I add your said in my list, I will check these thing, e.g. log, and suspend/resume or shelve/unshelve
11:25:31 gibi lyarwood: hi! I see a lot of rescue failure in the lvm job http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22cannot%20be%20rescued%5C%22 is it a known issue?
11:25:39 huaqiang gibi: Got. so the 'obj_to_primitive' offers the capability to run, but not with the full object function.
11:25:57 sean-k-mooney huaqiang: its not that it does not have full fucntion
11:26:21 sean-k-mooney its more that any feature that depends on data only contained in a later version cannot be used
11:27:30 sean-k-mooney huaqiang: when you are backleveling object you baseically are restited to the feature set of the oldest code base invovled in the rpc
11:28:17 huaqiang I am think my design for 'mixed-instance', that is an instance mixed with dedicated cpus and shared cpus, when I deal with the compatibility 'instanceNUMATopology', maybe one choice is dropping the dedicated CPUs directly
11:28:22 sean-k-mooney there are some expctions to that but in generall we dont try to caluate the valuse in new codebases if the object was created in an older version
11:29:14 sean-k-mooney huaqiang: well there are two cases
11:29:30 huaqiang sean-k-mooney: pls
11:29:52 sean-k-mooney if a field existied in an older version but the value was not supported we raise an excpetion if you try to backlevel it
11:30:07 sean-k-mooney but if the filed does not exist we remove the filed
11:30:27 sean-k-mooney let me find an example quick
11:30:28 huaqiang yes...
11:30:57 sean-k-mooney https://github.com/openstack/nova/blob/master/nova/objects/image_meta.py#L194-L200
11:31:18 sean-k-mooney so in 1.22 we extended the hw_video_model filed
11:32:05 sean-k-mooney if an object was created using one of the values that was only supported in 1.22+ we raise an excption
11:32:05 huaqiang Yes. raised an exception
11:32:34 sean-k-mooney but for hw_time_hpet when it is backleveled it is dropped
11:32:40 sean-k-mooney so for your feature
11:32:56 sean-k-mooney we would raise an excpetion for the cpu policy
11:33:16 sean-k-mooney e.g. you would not be allowed to backevel an object with cpu_policy=mixed
11:33:39 huaqiang Yes. I agree
11:33:40 sean-k-mooney because that woudl result in incorrect behavior
11:33:52 huaqiang how about InstanceNUMACell
11:34:02 huaqiang the closest example is this:https://github.com/openstack/nova/blob/master/nova/objects/numa.py#L49
11:34:25 huaqiang It dropped the host 'pcpuset' directly
11:35:19 sean-k-mooney yes
11:35:36 huaqiang Not translate the pcpuset to exsiting cpuset
11:35:53 sean-k-mooney so for mixed cpus you should not need to modify the OVOs out side fo adding the new value for the cpu policy correct
11:36:17 sean-k-mooney we dont need to modify the host cell object
11:36:27 huaqiang I don't
11:36:33 brinzhang_ gibi: can you open this link http://people.redhat.com/pbonzini/qemu-test-doc/_build/html/topics/vnc_005fsecurity.html
11:36:50 sean-k-mooney so the allowed values of https://github.com/openstack/nova/blob/master/nova/objects/instance_numa.py#L59 will change
11:37:12 sean-k-mooney but the cpu_pinning_raw value can be used in both the dedicated or mixed case
11:37:23 sean-k-mooney in the dedicated case it will have an entry for all cpus
11:37:44 sean-k-mooney in the mixed case it will have a mapping only for the pinned cpus and the floating cpus will not be listed

Earlier   Later