| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-05-04 | |||
| 13:55:56 | openstackgerrit | Thomas Goirand proposed openstack/nova master: Add a /healthcheck URL https://review.opendev.org/724684 | |
| 13:56:43 | bauzas | zigo: hold your change | |
| 13:56:47 | bauzas | it won't work (yet) | |
| 13:58:10 | bauzas | ahah ! | |
| 13:58:19 | bauzas | > /home/sbauza/git/openstack/nova/nova/tests/functional/api/client.py(172)api_request() | |
| 13:58:20 | bauzas | (Pdb) n | |
| 13:58:20 | bauzas | 'http://94193b57-ca75-4e13-9d4c-2cc961eeaf5b:80/6f70656e737461636b20342065766572//healthcheck' | |
| 13:58:20 | bauzas | (Pdb) full_uri | |
| 13:58:20 | bauzas | -> response = self.request(full_uri, **kwargs) | |
| 13:58:36 | bauzas | we don't want the project here | |
| 13:59:21 | bauzas | 200 | |
| 13:59:21 | bauzas | (Pdb) self.request(good_uri, **kwargs).status_code | |
| 13:59:21 | bauzas | (Pdb) good_uri = 'http://94193b57-ca75-4e13-9d4c-2cc961eeaf5b:80/healthcheck' | |
| 13:59:26 | bauzas | zigo: ^ | |
| 14:03:23 | bauzas | zigo: found how to solve it | |
| 14:03:27 | bauzas | zigo: https://github.com/openstack/nova/blob/master/nova/tests/fixtures.py#L931 | |
| 14:03:29 | openstackgerrit | Thomas Goirand proposed openstack/nova master: Add a /healthcheck URL https://review.opendev.org/724684 | |
| 14:04:39 | bauzas | zigo: stop eating our CI resources, please :) | |
| 14:04:46 | zigo | Will do ! :) | |
| 14:04:53 | bauzas | zigo: I'm close to the resolution | |
| 14:05:13 | bauzas | zigo: I can propose a revision if you're okay with ? | |
| 14:05:20 | zigo | Sure, thanks ! | |
| 14:05:49 | bauzas | zigo: ok, I'll just propose another test class | |
| 14:09:15 | zigo | Indeed, it's probably fine in this file, but not the same class, I thought about fixing that too ! | |
| 14:17:12 | openstack | Launchpad bug 1818671 in OpenStack Compute (nova) "Openstack usage list not showing all projects" [Undecided,New] | |
| 14:17:12 | gibi | melwitt: you looked at this bug report before: https://bugs.launchpad.net/nova/+bug/1818671 There are some new data in there. I looked at it. I cannot reproduce it on master and the bugfix that seems relevant backported to the version of used by the last commenter | |
| 14:18:12 | gibi | melwitt: I don't have a queens devstack at hand. Do you have any idea what fixed the problem since Queens? | |
| 14:28:36 | bauzas | zigo: I'm done with your change | |
| 14:28:39 | bauzas | zigo: it works locally | |
| 14:28:47 | bauzas | zigo: but I'd like to add a negative test | |
| 14:29:12 | zigo | bauzas: Of what kind? What will you negatively test? | |
| 14:29:12 | bauzas | zigo: how can I fake healthcheck to say "sorry but no" ? | |
| 14:29:20 | zigo | Oh... | |
| 14:33:03 | openstackgerrit | Doug Hellmann proposed openstack/nova master: increase verbose level for release notes build https://review.opendev.org/725290 | |
| 14:34:56 | bauzas | ok, nevermind, you haven't enabled the disabled_per_file option | |
| 14:35:07 | bauzas | will just verify the JSON output | |
| 14:37:01 | bauzas | /home/sbauza/git/openstack/nova/.tox/functional/lib/python3.7/site-packages/paste/deploy/util.py:55: DeprecationWarning: Using function/method 'Healthcheck.factory()' is deprecated: The healthcheck middleware must now be configured as an application, not as a filter | |
| 14:37:01 | bauzas | ahah, very interesting | |
| 14:37:02 | zigo | bauzas: I don't see any reason why it would be needed, but yeah, we could set /etc/nova/disable_healthcheck by default. | |
| 14:37:14 | bauzas | zigo: let's not overthink this | |
| 14:37:21 | zigo | Oh ! :) | |
| 14:37:26 | bauzas | this being said, see the deprecation warning above | |
| 14:37:41 | zigo | I've seen it as an app somewhere. | |
| 14:38:13 | bauzas | zigo: https://github.com/openstack/oslo.middleware/blob/2e56b4379ab5a8bd5c42e885253c81d2a5f021c2/oslo_middleware/healthcheck/__init__.py#L242-L248 | |
| 14:38:22 | bauzas | zigo: just amending my revision | |
| 14:39:07 | zigo | Thanks a lot for all of this, this will really be helpful for operators. | |
| 14:40:03 | zigo | option httpchk GET /healthcheck | |
| 14:40:03 | zigo | backend novabackend | |
| 14:40:03 | zigo | Typically, in haproxy, you'd setup: | |
| 14:40:12 | zigo | If you don't, then you get crap in the nova-api.log ... | |
| 14:40:51 | zigo | As in, haproxy tries to open the connection, does no request, and close the connection, which is *very* hugly. | |
| 14:45:58 | gmann | bauzas: i feel we can keep those upgrade notes for V upgrade also as we will remove the old defaults in W cycle (along with U)- https://review.opendev.org/#/c/725226/1 | |
| 14:47:24 | bauzas | zigo: okay, you know what ? I can't really help on the paste issue, but I'll upload my new rev | |
| 14:47:41 | bauzas | zigo: then you can ask gmann or other API specialists to look at your paste config | |
| 14:51:42 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Add a /healthcheck URL https://review.opendev.org/724684 | |
| 14:52:17 | bauzas | zigo: okay, I left the deprecated usage but the functional test should work | |
| 14:52:42 | bauzas | zigo: this being said, I'll -1 because of the deprecation usage, please try to look at it | |
| 14:53:57 | zigo | Will do, let's first wait to see if it passes the gate. | |
| 14:55:22 | bauzas | zigo: it will : | |
| 14:55:32 | bauzas | nova.tests.functional.test_middleware.TestHealthCheckMiddleware.test_healthcheck 4.460 | |
| 14:55:32 | bauzas | -------------------------------------------------------------------------------- ----------- | |
| 14:55:32 | bauzas | Test id Runtime (s) | |
| 14:55:32 | bauzas | functional run-test: commands[1] | stestr slowest | |
| 14:55:33 | bauzas | __________________________________________________________________________________________________________________ summary ___________________________________________________________________________________________________________________ | |
| 14:55:34 | bauzas | functional: commands succeeded | |
| 14:55:35 | bauzas | congratulations :) | |
| 14:58:18 | dhellmann | bauzas : o/ | |
| 14:58:19 | artom | bauzas, zigo, also, since you're collaborating on that patch, reno and docs plz :) | |
| 14:58:21 | bauzas | dhellmann: thanks for joining :) | |
| 14:58:39 | bauzas | artom: I just helped zigo with his functest issue, nothing really important | |
| 14:58:50 | bauzas | now back on the RC2 holding bug | |
| 14:58:54 | dhellmann | I think the fix for the issue is to change the way the prelude links to the upgrade notes section, but I'm not sure of the best way to do that because you're in the middle of the RCs | |
| 14:59:10 | bauzas | dhellmann: ah, that's because we made an implicit target? | |
| 14:59:17 | dhellmann | after a final release, the rc sections are collapsed into that final version number, so the link targets change | |
| 14:59:18 | dhellmann | yes | |
| 14:59:27 | dhellmann | I'm experimenting with a fix locally | |
| 14:59:51 | bauzas | dhellmann: so https://review.opendev.org/#/c/725226/ wouldn't help with the issue ? | |
| 15:00:09 | bauzas | (sorry, got dragged from a bit) | |
| 15:00:21 | bauzas | gibi: you could be interested in this | |
| 15:01:01 | bauzas | dhellmann: we honestly used the implicit target for the prelude a lot of times | |
| 15:01:25 | bauzas | dhellmann: and i don't understand why it would be a problem due to https://review.opendev.org/#/q/Id9cd65877e53577bff22e408ca07bbeec4407f6e | |
| 15:02:03 | gmann | yeah that was i am wondering as it merged previous notes or section without comlain | |
| 15:02:27 | dhellmann | bauzas : no, that patch won't fix it. you might want that change anyway, but that's not the problem. | |
| 15:02:59 | dhellmann | bauzas : the problem is that with gmann's patch there are now 2 sections on the same page with the same title, so sphinx doesn't know which one you want to link to | |
| 15:03:21 | dhellmann | after the final release is tagged, they will be collapsed into 1 section, which is probably what you've seen on other releases | |
| 15:03:41 | dhellmann | and the problem is not really that there are 2 sections, it is that there are *links* to those sections in the text | |
| 15:03:49 | jsuchome | dansmith: Hi again, I rebased https://review.opendev.org/#/c/572805 and https://review.opendev.org/#/c/574301/ , could I get some reviews, please? | |
| 15:03:51 | dhellmann | so sphinx has to resolve where those links should go | |
| 15:04:13 | bauzas | dhellmann: looking at the paste you provided | |
| 15:05:58 | bauzas | okay, I *think* I understand | |
| 15:06:14 | bauzas | by merging gmann's patch, we're creating a new section | |
| 15:06:19 | dhellmann | right | |
| 15:06:45 | dansmith | jsuchome: I had feedback, so addressing that is necessary in addition to just rebasing it | |
| 15:07:13 | dhellmann | sheesh, there are a lot of changes in nova :-) generating the release notes takes ages | |
| 15:10:18 | gmann | dhellmann: should not merge section happen when it is release say rc2 version relese? and till then anything new goes into unreleased section instead of ussuri release section ? | |
| 15:10:31 | dhellmann | I think I have a fix, give me a sec to rebase | |
| 15:11:38 | gmann | dhellmann: ok, thanks | |
| 15:12:59 | gmann | bauzas: dhellmann may be i could have edited the existing reno instead of new so that it would conflict but that just hides this issue does not solve. | |
| 15:13:31 | gmann | bauzas: gibi i was searching and could not find any such issue (where new reno added in rc) for train and stein rc. | |
| 15:17:11 | gibi | honestly I can only agree what you found with the reno problem but I cannot give to that discussion. I hope dhellmann's fix will help | |