| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-04-30 | |||
| 21:40:16 | openstackgerrit | Ghanshyam Mann proposed openstack/os-vif master: [Community goal] Update contributor documentation https://review.opendev.org/722392 | |
| 21:41:09 | gmann | working now \o/ | |
| 21:41:34 | gmann | sean-k-mooney: ^^ updated as per your comment on 722392 | |
| 21:41:49 | sean-k-mooney | yep looking now | |
| 21:42:20 | sean-k-mooney | omg you have a white space how coudl you :P https://review.opendev.org/#/c/722392/3/doc/source/contributor/contributing.rst@29 | |
| 21:46:07 | sean-k-mooney | gmann: if you have time to fix https://review.opendev.org/#/c/722392/3/doc/source/contributor/contributing.rst those nits im happy with the content | |
| 21:46:39 | openstackgerrit | Ghanshyam Mann proposed openstack/os-vif master: [Community goal] Update contributor documentation https://review.opendev.org/722392 | |
| 21:46:54 | gmann | sean-k-mooney: done | |
| 21:47:03 | sean-k-mooney | awsome | |
| 21:47:47 | sean-k-mooney | ah i see you have already rechecked the other patch | |
| 21:47:57 | sean-k-mooney | i proably got lost with the zuul restart | |
| 21:48:28 | gmann | yeah, i thought that was merged | |
| 21:48:42 | sean-k-mooney | ya same | |
| 21:48:51 | sean-k-mooney | i guess not but it should merge soon | |
| 21:49:18 | sean-k-mooney | then we can merge stephens cahnge which is blocked by that | |
| 21:51:14 | gmann | sean-k-mooney: seems we need to backport that on ussuri brach also - https://review.opendev.org/#/c/724712/ | |
| 21:52:14 | sean-k-mooney | ya that makes sense i dont think we cap the sphinx version in the upperconstratit to prevent the issue | |
| 21:53:35 | gmann | we missed to recheck the fix and ussuri release one merged first - https://review.opendev.org/#/c/723687/ | |
| 21:55:22 | sean-k-mooney | ya one it merges on master we can cherry pick it and fast appove | |
| 21:55:33 | sean-k-mooney | then rebase teh git review patch on top | |
| 21:55:58 | sean-k-mooney | im not sure if i will be around much longer today be we can get that done tommorow | |
| 21:58:27 | gmann | +1 | |
| 22:14:49 | openstackgerrit | Merged openstack/nova stable/ussuri: zuul: Switch to the Zuulv3 grenade job https://review.opendev.org/724189 | |
| 22:20:43 | melwitt | gmann: added a comment on the nova-status review, I had been thinking the non-existent policy file would also result in taking all of the defaults | |
| 23:22:09 | gmann | melwitt: sorry, I was away. | |
| 23:23:35 | gmann | you mean file location in nova.conf but does not exist or with defaults conf (oslo_policy.policy_file) with no file. | |
| 23:48:08 | melwitt | gmann: um... I'm not sure, I just meant like when there's no policy.json file, it uses the defaults in code? | |
| #openstack-nova - 2020-05-01 | |||
| 00:36:07 | openstackgerrit | Merged openstack/os-vif master: Fix doc build job for wanring turn into error https://review.opendev.org/722407 | |
| 00:39:31 | gmann | melwitt: yes that is right. like all our job in gate is without no file. if no file then there is no issue it will be always default. | |
| 00:41:09 | gmann | oslo load file first if exist (1. try json load 2. if error then yaml load), and then any registered rule missing from file will be loaded from default. in case of no file all the rules will be missing so everything default will loaded in policy namespace | |
| 00:41:39 | openstackgerrit | Ghanshyam Mann proposed openstack/os-vif stable/ussuri: Fix doc build job for wanring turn into error https://review.opendev.org/724784 | |
| 00:42:13 | gmann | sean-k-mooney: stephenfin backported the os-vif doc job fix - https://review.opendev.org/#/c/724784/ | |
| 03:10:44 | melwitt | gmann: ok. thanks. sorry, was just wondering whether that was something to also mention in the nova-status upgrade mention or not, where it said blank file. I wasn't sure if blank file would also do the same as "no file" for option 3 in the message | |
| 07:18:22 | bauzas | gibi: bank holiday today, will be back on Monday | |
| 09:06:51 | stephenfin | lyarwood: you stable-core on os-vif? https://review.opendev.org/#/c/724784/ | |
| 09:11:58 | openstackgerrit | Merged openstack/os-vif master: [Community goal] Update contributor documentation https://review.opendev.org/722392 | |
| 09:12:46 | lyarwood | stephenfin: yes | |
| 09:13:40 | stephenfin | Cool. Would you mind? There are also a few stable branch creation patches there. They're -1 but that's because we need the patch I linked to merge first | |
| 09:14:47 | lyarwood | stephenfin: ack, +W'd | |
| 09:14:58 | stephenfin | thanks | |
| 09:15:20 | openstackgerrit | Lee Yarwood proposed openstack/os-vif stable/ussuri: Update .gitreview for stable/ussuri https://review.opendev.org/724712 | |
| 09:15:29 | openstackgerrit | Lee Yarwood proposed openstack/os-vif stable/ussuri: Update TOX_CONSTRAINTS_FILE for stable/ussuri https://review.opendev.org/724713 | |
| 09:16:09 | lyarwood | stephenfin: https://review.opendev.org/#/c/723853/ - trivial one if you have time, any idea why that link doesn't work? | |
| 09:17:02 | stephenfin | looking | |
| 09:20:58 | stephenfin | lyarwood: it's the os-api-ref extension | |
| 09:21:32 | stephenfin | this is what the URL looks like if you navigate to the "Execute Server" section first: ?expanded=evacuate-server-evacuate-action-detail#forced-down | |
| 09:21:51 | stephenfin | that doesn't work since the block the anchor relates to is not visible | |
| 09:22:33 | stephenfin | if you navigate to the 'Update Forced Down' section first, followed by 'Evacuate Server', you get this: ?expanded=update-forced-down-detail,evacuate-server-evacuate-action-detail#forced-down | |
| 09:22:36 | stephenfin | which does work | |
| 09:24:00 | openstackgerrit | jayaditya gupta proposed openstack/nova master: Support for --force flag for nova-manage placement heal_allocations command use this flag to forcefully call heal allocation for a specific instance https://review.opendev.org/715395 | |
| 09:24:23 | lyarwood | stephenfin: ah, so is the best we can do? | |
| 09:24:53 | lyarwood | stephenfin: I just copied the approach from another section FWIW | |
| 09:25:51 | stephenfin | lyarwood: try removing the anchor you added and using ':ref:`update-forced-down` instead | |
| 09:26:03 | lyarwood | ack | |
| 09:26:36 | stephenfin | because that already exists https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_348/723853/1/check/build-openstack-api-ref/348c486/docs/#update-forced-down | |
| 09:31:37 | openstackgerrit | Lee Yarwood proposed openstack/nova master: docs: Add evacuation pre-conditions around the src host https://review.opendev.org/723853 | |
| 09:32:54 | lyarwood | huh that only took a while as my upgrade to f32 somehow removed precommit | |
| 09:33:05 | lyarwood | weird | |
| 10:26:52 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Add evacuation pre-conditions around the src host https://review.opendev.org/723853 | |
| 11:05:56 | openstackgerrit | Merged openstack/os-vif stable/ussuri: Fix doc build job for wanring turn into error https://review.opendev.org/724784 | |
| 11:09:58 | sean-k-mooney | lyarwood: thanks for merging ^ | |
| 11:11:37 | lyarwood | np | |
| 11:11:45 | sean-k-mooney | i still haven't gotten around to creating a sepeart stable team for os-vif specifcally but since i have generally been able to fine people to merge teh patches its been a low priority but those are the kinds of patches i want to be able to merge on stable | |
| 11:12:38 | lyarwood | sean-k-mooney: yeah, I've just ack'd the two above it btw enabling stable/ussuri stuff | |
| 11:12:53 | lyarwood | sean-k-mooney: after that I'll leave others to that branch as I've not worked on os-vif | |
| 11:13:41 | sean-k-mooney | lyarwood: well nova-stable-maint are the only people that can merge stuff other then the gloabl stable mainaters | |
| 11:13:51 | sean-k-mooney | there is not os-vif stable team | |
| 11:14:23 | sean-k-mooney | so im happy you are taking a look as it means i dont have to try and find someone to review | |
| 11:14:35 | lyarwood | ah okay | |
| 11:15:30 | sean-k-mooney | that is why i have considerd createding an os-vif-release team a few times as i dont really want o join nova-stable-maint or simialr for the low volume of os-vif stable patches | |
| 11:19:21 | sean-k-mooney | speaking of finding someone tonyb: would you be able to take a look at two procedual patches .gitreview update https://review.opendev.org/#/c/724712/2 and tox constraits update https://review.opendev.org/#/c/724713/2 for os-vif | |
| 11:19:57 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Use unittest.mock instead of third party mock https://review.opendev.org/714676 | |
| 11:19:57 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove future imports https://review.opendev.org/714675 | |
| 11:19:58 | openstackgerrit | Stephen Finucane proposed openstack/nova master: hacking: force explicit import of python's mock https://review.opendev.org/708768 | |
| 11:21:32 | sean-k-mooney | oh im not on irc downstream my vpn is still down | |
| 11:34:11 | openstackgerrit | Merged openstack/nova stable/rocky: Lowercase ironic driver hash ring and ignore case in cache https://review.opendev.org/723050 | |
| 12:29:29 | openstackgerrit | Merged openstack/os-vif master: trivial: Remove some rules from flake8 ignore list https://review.opendev.org/716223 | |
| 13:10:42 | lyarwood | stephenfin: another trivial docs question for you, is there a way to reference the values of a given nova.objects.field in the api-ref? | |
| 13:11:21 | lyarwood | stephenfin: adding a validation of block_device_mapping_v2.disk_bus in the compute API and wanted to update the docs with the possible values without listing them out as a static list | |
| 13:11:34 | artom | Wait, we have the nova objects fields documented somewhere? | |
| 13:11:41 | stephenfin | Not easily. You'd have to write a custom extension to do it. That might be worth it if you plan to do it multiple times, but otherwise I'd just add a NOTE reminding people to update the docs if they change the o.vo | |
| 13:12:53 | lyarwood | artom: no this is in the api-ref for the actual request, I'm just using the fields to validate the input | |
| 13:13:21 | lyarwood | stephenfin: ack understood, I couldn't find one so just wanted to check that I wasn't missing anything | |
| 13:21:05 | openstackgerrit | tianmaofu proposed openstack/nova master: Delete queued image after deleting instance when creating image from instance https://review.opendev.org/724839 | |
| 13:40:46 | sean-k-mooney | lyarwood: out side of the notification object there should be non ovos at teh api level currently | |
| 13:41:02 | sean-k-mooney | we dont use ovo over any of the rest apis | |
| 13:41:23 | dansmith | aren't you guys on holiday today? | |
| 13:41:23 | sean-k-mooney | so i would not expect ovo to be mentioned in the api-ref at all | |
| 13:41:29 | sean-k-mooney | monday | |
| 13:41:34 | sean-k-mooney | in ireland | |
| 13:41:34 | dansmith | oh I thought both days | |
| 13:42:05 | sean-k-mooney | no ireland just moves the bank holiday to the first monday in may | |
| 13:42:24 | openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Validate a BDMs disk_bus when provided https://review.opendev.org/724842 | |
| 13:42:25 | dansmith | okay but is UK of today? | |
| 13:42:30 | sean-k-mooney | the uk normally doesd too but the have friday next week off instead as due to the 75 aniversry of ve day | |
| 13:42:58 | dansmith | okay I thought it was today and monday | |
| 13:43:04 | lyarwood | sean-k-mooney: ^ I'm not using the o.vo objects, just the associated field to validate the values in the compute API | |
| 13:43:07 | sean-k-mooney | dansmith: i think france is today | |
| 13:43:11 | dansmith | ahh | |
| 13:43:20 | dansmith | of course france | |