| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-04-30 | |||
| 19:34:28 | gmann | my intention is they are aware of new flag enforce_new_defaults t o avoid legacy way of overwriting the file to new default | |
| 19:34:30 | dansmith | gmann: I will try really hard to +2 the next one | |
| 19:34:39 | gmann | ok, updating. | |
| 19:34:53 | dansmith | gmann: ack, I just think the message should include the error, and "how to fix the error" | |
| 19:40:54 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add nova-status upgrade check and reno for policy new defaults https://review.opendev.org/723645 | |
| 19:41:17 | gmann | dansmith: ^^ updated | |
| 19:44:49 | dansmith | gmann: I think you forgot to remove the old sentence | |
| 19:45:03 | gmann | ohh :( | |
| 19:45:08 | dansmith | otherwise that looks good to me | |
| 19:46:05 | dansmith | melwitt: you around to help me put gmann out of his misery? | |
| 19:47:29 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add nova-status upgrade check and reno for policy new defaults https://review.opendev.org/723645 | |
| 19:47:52 | gmann | dansmith: done, sorry for that. | |
| 19:47:56 | dansmith | gmann: thanks for your patience with me, +2d | |
| 19:47:57 | dansmith | melwitt: ^ | |
| 19:48:10 | dansmith | I gotta stretch my legs, bbl | |
| 19:49:48 | gmann | dansmith: thanks | |
| 19:51:31 | melwitt | yeah I'll get it | |
| 20:13:27 | melwitt | gmann: I found some misspellings and grammar things and what seem to be a few bugs, but I also suggested some additional info. let me know what you think. if you agree with them, I can update and approve if you want. I know you have been through a lot of updates with the policy docs things | |
| 20:13:56 | gmann | melwitt: ok, checking.. | |
| 20:15:13 | melwitt | the main thing I'm worried about is if operators just enable enforce_scope = True when they see the status check, without realizing that means end users will have to request scoped tokens from keystone in order to access the formerly admin, now system scoped admin APIs. if I understand correctly | |
| 20:33:58 | gmann | melwitt: thanks. replied. i linked the new doc there which i can move on those line so that they have complete steps info. | |
| 20:34:24 | gmann | mentioning those in upgrade checks is too much as they need to do read-only roles things also. | |
| 20:34:39 | gmann | is that fine ? | |
| 20:35:20 | melwitt | I dunno ... will depend on how carefully the operators regard that message | |
| 20:36:04 | melwitt | we can try it, just let's be ready for when/if people miss the "you have to request scoped tokens" part | |
| 20:37:05 | melwitt | like blarg admin APIs no longer work! | |
| 20:37:33 | gmann | ok, let me add those lines and then doc link. | |
| 20:38:24 | melwitt | I could be wrong. let's just say I've been burned by not 100% overly clear reno/tool output ... nova-consoleauth *cough cough* | |
| 21:22:57 | gmann | melwitt: ^^ updated, please check if looks fine. linked the main doc as 'educate' in reno but in upgrade check msg i need to paste the complete link - https://review.opendev.org/#/c/723645/15 | |
| 21:26:52 | melwitt | gmann: thanks. weird it didn't post an update in channel | |
| 21:26:56 | melwitt | oh our gerritbot left | |
| 21:28:06 | gmann | melwitt: yeah i was also surprised initially and rechecking my local branch that i did submit or not :) | |
| 21:28:17 | melwitt | haha yeah | |
| 21:28:32 | melwitt | I mentioned it in #opendev | |
| 21:31:31 | melwitt | gmann: the updates look good. I will watch in zuul so I can sanity check the generated doc previews and then I'll approve it after that | |
| 21:31:52 | gmann | melwitt: sure, thanks | |
| 21:40:16 | openstackgerrit | Ghanshyam Mann proposed openstack/os-vif master: [Community goal] Update contributor documentation https://review.opendev.org/722392 | |
| 21:41:09 | gmann | working now \o/ | |
| 21:41:34 | gmann | sean-k-mooney: ^^ updated as per your comment on 722392 | |
| 21:41:49 | sean-k-mooney | yep looking now | |
| 21:42:20 | sean-k-mooney | omg you have a white space how coudl you :P https://review.opendev.org/#/c/722392/3/doc/source/contributor/contributing.rst@29 | |
| 21:46:07 | sean-k-mooney | gmann: if you have time to fix https://review.opendev.org/#/c/722392/3/doc/source/contributor/contributing.rst those nits im happy with the content | |
| 21:46:39 | openstackgerrit | Ghanshyam Mann proposed openstack/os-vif master: [Community goal] Update contributor documentation https://review.opendev.org/722392 | |
| 21:46:54 | gmann | sean-k-mooney: done | |
| 21:47:03 | sean-k-mooney | awsome | |
| 21:47:47 | sean-k-mooney | ah i see you have already rechecked the other patch | |
| 21:47:57 | sean-k-mooney | i proably got lost with the zuul restart | |
| 21:48:28 | gmann | yeah, i thought that was merged | |
| 21:48:42 | sean-k-mooney | ya same | |
| 21:48:51 | sean-k-mooney | i guess not but it should merge soon | |
| 21:49:18 | sean-k-mooney | then we can merge stephens cahnge which is blocked by that | |
| 21:51:14 | gmann | sean-k-mooney: seems we need to backport that on ussuri brach also - https://review.opendev.org/#/c/724712/ | |
| 21:52:14 | sean-k-mooney | ya that makes sense i dont think we cap the sphinx version in the upperconstratit to prevent the issue | |
| 21:53:35 | gmann | we missed to recheck the fix and ussuri release one merged first - https://review.opendev.org/#/c/723687/ | |
| 21:55:22 | sean-k-mooney | ya one it merges on master we can cherry pick it and fast appove | |
| 21:55:33 | sean-k-mooney | then rebase teh git review patch on top | |
| 21:55:58 | sean-k-mooney | im not sure if i will be around much longer today be we can get that done tommorow | |
| 21:58:27 | gmann | +1 | |
| 22:14:49 | openstackgerrit | Merged openstack/nova stable/ussuri: zuul: Switch to the Zuulv3 grenade job https://review.opendev.org/724189 | |
| 22:20:43 | melwitt | gmann: added a comment on the nova-status review, I had been thinking the non-existent policy file would also result in taking all of the defaults | |
| 23:22:09 | gmann | melwitt: sorry, I was away. | |
| 23:23:35 | gmann | you mean file location in nova.conf but does not exist or with defaults conf (oslo_policy.policy_file) with no file. | |
| 23:48:08 | melwitt | gmann: um... I'm not sure, I just meant like when there's no policy.json file, it uses the defaults in code? | |
| #openstack-nova - 2020-05-01 | |||
| 00:36:07 | openstackgerrit | Merged openstack/os-vif master: Fix doc build job for wanring turn into error https://review.opendev.org/722407 | |
| 00:39:31 | gmann | melwitt: yes that is right. like all our job in gate is without no file. if no file then there is no issue it will be always default. | |
| 00:41:09 | gmann | oslo load file first if exist (1. try json load 2. if error then yaml load), and then any registered rule missing from file will be loaded from default. in case of no file all the rules will be missing so everything default will loaded in policy namespace | |
| 00:41:39 | openstackgerrit | Ghanshyam Mann proposed openstack/os-vif stable/ussuri: Fix doc build job for wanring turn into error https://review.opendev.org/724784 | |
| 00:42:13 | gmann | sean-k-mooney: stephenfin backported the os-vif doc job fix - https://review.opendev.org/#/c/724784/ | |
| 03:10:44 | melwitt | gmann: ok. thanks. sorry, was just wondering whether that was something to also mention in the nova-status upgrade mention or not, where it said blank file. I wasn't sure if blank file would also do the same as "no file" for option 3 in the message | |
| 07:18:22 | bauzas | gibi: bank holiday today, will be back on Monday | |
| 09:06:51 | stephenfin | lyarwood: you stable-core on os-vif? https://review.opendev.org/#/c/724784/ | |
| 09:11:58 | openstackgerrit | Merged openstack/os-vif master: [Community goal] Update contributor documentation https://review.opendev.org/722392 | |
| 09:12:46 | lyarwood | stephenfin: yes | |
| 09:13:40 | stephenfin | Cool. Would you mind? There are also a few stable branch creation patches there. They're -1 but that's because we need the patch I linked to merge first | |
| 09:14:47 | lyarwood | stephenfin: ack, +W'd | |
| 09:14:58 | stephenfin | thanks | |
| 09:15:20 | openstackgerrit | Lee Yarwood proposed openstack/os-vif stable/ussuri: Update .gitreview for stable/ussuri https://review.opendev.org/724712 | |
| 09:15:29 | openstackgerrit | Lee Yarwood proposed openstack/os-vif stable/ussuri: Update TOX_CONSTRAINTS_FILE for stable/ussuri https://review.opendev.org/724713 | |
| 09:16:09 | lyarwood | stephenfin: https://review.opendev.org/#/c/723853/ - trivial one if you have time, any idea why that link doesn't work? | |
| 09:17:02 | stephenfin | looking | |
| 09:20:58 | stephenfin | lyarwood: it's the os-api-ref extension | |
| 09:21:32 | stephenfin | this is what the URL looks like if you navigate to the "Execute Server" section first: ?expanded=evacuate-server-evacuate-action-detail#forced-down | |
| 09:21:51 | stephenfin | that doesn't work since the block the anchor relates to is not visible | |
| 09:22:33 | stephenfin | if you navigate to the 'Update Forced Down' section first, followed by 'Evacuate Server', you get this: ?expanded=update-forced-down-detail,evacuate-server-evacuate-action-detail#forced-down | |
| 09:22:36 | stephenfin | which does work | |
| 09:24:00 | openstackgerrit | jayaditya gupta proposed openstack/nova master: Support for --force flag for nova-manage placement heal_allocations command use this flag to forcefully call heal allocation for a specific instance https://review.opendev.org/715395 | |
| 09:24:23 | lyarwood | stephenfin: ah, so is the best we can do? | |
| 09:24:53 | lyarwood | stephenfin: I just copied the approach from another section FWIW | |
| 09:25:51 | stephenfin | lyarwood: try removing the anchor you added and using ':ref:`update-forced-down` instead | |
| 09:26:03 | lyarwood | ack | |
| 09:26:36 | stephenfin | because that already exists https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_348/723853/1/check/build-openstack-api-ref/348c486/docs/#update-forced-down | |
| 09:31:37 | openstackgerrit | Lee Yarwood proposed openstack/nova master: docs: Add evacuation pre-conditions around the src host https://review.opendev.org/723853 | |
| 09:32:54 | lyarwood | huh that only took a while as my upgrade to f32 somehow removed precommit | |
| 09:33:05 | lyarwood | weird | |
| 10:26:52 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Add evacuation pre-conditions around the src host https://review.opendev.org/723853 | |
| 11:05:56 | openstackgerrit | Merged openstack/os-vif stable/ussuri: Fix doc build job for wanring turn into error https://review.opendev.org/724784 | |
| 11:09:58 | sean-k-mooney | lyarwood: thanks for merging ^ | |
| 11:11:37 | lyarwood | np | |
| 11:11:45 | sean-k-mooney | i still haven't gotten around to creating a sepeart stable team for os-vif specifcally but since i have generally been able to fine people to merge teh patches its been a low priority but those are the kinds of patches i want to be able to merge on stable | |
| 11:12:38 | lyarwood | sean-k-mooney: yeah, I've just ack'd the two above it btw enabling stable/ussuri stuff | |