| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-04-28 | |||
| 21:02:28 | bnemec | gmann: But we can't error on a missing policy file because that's perfectly valid. | |
| 21:03:20 | gmann | bnemec: ah, that's right. | |
| 21:03:21 | sean-k-mooney | like this right https://docs.openstack.org/oslo.config/4.0.0/faq.html#why-are-configuration-options-not-part-of-a-library-s-api | |
| 21:03:31 | bnemec | sean-k-mooney: There's an api provided for it: https://github.com/openstack/oslo.policy/blob/master/oslo_policy/opts.py#L121 | |
| 21:03:40 | bnemec | Generally speaking, consumers shouldn't mess with library opts directly. | |
| 21:03:56 | sean-k-mooney | yep i just linked to the docs for it | |
| 21:04:03 | bnemec | Yes, exactly. | |
| 21:04:09 | bnemec | async communication. :-) | |
| 21:04:14 | sean-k-mooney | and ya i agree because it make debuging it a pain for the lib maintainer | |
| 21:04:28 | bnemec | And it will break if we ever rename the opt, even with deprecation. | |
| 21:04:45 | bnemec | Because the in-code references don't have deprecation logic. | |
| 21:05:26 | sean-k-mooney | you could proably make that work bust defineing an atribute that was initalsed to the other one | |
| 21:05:35 | sean-k-mooney | but also good to know | |
| 21:05:54 | sean-k-mooney | im not sure we actully ever do this in nova | |
| 21:06:01 | sean-k-mooney | or in any other code i have looked at | |
| 21:09:50 | sean-k-mooney | hum actully we are for things in our own config.... im going to pretend i didnt see that and move on | |
| 22:08:14 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add nova-status upgrade check and reno for policy new defaults https://review.opendev.org/723645 | |
| 22:20:21 | openstackgerrit | Merged openstack/nova master: zuul: Switch to the Zuulv3 grenade job https://review.opendev.org/704364 | |
| 22:28:13 | openstackgerrit | sean mooney proposed openstack/nova master: silence amqp heartbeat warning https://review.opendev.org/724188 | |
| 22:29:10 | openstackgerrit | Ghanshyam Mann proposed openstack/nova stable/ussuri: zuul: Switch to the Zuulv3 grenade job https://review.opendev.org/724189 | |
| 22:30:03 | gmann | lyarwood: melwitt backported to ussuri ^^ to have single grenade job running in ussuri as grenade zuulv3 job merged in ussuri | |
| 22:31:27 | sean-k-mooney | melwitt: im not sure if https://review.opendev.org/#/c/724188/1/nova/config.py will work but assuming it does it would be good to get your input on if we should drop that log message as the patch currently does or just reduce the log level to debug | |
| 22:35:28 | gmann | dansmith: bauzas gibi added the upgrade check also for policy stuff - https://review.opendev.org/#/c/723645/ | |
| #openstack-nova - 2020-04-29 | |||
| 00:36:55 | openstackgerrit | Brin Zhang proposed openstack/nova master: Add nested resource providers limit for multi create https://review.opendev.org/723884 | |
| 00:41:16 | openstack | bug 1874664 in OpenStack Compute (nova) "Instance multi-create doesn't support available resources spread between children RPs" [Medium,Confirmed] https://launchpad.net/bugs/1874664 - Assigned to Wenping Song (wenping1) | |
| 00:41:16 | brinzhang_ | bauzas: I was updated https://review.opendev.org/723884, as you said in bug 1874664, I copied and modified. | |
| 01:04:29 | openstackgerrit | sean mooney proposed openstack/nova master: silence amqp heartbeat warning https://review.opendev.org/724188 | |
| 01:16:02 | melwitt | sean-k-mooney: re: that log message, I dunno. we suggested it in the past to the oslo.messaging ppl and they thought it's something that should be logged, at info. iirc they didn't want to downgrade it to debug either | |
| 01:16:34 | melwitt | I recognize that maybe there's a way we could hide it on our side but I guess I dunno what to think about that | |
| 02:17:37 | openstackgerrit | xuyuanhao proposed openstack/nova master: fix bug/1875624 https://review.opendev.org/724213 | |
| 06:35:04 | bauzas | gibi: on PTO this morning only FYI | |
| 06:48:05 | gibi | bauzas: hi. ack. | |
| 07:27:25 | openstackgerrit | Kevin Zhao proposed openstack/nova master: [WIP] CI: add tempest-integrated-compute-aarch64 job https://review.opendev.org/714439 | |
| 07:58:57 | openstackgerrit | Jiri Suchomel proposed openstack/nova-specs master: Add spec for downloading images via RBD https://review.opendev.org/572805 | |
| 08:20:59 | brinzhang_ | gibi: hi, https://review.opendev.org/#/c/723884/2/api-guide/source/accelerator-support.rst@69 what do you mean? | |
| 08:22:47 | brinzhang_ | gibi: Or other words, I seems not understand this sentence "I would make this cyborg specific in this doc.", and Line 76 | |
| 08:51:41 | brinzhang_ | gibi: I think I get your comment, will be update | |
| 08:53:17 | openstackgerrit | Jiri Suchomel proposed openstack/nova-specs master: Add spec for downloading images via RBD https://review.opendev.org/572805 | |
| 09:08:13 | openstackgerrit | xuyuanhao proposed openstack/nova master: the vms can not be force deleted when vm_status is soft-delete and task-state=deleting https://review.opendev.org/724260 | |
| 09:17:37 | openstackgerrit | Brin Zhang proposed openstack/nova master: Add nested resource providers limit for multi create https://review.opendev.org/723884 | |
| 09:17:44 | brinzhang_ | gibi: updated, although the sentence is somewhat redundant, but it is easier to understand, please review again, thanks | |
| 09:33:16 | stephenfin | gibi, bauzas: Could I get you folks to take a look at these patches for me, one of which has been around for a loooong time https://review.opendev.org/#/c/706013/ https://review.opendev.org/#/c/530905/ | |
| 10:15:28 | openstackgerrit | Brin Zhang proposed openstack/nova master: Add nested resource providers limit for multi create https://review.opendev.org/723884 | |
| 10:16:19 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Fix 500 error while passing 4-byte unicode data https://review.opendev.org/407514 | |
| 10:59:36 | openstackgerrit | Merged openstack/nova master: libvirt:driver:Disallow AIO=native when 'O_DIRECT' is not available https://review.opendev.org/682772 | |
| 10:59:43 | openstackgerrit | Merged openstack/nova master: Feature matrix: update AArch64 information https://review.opendev.org/715979 | |
| 11:28:02 | openstackgerrit | jayaditya gupta proposed openstack/nova master: Support for --force flag for nova-manage placement heal_allocations command use this flag to forcefully call heal allocation for a specific instance https://review.opendev.org/715395 | |
| 12:22:57 | gibi | stephenfin: did a review on both | |
| 12:23:05 | stephenfin | gibi++ ta | |
| 12:29:38 | bauzas | (from PTO morning) | |
| 12:36:05 | gibi | gmann: I left feedback on https://review.opendev.org/#/c/723645 | |
| 13:09:50 | openstackgerrit | Jiri Suchomel proposed openstack/nova master: Add ability to download Glance images into the libvirt image cache via RBD https://review.opendev.org/574301 | |
| 13:15:41 | bauzas | gibi: gmann: fwiw, we need to merge https://review.opendev.org/#/c/723645/ by a RC2 :( | |
| 13:16:04 | bauzas | I mean, by merging it back to Ussuri for a next RC | |
| 13:16:40 | bauzas | because if not, nova-status for Ussuri won't check it | |
| 13:17:46 | gibi | bauzas: yes, we have to do that | |
| 13:18:46 | bauzas | gibi: then I'm adding an ussuri-rc-potential tag to the bug | |
| 13:20:53 | gibi | bauzas: good point, thanks | |
| 13:24:02 | gibi | gmann: have you tried the new policy upgrade check in a devstack? I'm trying it but I see that the enforcer is None here https://review.opendev.org/#/c/723645/7/nova/cmd/status.py@378 | |
| 13:29:27 | gibi | gmann: linked printouts in the review | |
| 13:31:14 | sean-k-mooney | gibi: printouts as in paper? | |
| 13:31:24 | gibi | sean-k-mooney: :) | |
| 13:31:34 | gibi | sean-k-mooney: printouts as the stuff my debugger printed | |
| 13:31:41 | sean-k-mooney | ah | |
| 13:32:24 | sean-k-mooney | i have actully done some spec reviews in paper form when i needed to compare and contrast 3 interrealted specs and ran out of monitor space on 3 monitors.. | |
| 13:32:42 | sean-k-mooney | it works but its a pain and should be avoided unless you hate trees | |
| 13:34:03 | bauzas | gibi: I need to work on a next devstack :) | |
| 13:34:14 | bauzas | I have some hardware, I should try to use it | |
| 13:35:36 | gibi | sean-k-mooney: I did that last time when reading heavy telco specifications | |
| 13:42:23 | artom | belmoreira, hello again, have more time this morning (well, afternoon, for you) | |
| 13:42:52 | belmoreira | hi artom, tell me | |
| 13:43:53 | artom | belmoreira, so, stephenfin has proposed an online data migration here: https://review.opendev.org/#/c/537414/26/nova/objects/compute_node.py@533 to get rid of really old dict JSON blobs in instance_extra.numa_topology and replace them with ovo JSON blobs | |
| 13:45:28 | artom | The proposal is to use SQL string filtering, which is slow - so for deployments with a large number of instances (anything over 1000, based on what zzzeek was saying yesterday), this might be a painful migration to run | |
| 13:46:03 | artom | belmoreira, CERN's probably the largest operator (that we know of), so I was wondering if you could have any input on that | |
| 13:46:16 | artom | Like, maybe online data migrations taking forever isn't such a big deal? | |
| 13:46:27 | belmoreira | let me have a look | |
| 13:47:08 | artom | Thanks :) | |
| 13:52:08 | belmoreira | for what I see it should generate something like 'select * from compute_nodes where deleted = 0 and numa_topology like "%nova_object.name%";' | |
| 13:52:36 | belmoreira | being "compute_nodes" table, this will be done per cell | |
| 13:53:41 | stephenfin | belmoreira: pretty much | |
| 13:53:43 | stephenfin | though | |
| 13:53:43 | dansmith | belmoreira: he linked you to the wrong one.. we're doing compute nodes, but we're also doing all instances in the next file | |
| 13:54:14 | artom | belmoreira, oh, sorry, yeah, the compute nodes one isn't the big deal, there are rarely over a thousand of those | |
| 13:54:20 | artom | The instances are the open question | |
| 13:54:20 | stephenfin | 'select * from instance_extra where deleted = 0 and numa_topology is not null and numa_topology like "%nova_object.name%";' | |
| 13:54:36 | belmoreira | We have ~200 nodes per cell. If that is the correct query (I'm expecting that sql alchemy introduces much more stuff) executing it in a cell of ~200 is fast enough (39 ms) | |
| 13:55:29 | artom | stephenfin, did you find out about the filtering order? Like, if we put deleted=0 first, does it reduce the amount of instances the string filter has to work over? | |
| 13:55:51 | stephenfin | artom: the docs that I read said that the SQL engine would do that optimization itself | |
| 13:56:05 | belmoreira | stephenfin artom are we talking about instance_extra as well? | |
| 13:56:10 | artom | stephenfin, ok, that's reassuring | |
| 13:56:13 | artom | belmoreira, we are | |
| 13:56:18 | stephenfin | belmoreira: yes, both | |
| 13:57:33 | belmoreira | ok, I started with the compute_node.py :) | |
| 13:58:04 | artom | belmoreira, that was my bad, I linked the wrong thing | |
| 13:59:24 | belmoreira | I'm checking how much time takes the query that stephenfin mentioned | |
| 14:00:22 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-audit: Use cliff instead of homegrown argparse bleh https://review.opendev.org/724332 | |
| 14:00:30 | artom | I have to say, this shows the power of operator involvement upstream | |
| 14:00:46 | dansmith | artom: man, I really wish this had just been done as migrate-on-load | |
| 14:01:07 | artom | Us devs get "access" to actual large deployment, and the operators get devs not being stupid ;) | |
| 14:01:53 | artom | dansmith, I guess stephenfin's response to that would be "but then we'll never know for sure that we can remove the compat routines" | |