| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-04-28 | |||
| 20:50:15 | gmann | sean-k-mooney: the file form mentioned is yaml one -https://docs.openstack.org/nova/latest/configuration/sample-policy.html | |
| 20:50:19 | sean-k-mooney | ok it is a yaml file | |
| 20:50:34 | sean-k-mooney | ya you can download it https://docs.openstack.org/nova/rocky/_downloads/nova.policy.yaml.sample | |
| 20:50:34 | bnemec | Yep, that's the yaml sample policy output. | |
| 20:50:59 | sean-k-mooney | ok im just used to people saying policy.json the whole time | |
| 20:52:03 | sean-k-mooney | we still refer to it as policy.json here https://docs.openstack.org/nova/rocky/configuration/ | |
| 20:54:48 | bnemec | Yeah, and unfortunately policy.json is still the default name in oslo.policy. We've had discussions about making it look for both json and yaml, but it has security implications if we guess wrong. | |
| 20:55:48 | sean-k-mooney | so does it only look for one of them | |
| 20:56:11 | gmann | first it look for json and then yaml, if i am not wrong | |
| 20:56:23 | sean-k-mooney | ok so if you have both it will use the json file | |
| 20:56:50 | sean-k-mooney | or will it load the default form code then load the json then the yaml | |
| 20:57:14 | sean-k-mooney | both would be vaild but im not really sure which would be more suprising | |
| 20:57:46 | sean-k-mooney | i kind of would expect the second option with an error if there was a conflit between the json and yaml file | |
| 20:57:53 | sean-k-mooney | our just error if both were there | |
| 20:58:10 | sean-k-mooney | that will be less surprising i guess | |
| 20:58:41 | sean-k-mooney | having multiple souces of policy is a beacon for bugs | |
| 20:59:20 | bnemec | It only looks for policy.json. It will parse files in either format in the order gmann said. | |
| 20:59:40 | bnemec | So if you say policy_file=policy.something it will first attempt to parse it as json, and if that fails try again as yaml. | |
| 21:00:20 | sean-k-mooney | ok so to use https://docs.openstack.org/oslo.policy/latest/admin/policy-yaml-file.html you need to chagne the policy_file in the main config file to point to policy.yaml | |
| 21:00:27 | gmann | yeah and default are loaded only if the registered rule is not in file | |
| 21:00:28 | bnemec | Right | |
| 21:01:07 | sean-k-mooney | ok that is not obvious form the docs but i can see why you might have chosen that design | |
| 21:01:18 | sean-k-mooney | well good to know | |
| 21:01:19 | gmann | bnemec: i think we can change the default value to policy.yaml and start error if not present and no fallback to policy.json ? | |
| 21:01:28 | gmann | i mean in Victoria | |
| 21:01:29 | bnemec | Worth noting that it can be overridden by individual projects. I believe cinder has done that. | |
| 21:01:53 | bnemec | I don't know how much pain it caused their users when they switched, or if they were lucky enough to start out with it that way. | |
| 21:01:58 | sean-k-mooney | bnemec: right oslo.config support progomatic overrides | |
| 21:02:24 | sean-k-mooney | so we could do set_default in nova to point it to a different default for nova | |
| 21:02:28 | bnemec | gmann: But we can't error on a missing policy file because that's perfectly valid. | |
| 21:03:20 | gmann | bnemec: ah, that's right. | |
| 21:03:21 | sean-k-mooney | like this right https://docs.openstack.org/oslo.config/4.0.0/faq.html#why-are-configuration-options-not-part-of-a-library-s-api | |
| 21:03:31 | bnemec | sean-k-mooney: There's an api provided for it: https://github.com/openstack/oslo.policy/blob/master/oslo_policy/opts.py#L121 | |
| 21:03:40 | bnemec | Generally speaking, consumers shouldn't mess with library opts directly. | |
| 21:03:56 | sean-k-mooney | yep i just linked to the docs for it | |
| 21:04:03 | bnemec | Yes, exactly. | |
| 21:04:09 | bnemec | async communication. :-) | |
| 21:04:14 | sean-k-mooney | and ya i agree because it make debuging it a pain for the lib maintainer | |
| 21:04:28 | bnemec | And it will break if we ever rename the opt, even with deprecation. | |
| 21:04:45 | bnemec | Because the in-code references don't have deprecation logic. | |
| 21:05:26 | sean-k-mooney | you could proably make that work bust defineing an atribute that was initalsed to the other one | |
| 21:05:35 | sean-k-mooney | but also good to know | |
| 21:05:54 | sean-k-mooney | im not sure we actully ever do this in nova | |
| 21:06:01 | sean-k-mooney | or in any other code i have looked at | |
| 21:09:50 | sean-k-mooney | hum actully we are for things in our own config.... im going to pretend i didnt see that and move on | |
| 22:08:14 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add nova-status upgrade check and reno for policy new defaults https://review.opendev.org/723645 | |
| 22:20:21 | openstackgerrit | Merged openstack/nova master: zuul: Switch to the Zuulv3 grenade job https://review.opendev.org/704364 | |
| 22:28:13 | openstackgerrit | sean mooney proposed openstack/nova master: silence amqp heartbeat warning https://review.opendev.org/724188 | |
| 22:29:10 | openstackgerrit | Ghanshyam Mann proposed openstack/nova stable/ussuri: zuul: Switch to the Zuulv3 grenade job https://review.opendev.org/724189 | |
| 22:30:03 | gmann | lyarwood: melwitt backported to ussuri ^^ to have single grenade job running in ussuri as grenade zuulv3 job merged in ussuri | |
| 22:31:27 | sean-k-mooney | melwitt: im not sure if https://review.opendev.org/#/c/724188/1/nova/config.py will work but assuming it does it would be good to get your input on if we should drop that log message as the patch currently does or just reduce the log level to debug | |
| 22:35:28 | gmann | dansmith: bauzas gibi added the upgrade check also for policy stuff - https://review.opendev.org/#/c/723645/ | |
| #openstack-nova - 2020-04-29 | |||
| 00:36:55 | openstackgerrit | Brin Zhang proposed openstack/nova master: Add nested resource providers limit for multi create https://review.opendev.org/723884 | |
| 00:41:16 | openstack | bug 1874664 in OpenStack Compute (nova) "Instance multi-create doesn't support available resources spread between children RPs" [Medium,Confirmed] https://launchpad.net/bugs/1874664 - Assigned to Wenping Song (wenping1) | |
| 00:41:16 | brinzhang_ | bauzas: I was updated https://review.opendev.org/723884, as you said in bug 1874664, I copied and modified. | |
| 01:04:29 | openstackgerrit | sean mooney proposed openstack/nova master: silence amqp heartbeat warning https://review.opendev.org/724188 | |
| 01:16:02 | melwitt | sean-k-mooney: re: that log message, I dunno. we suggested it in the past to the oslo.messaging ppl and they thought it's something that should be logged, at info. iirc they didn't want to downgrade it to debug either | |
| 01:16:34 | melwitt | I recognize that maybe there's a way we could hide it on our side but I guess I dunno what to think about that | |
| 02:17:37 | openstackgerrit | xuyuanhao proposed openstack/nova master: fix bug/1875624 https://review.opendev.org/724213 | |
| 06:35:04 | bauzas | gibi: on PTO this morning only FYI | |
| 06:48:05 | gibi | bauzas: hi. ack. | |
| 07:27:25 | openstackgerrit | Kevin Zhao proposed openstack/nova master: [WIP] CI: add tempest-integrated-compute-aarch64 job https://review.opendev.org/714439 | |
| 07:58:57 | openstackgerrit | Jiri Suchomel proposed openstack/nova-specs master: Add spec for downloading images via RBD https://review.opendev.org/572805 | |
| 08:20:59 | brinzhang_ | gibi: hi, https://review.opendev.org/#/c/723884/2/api-guide/source/accelerator-support.rst@69 what do you mean? | |
| 08:22:47 | brinzhang_ | gibi: Or other words, I seems not understand this sentence "I would make this cyborg specific in this doc.", and Line 76 | |
| 08:51:41 | brinzhang_ | gibi: I think I get your comment, will be update | |
| 08:53:17 | openstackgerrit | Jiri Suchomel proposed openstack/nova-specs master: Add spec for downloading images via RBD https://review.opendev.org/572805 | |
| 09:08:13 | openstackgerrit | xuyuanhao proposed openstack/nova master: the vms can not be force deleted when vm_status is soft-delete and task-state=deleting https://review.opendev.org/724260 | |
| 09:17:37 | openstackgerrit | Brin Zhang proposed openstack/nova master: Add nested resource providers limit for multi create https://review.opendev.org/723884 | |
| 09:17:44 | brinzhang_ | gibi: updated, although the sentence is somewhat redundant, but it is easier to understand, please review again, thanks | |
| 09:33:16 | stephenfin | gibi, bauzas: Could I get you folks to take a look at these patches for me, one of which has been around for a loooong time https://review.opendev.org/#/c/706013/ https://review.opendev.org/#/c/530905/ | |
| 10:15:28 | openstackgerrit | Brin Zhang proposed openstack/nova master: Add nested resource providers limit for multi create https://review.opendev.org/723884 | |
| 10:16:19 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Fix 500 error while passing 4-byte unicode data https://review.opendev.org/407514 | |
| 10:59:36 | openstackgerrit | Merged openstack/nova master: libvirt:driver:Disallow AIO=native when 'O_DIRECT' is not available https://review.opendev.org/682772 | |
| 10:59:43 | openstackgerrit | Merged openstack/nova master: Feature matrix: update AArch64 information https://review.opendev.org/715979 | |
| 11:28:02 | openstackgerrit | jayaditya gupta proposed openstack/nova master: Support for --force flag for nova-manage placement heal_allocations command use this flag to forcefully call heal allocation for a specific instance https://review.opendev.org/715395 | |
| 12:22:57 | gibi | stephenfin: did a review on both | |
| 12:23:05 | stephenfin | gibi++ ta | |
| 12:29:38 | bauzas | (from PTO morning) | |
| 12:36:05 | gibi | gmann: I left feedback on https://review.opendev.org/#/c/723645 | |
| 13:09:50 | openstackgerrit | Jiri Suchomel proposed openstack/nova master: Add ability to download Glance images into the libvirt image cache via RBD https://review.opendev.org/574301 | |
| 13:15:41 | bauzas | gibi: gmann: fwiw, we need to merge https://review.opendev.org/#/c/723645/ by a RC2 :( | |
| 13:16:04 | bauzas | I mean, by merging it back to Ussuri for a next RC | |
| 13:16:40 | bauzas | because if not, nova-status for Ussuri won't check it | |
| 13:17:46 | gibi | bauzas: yes, we have to do that | |
| 13:18:46 | bauzas | gibi: then I'm adding an ussuri-rc-potential tag to the bug | |
| 13:20:53 | gibi | bauzas: good point, thanks | |
| 13:24:02 | gibi | gmann: have you tried the new policy upgrade check in a devstack? I'm trying it but I see that the enforcer is None here https://review.opendev.org/#/c/723645/7/nova/cmd/status.py@378 | |
| 13:29:27 | gibi | gmann: linked printouts in the review | |
| 13:31:14 | sean-k-mooney | gibi: printouts as in paper? | |
| 13:31:24 | gibi | sean-k-mooney: :) | |
| 13:31:34 | gibi | sean-k-mooney: printouts as the stuff my debugger printed | |
| 13:31:41 | sean-k-mooney | ah | |
| 13:32:24 | sean-k-mooney | i have actully done some spec reviews in paper form when i needed to compare and contrast 3 interrealted specs and ran out of monitor space on 3 monitors.. | |
| 13:32:42 | sean-k-mooney | it works but its a pain and should be avoided unless you hate trees | |
| 13:34:03 | bauzas | gibi: I need to work on a next devstack :) | |
| 13:34:14 | bauzas | I have some hardware, I should try to use it | |
| 13:35:36 | gibi | sean-k-mooney: I did that last time when reading heavy telco specifications | |
| 13:42:23 | artom | belmoreira, hello again, have more time this morning (well, afternoon, for you) | |
| 13:42:52 | belmoreira | hi artom, tell me | |