| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-04-21 | |||
| 09:39:39 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: WIP: nova-next: Start testing the 'q35' machine type https://review.opendev.org/708701 | |
| 09:41:38 | lyarwood | kashyap: lets get the spec reproposed, updated and on the agenda for PTG first | |
| 09:42:29 | lyarwood | kashyap: I'm not going to be around for PTG btw would you be okay leading any sessions/discussions on the ML? | |
| 09:42:53 | openstack | Launchpad bug 1860312 in OpenStack Compute (nova) "compute service failed to delete" [Undecided,Incomplete] | |
| 09:42:53 | bauzas | gibi: FYI I think I found the problem but before triaging it to Confirmed, I need to ask the reporter to tell us whether I'm right https://bugs.launchpad.net/nova/+bug/1860312/comments/1 | |
| 09:42:58 | kashyap | lyarwood: Yeah, I was intending to that. As I've been delaying this work for various reasons | |
| 09:43:56 | gibi | bauzas: cool | |
| 09:44:08 | gibi | bauzas: also I left some comments on the prelude. good job! | |
| 09:44:31 | bauzas | gibi: ack | |
| 09:45:05 | gibi | stephenfin: could you re-review stable device rescue doc patch? https://review.opendev.org/#/c/700837 | |
| 09:45:09 | openstack | bug 1860312 in OpenStack Compute (nova) "compute service failed to delete" [Undecided,Incomplete] https://launchpad.net/bugs/1860312 | |
| 09:45:09 | bauzas | I wish I could easily find bug duplicates with Launchpad, because I'm pretty sure that bug 1860312 is not the only one for the same issue | |
| 09:45:17 | stephenfin | sure, just finished gmann doc change | |
| 09:45:21 | stephenfin | *gmann's | |
| 09:45:32 | gibi | stephenfin: that would have been my other request :) | |
| 09:46:54 | openstack | Launchpad bug 1853009 in OpenStack Compute (nova) "Ironic node rebalance race can lead to missing compute nodes in DB" [Undecided,In progress] - Assigned to Mark Goddard (mgoddard) | |
| 09:46:54 | bauzas | gibi: bingo : https://bugs.launchpad.net/nova/+bug/1853009 | |
| 09:47:53 | mgoddard | bauzas, gibi: would love some reviews on those patches :) | |
| 09:48:10 | bauzas | mgoddard: absolutely, will do | |
| 09:48:13 | mgoddard | I think some were failing unit tests, I can tidy up if someone plans to look | |
| 09:48:28 | bauzas | mgoddard: how many times ironic can rebalance ? | |
| 09:48:46 | bauzas | because I think that can be a problem for a shit ton of deployers using ironic | |
| 09:48:55 | mgoddard | bauzas: advance warning: prepare a cup of coffee, or three. Nasty race conditions ahead | |
| 09:49:08 | mgoddard | bauzas: unlimited rebalancing | |
| 09:49:15 | bauzas | in particular when it goes on top on something abstract API like k8s... | |
| 09:49:15 | stephenfin | lyarwood, gibi: done https://review.opendev.org/#/c/700837/ | |
| 09:49:52 | mgoddard | bauzas: the hash ring just consists of the active nova computes | |
| 09:49:54 | bauzas | mgoddard: just tbc, ironic does rebalance if the things below it are shuffled ? | |
| 09:50:12 | gibi | bauzas: ack about the duplicates | |
| 09:50:16 | gibi | stephenfin: thanks | |
| 09:50:18 | bauzas | in our case, because pods changed or whatever, right? | |
| 09:50:20 | lyarwood | stephenfin: ah thanks, ./me respins | |
| 09:50:38 | mgoddard | bauzas: there are two hash rings - one in nova, one in ironic conductor. You only need to care about the one in nova | |
| 09:50:46 | openstack | Launchpad bug 1860312 in OpenStack Compute (nova) "compute service failed to delete" [Undecided,Incomplete] | |
| 09:50:46 | bauzas | mgoddard: you do confirm that https://bugs.launchpad.net/nova/+bug/1860312 sounds dup of https://bugs.launchpad.net/nova/+bug/1853009 ? | |
| 09:50:47 | openstack | Launchpad bug 1853009 in OpenStack Compute (nova) "Ironic node rebalance race can lead to missing compute nodes in DB" [Undecided,In progress] - Assigned to Mark Goddard (mgoddard) | |
| 09:51:51 | mgoddard | bauzas: if it's sitting on top of a wobbly k8s jelly, with containers coming and going, it's quite likely :) will look in more detail | |
| 09:51:53 | bauzas | mgoddard: I'd dare say there are two hard problems in CS | |
| 09:52:13 | bauzas | hash rings come with the first hard problme | |
| 09:52:56 | bauzas | I deployed openstack with openstack-helm on kubernetes.When one of the nova-compute service(driver=ironic replica of the deployment is 1) breakdown.It may be scheduled to another node by kubernetes.When I try to delete the old compute service(status down), it failed." | |
| 09:52:56 | bauzas | mgoddard: that's exactly what the reporter says " | |
| 09:53:39 | mgoddard | bauzas: although in this case I think it's a different problem. They're trying to delete the compute service, not the compute node | |
| 09:53:58 | mgoddard | bauzas: I'd guess it's because they're using the service ID rather than the UUID | |
| 09:54:02 | mgoddard | ID no longer seems to work | |
| 09:54:16 | mgoddard | need to specify an API version to get the UUID in the list | |
| 09:55:20 | bauzas | mgoddard: it's a side effect | |
| 09:55:43 | bauzas | mgoddard: since the virt driver stopped reporting the node, then the RT deleted the compute node record | |
| 09:55:51 | openstackgerrit | Lee Yarwood proposed openstack/nova master: docs: Add stable device rescue docs https://review.opendev.org/700837 | |
| 09:56:49 | lyarwood | stephenfin: ^ thanks btw | |
| 09:57:05 | mgoddard | bauzas: but the service should still exist, even without a node | |
| 09:57:31 | bauzas | mgoddard: we're making different assumptions in different pieces of code | |
| 09:57:55 | mgoddard | bauzas: I haven't seen that happen before | |
| 09:58:14 | bauzas | mgoddard: in the RT, we assume that it's reasonable to not have a CN record when the virt driver tells you no about it | |
| 09:58:35 | bauzas | mgoddard: but on the other hand, we assume that compute nodes exist if you delete a compute service | |
| 10:00:22 | mgoddard | bauzas: if that is true, should be easy to reproduce? | |
| 10:00:37 | mgoddard | and probably easy to test my hypothesis also | |
| 10:03:30 | bauzas | mgoddard: I've asked the reporter to come back with details | |
| 10:04:21 | openstackgerrit | Merged openstack/nova master: Use oslo policy flag to disable default change warning instead of all https://review.opendev.org/717884 | |
| 10:04:26 | bauzas | I could have some OSP crazy env that would help me to verify this hypothesis but to be frank I don't have the energy for it :) | |
| 10:05:05 | openstack | bug 1860312 in OpenStack Compute (nova) "compute service failed to delete" [Undecided,Incomplete] https://launchpad.net/bugs/1860312 | |
| 10:05:05 | bauzas | mgoddard: like I said in my last comment of bug 1860312, I'd rather spend my energy on reviewing your change | |
| 10:08:36 | bauzas | mgoddard: actually, the bug is pretty nasty and has a lot of other related bugs, do you think you'd be able to give it a good shape soon ? | |
| 10:08:54 | bauzas | to give *the change a good shape soon ? | |
| 10:10:38 | bauzas | gibi: FYI, ^ | |
| 10:11:29 | bauzas | we're too close to RC1 to consider those bugs as rc-potential but they're definitely worth backportable down the road to all our stable branches | |
| 10:12:08 | openstack | Launchpad bug 1841481 in OpenStack Compute (nova) "Race during ironic re-balance corrupts local RT ProviderTree and compute_nodes cache" [Medium,In progress] - Assigned to Matt Riedemann (mriedem) | |
| 10:12:08 | bauzas | actually, mriedem thought the same https://bugs.launchpad.net/nova/+bug/1841481 | |
| 10:12:41 | gibi | bauzas: ack, I agree that we should not try to blow up RC1 with this fix. | |
| 10:12:45 | bauzas | mgoddard: sorry for interupting you again, but we have around 4 open bugs for probably the same issue(s) or related | |
| 10:12:59 | bauzas | mgoddard: could we consider https://bugs.launchpad.net/nova/+bug/1853009 as the primary one ? | |
| 10:13:00 | openstack | Launchpad bug 1853009 in OpenStack Compute (nova) "Ironic node rebalance race can lead to missing compute nodes in DB" [High,In progress] - Assigned to Mark Goddard (mgoddard) | |
| 10:14:16 | mgoddard | bauzas: I'll get the patches into shape today | |
| 10:15:15 | bauzas | mgoddard: as I said, we're too short in time to deliver them for RC1, but I think this should be addressed as quicky as possible after the victoria branch | |
| 10:15:48 | mgoddard | bauzas: ack | |
| 10:22:05 | bauzas | mgoddard: fwiw, starting to review https://review.opendev.org/#/c/695012/4/nova/tests/functional/regressions/test_bug_1853009.py | |
| 10:23:04 | mgoddard | bauzas: cool. I don't expect the code to change significantly, just need to adapt to upstream changes since proposed | |
| 10:39:23 | openstack | Launchpad bug 1872385 in OpenStack Compute (nova) "delete sub resource provider in tree" [High,In progress] - Assigned to Wenping Song (wenping1) | |
| 10:39:23 | gibi | bauzas: what do you think about https://bugs.launchpad.net/nova/+bug/1872385 it is currently marked as rc potential but it the fix is not ready. I can take the fix over this afternoon and make it complete or we can drop the rc potential tag as you also noted that this is not a clear regression for Ussuri as we have child RPs for couple of releases now | |
| 10:47:09 | openstack | Launchpad bug 1851545 in OpenStack Compute (nova) "Port update exception on nova unshelve for instance with PCI devices (part 2)" [Undecided,New] | |
| 10:47:09 | sean-k-mooney | gibi: i dont have it deploy but i have worked with dvd on https://bugs.launchpad.net/nova/+bug/1851545 downstream https://bugzilla.redhat.com/show_bug.cgi?id=1767797 | |
| 10:47:10 | openstack | bugzilla.redhat.com bug 1767797 in openstack-nova "When unshelving an SR-IOV instance, the binding profile isn't reclaimed or rescheduled, and this might cause PCI-PT conflicts" [High,New] - Assigned to nova-maint | |
| 10:48:06 | sean-k-mooney | gibi: it looks like all my comments downstream are private but yes this is broken on queens i memtioned this seperatly before. we are not updating the port binding profile before generating the xml on unshelve | |
| 10:48:33 | sean-k-mooney | im not sure if it affect all release but its broken on queens | |
| 10:50:57 | sean-k-mooney | gibi: ill traige the upstream bug. i can proably try and replicate it later i just have not had time to work on it since it was first reported but now might be as good a time as any one i finish rebasing my current patches | |
| 11:11:07 | gibi | sean-k-mooney: thanks a lot! | |
| 11:29:57 | openstackgerrit | Merged openstack/nova master: Add missing white spaces between words in log messages https://review.opendev.org/720112 | |
| 12:03:16 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Revert "Temporarily skip TestNovaMigrationsMySQL" https://review.opendev.org/718630 | |
| 12:15:21 | gibi | bauzas and others: I have to jump on a meeting marathon for the next 2 and a half hours | |
| 12:19:47 | openstackgerrit | Merged openstack/nova-specs master: Adds spec infrastructure for Victoria https://review.opendev.org/710023 | |
| 12:48:35 | bauzas | gibi: ack thanks, and I'll review https://review.opendev.org/#/c/719163/ | |
| 13:05:10 | openstackgerrit | Merged openstack/nova master: docs: Add stable device rescue docs https://review.opendev.org/700837 | |
| 13:16:31 | kashyap | lyarwood: Since I've written it partially, and been vacillating on this for a while, I'll repropose this spec for V, as that is on TODO "forever" anyway. I know you've already got plenty on your plate | |
| 13:17:01 | kashyap | lyarwood: And I'll add you to the 'collaborators' list, that sounds okay? | |
| 13:17:32 | lyarwood | ack sure | |
| 13:20:01 | kashyap | lyarwood: Appreciate the virtual kick in the *** | |
| 13:20:38 | kashyap | A real one will also be accepted when circumstances allow in-person gathering ;-) | |
| 13:22:44 | gmann | gibi: stephenfin thanks. let me squash both policy doc patches. | |
| 13:43:37 | openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP: nova-next: Start testing the 'q35' machine type https://review.opendev.org/708701 | |
| 13:45:25 | lyarwood | kashyap: ^ added a virt-preview job, I think swap volume might only work once we switch to block copy | |
| 13:45:32 | lyarwood | kashyap: with q35 | |