| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-04-17 | |||
| 14:55:11 | melwitt | yeah. hm, so maybe we would want to remove all references. ajaeger had said babel is used to build translations so I was not sure what's going on | |
| 14:55:12 | stephenfin | melwitt: That _seems_ correct. You need Babel to run the e.g. 'python setup.py extract_messages' distutils command but I think _that_ would require it already be present, like setuptools | |
| 14:55:16 | bauzas | I'm just afraid of breaking things so close to the HardStringFreeze so I'd defer this to later | |
| 14:55:29 | melwitt | ah, nevermind | |
| 14:55:39 | stephenfin | Also, AJaeger suggested it and he knows these things so I'd trust him on that | |
| 14:55:43 | stephenfin | *on this | |
| 14:56:15 | bauzas | FWIW, that's how translations work atm https://docs.openstack.org/i18n/latest/reviewing-translation-import.html | |
| 14:56:28 | melwitt | I thought it'd be wise to see if anyone in the team understands this before merging it | |
| 14:57:00 | bauzas | melwitt: like I said, I would maybe defer this to post-RC1 | |
| 14:57:13 | melwitt | if literally no one understands it, then fine, but I wanted to check first | |
| 14:58:12 | bauzas | melwitt: we should first look at the translation jobs I think | |
| 14:58:23 | bauzas | or ask someone in their team | |
| 15:00:22 | bauzas | stephenfin: sean-k-mooney: trust me, if I was able to use the existing functional helpers, I'd use them | |
| 15:01:10 | bauzas | stephenfin: sean-k-mooney: but all those stuff like https://github.com/openstack/nova/blob/e1359567e4985e9a671359d4c0d53404a8ba64ab/nova/tests/functional/integrated_helpers.py#L1057-L1067 are from a class that's separated from the general base test class | |
| 15:01:26 | bauzas | if the whole thing was a mixin, I'd sign off for this | |
| 15:01:45 | bauzas | but using those helpers requires me to modify the inheritance of my own classes | |
| 15:01:59 | bauzas | stephenfin: sean-k-mooney: https://github.com/openstack/nova/blob/e1359567e4985e9a671359d4c0d53404a8ba64ab/nova/tests/functional/integrated_helpers.py#L498-L500 | |
| 15:04:11 | sean-k-mooney | bauzas: they are a mixin | |
| 15:04:12 | stephenfin | melwitt, bauzas: Okay, they're not using the setuptools integration any more so yes, we can remove it https://opendev.org/openstack/openstack-zuul-jobs/src/branch/master/roles/prepare-zanata-client/files/common_translation_update.sh#L371-L379 | |
| 15:04:30 | stephenfin | Will ask AJaeger for more information in the commit message though | |
| 15:05:03 | bauzas | sean-k-mooney: huh ? https://github.com/openstack/nova/blob/e1359567e4985e9a671359d4c0d53404a8ba64ab/nova/tests/functional/integrated_helpers.py#L500 | |
| 15:07:37 | sean-k-mooney | oh they are not in the mixin class you are right | |
| 15:08:29 | sean-k-mooney | bauzas: that said you are doing testing with placment so you proably should be inheriting form ProviderUsageBaseTestCase | |
| 15:08:54 | bauzas | sean-k-mooney: this was my original plan | |
| 15:08:55 | sean-k-mooney | bauzas: why dont you move them up to the mixin class | |
| 15:09:11 | sean-k-mooney | e.g. the resize functions | |
| 15:09:13 | bauzas | sean-k-mooney: see the FIXME on top | |
| 15:09:45 | bauzas | sean-k-mooney: oh, you mean moving my own methods to integrated_helpers ? | |
| 15:09:54 | bauzas | I can do this for sure | |
| 15:10:08 | sean-k-mooney | i mean move the existing resize one form the ProviderUsageBaseTestCase to the mixin | |
| 15:10:32 | bauzas | sean-k-mooney: this would be doable | |
| 15:10:37 | sean-k-mooney | then you can use the mixin | |
| 15:10:52 | sean-k-mooney | and other that want the mixin but not the other things can too | |
| 15:11:38 | openstack | Launchpad bug 1860913 in OpenStack Compute (nova) "Instance uses base image file when it is rebooted after snapshot creation if cinder nfs backend is used" [Undecided,New] | |
| 15:11:38 | gibi | bauzas: fyi you got answers in https://bugs.launchpad.net/nova/+bug/1860913 | |
| 15:12:37 | bauzas | gibi: this looks a bug then | |
| 15:13:00 | openstack | Launchpad bug 1860913 in OpenStack Compute (nova) "Instance uses base image file when it is rebooted after snapshot creation if cinder nfs backend is used" [Undecided,New] | |
| 15:13:00 | bauzas | lyarwood: https://bugs.launchpad.net/nova/+bug/1860913 we got answers on this one, I'm about to confirm it | |
| 15:13:29 | sean-k-mooney | gibi: that sound familar | |
| 15:13:29 | gibi | bauzas: yeah it is almost even triaged by pointing to the problem of the missing bdm update | |
| 15:13:47 | bauzas | gibi: agreed, I think we could dup this one | |
| 15:13:49 | gibi | but I haven't checked the code | |
| 15:13:55 | sean-k-mooney | lyarwood: where you looking into https://bugs.launchpad.net/nova/+bug/1860913 downstream | |
| 15:14:24 | gibi | I let you folks to handle it :) | |
| 15:14:42 | bauzas | the 'you folks' is important :) | |
| 15:14:47 | bauzas | :D | |
| 15:15:02 | lyarwood | sean-k-mooney: nope I don't recall seeing this | |
| 15:15:14 | sean-k-mooney | gibi: well this is basically an issue with how we handel the snapshot | |
| 15:15:35 | openstack | bugzilla.redhat.com bug 1757691 in openstack-nova "Instance uses base image file when it is rebooted after snapshot creation if cinder nfs backend is used" [Urgent,New] - Assigned to nova-maint | |
| 15:15:35 | sean-k-mooney | https://bugzilla.redhat.com/show_bug.cgi?id=1757691#c1 | |
| 15:15:38 | lyarwood | looks like Matt triaged it a while ago | |
| 15:15:52 | sean-k-mooney | we discussed it on the triage call | |
| 15:16:44 | sean-k-mooney | whats happening is during the snapshot we cate a path form cinder to use a a temp file or something which updates the xml but if you do a hard reboot we regenerate it and use the one it had beofre | |
| 15:17:03 | sean-k-mooney | the real fix is to not allow reboots while we do snapshots | |
| 15:17:47 | bauzas | either way, the upstream bug is triaged with no assignee | |
| 15:17:55 | bauzas | feel free to pick it, teammates | |
| 15:18:03 | lyarwood | I'll take it | |
| 15:18:16 | bauzas | lyarwood: thanks | |
| 15:18:18 | lyarwood | we should be able to fix this easily by updating the connection_info | |
| 15:19:28 | sean-k-mooney | maybe i still think we need to lock the instance when you intialise the snapshot of the volume via cinder somehow | |
| 15:23:13 | stephenfin | bauzas: RE: the integrated_helpers duplication, I'm okay with you doing that as a follow-up, so long as it's actually done and you stick a TODO in in your patch saying that it will be done :) | |
| 15:23:45 | stephenfin | Will happily review the follow-up too | |
| 15:23:50 | sean-k-mooney | ya i guss i would be fine with that as well. | |
| 15:24:06 | stephenfin | need the TODOs though | |
| 15:37:39 | openstack | Launchpad bug 1858402 in OpenStack Compute (nova) "In-use volume does not support the same ceph cluster retype" [Undecided,New] | |
| 15:37:39 | gibi | lyarwood: do you think https://bugs.launchpad.net/nova/+bug/1858402 is a duplicate of https://bugs.launchpad.net/nova/+bug/1868996 ? | |
| 15:37:41 | openstack | Launchpad bug 1868996 in OpenStack Compute (nova) "Unable to swap between RBD volumes using virDomainBlockRebase" [High,Fix released] - Assigned to Lee Yarwood (lyarwood) | |
| 15:46:04 | bauzas | stephenfin: nah, no worries, I'm pretty done with the new revision, since I need to update it for the main revert resize issue that dansmith said, I won't provide a FUP | |
| 15:49:07 | lyarwood | gibi: hey sorry yes that's a duplicate | |
| 15:49:10 | bauzas | gibi: any idea why I got this weird exception : http://paste.openstack.org/show/792339/ | |
| 15:51:28 | gibi | lyarwood: tahnks | |
| 15:51:32 | lyarwood | gibi: updated the bug | |
| 15:51:58 | gibi | lyarwood: thanks a lot | |
| 15:52:19 | lyarwood | np | |
| 15:52:20 | gibi | bauzas: looking | |
| 15:52:32 | bauzas | thanks, I know it's late | |
| 15:53:27 | bauzas | gibi: and that's what I wait for : | |
| 15:53:28 | bauzas | 'instance.resize_revert.end') | |
| 15:53:28 | bauzas | fake_notifier.wait_for_versioned_notifications( | |
| 15:54:30 | bauzas | oh, but I understand the error, I was expecting 'instance.resize_revert' but i never got it | |
| 15:54:49 | bauzas | weirdo | |
| 15:54:50 | gibi | that is my guess yes | |
| 15:54:58 | gibi | you can print all the notification that you received | |
| 15:55:09 | bauzas | gibi: the paste says [] | |
| 15:55:17 | gibi | fake_notifier.VERSIONED_NOTIFICATIONS | |
| 15:55:58 | bauzas | do I need to setup something specific in setUp ? | |
| 15:56:36 | gibi | you need to call stub_notifier() | |
| 15:56:52 | gibi | from fake_notifier | |
| 15:57:07 | bauzas | gibi: I moved https://github.com/openstack/nova/blob/cd16ae2/nova/tests/functional/integrated_helpers.py#L1009-L1019 to https://github.com/openstack/nova/blob/cd16ae2/nova/tests/functional/integrated_helpers.py#L75 | |
| 15:57:25 | gibi | self.addCleanup(fake_notifier.reset) | |
| 15:57:25 | gibi | fake_notifier.stub_notifier(self) | |
| 15:57:39 | bauzas | ah, thanks | |
| 15:57:41 | bauzas | TIL | |
| 15:58:22 | gibi | cool | |
| 16:02:44 | gibi | OK, I'm leaving for today. See you on Monday | |
| 16:07:48 | openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP block_device: Use the attachment update API to refresh connection_info https://review.opendev.org/720769 | |
| 16:08:34 | bauzas | gibi: \o | |
| 16:09:32 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Allocate mdevs when resizing or reverting resize https://review.opendev.org/712741 | |
| 16:09:55 | bauzas | stephenfin: ^ updated the last change for the vgpu resize thing | |
| 16:10:42 | stephenfin | ack | |