| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-04-16 | |||
| 17:35:13 | sean-k-mooney | yes | |
| 17:35:50 | sean-k-mooney | that is a behavioral differen form every other extra spec that is defined by nova | |
| 17:35:55 | bauzas | holy f..., gotcha | |
| 17:36:38 | sean-k-mooney | melwitt: do you follow too ^ | |
| 17:36:48 | bauzas | okay, so indeed the fix is not about the filter | |
| 17:36:59 | bauzas | it's about where we use this extraspec for booting | |
| 17:37:01 | melwitt | I see, ok. just read through the bug and comments again. yeah, I think so. this is an extra spec meant to be used without having to add a matching metadata key on an aggregate | |
| 17:37:27 | sean-k-mooney | ya so the fix is add a namespaced version of the extra spec and compat code | |
| 17:37:43 | sean-k-mooney | then deprecate teh non namespaced one | |
| 17:37:47 | melwitt | yeah, I think that makes sense. agree that's the way to fix | |
| 17:37:53 | bauzas | sean-k-mooney: easy fix then https://review.opendev.org/#/c/555861/10/nova/virt/libvirt/driver.py | |
| 17:38:25 | bauzas | sean-k-mooney: just add another key there with a prefix and just provide a deprecation warning for the existing one | |
| 17:38:39 | sean-k-mooney | yep | |
| 17:38:45 | bauzas | that's all flavors and aggregates, we don't need to care about the interop | |
| 17:39:11 | sean-k-mooney | im wondering if we should also add a config option for the filter to disable checking unnamesapced extraspecs | |
| 17:39:14 | bauzas | tlrambo dropped but I'll leave a comment in the bug | |
| 17:39:22 | bauzas | sean-k-mooney: oh please don't | |
| 17:39:29 | bauzas | sean-k-mooney: it was a review problme | |
| 17:39:34 | bauzas | not a code problem | |
| 17:40:12 | sean-k-mooney | well the reason for doing it is i would prefer to drop the non namespced approch entirely eventually or maybe depreate the filters | |
| 17:40:25 | bauzas | NO again in capitals :) | |
| 17:40:40 | sean-k-mooney | given custom traits could used for this. you also suggested this last week by the way | |
| 17:40:49 | sean-k-mooney | this is why im tinking about it | |
| 17:41:32 | sean-k-mooney | anyway lets jus tdo the minima dirver fix for now | |
| 17:41:39 | bauzas | sean-k-mooney: the only difference is that we don't have traits on placement aggregates, right? | |
| 17:42:10 | sean-k-mooney | bauzas: correct they live on RPs | |
| 17:42:21 | sean-k-mooney | so i thikn the compute capablity filter can defiently go. | |
| 17:42:28 | bauzas | from what I understood from the very-long-standing battle of allocation ratios is that some operators do care about having a grouping system for managing their fleet of computes | |
| 17:42:41 | sean-k-mooney | this one woudl requirte us to creat a sharing resouce provider per host aggreate | |
| 17:42:49 | bauzas | (even if that can be done programmatically by something else) | |
| 17:43:18 | bauzas | my old grandma' was sayin' : "if that works, don't touch it" | |
| 17:43:37 | bauzas | and loooots of ops do manage aggregates thru this filter | |
| 17:43:57 | sean-k-mooney | we have had custoemr bitten by this in the past as an fyi. specifcly the conflict betwwen the capablity filter and aggreate one | |
| 17:44:11 | bauzas | so unless we come up with a solid upgrade plan for replacing it with very simple abstractions, don't touch it | |
| 17:44:26 | sean-k-mooney | bauzas: yep agree | |
| 17:44:29 | bauzas | sean-k-mooney: we resolved it with namespaces, right? | |
| 17:44:33 | sean-k-mooney | yes | |
| 17:44:42 | sean-k-mooney | basicaly they were adding pinned=true | |
| 17:44:47 | bauzas | problem solved. | |
| 17:44:58 | sean-k-mooney | they just namespaced it | |
| 17:45:06 | bauzas | ++ | |
| 17:51:32 | dansmith | man, so busy this morning I missed out on 50% of my usual coffee consumption.. it must be TEOTWAWKI | |
| 17:53:23 | sean-k-mooney | i try to some degree contol my caffein intake including normaly not drinking coffee at the weekends but i can totally feel teh difference when i dont have any | |
| 17:53:55 | sean-k-mooney | given i only drink 1-2 cups a day i dont know if it woudl be more noticable if i drank more or less | |
| 17:55:32 | sean-k-mooney | if i drank more i think it would have less of an effect when i drank it but likely more of an effect when i didnt which is why i reduced my cafee intake in the first place | |
| 19:55:33 | openstackgerrit | melanie witt proposed openstack/nova stable/stein: Reset the cell cache for database access in Service https://review.opendev.org/720587 | |
| 20:39:53 | openstackgerrit | melanie witt proposed openstack/nova stable/rocky: Reset the cell cache for database access in Service https://review.opendev.org/720592 | |
| 20:56:27 | openstackgerrit | melanie witt proposed openstack/nova stable/queens: Reset the cell cache for database access in Service https://review.opendev.org/720596 | |
| 20:56:57 | openstackgerrit | melanie witt proposed openstack/nova stable/rocky: Reset the cell cache for database access in Service https://review.opendev.org/720592 | |
| 21:40:58 | openstackgerrit | Merged openstack/nova master: libvirt: Remove VIR_DOMAIN_BLOCK_REBASE_RELATIVE flag check https://review.opendev.org/702021 | |
| 22:37:19 | openstackgerrit | Merged openstack/nova master: images: Make JSON the default output format of calls to qemu-img info https://review.opendev.org/711679 | |
| #openstack-nova - 2020-04-17 | |||
| 00:37:15 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add docs and releasenotes for BP policy-defaults-refresh https://review.opendev.org/720129 | |
| 00:40:10 | gmann | lbragstad: can you verify the steps for migration to new policy. I cannot find the keystone exact doc please let me know if there is any so that i can link that in my doc - https://review.opendev.org/#/c/720129/4..5/doc/source/configuration/policy-new-defaults.rst@227 | |
| 00:51:33 | openstackgerrit | melanie witt proposed openstack/nova master: Enable test_volume_backed_live_migration in tempest https://review.opendev.org/528104 | |
| 00:53:12 | lbragstad | gmann sounds good - i'm about to pick up the review i started earlier for https://review.opendev.org/#/c/720129/4/doc/source/configuration/policy-new-defaults.rst | |
| 00:53:39 | lbragstad | i'll take a look at the new patch set | |
| 01:01:59 | openstackgerrit | melanie witt proposed openstack/nova master: Move nova-manage db purge to nova-audit https://review.opendev.org/708783 | |
| 01:02:01 | openstackgerrit | melanie witt proposed openstack/nova master: Move nova-manage cell_v2 discover_hosts to nova-manage https://review.opendev.org/708785 | |
| 01:02:01 | openstackgerrit | melanie witt proposed openstack/nova master: Move nova-manage db archive_deleted_rows to nova-audit https://review.opendev.org/708784 | |
| 01:02:02 | openstackgerrit | melanie witt proposed openstack/nova master: Move nova-manage placement sync_aggregates to nova-audit https://review.opendev.org/708787 | |
| 01:02:02 | openstackgerrit | melanie witt proposed openstack/nova master: Move nova-manage cell_v2 map_instances to nova-audit https://review.opendev.org/708786 | |
| 01:02:03 | openstackgerrit | melanie witt proposed openstack/nova master: Move nova-manage placement heal_allocations to nova-audit https://review.opendev.org/708788 | |
| 01:20:21 | openstackgerrit | Merged openstack/nova-specs master: Cleanup py27 support https://review.opendev.org/718368 | |
| 02:03:08 | openstackgerrit | Brin Zhang proposed openstack/nova master: Accurately clean up ARQs resources during build_instances in conductor https://review.opendev.org/720439 | |
| 02:07:11 | openstackgerrit | Brin Zhang proposed openstack/nova master: Accurately clean up ARQs resources during build_instances in conductor https://review.opendev.org/720439 | |
| 02:23:46 | openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Re-proposes 'Proposal for a safer remote console with password authentication' https://review.opendev.org/719720 | |
| 02:31:52 | openstack | Launchpad bug 1841932 in OpenStack Compute (nova) "hide_hypervisor_id extra_specs in nova flavor cannot pass AggregateInstanceExtraSpecsFilter" [Undecided,New] | |
| 02:31:52 | rambo_li | sean-k-mooney: maybe their is an error, for the bug :https://bugs.launchpad.net/nova/+bug/1841932. when we set the metadata "hide_hypervisor_id=true"in aggreate,so we will go to the https://github.com/openstack/nova/blob/46a3bcd80b41e99ec4923c7cf3d0f8dd8505e97c/nova/scheduler/filters/aggregate_instance_extra_specs.py#L69-L71, but this should not break, because the aggregate_val doesn't match the req. | |
| 02:48:16 | rambo_li | maybe we should delete the for loop in https://github.com/openstack/nova/blob/46a3bcd80b41e99ec4923c7cf3d0f8dd8505e97c/nova/scheduler/filters/aggregate_instance_extra_specs.py#L69 | |
| 02:51:32 | openstackgerrit | Merged openstack/os-traits master: Cleanup py27 support https://review.opendev.org/719350 | |
| 03:06:34 | openstackgerrit | Brin Zhang proposed openstack/nova master: Accurately clean up ARQs resources during build_instances in conductor https://review.opendev.org/720439 | |
| 06:36:27 | openstack | Launchpad bug 1873387 in OpenStack Compute (nova) "Unable to delete instance because cyborg.get_client() failed" [Medium,Confirmed] - Assigned to Brin Zhang (zhangbailin) | |
| 06:36:27 | brinzhang | gibi, bauzas: I open a new bug https://bugs.launchpad.net/nova/+bug/1873387, please check while you are wake up. | |
| 06:45:37 | gibi | brinzhang: thanks for finding that bug | |
| 06:46:27 | gibi | brinzhang: I marked it as ussuri-rc-potential as it is a new regression in Ussuri | |
| 06:51:08 | brinzhang | gibi: Got it | |
| 06:51:11 | brinzhang | thanks | |
| 07:29:59 | openstack | bug 1872934 in OpenStack Compute (nova) "Accurately clean up ARQs resources during build_instances() in conductor" [Low,In progress] https://launchpad.net/bugs/1872934 - Assigned to Brin Zhang (zhangbailin) | |
| 07:29:59 | brinzhang | gibi: for bug 1872934 we pushed the fix patch https://review.opendev.org/#/c/720439/, please review if you are free | |
| 09:17:44 | openstackgerrit | Wenping Song proposed openstack/nova master: handle to get cyborg client exception when delete instance https://review.opendev.org/720670 | |
| 10:05:47 | hrw | lyarwood: replied to your comment ;D | |
| 10:11:07 | openstackgerrit | Wenping Song proposed openstack/nova master: Handle to get cyborg client exception when delete instance https://review.opendev.org/720670 | |
| 10:15:19 | lyarwood | hrw: /me rolls eyes | |
| 10:15:42 | lyarwood | hrw: just a suggestion | |
| 10:19:16 | hrw | lyarwood: a bit of pure sarcasm in a morning | |
| 10:19:42 | lyarwood | :) I've not had enough coffee for that yet | |
| 10:19:55 | hrw | I just finished second | |
| 10:26:33 | lyarwood | just starting mine, tgif++ | |
| 10:26:49 | lyarwood | https://review.opendev.org/#/c/669674/ - could use a non-RH core on this given it has an impact across virt drivers. | |
| 11:52:37 | averi | hi, anyone has an idea on why code changes are not picked up by nova_compute containers (OSP 13)? | |
| 11:53:06 | averi | even when spinning up a new image based on the nova-compute one, it doesn't work, code changes are there but they're like ignored all together | |
| 11:53:32 | averi | even killing one of the library files results in the binary not to fail like the file was still around | |
| 12:47:55 | gibi | dansmith, sean-k-mooney, brinzhang: I need a second opinion in https://review.opendev.org/#/c/720670 | |
| 12:51:26 | sean-k-mooney | gibi: well my view is we should have been storing the acell profile in the request spec or in the instnace like we cache the flavor so we dont have this proble but ill go read what the patch acatully does now | |
| 12:52:27 | gibi | sean-k-mooney: it is like create an instance with accel, then remove cyborg service from deployment, then try to delete the instance which will fail | |
| 12:52:47 | sean-k-mooney | gibi: im kind of felling like we should do what ever we would do if cinder or neutron went away | |
| 12:53:01 | sean-k-mooney | i would assume we would fail to delete but i confess i have never tried it | |
| 12:53:20 | gibi | I can try that | |
| 12:54:27 | sean-k-mooney | cool you should jsut need to delete the entry in the service in keystone to emulate that right | |
| 12:55:19 | gibi | I'm not sure that a) this is a valid scenarios that cyborg service is removed from the deployment b) if yes then which is more important in general keeping cyborg - nova in sync or allowing to delete an instance during a temporary failure of cyborg | |