| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-04-14 | |||
| 09:57:57 | bauzas | stephenfin: but given I'm faking privsep https://github.com/openstack/nova/blob/master/nova/tests/functional/libvirt/test_vgpu.py#L45-L47 | |
| 09:58:06 | bauzas | stephenfin: I can't know which compute was for | |
| 09:58:17 | bauzas | :( | |
| 09:58:33 | bauzas | I only know the parent PCI ID | |
| 09:59:57 | stephenfin | I think you need to keep track of individual fake connections like we do in the 'start_computes' function https://github.com/openstack/nova/blob/master/nova/tests/functional/libvirt/base.py#L138-L152 | |
| 10:01:06 | bauzas | stephenfin: sure, but then how to know which fake connection to modify then ? | |
| 10:01:24 | bauzas | I mean in https://github.com/openstack/nova/blob/master/nova/tests/functional/libvirt/test_vgpu.py#L56 | |
| 10:01:45 | bauzas | both compute have the exact same PCI IDs | |
| 10:01:54 | bauzas | computes* | |
| 10:02:17 | stephenfin | ah, yes, gotcha | |
| 10:02:34 | bauzas | 'self' is not the compute driver... | |
| 10:02:55 | gibi | does the fake connection know hostname? | |
| 10:03:11 | gibi | or nodename | |
| 10:03:17 | bauzas | yes | |
| 10:03:21 | bauzas | that's easy | |
| 10:03:30 | gibi | then you can branch based on that | |
| 10:03:37 | bauzas | but again, I don't know which compute was calling https://github.com/openstack/nova/blob/master/nova/tests/functional/libvirt/test_vgpu.py#L56 | |
| 10:04:01 | bauzas | eg. if you create an instance for compute 1 and then compute2 | |
| 10:04:20 | bauzas | then both calls to https://github.com/openstack/nova/blob/master/nova/tests/functional/libvirt/test_vgpu.py#L56 will have the same arguments | |
| 10:04:44 | bauzas | so, _create_mdev() wouldn't know which fake connection to modify | |
| 10:05:17 | gibi | can we have different pci ids per compute? | |
| 10:06:08 | stephenfin | It's very hacky, but you could intercept a higher call and set some attribute to say "compute node N is now attempting to create an mdev" | |
| 10:06:14 | bauzas | gibi: well, we could... but I think it would be a large change then :( | |
| 10:06:34 | bauzas | stephenfin: I can try this | |
| 10:06:55 | bauzas | tbh, I tried to discuss with you to find another solution | |
| 10:07:03 | bauzas | but you told me the two ones I was thinking | |
| 10:07:09 | bauzas | and both of them are difficult :p | |
| 10:07:11 | bauzas | anyway | |
| 10:07:22 | bauzas | I can try to resize to the same host | |
| 10:07:37 | bauzas | (for testing what I want) | |
| 10:07:45 | bauzas | but that won't fix the problem | |
| 10:07:50 | bauzas | anyway, thanks | |
| 10:38:53 | stephenfin | johnthetubaguy: could you help me understand why we are changing the scope types for the create policy here? https://review.opendev.org/#/c/717175/9/nova/policies/server_groups.py | |
| 10:46:18 | openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP/DNM zuul: Attempt to migrate and break up the nova-live-migration job https://review.opendev.org/711604 | |
| 11:08:18 | openstackgerrit | jayaditya gupta proposed openstack/nova master: Support for --force flag for nova-manage placement heal_allocations command https://review.opendev.org/715395 | |
| 13:06:13 | openstackgerrit | Merged openstack/nova master: workarounds: Add option to disable native LUKSv1 decryption by QEMU https://review.opendev.org/708030 | |
| 13:06:20 | openstackgerrit | Merged openstack/nova master: Add test coverage of existing keypairs policies https://review.opendev.org/718604 | |
| 13:06:28 | openstackgerrit | Merged openstack/nova master: Introduce scope_types in keypairs https://review.opendev.org/718609 | |
| 13:06:36 | openstackgerrit | Merged openstack/nova master: Add test coverage of existing quota sets policies https://review.opendev.org/719128 | |
| 13:06:50 | openstackgerrit | Merged openstack/nova master: Add test coverage of existing quota class policies https://review.opendev.org/719095 | |
| 13:06:58 | openstackgerrit | Merged openstack/nova master: Introduce scope_types in quota class Policies https://review.opendev.org/719096 | |
| 13:07:06 | openstackgerrit | Merged openstack/nova master: Add new default roles in keypairs policies https://review.opendev.org/718619 | |
| 13:07:16 | openstackgerrit | Merged openstack/nova master: Pass the actual target in keypairs policy https://review.opendev.org/718621 | |
| 13:07:40 | openstackgerrit | Merged openstack/nova master: api: Allow custom traits https://review.opendev.org/718461 | |
| 13:25:49 | openstackgerrit | Merged openstack/nova master: Use placement stable version for functional job https://review.opendev.org/719119 | |
| 13:51:38 | openstack | Launchpad bug 1872082 in OpenStack Compute (nova) "available disk on compute may be lightly overestimated in some cases" [High,In progress] - Assigned to Alexandre arents (aarents) | |
| 13:51:38 | aarents | Hi there, lyarwood I put few examples on associated bug https://bugs.launchpad.net/nova/+bug/1872082 ( https://review.opendev.org/#/c/719008 ) | |
| 13:59:26 | lyarwood | aarents: yeah sorry missed the RAW example | |
| 14:01:01 | aarents | lyarwood: np | |
| 14:08:15 | lyarwood | aarents: so I think the RAW behaviour is actually a bug due to the way we call fallocate | |
| 14:08:44 | lyarwood | aarents: I think it's writing out a block of zero's at the start | |
| 14:09:01 | lyarwood | aarents: as we aren't using -d | |
| 14:10:08 | gmann | stephenfin: replied for SG scope things- https://review.opendev.org/#/c/717175/9/nova/policies/server_groups.py@36 | |
| 14:10:20 | gmann | stephenfin: please check if that make sense, it is same for POST servers also | |
| 14:11:10 | lyarwood | aarents: https://paste.centos.org/view/90da78f0 for example | |
| 14:11:23 | lyarwood | aarents: I think your change is still good FWIW | |
| 14:11:34 | lyarwood | aarents: but we should also fix our call to fallocate | |
| 14:13:32 | aarents | lyarwood: exact for -d , seems necessary | |
| 14:18:39 | lyarwood | aarents: actually -d is wrong | |
| 14:21:55 | openstackgerrit | Merged openstack/nova master: Add new default roles in tenant tenant usage policies https://review.opendev.org/717587 | |
| 14:22:03 | openstackgerrit | Merged openstack/nova master: Add test coverage of existing server topology policies https://review.opendev.org/717524 | |
| 14:22:33 | nightmare_unreal | how can I get migration ID when migrating an instance ? When I run the live migration cmd from CLI i don't get any output | |
| 14:24:03 | gibi | brinzhang_, sean-k-mooney, dansmith: regarding cyborg-nova integration: can I close the bp and there will be a new bp for Victoria? Does https://review.opendev.org/#/c/716186 needs to be handled as a bug? | |
| 14:24:36 | dansmith | gibi: yes and yes, IMHO | |
| 14:25:11 | gibi | dansmith: OK. I will wait for brinzhang_ to comment too and I will ask him to file the bug too | |
| 14:25:34 | dansmith | ack | |
| 14:26:18 | sean-k-mooney | gibi: yep agree with dansmith | |
| 14:26:24 | gibi | sean-k-mooney: cool | |
| 14:26:59 | sean-k-mooney | speaking of ill go file said bug before i get distracted | |
| 14:27:14 | gibi | sean-k-mooney: thanks | |
| 14:33:33 | sean-k-mooney | gibi: should i mark this as rc potential or shoudl we just treat it as a normal bugfix that we will backport after ussuri is released as normal. | |
| 14:33:58 | stephenfin | gmann: Thanks for the explanation. Would it be possible edit the commit message to include that information there? | |
| 14:34:57 | gibi | sean-k-mooney: what is the worst case issue by that bug? | |
| 14:35:42 | gmann | stephenfin: sure, doing. | |
| 14:36:36 | sean-k-mooney | if we create the ARQ and fail to clean them up becasue binding fail then we leak the arq. since its not bound i think its just leaking a db recored. i need to double check that | |
| 14:37:45 | openstack | Launchpad bug 1872730 in OpenStack Compute (nova) "Delete ARQs for an instance when the instance is deleted only delete bound arqs" [High,Triaged] | |
| 14:37:45 | sean-k-mooney | gibi: https://bugs.launchpad.net/nova/+bug/1872730 | |
| 14:38:10 | gibi | sean-k-mooney: then I think it is not an rc potential bug | |
| 14:38:13 | openstackgerrit | Merged openstack/nova master: Introduce scope_types in server topology https://review.opendev.org/717584 | |
| 14:38:19 | openstackgerrit | Merged openstack/nova master: Add new default roles in server topology policies https://review.opendev.org/717585 | |
| 14:38:27 | openstackgerrit | Merged openstack/nova master: workarounds: Add option to locally attach RBD volumes on compute hosts https://review.opendev.org/708029 | |
| 14:38:42 | gibi | sean-k-mooney: thanks for fileing it | |
| 14:40:02 | sean-k-mooney | gibi: ya i might ping thet cyborg folk to take a look too and confirm its not going to leak devices on there end. but my understanding is they dont allocate or program the device until we bind it as that is when we set the host and pass the allocation to cyborg | |
| 14:40:16 | sean-k-mooney | so if we failed to bind it then they should not need to clean anything up | |
| 14:40:30 | sean-k-mooney | we should be deleted and recreating the arqs when we reschdule | |
| 14:40:34 | gibi | I have a similar understanding, thanks for following it up | |
| 14:45:41 | openstackgerrit | Merged openstack/nova master: fup: Add removal TODOs for disable_native_luksv1 and rbd_volume_local_attach https://review.opendev.org/718099 | |
| 14:45:52 | openstackgerrit | Merged openstack/nova master: Add new default roles in os-evacuate policies https://review.opendev.org/708237 | |
| 14:52:26 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in server group policies https://review.opendev.org/717175 | |
| 14:52:47 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix servers policy for admin_or_owner https://review.opendev.org/718501 | |
| 14:55:16 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix servers policy for admin_or_owner https://review.opendev.org/718501 | |
| 14:55:50 | gmann | stephenfin: done. also this one too - https://review.opendev.org/#/c/718501/ | |
| 14:56:09 | gmann | stephenfin: once you are ok with those then i will rebase the series | |
| 14:56:25 | openstackgerrit | Merged openstack/nova master: Pass the target in os-services APIs policy https://review.opendev.org/676688 | |
| 14:56:32 | openstackgerrit | Merged openstack/nova master: Pass the actual target in server group policy https://review.opendev.org/717176 | |
| 14:56:40 | openstackgerrit | Merged openstack/nova master: Add new default roles in server external events policies https://review.opendev.org/717168 | |
| 14:57:55 | stephenfin | gmann: comment on https://review.opendev.org/#/c/717175/10 | |
| 14:58:21 | stephenfin | I could be wrong though | |
| 14:59:38 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in server group policies https://review.opendev.org/717175 | |
| 15:00:10 | gmann | stephenfin: i think yes. sorry i update that directly. | |