| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-04-09 | |||
| 14:20:27 | sean-k-mooney | it was for the fact we skiped creating the mdev if the could not instead of failing to start the agent | |
| 14:21:32 | gmann | gibi: i will be requesting the FFE for policy things as few are still need to be merged and I am thinking to do for deprecated APIs also | |
| 14:21:37 | sean-k-mooney | bauzas: so this comment https://review.opendev.org/#/c/715490/10/nova/virt/libvirt/driver.py@814 | |
| 14:21:47 | stephenfin | same comment for me | |
| 14:22:11 | gmann | gibi: I will request on ML. my question is for cycle highlights - https://review.opendev.org/#/c/712498/2/deliverables/ussuri/nova.yaml@25 | |
| 14:23:00 | bauzas | sean-k-mooney: okay, fixed by the rev I'm testing | |
| 14:23:22 | bauzas | need to adapt a few more tests than planned, but fair enough | |
| 14:23:25 | gmann | should we include policy things in highlights because amending later might not be acceptable (or at least might get missed by various other forum ) | |
| 14:23:28 | bauzas | won't be a FUP | |
| 14:24:12 | gibi | gmann: hm, let's try to grant FFE for policy bp on the today's meeting and if nobody is against that then I can add info about it to the cyclehighlight | |
| 14:24:20 | gibi | gmann: but I would need some doc I can link to | |
| 14:26:07 | gmann | gibi: ok. then let me work on doc part and release notes first. thanks. | |
| 14:26:16 | gibi | gmann: thanks | |
| 14:26:44 | gmann | gibi: you want me to send FFE on ML and then discuss in meeting or directly in meeting ? | |
| 14:27:18 | gibi | gmann: let's have a mail about the FFE but it is OK to send the mail after the meeting | |
| 14:27:39 | gmann | i see. let's wait for meeting. | |
| 14:27:41 | gibi | my point is to let's discuss that today | |
| 14:27:50 | gmann | sure | |
| 14:28:04 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Support different vGPU types per pGPU https://review.opendev.org/715490 | |
| 14:28:05 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Functional test with pGPUs https://review.opendev.org/717975 | |
| 14:30:28 | bauzas | gibi: stephenfin: sean-k-mooney: last revision, based on your feedback, hardstopping if two types are provided but only one is having PCI devices | |
| 14:31:01 | gibi | bauzas: ack, will look shortly | |
| 14:31:10 | bauzas | how can I help now ? | |
| 14:31:28 | bauzas | gibi: my time is free, so maybe time for you to handover some reviews if you want | |
| 14:32:55 | gibi | bauzas: are you familiar with gmann's policy changes? he just pinged me about an FFE request, so we could speed that series up with some review | |
| 14:33:06 | sean-k-mooney | bauzas: we get a company day in ireland for good friday and then monday is a public holiday | |
| 14:33:20 | sean-k-mooney | bauzas: so stephenfin and i wont be around until tuesday | |
| 14:33:42 | bauzas | gibi: I was knowing a bit, but I can look | |
| 14:33:56 | gibi | bauzas: cool, that would help | |
| 14:34:02 | bauzas | sean-k-mooney: yup, I know, also UK, Germany, Hungary and other EU countries AFAICU | |
| 14:34:09 | gibi | yepp, me too ^^ | |
| 14:34:30 | bauzas | some US states aren't working too | |
| 14:34:39 | bauzas | I don't know for Canada, artom ? | |
| 14:34:48 | gibi | but having the covid situation I might check in a bit each day | |
| 14:34:49 | sean-k-mooney | i may have forgot easter was a thing until remineded by stephenfin that i dont need to work on friday or monday... | |
| 14:34:59 | artom | bauzas, tomorrow? Yeah, we're off | |
| 14:35:03 | bauzas | k | |
| 14:35:04 | artom | Monday too | |
| 14:35:24 | bauzas | so, afaict, I can see our Chinese contributors be around and maybe France | |
| 14:35:32 | bauzas | can't speak for Italy and Spain | |
| 14:35:36 | sean-k-mooney | i basically know this as FF week instead of easter | |
| 14:39:45 | bauzas | sean-k-mooney: my wife and I just realized on Monday it was Easter this week | |
| 14:39:51 | bauzas | you're not alone | |
| 14:41:55 | gmann | lbragstad: this can go in or should i add the diff in some doc ? - https://review.opendev.org/#/c/717879/3 | |
| 14:41:56 | bauzas | gibi: mind giving me the gmann's policy patches ? | |
| 14:42:24 | gmann | bauzas: these - https://review.opendev.org/#/q/topic:bp/policy-defaults-refresh+(status:open+OR+status:merged) | |
| 14:42:27 | gibi | bauzas: it is multiple thread of patches but each is on this topic https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/policy-defaults-refresh | |
| 14:42:44 | stephenfin | gmann: How many of those are left to do? | |
| 14:42:45 | gmann | bauzas: i need to update few policies also and deprecated API policy | |
| 14:42:53 | stephenfin | if you know off the top of your head? | |
| 14:44:28 | gmann | stephenfin: other than which are already up + 3 APIs new + deprecated APIs. i think doing deprecated APIs also good to update also to make it consistent as they still stay. | |
| 14:44:44 | bauzas | gibi: gmann: FWIW, I remember our discussions at the Shanghai PTG, any important points you wanna me to explain before I go reviewing ? | |
| 14:45:03 | bauzas | or is it something not new from Shanghai, just implementation thingies ? | |
| 14:45:22 | nightmare_unreal | Thanks. | |
| 14:45:22 | nightmare_unreal | if someone has time, can you look at this : https://review.opendev.org/#/c/715395/ . | |
| 14:45:30 | gmann | bauzas: key things is the existing test coverage at the first patch and then see how those gets changed for scope and new defaults | |
| 14:46:25 | gmann | bauzas: nothing new from shanghai. it is just implementation of that in all policies | |
| 14:46:27 | bauzas | nightmare_unreal: we're cutting M-3 tonight with Feature Freeze, I'll spend a reasonable couple of hours for reviewing bugs in the next week | |
| 14:46:41 | bauzas | gmann: perfect, then I know the outcomes | |
| 14:47:02 | nightmare_unreal | aah o.O thanks for your work :) | |
| 14:47:04 | bauzas | gmann: will you be around tomorrow or off ? | |
| 14:47:17 | bauzas | gmann: (can't remember where you live, I apologize) | |
| 14:47:20 | gmann | bauzas: thanks. I am working tomorrow and Monday too. might be on weekend too | |
| 14:47:25 | gmann | bauzas: canada | |
| 14:48:10 | bauzas | gmann: ok, gtk, just saying because we just discovered we'll miss a couple of countries for work tomorrow, including Canada | |
| 14:48:24 | gmann | yeah. | |
| 14:48:25 | bauzas | (at least for Red Hat) | |
| 14:50:19 | artom | bauzas, in practice, feature freeze is today :P | |
| 14:50:44 | sean-k-mooney | nightmare_unreal: that --overwrite kind of acts like a --force would | |
| 14:50:53 | bauzas | gmann: patches seem not to be piled in a branch, but rather only by topic name | |
| 14:51:05 | bauzas | artom: I fuckingly know about it | |
| 14:52:03 | bauzas | gmann: that makes reviewing a bit hard, I don't know where to start and a couple of patches got -1 from Zuul | |
| 14:52:03 | gmann | bauzas: correct. 2 are olso one which I are almost ready to go. | |
| 14:52:14 | bauzas | gmann: so I need guidance for reviews | |
| 14:52:34 | bauzas | gmann: I'd say https://review.opendev.org/#/c/718348/ is crucial before we move on | |
| 14:52:35 | stephenfin | bauzas: anything +2'd by me is passing CI | |
| 14:52:37 | gmann | bauzas: ok so there is always set of series for each API. let me find the review guidelines i sent on ML | |
| 14:52:55 | stephenfin | and good (IMO, of course) | |
| 14:52:56 | bauzas | stephenfin: you're Zuul \o/ | |
| 14:53:08 | bauzas | we finally discovered it | |
| 14:53:11 | stephenfin | I wish I was that good at multitasking | |
| 14:53:39 | bauzas | stephenfin: raise 2 kids, get locked down and you'll be surprised about multitasking | |
| 14:53:45 | sean-k-mooney | stephenfin: e.g. it is force updating an allocation even if we dont think it needs healing | |
| 14:53:53 | sean-k-mooney | oh that was for nightmare_unreal ^ | |
| 14:54:10 | gmann | bauzas: http://lists.openstack.org/pipermail/openstack-discuss/2019-August/008504.html | |
| 14:54:55 | bauzas | gmann: perfect, thanks | |
| 14:55:33 | bauzas | gmann: you'd understand that I'd hold reviews on the servers API until https://review.opendev.org/#/c/718348/ get merged ? | |
| 14:56:36 | bauzas | in particular given the criticity of the servers API about policy enforcement | |
| 14:56:46 | gmann | bauzas: yeah that make sense. if test coverage is failing somewhere then it is good to wait to have clear pic of what going to be changed in scope and new defaults patches | |
| 14:57:50 | gmann | bauzas: true. that is one of complex one too given the lot of inline policies per attributes . | |
| 14:57:51 | stephenfin | bauzas: I think you missed sean-k-mooney and I's point https://review.opendev.org/#/c/715490/11/nova/virt/libvirt/driver.py@815 | |
| 14:58:08 | bauzas | stephenfin: did I ? shit. | |
| 14:58:28 | stephenfin | To be clear, I agree with the change you've made in that PS, but it's not the one we were concerned about so I think there's another one to do | |
| 14:58:59 | bauzas | holy shit. | |
| 14:59:09 | sean-k-mooney | bauzas: basically the current code logs a warning if an instance was using an mdev type that cant be recreated | |
| 14:59:13 | bauzas | stephenfin: I absolutely missed your concern, I apologize. | |
| 14:59:16 | openstackgerrit | Ivaylo Mitev proposed openstack/nova master: Implementing graceful shutdown. https://review.opendev.org/666245 | |
| 14:59:24 | sean-k-mooney | i was saying that should cause the agent not to start | |
| 14:59:41 | sean-k-mooney | which i think is what stephenfin ment by make it an error too right | |
| 14:59:44 | bauzas | sean-k-mooney: stephenfin: lemme think about it | |