Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-04-08
21:57:16 openstackgerrit Sylvain Bauza proposed openstack/nova master: Support different vGPU types per pGPU https://review.opendev.org/715490
22:28:27 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing server policies https://review.opendev.org/718348
23:50:24 lbragstad gmann https://review.opendev.org/#/c/717943/2 looks good to me - i tested it locally
#openstack-nova - 2020-04-09
00:02:31 gmann lbragstad: thanks. i will update with the nova test result on that
00:13:02 gmann brinzhang: you planning to add these tests in follow up right? - https://review.opendev.org/#/c/693828/25/nova/tests/unit/api/openstack/compute/test_volumes.py@1342
00:13:32 brinzhang gmann: yes
00:13:41 gmann ok, thanks
00:13:46 brinzhang gmann: but will be later, after FF
00:13:58 brinzhang I remember this patch need to add FUP
00:22:56 openstackgerrit Brin Zhang proposed openstack/python-novaclient master: Microversion 2.85: Change volume-update CLI https://review.opendev.org/712651
00:23:27 brinzhang gmann: I update the microversion 2.85 novalcient comment by stephenfin, pls review again, thanks
00:52:38 openstackgerrit Brin Zhang proposed openstack/python-novaclient master: Microversion 2.85: Change volume-update CLI https://review.opendev.org/712651
01:28:52 openstackgerrit Brin Zhang proposed openstack/nova master: FUP: add missing test for PUT volume attachments API https://review.opendev.org/718589
01:30:28 brinzhang gmann: follow up your comments in https://review.opendev.org/#/c/718589/
01:39:35 openstackgerrit Merged openstack/python-novaclient master: Make 'server list --config-drive' a boolean option https://review.opendev.org/718349
02:06:45 huaqiang ls
02:25:57 openstackgerrit Ghanshyam Mann proposed openstack/nova master: DNM testing enforce new defaults flag https://review.opendev.org/717945
02:34:52 openstackgerrit Merged openstack/nova master: Add new default roles in server password policies https://review.opendev.org/717417
03:01:09 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Disable warning for policies changing default check_str https://review.opendev.org/717884
03:01:44 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Disable warning for policies changing default check_str https://review.opendev.org/717884
03:21:59 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in tenant tenant usage policies https://review.opendev.org/717587
04:11:27 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-console-auth-tokens policies https://review.opendev.org/706689
04:24:02 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-console-auth-tokens policies https://review.opendev.org/706689
04:24:36 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Pass the actual target in os-console-auth-tokens policy https://review.opendev.org/706690
04:25:17 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-aggregates policies https://review.opendev.org/701654
04:57:53 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-aggregates policies https://review.opendev.org/701654
05:02:55 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Pass the actual target in os-aggregates policy https://review.opendev.org/701656
05:10:08 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Fix servers policy for admin_or_owner https://review.opendev.org/718501
05:26:55 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing server policies https://review.opendev.org/718348
05:36:15 openstackgerrit Ghanshyam Mann proposed openstack/nova master: DNM testing enforce new defaults flag https://review.opendev.org/717945
06:07:00 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing server policies https://review.opendev.org/718348
07:01:47 openstackgerrit Merged openstack/nova master: api: Add framework for extra spec validation https://review.opendev.org/704643
07:09:17 gibi good morning
07:19:42 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing keypairs policies https://review.opendev.org/718604
07:20:28 openstackgerrit Guo Jingyu proposed openstack/nova master: WIP: nova supports password encrypted VNC https://review.opendev.org/622336
07:24:42 gibi brinzhang_: hi! are you working on a follow up for https://review.opendev.org/#/c/712651/ ?
07:28:18 brinzhang_ gibi: yeah, it can be follow up, but not now
07:28:28 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Fix servers policy for admin_or_owner https://review.opendev.org/718501
07:29:28 gibi brinzhang_: ack
07:29:30 bauzas gibi: fwiw, I updated my vgpu series based on stephenfin's feedback https://review.opendev.org/#/c/715489/
07:29:39 gibi bauzas: ack :)
07:29:41 brinzhang_ gibi: I fixed some commnets from stephenfin, and Takashi in PS17, can you +A for this patch?
07:30:33 gibi brinzhang_: I will read, and I have to decied how much of that patch is my code before I +At. worst case we can ask stephenfin to +A-it
07:30:36 bauzas gibi: thanks
07:31:12 bauzas gibi: I understand your position, I don't want to rush on you
07:32:46 brinzhang_ gibi: got it, thanks ^^
07:32:55 brinzhang_ good morning gibi
07:33:09 lyarwood \o morning all
07:33:31 gibi bauzas: I want to unblock the client patches as we need to release the client today and that need the API patches to land.
07:33:49 gibi lyarwood: o/
07:34:13 gibi lyarwood: surprise! your 2.87 patches got merge conflicted :/
07:37:45 lyarwood gibi: /o\
07:37:49 lyarwood gibi: ./me looks
07:38:10 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing server policies https://review.opendev.org/718348
07:38:43 lyarwood ah stephenfin rebased his series
07:39:20 bauzas gibi: that's totally understandable
07:39:41 bauzas gibi: fwiw, I can also review a few things
07:40:28 openstackgerrit Lee Yarwood proposed openstack/nova master: virt: Provide block_device_info during rescue https://review.opendev.org/700811
07:40:29 openstackgerrit Lee Yarwood proposed openstack/nova master: compute: Report COMPUTE_RESCUE_BFV and check during rescue https://review.opendev.org/701429
07:40:29 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Add support for stable device rescue https://review.opendev.org/700812
07:40:30 openstackgerrit Lee Yarwood proposed openstack/nova master: compute: Extract _get_bdm_image_metadata into nova.utils https://review.opendev.org/705212
07:40:30 openstackgerrit Lee Yarwood proposed openstack/nova master: api: Introduce microverion 2.87 allowing boot from volume rescue https://review.opendev.org/701430
07:40:31 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Support boot from volume stable device instance rescue https://review.opendev.org/701431
07:41:55 brinzhang_ lyarwood: your rebase are not lost +A, surprise
07:42:21 brinzhang_ today I rebased watcher, cyborg project's patch, all lost the +A :(
07:46:14 bauzas brinzhang_: you loose the +W if your rebase impacted your series somewhere
07:47:04 bauzas brinzhang_: if you just rebase on some change or master that just changes SHA1s without really needing to update your series, then meh
07:47:13 brinzhang_ bauzas: you mean, if anything changed, and not conflict in the same place, it will be not lost the +W?
07:47:41 lyarwood brinzhang_: if nothing has changed in your changes you keep the +W
07:48:26 brinzhang_ lyarwood: Got it, I will be concern this in the future ^^, thanks lyarwood, bauzas
07:56:00 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in keypairs https://review.opendev.org/718609
08:00:25 bauzas brinzhang_: fwiw, you can upload your series without having them rebased on the gerrit remote before by using git review -R
08:00:33 bauzas i never use this one tho
08:01:10 bauzas tbc, git review does rebase on the gerrit git remote you have locally (and which is updated) before it does send it to Gerrit
08:01:28 bauzas brinzhang: this is the step you can skip with the -R flag
08:06:00 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Break up get_disk_mapping within blockinfo https://review.opendev.org/714962
08:06:01 openstackgerrit Lee Yarwood proposed openstack/nova master: fup: Add missing docstrings from get_rescue_device|bus diskinfo funcs https://review.opendev.org/718464
08:06:01 openstackgerrit Lee Yarwood proposed openstack/nova master: fup: Remove the use of the term `unstable rescue` INFO logs https://review.opendev.org/718451
08:06:01 openstackgerrit Lee Yarwood proposed openstack/nova master: fup: Combine SUPPORTED_DEVICE_BUS and SUPPORTED_STORAGE_BUSES https://review.opendev.org/718448
08:06:20 lyarwood I'm using it at the moment to avoid rebasing mine and stephenfin's unmerged stuff
08:09:09 bauzas lyarwood: good call
08:11:00 brinzhang bauzas: I have nerver used this, do you have some docs that I can reference, I would like to study ^^
08:20:27 bauzas brinzhang: not more than https://docs.openstack.org/infra/git-review/usage.html
08:22:41 brinzhang bauzas: "git review -R" not any suffix? that I can directly run it, and that can skip "git rebase i xxx"
08:24:12 bauzas it's just a flag
08:24:22 bauzas you can use any other one for uploading
08:24:34 bauzas of course git review -d -R doesn't make any sense
08:24:43 bauzas since you download instead
08:25:02 brinzhang I always use git review -d id
08:25:16 gibi stephenfin: could you hit https://review.opendev.org/#/c/712651 when you are up?
08:27:20 gibi bauzas: if you have time, could you re-review https://review.opendev.org/#/c/718357 ?
08:28:08 gibi stephenfin: the tests in custom trait handling needs tweeking https://review.opendev.org/#/c/718461
08:30:23 gibi we need somebody other than stephen who feels good about +2ing https://review.opendev.org/#/c/700812 in lyarwood's series. that part of nova is not my strong suite so I'm only +1
08:31:21 bauzas gibi: sure thing, I'm available for upstream this week
08:32:41 brinzhang gibi: I have a question in https://review.opendev.org/#/c/712651/19/novaclient/v2/shell.py@2741
08:33:09 brinzhang gibi: do we need add default=None to --no-delete-on-termination? and why?
08:33:18 gibi brinzhang: let me check that
08:33:22 gibi bauzas: thanks
08:33:41 gibi brinzhang: I copied stephenfin's solution from the reworked 2.83 patch
08:34:21 brinzhang I reviewed the config_drive form stephenfin, I also find he also set for the --no-config-drive

Earlier   Later