| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-04-08 | |||
| 15:00:59 | gmann | stephenfin: done - https://review.opendev.org/#/c/717879/ | |
| 15:01:12 | bauzas | sean-k-mooney: I wouldn't usually worry by exception handling on nova-computes, but here we talk of the API | |
| 15:01:30 | bauzas | and this exception can be populated down to the end user | |
| 15:02:02 | sean-k-mooney | i think this is only used in bind_arqs | |
| 15:02:12 | sean-k-mooney | and i think we cach all error form that but i have to check | |
| 15:03:17 | sean-k-mooney | bauzas: its handeled here https://github.com/openstack/nova/blob/66965e48e1bf013e275148720b860dc5becba6bd/nova/conductor/manager.py#L840-L850 | |
| 15:04:00 | sean-k-mooney | bauzas: so the exception never gets to the end user we just log it | |
| 15:04:54 | bauzas | sean-k-mooney: not if _delete_arqs_by_uuid() which was just added raises an exception when trying to reach Cyborg API | |
| 15:04:57 | bauzas | right? | |
| 15:07:36 | sean-k-mooney | _create_and_bind_arqs calls bind_arqs which is the only thing that calls _delete_arqs_by_uuid | |
| 15:08:17 | sean-k-mooney | and _create_and_bind_arqs is called in a try block that catches all exception and logs them | |
| 15:09:36 | sean-k-mooney | bauzas: acully im not sure _create_and_bind_arqs can raise an exception | |
| 15:10:39 | sean-k-mooney | def _call_cyborg(self, func, *args, **kwargs): | |
| 15:10:40 | sean-k-mooney | resp = err_msg = None | |
| 15:10:42 | sean-k-mooney | try: | |
| 15:10:44 | sean-k-mooney | resp = func(*args, **kwargs) | |
| 15:10:46 | sean-k-mooney | if not resp: | |
| 15:10:48 | sean-k-mooney | msg = _('Invalid response from Cyborg: ') | |
| 15:10:50 | sean-k-mooney | err_msg = msg + str(resp) | |
| 15:10:52 | sean-k-mooney | except ks_exc.ClientException as exc: | |
| 15:10:54 | sean-k-mooney | err_msg = _('Could not communicate with Cyborg.') | |
| 15:10:56 | sean-k-mooney | LOG.exception('%s: %s', err_msg, six.text_type(exc)) | |
| 15:11:11 | sean-k-mooney | ya it should not unless we get like a type error form func | |
| 15:11:43 | sean-k-mooney | ks_exc.ClientException should catch all exception related to the network | |
| 15:21:48 | bauzas | sean-k-mooney: OK, then we're all good | |
| 15:21:55 | bauzas | sean-k-mooney: create a bug and I'll +2 | |
| 15:24:21 | gibi | stephenfin: does the solution for https://review.opendev.org/#/c/718349/3/novaclient/v2/shell.py@1669 is to use different dest for the two flag? | |
| 15:25:36 | sean-k-mooney | bauzas: cool ill do it after downstream call finishes | |
| 15:27:40 | melwitt | gibi: hi, I am looking for review on a gate bug fix https://review.opendev.org/717662 "timed out waiting for response from cell" | |
| 15:28:23 | gibi | melwitt: looking | |
| 15:32:07 | melwitt | thanks | |
| 15:34:45 | gibi | melwitt: +2, thanks | |
| 15:35:22 | melwitt | dansmith: you might be interested in reviewing as well? ^ | |
| 15:37:33 | openstackgerrit | Huaqiang Wang proposed openstack/nova master: Introduce 'pcpuset' field for InstanceNUMACell https://review.opendev.org/714658 | |
| 15:37:34 | openstackgerrit | Huaqiang Wang proposed openstack/nova master: hardware: Add support for 'hw:cpu_dedicated_mask' extra spec https://review.opendev.org/714706 | |
| 15:37:34 | openstackgerrit | Huaqiang Wang proposed openstack/nova master: Introduce the 'CPUAllocationPolicy.MIXED' enum https://review.opendev.org/716267 | |
| 15:37:35 | openstackgerrit | Huaqiang Wang proposed openstack/nova master: Calculate the pinned and unpinned CPU usage for mixed instance https://review.opendev.org/716269 | |
| 15:37:35 | openstackgerrit | Huaqiang Wang proposed openstack/nova master: computer: validate cpu pinning configuration for mixed instance https://review.opendev.org/716268 | |
| 15:37:36 | openstackgerrit | Huaqiang Wang proposed openstack/nova master: libvirt/hardware: refactor numa_get_constraints https://review.opendev.org/718294 | |
| 15:37:36 | openstackgerrit | Huaqiang Wang proposed openstack/nova master: mark mixed policy as ready, bump compute service version https://review.opendev.org/716271 | |
| 15:37:37 | openstackgerrit | Huaqiang Wang proposed openstack/nova master: metadata: export the vCPU IDs that are pinning on the host CPUs https://review.opendev.org/688936 | |
| 15:37:37 | openstackgerrit | Huaqiang Wang proposed openstack/nova master: Setup 'mixed' instance through 'PCPU' and 'VCPU' resource https://review.opendev.org/713355 | |
| 15:37:38 | openstackgerrit | Huaqiang Wang proposed openstack/nova master: online data migration for cpuset of dedicated instance https://review.opendev.org/718493 | |
| 15:38:26 | stephenfin | gibi: For https://review.opendev.org/#/c/718461/2/nova/api/validation/extra_specs/traits.py@65 should I enforce upper-case? | |
| 15:40:02 | gibi | stephenfin: if we don't do that then GET allocation_candidates query will return no canididates during scheduling so I think this needs to be considered as a typo | |
| 15:40:35 | gibi | I'm OK not to have the length requirement enforced that is harder to justify as a typo | |
| 15:43:12 | dansmith | melwitt: ack yep | |
| 15:43:43 | melwitt | danke | |
| 15:47:38 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix servers policy for admin_or_owner https://review.opendev.org/718501 | |
| 15:48:15 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix servers policy for admin_or_owner https://review.opendev.org/718501 | |
| 15:48:40 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing server policies https://review.opendev.org/718348 | |
| 15:49:04 | dansmith | melwitt: commented on something, if you can link me to that quicker than I can find it that'd be helpful :) | |
| 15:50:25 | melwitt | yeah hang on | |
| 15:58:34 | openstackgerrit | Stephen Finucane proposed openstack/nova master: api: Allow custom traits https://review.opendev.org/718461 | |
| 15:58:44 | stephenfin | gibi: done and done ^ | |
| 15:59:46 | gibi | stephenfin: ack | |
| 16:00:13 | gibi | will review before I leave today | |
| 16:03:27 | melwitt | dansmith: finally replied. tracing that always confuses me for whatever reason | |
| 16:09:00 | gibi | stephenfin: does the solution for https://review.opendev.org/#/c/718349/3/novaclient/v2/shell.py@1669 is to use different dest for the two flags? I'm failing to implement mutual exclusivity in 2.85 | |
| 16:09:56 | stephenfin | oh, so error out if e.g. both the 'config_drive' and 'no_config_drive' dests are set? | |
| 16:09:58 | gibi | most probably I've already fried my brain for today | |
| 16:10:04 | stephenfin | that would work | |
| 16:10:14 | stephenfin | let me try it | |
| 16:10:24 | gibi | stephenfin: I let you fix 2.83 while I do similar things for 2.85 | |
| 16:10:31 | stephenfin | ack | |
| 16:10:54 | stephenfin | bauzas: question at https://review.opendev.org/#/c/715489/8/nova/virt/libvirt/driver.py@6953 | |
| 16:13:15 | bauzas | stephenfin: thanks, replying | |
| 16:15:12 | bauzas | stephenfin: replied. | |
| 16:18:33 | stephenfin | bauzas: cool, thanks for the clarification | |
| 16:19:56 | bauzas | stephenfin: yeah sorry this patch is mostly a cleanup prep work | |
| 16:28:01 | openstackgerrit | Merged openstack/nova master: Introduce scope_types in simple tenant usage https://review.opendev.org/717586 | |
| 16:28:05 | openstackgerrit | Stephen Finucane proposed openstack/python-novaclient master: Make 'server list --config-drive' a boolean option https://review.opendev.org/718349 | |
| 16:28:24 | stephenfin | gibi: you'll probably want that for 2.85, assuming you like the approach ^ | |
| 16:28:37 | gibi | ack | |
| 16:33:25 | gibi | stephenfin: +2 | |
| 16:33:42 | stephenfin | \o/ | |
| 16:37:50 | gibi | stephenfin: and +2 on both of the extra spec FUPs | |
| 16:43:19 | bauzas | gibi: stephenfin: sorry I dropped my attention from the issue gibi found (thanks btw.!) but can I take a look at it now ? | |
| 16:43:28 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: FUP: Support multiple vGPU types https://review.opendev.org/718516 | |
| 16:43:28 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Functional test with pGPUs https://review.opendev.org/717975 | |
| 16:43:29 | stephenfin | yup, I think so | |
| 16:43:54 | bauzas | gibi: stephenfin: FWIW, I worked the func tests for verifying both types and provided a FUP based on lyarwood's comments ^ | |
| 16:44:24 | bauzas | I totally understand how vGPU in libvirt is old greek, that's why you can ask me for more functional testing if you want | |
| 16:45:27 | bauzas | gibi: FWIW, your reshape test also simulates a Train compute and I didn't had to change this reshape test (except where to call the config) for making it work, which proves I didn't regress | |
| 16:45:48 | bauzas | stephenfin: and ack, will review your last bits before I go | |
| 16:52:00 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: FUP: Support multiple vGPU types https://review.opendev.org/718516 | |
| 16:52:00 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Functional test with pGPUs https://review.opendev.org/717975 | |
| 16:52:54 | dansmith | melwitt: so, I didn't go looking, but where's the entrypoint for the thing when we're running underneath a proper WSGI server like apache or nginx? I'm guessing maybe that won't suffer from the same issue because it's forked from the main process before it gets to any nova/oslo stuff, but.. did you confirm? | |
| 16:55:04 | melwitt | dansmith: oh, no ... I had looked only at the nova/cmd because I was focused on nova-scheduler. hmm | |
| 16:55:42 | melwitt | but I'd guess the same | |
| 16:56:28 | dansmith | melwitt: okay one more comment on the wsgi service if you can look | |
| 16:56:39 | openstackgerrit | Balazs Gibizer proposed openstack/python-novaclient master: Microversion 2.85: Change volume-update CLI https://review.opendev.org/712651 | |
| 16:56:42 | dansmith | not related to scheduler of course, but ... | |
| 16:57:00 | openstackgerrit | Merged openstack/nova master: partial support for live migration with specific resources https://review.opendev.org/715362 | |
| 16:57:04 | gibi | stephenfin: 2.85 client patch enhanced by following your lead https://review.opendev.org/712651 | |
| 16:57:33 | gibi | and that marks the end of my day. | |
| 16:58:02 | stephenfin | I'm knocking off shortly. Will grab that before then (y) | |
| 16:58:43 | gibi | see you folks tomorrow o/ | |
| 16:58:45 | melwitt | dansmith: oh, dang, I had meant to add to WSGIService as well but it slipped my mind, likely because WSGIService derives from Service ... but it overrides start() so I need to | |
| 16:59:01 | dansmith | melwitt: yeah | |