| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-04-08 | |||
| 14:54:17 | bauzas | sean-k-mooney: since it's already sent to the gate, I left a +1 to not fuck gibi's and lyarwood's stats :p | |
| 14:54:35 | lbragstad | gmann i have an environment up - i should be able to do it today | |
| 14:54:51 | gmann | lbragstad: i tried to simulate it on nova but somehow due to our fake_policy things for tests not letting me or something i am missing - https://review.opendev.org/#/c/717945/ | |
| 14:54:59 | gmann | lbragstad: great thanks a lot. | |
| 14:56:37 | bauzas | sean-k-mooney: -1 on https://review.opendev.org/#/c/716186/6 | |
| 14:56:47 | bauzas | is Sundar no longer around ? | |
| 14:56:56 | bauzas | who from the cyborg team can handover this ? | |
| 14:57:22 | sean-k-mooney | bauzas: im taking over his nova work | |
| 14:57:22 | gmann | stephenfin: should i fix those nits if you are here to re+2 on this ? otherwise do not want to lose that +2- https://review.opendev.org/#/c/717879/2 | |
| 14:57:36 | sean-k-mooney | i can go file a bug report and add the bug link | |
| 14:57:39 | bauzas | please | |
| 14:57:41 | sean-k-mooney | bauzas: were you ok with the code | |
| 14:57:51 | stephenfin | gmann: yes, if you can fix them, I'm okay to re +2 | |
| 14:58:03 | bauzas | sean-k-mooney: from what I've seen, yes | |
| 14:58:36 | bauzas | sean-k-mooney: maybe just one question, can _delete_arqs_by_uuid() raise some Exception ? | |
| 14:58:38 | sean-k-mooney | cool ill see if i can adress your other commens in a seperate follow up patch | |
| 14:58:56 | sean-k-mooney | bauzas: yes | |
| 14:59:06 | bauzas | from what i've seen, we just call the API and treat the error | |
| 14:59:22 | bauzas | oh, _call_cyborg can return an exception ? | |
| 14:59:36 | sean-k-mooney | basically i can rais an exception for auth issue or normal network issues | |
| 14:59:59 | sean-k-mooney | e.g. since ita an api requst cyborg could be dead | |
| 15:00:05 | bauzas | OK, I just wonder whether this would trample the user if we got an exception in the meantime | |
| 15:00:21 | sean-k-mooney | i dont think so | |
| 15:00:35 | sean-k-mooney | maybe but i dont think it will | |
| 15:00:38 | bauzas | correct, but then we need to handle it to return AcceleratorRequestOpFailed correctly then | |
| 15:00:59 | gmann | stephenfin: done - https://review.opendev.org/#/c/717879/ | |
| 15:01:12 | bauzas | sean-k-mooney: I wouldn't usually worry by exception handling on nova-computes, but here we talk of the API | |
| 15:01:30 | bauzas | and this exception can be populated down to the end user | |
| 15:02:02 | sean-k-mooney | i think this is only used in bind_arqs | |
| 15:02:12 | sean-k-mooney | and i think we cach all error form that but i have to check | |
| 15:03:17 | sean-k-mooney | bauzas: its handeled here https://github.com/openstack/nova/blob/66965e48e1bf013e275148720b860dc5becba6bd/nova/conductor/manager.py#L840-L850 | |
| 15:04:00 | sean-k-mooney | bauzas: so the exception never gets to the end user we just log it | |
| 15:04:54 | bauzas | sean-k-mooney: not if _delete_arqs_by_uuid() which was just added raises an exception when trying to reach Cyborg API | |
| 15:04:57 | bauzas | right? | |
| 15:07:36 | sean-k-mooney | _create_and_bind_arqs calls bind_arqs which is the only thing that calls _delete_arqs_by_uuid | |
| 15:08:17 | sean-k-mooney | and _create_and_bind_arqs is called in a try block that catches all exception and logs them | |
| 15:09:36 | sean-k-mooney | bauzas: acully im not sure _create_and_bind_arqs can raise an exception | |
| 15:10:39 | sean-k-mooney | def _call_cyborg(self, func, *args, **kwargs): | |
| 15:10:40 | sean-k-mooney | resp = err_msg = None | |
| 15:10:42 | sean-k-mooney | try: | |
| 15:10:44 | sean-k-mooney | resp = func(*args, **kwargs) | |
| 15:10:46 | sean-k-mooney | if not resp: | |
| 15:10:48 | sean-k-mooney | msg = _('Invalid response from Cyborg: ') | |
| 15:10:50 | sean-k-mooney | err_msg = msg + str(resp) | |
| 15:10:52 | sean-k-mooney | except ks_exc.ClientException as exc: | |
| 15:10:54 | sean-k-mooney | err_msg = _('Could not communicate with Cyborg.') | |
| 15:10:56 | sean-k-mooney | LOG.exception('%s: %s', err_msg, six.text_type(exc)) | |
| 15:11:11 | sean-k-mooney | ya it should not unless we get like a type error form func | |
| 15:11:43 | sean-k-mooney | ks_exc.ClientException should catch all exception related to the network | |
| 15:21:48 | bauzas | sean-k-mooney: OK, then we're all good | |
| 15:21:55 | bauzas | sean-k-mooney: create a bug and I'll +2 | |
| 15:24:21 | gibi | stephenfin: does the solution for https://review.opendev.org/#/c/718349/3/novaclient/v2/shell.py@1669 is to use different dest for the two flag? | |
| 15:25:36 | sean-k-mooney | bauzas: cool ill do it after downstream call finishes | |
| 15:27:40 | melwitt | gibi: hi, I am looking for review on a gate bug fix https://review.opendev.org/717662 "timed out waiting for response from cell" | |
| 15:28:23 | gibi | melwitt: looking | |
| 15:32:07 | melwitt | thanks | |
| 15:34:45 | gibi | melwitt: +2, thanks | |
| 15:35:22 | melwitt | dansmith: you might be interested in reviewing as well? ^ | |
| 15:37:33 | openstackgerrit | Huaqiang Wang proposed openstack/nova master: Introduce 'pcpuset' field for InstanceNUMACell https://review.opendev.org/714658 | |
| 15:37:34 | openstackgerrit | Huaqiang Wang proposed openstack/nova master: hardware: Add support for 'hw:cpu_dedicated_mask' extra spec https://review.opendev.org/714706 | |
| 15:37:34 | openstackgerrit | Huaqiang Wang proposed openstack/nova master: Introduce the 'CPUAllocationPolicy.MIXED' enum https://review.opendev.org/716267 | |
| 15:37:35 | openstackgerrit | Huaqiang Wang proposed openstack/nova master: Calculate the pinned and unpinned CPU usage for mixed instance https://review.opendev.org/716269 | |
| 15:37:35 | openstackgerrit | Huaqiang Wang proposed openstack/nova master: computer: validate cpu pinning configuration for mixed instance https://review.opendev.org/716268 | |
| 15:37:36 | openstackgerrit | Huaqiang Wang proposed openstack/nova master: libvirt/hardware: refactor numa_get_constraints https://review.opendev.org/718294 | |
| 15:37:36 | openstackgerrit | Huaqiang Wang proposed openstack/nova master: mark mixed policy as ready, bump compute service version https://review.opendev.org/716271 | |
| 15:37:37 | openstackgerrit | Huaqiang Wang proposed openstack/nova master: metadata: export the vCPU IDs that are pinning on the host CPUs https://review.opendev.org/688936 | |
| 15:37:37 | openstackgerrit | Huaqiang Wang proposed openstack/nova master: Setup 'mixed' instance through 'PCPU' and 'VCPU' resource https://review.opendev.org/713355 | |
| 15:37:38 | openstackgerrit | Huaqiang Wang proposed openstack/nova master: online data migration for cpuset of dedicated instance https://review.opendev.org/718493 | |
| 15:38:26 | stephenfin | gibi: For https://review.opendev.org/#/c/718461/2/nova/api/validation/extra_specs/traits.py@65 should I enforce upper-case? | |
| 15:40:02 | gibi | stephenfin: if we don't do that then GET allocation_candidates query will return no canididates during scheduling so I think this needs to be considered as a typo | |
| 15:40:35 | gibi | I'm OK not to have the length requirement enforced that is harder to justify as a typo | |
| 15:43:12 | dansmith | melwitt: ack yep | |
| 15:43:43 | melwitt | danke | |
| 15:47:38 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix servers policy for admin_or_owner https://review.opendev.org/718501 | |
| 15:48:15 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix servers policy for admin_or_owner https://review.opendev.org/718501 | |
| 15:48:40 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing server policies https://review.opendev.org/718348 | |
| 15:49:04 | dansmith | melwitt: commented on something, if you can link me to that quicker than I can find it that'd be helpful :) | |
| 15:50:25 | melwitt | yeah hang on | |
| 15:58:34 | openstackgerrit | Stephen Finucane proposed openstack/nova master: api: Allow custom traits https://review.opendev.org/718461 | |
| 15:58:44 | stephenfin | gibi: done and done ^ | |
| 15:59:46 | gibi | stephenfin: ack | |
| 16:00:13 | gibi | will review before I leave today | |
| 16:03:27 | melwitt | dansmith: finally replied. tracing that always confuses me for whatever reason | |
| 16:09:00 | gibi | stephenfin: does the solution for https://review.opendev.org/#/c/718349/3/novaclient/v2/shell.py@1669 is to use different dest for the two flags? I'm failing to implement mutual exclusivity in 2.85 | |
| 16:09:56 | stephenfin | oh, so error out if e.g. both the 'config_drive' and 'no_config_drive' dests are set? | |
| 16:09:58 | gibi | most probably I've already fried my brain for today | |
| 16:10:04 | stephenfin | that would work | |
| 16:10:14 | stephenfin | let me try it | |
| 16:10:24 | gibi | stephenfin: I let you fix 2.83 while I do similar things for 2.85 | |
| 16:10:31 | stephenfin | ack | |
| 16:10:54 | stephenfin | bauzas: question at https://review.opendev.org/#/c/715489/8/nova/virt/libvirt/driver.py@6953 | |
| 16:13:15 | bauzas | stephenfin: thanks, replying | |
| 16:15:12 | bauzas | stephenfin: replied. | |
| 16:18:33 | stephenfin | bauzas: cool, thanks for the clarification | |
| 16:19:56 | bauzas | stephenfin: yeah sorry this patch is mostly a cleanup prep work | |
| 16:28:01 | openstackgerrit | Merged openstack/nova master: Introduce scope_types in simple tenant usage https://review.opendev.org/717586 | |
| 16:28:05 | openstackgerrit | Stephen Finucane proposed openstack/python-novaclient master: Make 'server list --config-drive' a boolean option https://review.opendev.org/718349 | |
| 16:28:24 | stephenfin | gibi: you'll probably want that for 2.85, assuming you like the approach ^ | |
| 16:28:37 | gibi | ack | |
| 16:33:25 | gibi | stephenfin: +2 | |