Posted	Nick	Remark
#openstack-nova - 2020-03-24
16:43:55	openstackgerrit	Stephen Finucane proposed openstack/nova master: WIP! hardware: Add support for 'hw:cpu_dedicated_mask' extra spec https://review.opendev.org/714706
16:53:48	openstackgerrit	John Garbutt proposed openstack/nova master: Update limit APIs https://review.opendev.org/712707
16:53:49	openstackgerrit	John Garbutt proposed openstack/nova master: Update quota sets APIs https://review.opendev.org/712749
17:07:43	sean-k-mooney	stephenfin: im going to rebase https://review.opendev.org/#/c/666915/24 since its in merge conflict
17:07:58	stephenfin	sean-k-mooney: go for it
17:30:28	openstackgerrit	sean mooney proposed openstack/nova master: libvirt: Use domain capabilities to get supported device models https://review.opendev.org/666915
17:30:29	openstackgerrit	sean mooney proposed openstack/nova master: Add transform_image_metadata request filter https://review.opendev.org/665775
17:49:56	openstackgerrit	Merged openstack/nova stable/pike: nova-live-migration: Wait for n-cpu services to come up after configuring Ceph https://review.opendev.org/713036
17:53:59	openstackgerrit	John Garbutt proposed openstack/nova master: Tell oslo.limit how to count nova resources https://review.opendev.org/713301
18:18:13	openstackgerrit	Elod Illes proposed openstack/nova stable/pike: pike-only: remove broken non-voting ceph jobs https://review.opendev.org/700072
18:33:42	openstackgerrit	Elod Illes proposed openstack/nova stable/pike: Init HostState.failed_builds https://review.opendev.org/669538
20:11:06	openstackgerrit	Lee Yarwood proposed openstack/nova stable/pike: Improve metadata server performance with large security groups https://review.opendev.org/697523
20:14:34	lyarwood	melwitt: https://review.opendev.org/#/q/I77ebada015f6522a300be4fa043fb8676458402b - could you hit this if you have time today?
20:14:59	melwitt	lyarwood: sure
20:15:13	lyarwood	melwitt: https://review.opendev.org/#/q/I8af2ad741ca08c3d88efb9aa817c4d1470491a23 - and this if you wouldn't mind
20:15:34	melwitt	sure
20:16:17	lyarwood	thanks :)
20:17:12	melwitt	np
23:15:19	alex_xu	dansmith: thanks
#openstack-nova - 2020-03-25
00:54:23	openstackgerrit	Brin Zhang proposed openstack/python-novaclient master: Microversion 2.83 - action event fault details https://review.opendev.org/714561
00:58:13	openstackgerrit	Merged openstack/nova stable/pike: rt: only map compute node if we created it https://review.opendev.org/676463
00:58:29	openstackgerrit	Brin Zhang proposed openstack/nova master: Add instance actions v283 samples test https://review.opendev.org/706251
00:58:29	openstackgerrit	Brin Zhang proposed openstack/nova master: Expose instance action event details out of the API https://review.opendev.org/694430
00:58:59	brinzhang_	stephenfin, gibi: updated done of bp/action-event-fault-details https://review.opendev.org/694430
01:05:38	openstackgerrit	Merged openstack/nova stable/pike: pike-only: remove broken non-voting ceph jobs https://review.opendev.org/700072
01:11:52	brinzhang_	dansmith: Did you see my reply in https://review.opendev.org/#/c/693828/?
01:21:23	brinzhang_	sean-k-mooney: I left some comments in https://review.opendev.org/#/c/631244/69/nova/accelerator/cyborg.py@214, can you check again? if it's true, I think that can be don by follow up.
01:34:48	gmann	brinzhang_: one comment on policy check for older version - https://review.opendev.org/694430
01:36:04	brinzhang_	gmann: will check
01:40:38	brinzhang_	gmann: https://review.opendev.org/#/c/694430/11/nova/api/openstack/compute/instance_actions.py@187 it does not many impact as before, right?
01:41:43	gmann	brinzhang_: one more comment on policy name
01:42:10	gmann	brinzhang_: you mean for request with <2.83 ?
01:42:31	brinzhang_	but that can reduce to judgement the policy,
01:42:57	gmann	yeah, with <2.83 we anyhow will not show the 'details' field so no need to check policy things also
01:44:01	brinzhang_	ok, I will change to your write
01:44:34	brinzhang_	change The value will be ``null`` for old records. to The value will be ``null`` for older version. is it ok?
01:45:26	openstackgerrit	melanie witt proposed openstack/nova master: DNM: try to get some debug info for bug 1844929 https://review.opendev.org/701478
01:45:27	openstack	bug 1844929 in OpenStack Compute (nova) "grenade jobs failing due to "Timed out waiting for response from cell" in scheduler" [High,Confirmed] https://launchpad.net/bugs/1844929
01:46:27	gmann	brinzhang_: that is I am confuse, older version you mean API version ?
01:46:44	gmann	because for older microversion we are not showing the field itself.
01:46:47	brinzhang_	yes, before microversion 2.83
01:47:32	gmann	ok, then you can remove that line as that field is present in response only after 2.83. if request if with <2.83 then 'details' itself is not present
01:48:02	brinzhang_	ok
01:48:19	brinzhang_	remove this line
01:48:32	gmann	your api-ref change reflect that this field is new in 2.83
01:48:40	gmann	+1
02:05:00	openstackgerrit	Brin Zhang proposed openstack/nova master: Add instance actions v283 samples test https://review.opendev.org/706251
02:05:00	openstackgerrit	Brin Zhang proposed openstack/nova master: Expose instance action event details out of the API https://review.opendev.org/694430
02:05:12	brinzhang_	gmann: done, thanks
02:05:51	brinzhang_	because of the policy name changes, I have tested in my local, it works fine.
02:08:38	openstackgerrit	Brin Zhang proposed openstack/nova master: Expose instance action event details out of the API https://review.opendev.org/694430
02:08:59	openstackgerrit	Brin Zhang proposed openstack/nova master: Add instance actions v283 samples test https://review.opendev.org/706251
02:11:39	openstackgerrit	melanie witt proposed openstack/nova master: DNM: try to get some debug info for bug 1844929 https://review.opendev.org/701478
02:11:41	openstack	bug 1844929 in OpenStack Compute (nova) "grenade jobs failing due to "Timed out waiting for response from cell" in scheduler" [High,Confirmed] https://launchpad.net/bugs/1844929
02:20:40	gmann	brinzhang_: after reading the 2.62 changes, i think we do not need the new policy. we already have existing policy which can control the info from non-admin. commented on spec also
02:20:56	gmann	let's wait for sean-k-mooney reply. https://review.opendev.org/#/c/694430/13/nova/policies/instance_actions.py@52
02:22:28	gmann	i think sean-k-mooney concern was we should not pass these info to non-admin which is controlled via existing policy also, like host info in 'events' - https://github.com/openstack/nova/blob/f454e1dec9580abf4605e071bdd678a40f492a49/nova/api/openstack/compute/instance_actions.py#L170
02:35:06	brinzhang_	gmann: I cannot open github, you mean the https://review.opendev.org/#/c/694430/13/nova/api/openstack/compute/instance_actions.py@172
02:35:35	brinzhang_	gmann: the show_host = api_version_request.is_supported(req, '2.62')?
02:35:37	gmann	brinzhang_: yeah, show_host with 2.62
02:37:25	gmann	brinzhang_: let's wait for sean-k-mooney reply before changes in case something i missed
02:37:50	brinzhang_	gmann: the .BASE_POLICY_NAME % 'events' is a rule_admin policy
02:37:54	openstackgerrit	Merged openstack/nova stable/train: libvirt: Provide the backing file format when creating qcow2 disks https://review.opendev.org/710788
02:38:34	brinzhang_	gmann: ok, let sean-k-mooney check again
02:40:41	gmann	yeah event policy is admin by default
02:42:07	brinzhang_	so show_host can be shown for an admin user, I think the details policy (SYSTEM_READER) is suitable for now.
02:44:46	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing flavor_manage policies https://review.opendev.org/714814
02:47:00	openstackgerrit	Brin Zhang proposed openstack/nova-specs master: [Trivial] Remove note for the implementation https://review.opendev.org/714817
03:00:54	openstackgerrit	Luyao Zhong proposed openstack/nova master: support live migration with vpmems https://review.opendev.org/687856
03:00:54	openstackgerrit	Luyao Zhong proposed openstack/nova master: bug-fix: set do_cleanup always True for libvirt driver https://review.opendev.org/714593
03:00:55	openstackgerrit	Luyao Zhong proposed openstack/nova master: Track orphan instances and error migrations in resource tracker https://review.opendev.org/714653
03:02:26	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in os-flavor-manage https://review.opendev.org/714818
03:18:11	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-flavor_manage policies https://review.opendev.org/714819
03:25:06	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Pass the actual target in os-flavor-manage policy https://review.opendev.org/714822
04:51:49	openstackgerrit	melanie witt proposed openstack/nova master: DNM: try to get some debug info for bug 1844929 https://review.opendev.org/701478
04:51:50	openstack	bug 1844929 in OpenStack Compute (nova) "grenade jobs failing due to "Timed out waiting for response from cell" in scheduler" [High,Confirmed] https://launchpad.net/bugs/1844929
05:26:15	openstackgerrit	Luyao Zhong proposed openstack/nova stable/train: bug-fix: Reject live migration with vpmem https://review.opendev.org/714064
06:12:55	openstackgerrit	Qiu Fossen proposed openstack/nova master: The instance is volume backed and power state is PAUSED，shelve the instance failed https://review.opendev.org/711609
06:12:55	openstackgerrit	Qiu Fossen proposed openstack/nova master: The instance is volume backed and power state is PAUSED，shelve the instance failed https://review.opendev.org/711609
06:40:15	openstackgerrit	Elod Illes proposed openstack/nova stable/pike: Mask the token used to allow access to consoles https://review.opendev.org/708876
06:40:31	openstackgerrit	Elod Illes proposed openstack/nova stable/pike: Avoid circular reference during serialization https://review.opendev.org/714148
06:48:21	openstackgerrit	Sundar Nadathur proposed openstack/nova master: Delete ARQs for an instance when the instance is deleted. https://review.opendev.org/673735
06:48:22	openstackgerrit	Sundar Nadathur proposed openstack/nova master: Enable and use COMPUTE_ACCELERATORS trait. https://review.opendev.org/699554
06:48:22	openstackgerrit	Sundar Nadathur proposed openstack/nova master: Enable start/stop of instances with accelerators. https://review.opendev.org/699553
06:48:22	openstackgerrit	Sundar Nadathur proposed openstack/nova master: Enable hard/soft reboot with accelerators. https://review.opendev.org/697940
06:48:23	openstackgerrit	Sundar Nadathur proposed openstack/nova master: Block unsupported instance operations with accelerators. https://review.opendev.org/674726
06:48:23	openstackgerrit	Sundar Nadathur proposed openstack/nova master: Bump compute rpcapi version and reduce Cyborg calls. https://review.opendev.org/704227
06:48:24	openstackgerrit	Sundar Nadathur proposed openstack/nova master: Add cyborg tempest job. https://review.opendev.org/670999
08:13:02	openstackgerrit	Luyao Zhong proposed openstack/nova master: Track orphan instances and error migrations in resource tracker https://review.opendev.org/714653
08:26:20	nightmare_unreal	openstackgerrit:
08:44:33	luyao	brinzhang_: https://review.opendev.org/#/c/678451/ was moved to https://review.opendev.org/#/c/714653, I add more testcases, thanks for your review
08:55:32	lyarwood	elod: morning, https://review.opendev.org/#/c/713961/ if you have time, almost finished with these now.
09:00:32	brinzhang_	luyao: Thansk, got it, I will check later(I have some docs need to compete.)
09:02:08	luyao	brinzhang_: thanks
09:02:49	brinzhang_	luyao:np ^^
09:04:21	luyao	lyarwood: I have a seperate patch to address the 'do_cleanup' flag issue, could you look at it again? https://review.opendev.org/#/c/714593
09:05:14	lyarwood	yup can try today
09:05:45	luyao	lyarwood: thanks :)
09:07:28	luyao	elod: thanks for review, comments addressed https://review.opendev.org/#/c/714064/
09:18:37	brinzhang_	sean-k-mooney: https://review.opendev.org/#/c/694430/ and https://review.opendev.org/#/c/699669/ need your check, gmann have a question -1 for the new policy for show events:details, and I think it's necessary, and adopt my case, I left my comment in the spec.

Earlier   Later