| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-03-19 | |||
| 13:22:24 | PetrTuma | ah, so that's what I misunderstood | |
| 13:22:55 | PetrTuma | it's not the issue with rebuild itself, but any subsequent action that might be run on the instance | |
| 13:23:08 | sean-k-mooney | yes | |
| 13:23:29 | sean-k-mooney | cold migate and shelve/unshevel could fix the instnace. as would evacuate i guess | |
| 13:23:47 | sean-k-mooney | but live migate, hard reboot rescue would not help | |
| 13:24:21 | PetrTuma | ok, thanks for clarification, I'm going to run some more tests then (I have the fix backported to my nova) | |
| 13:24:49 | sean-k-mooney | sure let me know if you have any specific questions. | |
| 13:25:44 | sean-k-mooney | we technically could allow rebuild to change resouce usage but its invaive as we would have to alter rebuild to not use a noop claim and instead use a move claim. basicaly allowing a rebuild to change host | |
| 13:25:57 | sean-k-mooney | like a resize | |
| 13:26:32 | lyarwood | sean-k-mooney: https://review.opendev.org/#/c/713674/ is ready for review again btw, had to remember to escapte a few things. | |
| 13:27:03 | sean-k-mooney | that is not something that would be backportable and im not sure its something we want to do | |
| 13:27:09 | sean-k-mooney | lyarwood: cool | |
| 13:27:35 | sean-k-mooney | so ya the virsh list was not evaluated on the target host | |
| 13:27:43 | sean-k-mooney | i was assuming it would not be | |
| 13:28:05 | sean-k-mooney | look like the job passed which is a good sign | |
| 13:28:29 | lyarwood | yeah I haven't seen it fail yet since we stopped all of the devstack@* services on the subnode | |
| 13:29:04 | lyarwood | I also don't see the ceph errors in n-cpu on the primary host | |
| 13:29:33 | sean-k-mooney | presumably because the vm is actully stopped on the source host | |
| 13:29:39 | lyarwood | yeah | |
| 13:29:48 | lyarwood | just confirming | |
| 13:31:57 | sean-k-mooney | lyarwood: ya so i think that looks good | |
| 13:32:38 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Use domain capabilities to get supported device models https://review.opendev.org/666915 | |
| 13:32:39 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add transform_image_metadata request filter https://review.opendev.org/665775 | |
| 13:33:07 | sean-k-mooney | https://review.opendev.org/#/c/713342/1 isnt doing what i wanted it too. i might take a look at it again but i think im going to rebase it on top of your change | |
| 13:33:35 | sean-k-mooney | im seeing some port not fond messages with it | |
| 13:33:58 | stephenfin | gibi, alex_xu: Addressed your comments in that disk image metadata series ^ | |
| 13:34:11 | sean-k-mooney | which makes me think its doing more then removing the binding host | |
| 13:34:47 | gibi | stephenfin: ack | |
| 13:35:14 | alex_xu | stephenfin: got it | |
| 13:35:34 | alex_xu | sean-k-mooney: stephenfin just replied https://review.opendev.org/#/c/665775/25/nova/conf/scheduler.py@203, maybe I missunderstand sean-k-mooney's comment | |
| 13:35:53 | sean-k-mooney | also jsut replied | |
| 13:36:00 | alex_xu | sean-k-mooney: yes, that is what I said | |
| 13:36:15 | stephenfin | alex_xu: Yeah, you're correct. That's what I've said in the new patchset I think | |
| 13:36:18 | sean-k-mooney | you are saying we should not set it to true until all host are upgraded yes | |
| 13:36:35 | stephenfin | In addition to saying this only works with libvirt | |
| 13:36:35 | alex_xu | yes | |
| 13:36:37 | stephenfin | for now, anyway | |
| 13:36:41 | alex_xu | at least not suggest to set as true | |
| 13:37:22 | sean-k-mooney | alex_xu: ya so it default to false for two reasons. | |
| 13:37:30 | sean-k-mooney | one not all virt drivers support it | |
| 13:37:44 | alex_xu | ah, right | |
| 13:37:47 | sean-k-mooney | and second because on upgrade you want to finish the upgrade before enableing it | |
| 13:38:03 | alex_xu | ack | |
| 13:38:30 | sean-k-mooney | we wont be able to change that default untill all the in tree virt drivers supprot this | |
| 13:38:38 | sean-k-mooney | so it will proably always default to false | |
| 13:38:51 | sean-k-mooney | at least in the short to medium term | |
| 13:38:54 | alex_xu | agree with that | |
| 13:39:49 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/pike: nova-live-migration: Wait for n-cpu services to come up after configuring Ceph https://review.opendev.org/713036 | |
| 13:46:03 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/pike: pike-only: remove broken non-voting ceph jobs https://review.opendev.org/700072 | |
| 13:46:07 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/pike: Init HostState.failed_builds https://review.opendev.org/669538 | |
| 13:46:12 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/pike: Mask the token used to allow access to consoles https://review.opendev.org/708876 | |
| 13:46:31 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/pike: Remove exp legacy-tempest-dsvm-full-devstack-plugin-nfs https://review.opendev.org/702061 | |
| 13:46:35 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/pike: Improve metadata server performance with large security groups https://review.opendev.org/697523 | |
| 13:47:54 | lyarwood | gibi / stephenfin: https://review.opendev.org/#/c/713674/ - can you take a look at this nova-live-migration fix today please. | |
| 13:50:07 | gibi | lyarwood: do you need to make sure that the stopped services started later? or the whole subnode will be rebooted? | |
| 13:50:46 | lyarwood | gibi: evacuation is the final thing that happens in the job at the moment | |
| 13:50:48 | sean-k-mooney | gibi: we do the evacuation tests after all the others | |
| 13:51:05 | gibi | OK. thanks. then it make sense | |
| 13:51:10 | lyarwood | yeah the previous behaviour was to leave libvirt stopped on the subnode anyway | |
| 13:51:19 | lyarwood | I'm still plannig to break this out into seperate jobs btw | |
| 13:51:29 | lyarwood | Just want to get it stable again before I start with that | |
| 13:51:59 | sean-k-mooney | yep makes sense | |
| 13:52:15 | gibi | lyarwood: thank you for taking care of this. +2 | |
| 13:52:48 | lyarwood | np it has stopped my stuff from landing so this is the least I could do ;) | |
| 13:54:20 | gibi | lyarwood: you are unblocking everyone and that is highly appreciated :) | |
| 14:33:06 | sean-k-mooney | gibi: is the nova team meeing happing now by the way | |
| 14:33:23 | sean-k-mooney | oh its later i need to update my calandar | |
| 14:33:25 | gibi | sean-k-mooney: each occasion moved to 16:00 UTC | |
| 14:33:33 | sean-k-mooney | yep | |
| 14:37:48 | sean-k-mooney | ical file for anyone else http://eavesdrop.openstack.org/calendars/nova-team-meeting.ics | |
| 15:02:28 | gibi | dansmith: I went through the cyborg patch series. left comments. I did not find any ground breaking problem. | |
| 15:02:52 | dansmith | gibi: okay I haven't even looked at my reviews box yet this morning but will try to do that soon | |
| 15:03:17 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Use virDomainBlockCopy to swap volumes when using -blockdev https://review.opendev.org/696834 | |
| 15:04:27 | gibi | dansmith: ack | |
| 15:08:01 | openstack | Launchpad bug 1858019 in OpenStack Compute (nova) "The flavor id is not limited when creating a flavor" [Wishlist,Triaged] - Assigned to Choi-Sung-Hoon (knu-cse) | |
| 15:08:01 | gmann | sean-k-mooney: a bug related to flavor. id with name or vice versa are not unique. If we do some change in flavor things what we discussed yesterday, i think we can stop taking flavor id in request and always generate one- https://bugs.launchpad.net/nova/+bug/1858019 | |
| 15:08:29 | gmann | because i do not think fixing 1858019 alone is worth for microversion bump | |
| 15:08:36 | sean-k-mooney | gmann: im not sure about that | |
| 15:08:44 | gmann | any specific reason for flavor id in request ? | |
| 15:08:55 | sean-k-mooney | well people often just use the id | |
| 15:09:10 | sean-k-mooney | i know we frequently do that in ci | |
| 15:09:31 | sean-k-mooney | so we know that the m1.nano flaovr is 42 and that is just used in ci jobs | |
| 15:09:46 | sean-k-mooney | gmann: the flavor id is always uniqute | |
| 15:09:52 | sean-k-mooney | but the name is not | |
| 15:10:12 | gmann | name is also unique to each other but id with name is not | |
| 15:10:33 | sean-k-mooney | yes but you can have two flaovr with the same name | |
| 15:10:43 | sean-k-mooney | you cant have two flavors with the same id | |
| 15:10:47 | sean-k-mooney | right? | |
| 15:10:48 | gmann | no, it will be 409 i think | |
| 15:10:57 | gmann | in name case also | |
| 15:11:02 | sean-k-mooney | i would have to go check | |
| 15:11:07 | gmann | let me confirm quickly | |
| 15:11:08 | sean-k-mooney | i know we look for deleted status | |
| 15:12:21 | sean-k-mooney | gmann: i guess we could stop taking the id in the new microverion i just know i often specify the id if i am using ci jobs or locally so i dont know how wide spread that is | |
| 15:12:34 | sean-k-mooney | gmann: you suggesign blocking it on flavor create right | |
| 15:12:40 | openstackgerrit | Kevin Zhao proposed openstack/nova master: fix scsi disk unit number of the attaching volume when cdrom bus is scsi https://review.opendev.org/712607 | |
| 15:12:44 | sean-k-mooney | not for other operations | |
| 15:12:46 | gmann | yeah, in create | |
| 15:12:52 | gmann | create request only | |
| 15:13:38 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/models.py#L415-L418 | |