Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-03-16
15:35:50 spatel may be they have hack version of software design by them
15:37:54 spatel Anyway so you think BIOS level is best way then i will do with that but it will be growing pain as my cloud growing :(
15:39:23 openstackgerrit John Garbutt proposed openstack/nova master: Update quota sets APIs https://review.opendev.org/712749
15:39:23 openstackgerrit John Garbutt proposed openstack/nova master: Update limit APIs https://review.opendev.org/712707
15:39:24 openstackgerrit John Garbutt proposed openstack/nova master: WIP: Enforce unified limits using oslo.limit https://review.opendev.org/615180
15:48:03 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Use virDomainBlockCopy to swap volumes when using -blockdev https://review.opendev.org/696834
15:48:54 lyarwood kashyap: ^ updated btw
15:52:05 openstackgerrit Brin Zhang proposed openstack/nova master: Add PATCH volume attachments api to os-volume_attachments https://review.opendev.org/693828
15:52:05 openstackgerrit Brin Zhang proposed openstack/nova master: Add new default roles in os-volumes-attachments policies https://review.opendev.org/710190
15:52:06 openstackgerrit Brin Zhang proposed openstack/nova master: Add functional tests for PATCH volume attachments API https://review.opendev.org/710965
15:52:06 openstackgerrit Brin Zhang proposed openstack/nova master: Add new policy to PATCH update volume API https://review.opendev.org/711194
15:57:20 dansmith sean-k-mooney: AFAIK, the cyborg patch that generates the libvirt xml hasn't changed much, and you've tested that at some point with real devices (right?) so we can assume it works without much fanfare?
15:59:21 kashyap lyarwood: Will check; thx
16:00:58 sean-k-mooney dansmith: i havent tested with real device no
16:01:06 dansmith oh I thought you had okay
16:01:19 sean-k-mooney dansmith: i can go specific review that patch however
16:01:28 dansmith presumably sundar has
16:01:37 sean-k-mooney i belive you are correct in that it does not change much
16:01:58 sean-k-mooney dansmith: yes sundar has apparently tested it with the rushcreak fpga card
16:02:24 dansmith I looked over it a while back and I think the only way I'd be able to find stuff really wrong with it is through log examination
16:02:25 dansmith it's pretty straightforward
16:05:09 sean-k-mooney dansmith: i rebased the cyborg devstack pluging multinode this moringin by the way. just to resovle the merge conflict
16:05:16 dansmith I saw, thanks
16:06:12 sean-k-mooney if i rebase it again do you want me to move your host name fix patch lower? hoepfully they will merge soon anyway but that is usefaul outside of multinode testing
16:06:51 dansmith it's not super critical unless it's blocking people.. I put it later just to avoid messing up your series, but obviously it's probably an easy merge.. your call
16:08:00 sean-k-mooney ok if i need to respin i can move it down. i dont think other have really complained about it plus you can always override the host via the local.conf anyway
16:11:03 dansmith yup.. I imagine that's because most people are using more throwaway machines for their testing (and it's probably not getting a very wide audience anyway) but.. yep, not critical and there is a workaround
16:12:52 melwitt artom, dansmith: fyi I didn't change the meaning of the UNKNOWN status, it originally was only for host down and then when the down cells handling was added, it was used for that as well. my change was just a new policy rule to allow UNKNOWN status to be seen by non-admin if indicated by policy
16:13:35 dansmith melwitt: it was originally for cell down only, AFAIR
16:13:38 melwitt this is the logic for host down https://github.com/openstack/nova/blob/master/nova/compute/api.py#L5339-L5351
16:13:42 dansmith mark-host-down left the status in place
16:13:58 dansmith that's host status
16:14:09 sean-k-mooney dansmith: on a slightly different topic do you have interest in/ time to review the porvider.yaml series? just trying to figure out which redhat cores to bug as a reviewer when its ready.
16:14:11 dansmith he's talking about instance status right?
16:14:16 melwitt wasn't that the question?
16:14:20 sean-k-mooney melwitt: since your here same question ^
16:14:26 melwitt oh, sorry. sigh
16:14:32 dansmith melwitt: vm status
16:14:40 melwitt well, either way I didn't change the meaning of vm status either
16:15:02 dansmith melwitt: I thought you were proposing the vm status change but okay
16:16:21 melwitt dansmith: I did but you explained why it wouldn't be a good idea and I agreed with your reasoning and updated the spec to stop proposing it. the spec was approved some time after that
16:16:35 dansmith sean-k-mooney: I dunno, I don't have a huge interest in reviewing that
16:16:41 melwitt *I did originally
16:16:57 dansmith melwitt: ack, I didn't remember, I thought you had kept that in.
16:21:05 melwitt artom: sorry I got vm status and host status mixed up. UNKNOWN vm status is for down cell only and was not changed as a result of my adding a host_status:unknown-only policy rule
16:22:01 artom melwitt, oh? So what happens when the host isn't reachable? We report the last recorded status from the DB?
16:22:29 melwitt artom: correct. only host status will say UNKNOWN
16:22:40 dansmith host_status on the instance gives you a sanitized "don't expect this instance to be actionable because the host is not healthy"
16:23:02 dansmith normally only admins can see info about hosts, so that field is the indicator to the user that "things are not as they appear" without exposing too much
16:23:28 melwitt artom: and host status is normally admin-only, so I added a new policy rule host_status:unknown-only that defaults to admin-only intended for operators who want to let non-admin users see UNKNOWN host status
16:24:23 melwitt host_status policy rule includes showing UP, DOWN, MAINTENANCE, UNKNOWN and host_status:unknown-only shows only UNKNOWN
16:24:46 artom melwitt, aha, thanks :) Can you find a link to that patch/spec/whatever?
16:24:59 melwitt artom: https://review.opendev.org/679181
16:34:06 sean-k-mooney dansmith: no worries. gibi and erric were the main reviews so im just thinking of who can take over form erric. when its ready ill add it to the runway list and see how is interested
16:43:42 gibi sean-k-mooney: the provider config series are also on my radar
16:44:05 evrardjp https://review.opendev.org/711950 has merged. Congratulations!
16:44:43 sean-k-mooney gibi: yep im adressing the feedback on the last patch currently
16:44:52 gibi sean-k-mooney: cool. thanks
16:45:11 sean-k-mooney ill take a look at the unit tests once i have that done
16:58:08 gibi cores, there is a trivial, functional test only change: https://review.opendev.org/#/c/713243/
17:21:50 openstackgerrit melanie witt proposed openstack/nova master: Follow-ups for host_status:unknown-only policy rule https://review.opendev.org/713295
17:23:30 openstackgerrit Merged openstack/nova master: Fix intermittently failing regression case https://review.opendev.org/713243
17:28:39 melwitt dansmith: pedantic correction to what I said earlier, the spec was abandoned bc it was decided to no longer need a spec when it became policy rule only. and then blueprint was approved after it became policy rule only
17:29:32 melwitt (in case you ever go looking at the spec and can't find it, like I just did)
17:29:44 melwitt *for
17:49:42 openstackgerrit John Garbutt proposed openstack/nova master: WIP: Tell oslo.limit how to count nova resources https://review.opendev.org/713301
17:49:42 openstackgerrit John Garbutt proposed openstack/nova master: WIP: Enforce resource limits using oslo.limit https://review.opendev.org/615180
17:54:46 melwitt gibi: I dunno if you saw my comment in https://review.opendev.org/712674 test just needs a tweak to handle kwarg vs positional arg
17:55:22 dansmith melwitt: heh okay..
17:57:16 melwitt just in case you opened it and went, hWHAT! abandoned! ?!?!
18:09:24 openstackgerrit Dan Smith proposed openstack/nova master: Remove non-optional kwarg for virt block_device_info https://review.opendev.org/713310
18:36:38 gibi melwitt: ack, now see it. thanks. I will get back to that tomorrow
18:38:18 melwitt gibi: k. I didn't want to update it, so I will be able to +2
18:39:46 gibi melwitt: sure
18:42:42 openstackgerrit Balazs Gibizer proposed openstack/nova master: [Community goal] Update contributor documentation https://review.opendev.org/712420
18:43:44 gibi stephenfin, brinzhang_: fixed the comments ^^
18:58:34 sean-k-mooney gibi are you done for the day or are you still around
18:59:42 gibi sean-k-mooney: I'm here for quick questions, not for longer things
19:00:17 sean-k-mooney gibi: its related to the provider.conf
19:00:48 sean-k-mooney basically the way i was asserting that the triats dont conflict with the virt driver traits does not quite work
19:01:16 sean-k-mooney what hapens is it works on the first iteration then fails on the second as the trait is already there
19:01:41 sean-k-mooney the end to end functional test you asked for found the issue
19:01:58 sean-k-mooney im just wonder what the best way to adress that is
19:03:16 sean-k-mooney gibi: this is what im doing which works fine for inventories as we start from scratch each time https://review.opendev.org/#/c/676522/44/nova/compute/resource_tracker.py@1751
19:03:42 sean-k-mooney but for taits we start with the traits from placment
19:03:55 sean-k-mooney i guess i need to think about it again
19:04:12 gibi sean-k-mooney: let me sleep on it
19:04:30 sean-k-mooney ya kno worries
19:04:53 gibi sean-k-mooney: can it be that we say CUSTOM traits are always overwritten by the provider config as we don't expect that a virt driver reports CUSTOM traits anyhiw
19:04:57 sean-k-mooney it might be as simple as if we have prover.yaml remove all custome triats
19:05:13 sean-k-mooney gibi: ya so i think that is what erric wanted
19:05:28 sean-k-mooney either you manage if form the api and dont use the provider.yaml
19:05:47 sean-k-mooney or you use the provider.yaml in which case we can reset the traits and build them up again
19:07:04 gibi sean-k-mooney: yeah, this make senese
19:07:07 gibi sense
19:07:11 sean-k-mooney ill give that a try if you think that is valid
19:07:18 gibi we just need to document it carefully
19:07:39 sean-k-mooney ya ok ill see if i can make that work and get back to you.
19:08:09 sean-k-mooney the pardes may be canceled but its still st patricks day tomorrow so ill be off until wednesday
19:09:40 gibi sean-k-mooney: sure. happy st patricks day!

Earlier   Later