Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-03-06
23:24:44 gmann you modified the deprecation stuff also ?
23:24:44 openstackgerrit Brin Zhang proposed openstack/nova master: Add new default roles in os-instance-actions policies https://review.opendev.org/706470
23:25:53 brinzhang gmann: no
23:26:32 brinzhang I rebased on your os-attach-interfaces patch
23:26:55 gmann ok, let's fix all those comments and then it should pass
23:27:06 brinzhang gmann: I was updated, you can review again
23:27:44 gmann what happen is, in your patch where you deprecated wrong policy rule, event policy is deprecated with admin_or_owner and so does non-admin was able to access the traceback of events
23:28:21 brinzhang gmann: I want to separate the GET interface, do you agree?
23:29:07 brinzhang add '**:list' and '***:show' to restrict the list and show API
23:29:08 gmann separate ?
23:29:40 gmann yeah, that is what i commented on review, we need granularity on those
23:30:14 brinzhang yes, I will follow up this later
23:30:40 brinzhang gmann: thanks, I know what I am confusing question.
23:31:17 gmann ohk.
23:31:48 brinzhang I think while johnthetubaguy week up, he will see that run success ^^
23:32:43 openstackgerrit melanie witt proposed openstack/nova master: Lowercase ironic driver hash ring and ignore case in cache https://review.opendev.org/711680
23:49:47 brinzhang gmann: if I granularity on the os-instance-actions GET (list/show) API, does need to add a releasenote?
23:51:12 brinzhang gmann: or you will add realeasenote for refresh default policy topic?
23:52:10 brinzhang I mean, in your end patch, you will summary this topic changes, and add a total realeasenote to record these changes?
#openstack-nova - 2020-03-07
01:22:15 openstackgerrit Brin Zhang proposed openstack/nova master: Granular GET os-instance-actions API policies https://review.opendev.org/711791
01:52:09 openstackgerrit Brin Zhang proposed openstack/nova master: Granular GET os-instance-actions API policies https://review.opendev.org/711791
02:09:07 brinzhang gmann, johnthetubaguy: I leave some comments in https://review.opendev.org/#/c/706470/9, I think we don't seem to be solving the problem
02:20:15 openstackgerrit Brin Zhang proposed openstack/nova master: nit: Fix NOTE error of fatal=False https://review.opendev.org/711794
07:24:08 brinzhang_ gmann, johnthetubaguy: https://review.opendev.org/#/c/706470/9 I paste my debug in http://paste.openstack.org/show/790438/
07:27:07 brinzhang_ gmann, johnthetubaguy: pls see this link http://paste.openstack.org/show/790439/, I am confusing why "context.can(ia_policies.BASE_POLICY_NAME % 'events', target={'project_id': instance.project_id}, fatal=False)" is not True, but the context user is admin
07:27:31 brinzhang_ Theoretically, it should be True
14:32:42 smcginnis In case anyone has the time to investigate, it looks like Nova has an issue with the latest alembic release.
14:32:45 smcginnis https://zuul.opendev.org/t/openstack/build/4042825ec9094eba85274db861fdd588
#openstack-nova - 2020-03-08
01:36:10 gmann brinzhang: I will add that with placeholder now.
02:00:35 brinzhang gmann: Yeah, thanks
17:58:36 openstackgerrit Merged openstack/nova master: Fix hypervisors paginted collection_name. https://review.opendev.org/709431
#openstack-nova - 2020-03-09
02:15:02 openstackgerrit Sundar Nadathur proposed openstack/nova master: ksa auth conf and client for Cyborg access https://review.opendev.org/631242
02:15:03 openstackgerrit Sundar Nadathur proposed openstack/nova master: Create and bind Cyborg ARQs. https://review.opendev.org/631244
02:15:03 openstackgerrit Sundar Nadathur proposed openstack/nova master: Add Cyborg device profile groups to request spec. https://review.opendev.org/631243
02:15:04 openstackgerrit Sundar Nadathur proposed openstack/nova master: Compose accelerator PCI devices into domain XML in libvirt driver. https://review.opendev.org/631245
02:15:04 openstackgerrit Sundar Nadathur proposed openstack/nova master: Pass accelerator requests to each virt driver from compute manager. https://review.opendev.org/698581
02:15:05 openstackgerrit Sundar Nadathur proposed openstack/nova master: Enable hard/soft reboot with accelerators. https://review.opendev.org/697940
02:15:05 openstackgerrit Sundar Nadathur proposed openstack/nova master: Delete ARQs for an instance when the instance is deleted. https://review.opendev.org/673735
02:15:06 openstackgerrit Sundar Nadathur proposed openstack/nova master: Enable and use COMPUTE_ACCELERATORS trait. https://review.opendev.org/699554
02:15:06 openstackgerrit Sundar Nadathur proposed openstack/nova master: Enable start/stop of instances with accelerators. https://review.opendev.org/699553
02:15:07 openstackgerrit Sundar Nadathur proposed openstack/nova master: Block unsupported instance operations with accelerators. https://review.opendev.org/674726
02:15:07 openstackgerrit Sundar Nadathur proposed openstack/nova master: Bump compute rpcapi version and reduce Cyborg calls. https://review.opendev.org/704227
02:15:08 openstackgerrit Sundar Nadathur proposed openstack/nova master: Add cyborg tempest job. https://review.opendev.org/670999
05:47:16 openstackgerrit Sundar Nadathur proposed openstack/nova master: Enable hard/soft reboot with accelerators. https://review.opendev.org/697940
05:47:16 openstackgerrit Sundar Nadathur proposed openstack/nova master: Delete ARQs for an instance when the instance is deleted. https://review.opendev.org/673735
05:47:17 openstackgerrit Sundar Nadathur proposed openstack/nova master: Enable and use COMPUTE_ACCELERATORS trait. https://review.opendev.org/699554
05:47:17 openstackgerrit Sundar Nadathur proposed openstack/nova master: Enable start/stop of instances with accelerators. https://review.opendev.org/699553
05:47:18 openstackgerrit Sundar Nadathur proposed openstack/nova master: Block unsupported instance operations with accelerators. https://review.opendev.org/674726
05:47:18 openstackgerrit Sundar Nadathur proposed openstack/nova master: Bump compute rpcapi version and reduce Cyborg calls. https://review.opendev.org/704227
05:47:19 openstackgerrit Sundar Nadathur proposed openstack/nova master: Add cyborg tempest job. https://review.opendev.org/670999
09:50:26 openstackgerrit John Garbutt proposed openstack/nova master: [Trivial] Fix code comment of admin password tests https://review.opendev.org/711734
09:57:48 openstackgerrit John Garbutt proposed openstack/nova master: libvirt: don't log error if guest gone during interface detach https://review.opendev.org/610727
10:08:01 openstackgerrit Luyao Zhong proposed openstack/nova master: address specific resources cleanup issue https://review.opendev.org/699148
10:08:01 openstackgerrit Luyao Zhong proposed openstack/nova master: bug-fix: Reject live migration with vpmem https://review.opendev.org/708110
10:08:02 openstackgerrit Luyao Zhong proposed openstack/nova master: Track orphan instances and error migrations in resource tracker https://review.opendev.org/678451
10:08:02 openstackgerrit Luyao Zhong proposed openstack/nova master: support live migration with vpmems https://review.opendev.org/687856
10:45:55 openstackgerrit Merged openstack/nova master: Introduce scope_types in os-deferred_delete https://review.opendev.org/707476
10:48:06 openstackgerrit Stephen Finucane proposed openstack/nova stable/train: Fix os-keypairs pagination links https://review.opendev.org/711895
10:49:10 openstackgerrit Stephen Finucane proposed openstack/nova stable/stein: Fix os-keypairs pagination links https://review.opendev.org/711896
10:49:58 openstackgerrit Stephen Finucane proposed openstack/nova stable/rocky: Fix os-keypairs pagination links https://review.opendev.org/711898
11:13:11 openstackgerrit Merged openstack/nova master: Add new default roles in os-deferred_delete policies https://review.opendev.org/707485
12:25:01 openstackgerrit Merged openstack/nova stable/train: Ensure source service is up before resizing/migrating https://review.opendev.org/701757
12:25:06 openstackgerrit Merged openstack/nova master: hyper-v: update support matrix https://review.opendev.org/711234
12:25:12 openstackgerrit Merged openstack/nova master: Fix os-keypairs pagination links https://review.opendev.org/711662
12:25:19 openstackgerrit Merged openstack/nova master: trivial: Rename directory for os-keypairs samples https://review.opendev.org/711663
12:25:26 openstackgerrit Merged openstack/nova master: Add new default roles in os-atttach-inerfaces policies https://review.opendev.org/706672
13:43:41 lyarwood stephenfin: https://review.opendev.org/#/c/706900/8/nova/virt/libvirt/driver.py@1987 - I'm flip flopping on this, do we really need to catch everything that could possibily go wrong here given I'm only going to reraise it anyway.
13:44:04 lyarwood stephenfin: LOG.exception() should also give enough debug detail for anyone looking at this during a failure right?
13:58:38 sean-k-mooney lyarwood: i think we have a decorator or context manager you can use if you are just going to catch and reraise.
13:58:49 sean-k-mooney havent looked at the patch
13:58:55 sean-k-mooney but that might be an option
13:59:46 lyarwood sean-k-mooney: yup using that already, this was more if I used be duplicating that for specific exceptions.
13:59:57 lyarwood s/used/should/g
14:54:42 openstackgerrit Stephen Finucane proposed openstack/nova master: trivial: Use 'import foo from bar' https://review.opendev.org/710235
14:56:05 openstackgerrit Stephen Finucane proposed openstack/nova master: trivial: Use 'from foo import bar' https://review.opendev.org/710235
14:56:19 sean-k-mooney hehe
14:56:32 sean-k-mooney yes that is a better summary line
15:03:23 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Correctly resize encrypted LUKSv1 volumes https://review.opendev.org/706900
15:17:42 openstackgerrit Stephen Finucane proposed openstack/nova master: DNM: Add reproducer for subunit parser error https://review.opendev.org/700522
15:26:41 Sundar Hi gibi, whenever you have some time, could we discuss https://review.opendev.org/#/c/631243/60/nova/tests/fixtures.py@2538 ?
15:28:03 gibi Sundar: give me 5 mins to gather context
15:28:26 Sundar gibi: Sure
15:32:34 gibi Sundar: OK. I think if only the fixture issue remains then I'm fine not refactoring the fixture right now.
15:33:00 gibi I do have to re-review your patches as I see now that you updated them
15:34:27 Sundar gibi: Sure, of course. Just wanted to see if you are ok with my response. I'll wait for your reviews. Thanks!
15:34:49 gibi Sundar: yeah, I'm OK with your response regarding the Fixture
15:35:30 gibi Sundar: I will try to do the review tomorrow
15:41:46 openstackgerrit Merged openstack/nova master: trivial: Use 'from foo import bar' https://review.opendev.org/710235
16:05:08 openstackgerrit Jason Anderson proposed openstack/nova master: Use fair locks in resource tracker https://review.opendev.org/711528
16:34:28 melwitt gibi: if you're around, would like to know your thoughts on the above patch ^ re: test coverage. there doesn't seem to be a great way to verify the addition of fair=True to the synchronized decorators ... wondering if there is a good way to test it that you might know and if not, what do you think about accepting the patch without any test coverage for that?
16:36:09 gibi melwitt: could you please link the patch again, I missed the link during a client restart
16:37:13 melwitt gibi: oops sorry, here https://review.opendev.org/711528
16:39:25 gibi melwitt: so basically the test should enforce that all the utils.synchronized decorators in nova are created with fair=True ?
16:40:48 gibi I think I can hack someting up for that. But if we want to be selective about when to use fair=True then that might be a harder problem
16:40:55 sean-k-mooney does it make sense to set fair=false?
16:41:13 melwitt gibi: not all in nova but only the ones in nova/compute/resource_tracker.py and yes, I was thinking something that checks whether any use of it is with fair=True. I tried for awhile to mock patch the decorator as a wrapper and check the args but it failed miserably because there was something I was missing
16:41:36 sean-k-mooney melwitt: gibi mabye a hacking check would be better
16:41:53 gibi hacking could be a way if this rule is module specific
16:42:23 gibi sorry I have to drop off but I will look back tomorrow morning
16:42:31 melwitt thanks gibi

Earlier   Later