Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-03-06
17:25:02 openstackgerrit John Garbutt proposed openstack/nova master: WIP: Enforce unified limits using oslo.limit https://review.opendev.org/615180
17:26:20 gibi dansmith: it was the train PTG where we decided to go for the move support without microversion bumps. I made a mistake not change the error messages to not forcast such bum
17:26:24 gibi p
17:26:32 gibi anyhow I will work on the service level check
17:26:36 gibi thanks for the review
17:26:36 dansmith ack
17:38:42 openstackgerrit Lee Yarwood proposed openstack/nova master: WIP images: Make JSON the default output format of calls to qemu-img info https://review.opendev.org/711679
17:44:50 openstackgerrit melanie witt proposed openstack/nova master: Add logging of ironic driver hash ring to aid in debugging https://review.opendev.org/711680
17:47:38 melwitt dansmith: do you think ^ is a reasonable or did you think lower()ing names in the hash ring is something we should also do?
17:48:07 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-atttach-inerfaces policies https://review.opendev.org/706672
17:49:18 dansmith melwitt: I think we probably need to lower() the things we put into the hash ring
17:49:36 dansmith potentially checking for conflicts that would only arise due to case might be prudent,
17:49:58 dansmith but I can't imagine differing-only-by-case is anything other than a point of confusion for people
17:50:32 melwitt yeah, that's what I was wondering
17:50:53 melwitt wondering/thinking
17:50:58 melwitt thanks
17:54:21 gmann johnthetubaguy: brinzhang this is issue, you used same policy rule with two different check_str - https://review.opendev.org/#/c/706470/8/nova/policies/instance_actions.py@31
17:55:00 gmann so basically event policy has deprecation of admin_or_owner depends on order it goes in oslo policy
18:18:39 openstackgerrit melanie witt proposed openstack/nova master: Lowercase ironic driver hash ring hosts and add logging https://review.opendev.org/711680
18:19:27 melwitt dansmith: updated ^
18:26:22 melwitt also TheJulia or jroll fyi ^
18:27:00 TheJulia melwitt: I'll take a look after I'm done cooking my wifey some lunch
18:27:09 melwitt heh k
18:29:07 openstackgerrit Ghanshyam Mann proposed openstack/nova master: [Trivial] Fix code comment of admin password tests https://review.opendev.org/711734
19:00:06 jroll melwitt: nice, thanks
19:00:21 melwitt thanks for reviewing!
19:02:19 openstackgerrit Merged openstack/nova master: Name Enums https://review.opendev.org/708707
19:32:01 melwitt thanks for the review TheJulia !
19:32:39 TheJulia So turns out, someone renaming a conductor would also do some... bad things
19:32:44 TheJulia but only lock individual machines
19:43:47 melwitt TheJulia: good thinkin to go check that
19:50:29 openstackgerrit Merged openstack/nova master: Fix os-create-backup policy to be admin_or_owner https://review.opendev.org/706727
19:50:36 openstackgerrit Merged openstack/nova master: Add test coverage of existing create_backup policies https://review.opendev.org/706726
19:53:17 openstackgerrit Merged openstack/nova master: Introduce scope_types in os-create-backup https://review.opendev.org/707038
19:53:24 openstackgerrit Merged openstack/nova master: Add new default roles in os-create-backup policies https://review.opendev.org/707039
19:56:16 mloza How can I allow member to see the OS-EXT-SRV-ATTR of the instance ?
20:06:02 mloza Nvm. I found it nova policy.json
20:45:13 donnyd need to re-create the flavor for multi-numa - does anyone remember what meta-data was needed for the NFV jobs besides sean-k-mooney
22:40:07 brinzhang gmann: So https://review.opendev.org/#/c/706470/8/nova/policies/instance_actions.py@29 is why the functional-py36 failed?
22:44:35 brinzhang gmann: you are right, thanks.
22:44:57 brinzhang gmann: but I have a question, why we dont need https://review.opendev.org/#/c/706470/8/nova/tests/unit/fake_policy.py@49 this fake policy?
23:20:20 gmann brinzhang: it is needed, i am saying that policy should have exist before as that was old policy but somehow we missed
23:22:46 brinzhang gmann: but, if I keep this policy in fake, the functional-py36 failed too(same issue), otherwise it will run success.
23:23:35 brinzhang gmann: that's why I dont understand why I must delete it
23:24:22 gmann brinzhang: fake policy make all the policy accessible to everyone so that tests can verify the things without worry about right policy allowablecontext
23:24:43 openstackgerrit Brin Zhang proposed openstack/nova master: Add new default roles in os-atttach-inerfaces policies https://review.opendev.org/706672
23:24:44 gmann you modified the deprecation stuff also ?
23:24:44 openstackgerrit Brin Zhang proposed openstack/nova master: Add new default roles in os-instance-actions policies https://review.opendev.org/706470
23:25:53 brinzhang gmann: no
23:26:32 brinzhang I rebased on your os-attach-interfaces patch
23:26:55 gmann ok, let's fix all those comments and then it should pass
23:27:06 brinzhang gmann: I was updated, you can review again
23:27:44 gmann what happen is, in your patch where you deprecated wrong policy rule, event policy is deprecated with admin_or_owner and so does non-admin was able to access the traceback of events
23:28:21 brinzhang gmann: I want to separate the GET interface, do you agree?
23:29:07 brinzhang add '**:list' and '***:show' to restrict the list and show API
23:29:08 gmann separate ?
23:29:40 gmann yeah, that is what i commented on review, we need granularity on those
23:30:14 brinzhang yes, I will follow up this later
23:30:40 brinzhang gmann: thanks, I know what I am confusing question.
23:31:17 gmann ohk.
23:31:48 brinzhang I think while johnthetubaguy week up, he will see that run success ^^
23:32:43 openstackgerrit melanie witt proposed openstack/nova master: Lowercase ironic driver hash ring and ignore case in cache https://review.opendev.org/711680
23:49:47 brinzhang gmann: if I granularity on the os-instance-actions GET (list/show) API, does need to add a releasenote?
23:51:12 brinzhang gmann: or you will add realeasenote for refresh default policy topic?
23:52:10 brinzhang I mean, in your end patch, you will summary this topic changes, and add a total realeasenote to record these changes?
#openstack-nova - 2020-03-07
01:22:15 openstackgerrit Brin Zhang proposed openstack/nova master: Granular GET os-instance-actions API policies https://review.opendev.org/711791
01:52:09 openstackgerrit Brin Zhang proposed openstack/nova master: Granular GET os-instance-actions API policies https://review.opendev.org/711791
02:09:07 brinzhang gmann, johnthetubaguy: I leave some comments in https://review.opendev.org/#/c/706470/9, I think we don't seem to be solving the problem
02:20:15 openstackgerrit Brin Zhang proposed openstack/nova master: nit: Fix NOTE error of fatal=False https://review.opendev.org/711794
07:24:08 brinzhang_ gmann, johnthetubaguy: https://review.opendev.org/#/c/706470/9 I paste my debug in http://paste.openstack.org/show/790438/
07:27:07 brinzhang_ gmann, johnthetubaguy: pls see this link http://paste.openstack.org/show/790439/, I am confusing why "context.can(ia_policies.BASE_POLICY_NAME % 'events', target={'project_id': instance.project_id}, fatal=False)" is not True, but the context user is admin
07:27:31 brinzhang_ Theoretically, it should be True
14:32:42 smcginnis In case anyone has the time to investigate, it looks like Nova has an issue with the latest alembic release.
14:32:45 smcginnis https://zuul.opendev.org/t/openstack/build/4042825ec9094eba85274db861fdd588
#openstack-nova - 2020-03-08
01:36:10 gmann brinzhang: I will add that with placeholder now.
02:00:35 brinzhang gmann: Yeah, thanks
17:58:36 openstackgerrit Merged openstack/nova master: Fix hypervisors paginted collection_name. https://review.opendev.org/709431
#openstack-nova - 2020-03-09
02:15:02 openstackgerrit Sundar Nadathur proposed openstack/nova master: ksa auth conf and client for Cyborg access https://review.opendev.org/631242
02:15:03 openstackgerrit Sundar Nadathur proposed openstack/nova master: Create and bind Cyborg ARQs. https://review.opendev.org/631244
02:15:03 openstackgerrit Sundar Nadathur proposed openstack/nova master: Add Cyborg device profile groups to request spec. https://review.opendev.org/631243
02:15:04 openstackgerrit Sundar Nadathur proposed openstack/nova master: Compose accelerator PCI devices into domain XML in libvirt driver. https://review.opendev.org/631245
02:15:04 openstackgerrit Sundar Nadathur proposed openstack/nova master: Pass accelerator requests to each virt driver from compute manager. https://review.opendev.org/698581
02:15:05 openstackgerrit Sundar Nadathur proposed openstack/nova master: Enable hard/soft reboot with accelerators. https://review.opendev.org/697940
02:15:05 openstackgerrit Sundar Nadathur proposed openstack/nova master: Delete ARQs for an instance when the instance is deleted. https://review.opendev.org/673735
02:15:06 openstackgerrit Sundar Nadathur proposed openstack/nova master: Enable and use COMPUTE_ACCELERATORS trait. https://review.opendev.org/699554
02:15:06 openstackgerrit Sundar Nadathur proposed openstack/nova master: Enable start/stop of instances with accelerators. https://review.opendev.org/699553
02:15:07 openstackgerrit Sundar Nadathur proposed openstack/nova master: Block unsupported instance operations with accelerators. https://review.opendev.org/674726
02:15:07 openstackgerrit Sundar Nadathur proposed openstack/nova master: Bump compute rpcapi version and reduce Cyborg calls. https://review.opendev.org/704227
02:15:08 openstackgerrit Sundar Nadathur proposed openstack/nova master: Add cyborg tempest job. https://review.opendev.org/670999
05:47:16 openstackgerrit Sundar Nadathur proposed openstack/nova master: Enable hard/soft reboot with accelerators. https://review.opendev.org/697940
05:47:16 openstackgerrit Sundar Nadathur proposed openstack/nova master: Delete ARQs for an instance when the instance is deleted. https://review.opendev.org/673735
05:47:17 openstackgerrit Sundar Nadathur proposed openstack/nova master: Enable and use COMPUTE_ACCELERATORS trait. https://review.opendev.org/699554
05:47:17 openstackgerrit Sundar Nadathur proposed openstack/nova master: Enable start/stop of instances with accelerators. https://review.opendev.org/699553
05:47:18 openstackgerrit Sundar Nadathur proposed openstack/nova master: Block unsupported instance operations with accelerators. https://review.opendev.org/674726
05:47:18 openstackgerrit Sundar Nadathur proposed openstack/nova master: Bump compute rpcapi version and reduce Cyborg calls. https://review.opendev.org/704227
05:47:19 openstackgerrit Sundar Nadathur proposed openstack/nova master: Add cyborg tempest job. https://review.opendev.org/670999
09:50:26 openstackgerrit John Garbutt proposed openstack/nova master: [Trivial] Fix code comment of admin password tests https://review.opendev.org/711734
09:57:48 openstackgerrit John Garbutt proposed openstack/nova master: libvirt: don't log error if guest gone during interface detach https://review.opendev.org/610727
10:08:01 openstackgerrit Luyao Zhong proposed openstack/nova master: address specific resources cleanup issue https://review.opendev.org/699148
10:08:01 openstackgerrit Luyao Zhong proposed openstack/nova master: bug-fix: Reject live migration with vpmem https://review.opendev.org/708110

Earlier   Later