Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-03-06
16:47:37 gibi dansmith: if you are in a reviewing mood then the last pieces of the qos bp needs a second core https://review.opendev.org/#/q/status:open+bp/support-move-ops-with-qos-ports-ussuri
16:48:14 dansmith gibi: I'm in a -1ing mood.. do you want to take that gamble? :D
16:49:05 gibi dansmith: if it is as valid -1 as on the graceful shutdown patch then please go ahead
17:03:15 openstackgerrit Stephen Finucane proposed openstack/nova master: Fix os-keypairs pagination links https://review.opendev.org/711662
17:03:16 openstackgerrit Stephen Finucane proposed openstack/nova master: trivial: Rename directory for os-keypairs samples https://review.opendev.org/711663
17:03:17 stephenfin gibi: ^
17:03:28 stephenfin (second one's just a nice-to-have)
17:03:43 gibi stephenfin: thanks, looking
17:04:33 openstackgerrit Stephen Finucane proposed openstack/nova stable/train: Fix hypervisors paginted collection_name. https://review.opendev.org/711664
17:05:00 openstackgerrit Stephen Finucane proposed openstack/nova stable/train: Fix hypervisors paginted collection_name. https://review.opendev.org/711664
17:05:08 dansmith gibi: https://review.opendev.org/#/c/705475/4/nova/api/openstack/common.py
17:08:02 openstackgerrit Stephen Finucane proposed openstack/nova stable/stein: Fix hypervisors paginted collection_name. https://review.opendev.org/711669
17:08:48 openstackgerrit Stephen Finucane proposed openstack/nova stable/rocky: Fix hypervisors paginted collection_name. https://review.opendev.org/711670
17:11:59 gibi dansmith: so you mean we need a service version bump even without RPC change.
17:12:29 dansmith gibi: you're depending on a behavior change on the compute nodes from the api node.. even though there's not an RPC signature change, you don't know when/if those computes can do what you're asking
17:14:45 gibi dansmith: yeah. you are right. without the compute side change the port binding won't be updated during unshelve.
17:15:18 dansmith this is really *why* we have service version.. the tie to RPC just makes it easier to ensure we can also look up rpc versions for auto pinning
17:16:40 gibi dansmith: in theory it would be the goal of the scheduler to select a host during unshelve that is capable of supporting the server with qos port
17:17:09 dansmith yeah, you could enforce it there too, but that seems messy-er
17:17:13 gibi dansmith: would it be a compute host capability?
17:17:26 dansmith you'd basically need a new filter or a trait
17:17:42 dansmith we're doing the trait approach for cyborg because it's more than just newness that we're looking for
17:18:04 dansmith so yeah, if you want to go that route that's fine, but it'd be a lot simpler to just do the service version :)
17:18:12 gibi dansmith: another option is global compute service level check in the api
17:18:24 gibi which do seems easier
17:18:33 dansmith yeah, that's what I was suggesting.. gobal check
17:18:49 dansmith meaning, api keeps it disabled until everything is upgraded, which is the more common way we do this kind of thing
17:18:57 gibi OK. I get it. global check it is
17:19:09 dansmith basically replace your "return False" with "return $version >= $minimum"
17:19:37 gibi yepp
17:20:39 gibi regarding microversion bump. I think that ship is sailed when we enabled migrate, resize, evac and live migrate support for qos without microversion bump
17:21:03 gibi it would be equally weird to bump now
17:24:13 dansmith ack, that's why I didn't -1
17:24:18 dansmith I figured there was context I was missing
17:24:26 dansmith and you did say in a comment "if we decide to do so"
17:24:34 dansmith so I figured....you (all) decided
17:25:02 openstackgerrit John Garbutt proposed openstack/nova master: WIP: Enforce unified limits using oslo.limit https://review.opendev.org/615180
17:26:20 gibi dansmith: it was the train PTG where we decided to go for the move support without microversion bumps. I made a mistake not change the error messages to not forcast such bum
17:26:24 gibi p
17:26:32 gibi anyhow I will work on the service level check
17:26:36 gibi thanks for the review
17:26:36 dansmith ack
17:38:42 openstackgerrit Lee Yarwood proposed openstack/nova master: WIP images: Make JSON the default output format of calls to qemu-img info https://review.opendev.org/711679
17:44:50 openstackgerrit melanie witt proposed openstack/nova master: Add logging of ironic driver hash ring to aid in debugging https://review.opendev.org/711680
17:47:38 melwitt dansmith: do you think ^ is a reasonable or did you think lower()ing names in the hash ring is something we should also do?
17:48:07 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-atttach-inerfaces policies https://review.opendev.org/706672
17:49:18 dansmith melwitt: I think we probably need to lower() the things we put into the hash ring
17:49:36 dansmith potentially checking for conflicts that would only arise due to case might be prudent,
17:49:58 dansmith but I can't imagine differing-only-by-case is anything other than a point of confusion for people
17:50:32 melwitt yeah, that's what I was wondering
17:50:53 melwitt wondering/thinking
17:50:58 melwitt thanks
17:54:21 gmann johnthetubaguy: brinzhang this is issue, you used same policy rule with two different check_str - https://review.opendev.org/#/c/706470/8/nova/policies/instance_actions.py@31
17:55:00 gmann so basically event policy has deprecation of admin_or_owner depends on order it goes in oslo policy
18:18:39 openstackgerrit melanie witt proposed openstack/nova master: Lowercase ironic driver hash ring hosts and add logging https://review.opendev.org/711680
18:19:27 melwitt dansmith: updated ^
18:26:22 melwitt also TheJulia or jroll fyi ^
18:27:00 TheJulia melwitt: I'll take a look after I'm done cooking my wifey some lunch
18:27:09 melwitt heh k
18:29:07 openstackgerrit Ghanshyam Mann proposed openstack/nova master: [Trivial] Fix code comment of admin password tests https://review.opendev.org/711734
19:00:06 jroll melwitt: nice, thanks
19:00:21 melwitt thanks for reviewing!
19:02:19 openstackgerrit Merged openstack/nova master: Name Enums https://review.opendev.org/708707
19:32:01 melwitt thanks for the review TheJulia !
19:32:39 TheJulia So turns out, someone renaming a conductor would also do some... bad things
19:32:44 TheJulia but only lock individual machines
19:43:47 melwitt TheJulia: good thinkin to go check that
19:50:29 openstackgerrit Merged openstack/nova master: Fix os-create-backup policy to be admin_or_owner https://review.opendev.org/706727
19:50:36 openstackgerrit Merged openstack/nova master: Add test coverage of existing create_backup policies https://review.opendev.org/706726
19:53:17 openstackgerrit Merged openstack/nova master: Introduce scope_types in os-create-backup https://review.opendev.org/707038
19:53:24 openstackgerrit Merged openstack/nova master: Add new default roles in os-create-backup policies https://review.opendev.org/707039
19:56:16 mloza How can I allow member to see the OS-EXT-SRV-ATTR of the instance ?
20:06:02 mloza Nvm. I found it nova policy.json
20:45:13 donnyd need to re-create the flavor for multi-numa - does anyone remember what meta-data was needed for the NFV jobs besides sean-k-mooney
22:40:07 brinzhang gmann: So https://review.opendev.org/#/c/706470/8/nova/policies/instance_actions.py@29 is why the functional-py36 failed?
22:44:35 brinzhang gmann: you are right, thanks.
22:44:57 brinzhang gmann: but I have a question, why we dont need https://review.opendev.org/#/c/706470/8/nova/tests/unit/fake_policy.py@49 this fake policy?
23:20:20 gmann brinzhang: it is needed, i am saying that policy should have exist before as that was old policy but somehow we missed
23:22:46 brinzhang gmann: but, if I keep this policy in fake, the functional-py36 failed too(same issue), otherwise it will run success.
23:23:35 brinzhang gmann: that's why I dont understand why I must delete it
23:24:22 gmann brinzhang: fake policy make all the policy accessible to everyone so that tests can verify the things without worry about right policy allowablecontext
23:24:43 openstackgerrit Brin Zhang proposed openstack/nova master: Add new default roles in os-atttach-inerfaces policies https://review.opendev.org/706672
23:24:44 gmann you modified the deprecation stuff also ?
23:24:44 openstackgerrit Brin Zhang proposed openstack/nova master: Add new default roles in os-instance-actions policies https://review.opendev.org/706470
23:25:53 brinzhang gmann: no
23:26:32 brinzhang I rebased on your os-attach-interfaces patch
23:26:55 gmann ok, let's fix all those comments and then it should pass
23:27:06 brinzhang gmann: I was updated, you can review again
23:27:44 gmann what happen is, in your patch where you deprecated wrong policy rule, event policy is deprecated with admin_or_owner and so does non-admin was able to access the traceback of events
23:28:21 brinzhang gmann: I want to separate the GET interface, do you agree?
23:29:07 brinzhang add '**:list' and '***:show' to restrict the list and show API
23:29:08 gmann separate ?
23:29:40 gmann yeah, that is what i commented on review, we need granularity on those
23:30:14 brinzhang yes, I will follow up this later
23:30:40 brinzhang gmann: thanks, I know what I am confusing question.
23:31:17 gmann ohk.
23:31:48 brinzhang I think while johnthetubaguy week up, he will see that run success ^^
23:32:43 openstackgerrit melanie witt proposed openstack/nova master: Lowercase ironic driver hash ring and ignore case in cache https://review.opendev.org/711680
23:49:47 brinzhang gmann: if I granularity on the os-instance-actions GET (list/show) API, does need to add a releasenote?
23:51:12 brinzhang gmann: or you will add realeasenote for refresh default policy topic?

Earlier   Later