Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-03-04
14:27:19 gibi will be off tomorrow but I will check back on Firday
14:28:21 gibi I still left some comments and questions
14:28:27 lyarwood stephenfin: https://review.opendev.org/#/c/666915/ - did you see my review here btw, I think it's just a docs nit really but I might be missing something.
14:36:58 redrobot Hi Nova friends! I'm still looking for one more review on https://review.opendev.org/#/c/680562/
14:38:49 lyarwood efried: https://review.opendev.org/#/c/669121/ - blast from the past but this should be good to land now if you have time to review again.
14:40:52 rishabhhpe Hello All, can anyone please help me on above problem i raised
14:41:01 lyarwood redrobot: The people in this channel don't directly control that project, #puppet-openstack is where you will find them. I've +1'd anyway.
14:41:51 redrobot got it, thanks lyarwood!
14:58:50 openstackgerrit Lee Yarwood proposed openstack/nova master: DNM - Test TEMPEST_EXTEND_ATTACHED_ENCRYPTED_VOLUME https://review.opendev.org/707593
15:25:01 lyarwood https://review.opendev.org/#/c/711211/ - any non-RH cores able to review this fix, appears we are randomly hitting it in the gate at the moment.
15:26:58 stephenfin lyarwood: yup, just hadn't gotten to it now. Will do so before EOD
15:27:03 stephenfin *to it before now
15:27:26 lyarwood stephenfin: ack np
15:27:48 openstackgerrit Stephen Finucane proposed openstack/nova stable/train: Unplug VIFs as part of cleanup of networks https://review.opendev.org/711251
15:27:48 openstackgerrit Stephen Finucane proposed openstack/nova stable/train: Functional test for UnexpectedDeletingTaskStateError https://review.opendev.org/711210
15:27:49 stephenfin meanwhile, care to review these incoming patches? Have the affected functional and unit tests passing now
15:27:58 stephenfin *those (bad timing)
15:28:10 lyarwood yup of course
15:35:56 efried lyarwood: If you want to tweak the commit message, I'll fast approve. If you want to twiddle some of those other things at the same time, ditto (none of them impact logic).
15:37:02 efried lyarwood: gate fix +A
15:38:39 lyarwood efried: thanks, I'll respin the LUKS compat change now.
15:40:45 efried lyarwood: tbc, the only thing that *needs* to be fixed in the commit message is the name of the renamed helper function.
15:49:35 lyarwood efried: ack I'll just update that quickly then
15:50:06 efried lyarwood: ight. The other things (renames of test cases) could be done in a fup
15:50:08 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Remove native LUKS compat code https://review.opendev.org/669121
15:50:54 efried +A
16:04:46 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: FUP I41b7c1653c6a887ee4b08e588c5d422409aebfba https://review.opendev.org/711262
16:04:47 lyarwood efried: ack thanks again
16:09:21 kukacz_ hello, any idea what might be wrong with instance being unshelved on a host ignoring AggregateInstanceExtraSpecsFilter ? it seems to only happen to instances created before the filtering params were applied on instance types.
16:19:19 dansmith kukacz_: yeah, that's expected
16:19:41 dansmith kukacz_: when you boot an instance the flavor is crystalized into the instance to insulate it from further changes to the flavor
16:23:47 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: libvirt: Add methods to detect firmware auto-selection and SB https://review.opendev.org/682627
16:23:47 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: libvirt: Parse the 'os' element from domainCapabilities https://review.opendev.org/673790
16:25:43 kukacz_ dansmith: aha. and is there some method how could I push flavor params to existing instances too?
16:25:54 dansmith kukacz_: nope
16:26:07 dansmith kukacz_: you could snapshot and then re-deploy them with the new flavor, but that's about it
16:31:17 kukacz_ dansmith: hmm, that's bad. then it seems I don't have a method to safely prevent non-ssd instances being scheduled on ssd node - thinking the classic example used in Nova docs for ages: https://docs.openstack.org/nova/queens/admin/configuration/schedulers.html
16:31:54 dansmith kukacz_: nova is optimized for cattle, not pets
16:32:48 dansmith if you're on something new enough you could potentially use the new isolated aggregates thing for your ssd aggregate
16:34:20 kukacz_ dansmith: just for my curiosity - how does the pets/cattle apply in this case?
16:34:52 dansmith kukacz: it's a pet if you can't shoot it in the head and boot another one in its place
16:35:20 dansmith https://docs.openstack.org/nova/latest/reference/isolate-aggregates.html
16:37:37 dansmith also if you're willing to shelve/unshelve, you could just resize those instances to a flavor that has the new key in it
16:38:56 kukacz_ dansmith: unfortunately, this is queens. isolated aggregates seem to be from rocky
16:39:13 dansmith train actually
16:39:53 kukacz_ dansmith: yes, the resize method is something I was just thinking of. probably a way to go. but it's not my workload. I'll have to ask many customers to follow that rule
16:40:03 dansmith yup
16:50:48 kukacz_ dansmith: one more detail - how is the original set of flavor parameters stored for each instance? in nova.instances table I see instance_type_id pointing at the current flavor. it must be something else, I guess ...
16:51:23 dansmith kukacz_: it's a serialized json blob in instance_extra.flavor
16:51:52 kukacz_ dansmith: aha!
16:51:59 kukacz_ dansmith: thank you a lot for all the clarification!
16:52:18 dansmith kukacz_: how come you're willing to shelve something but not resize it? resize should be faster and less disturbing to the workload
16:54:24 kukacz_ dansmith: it's not problem of willingness to resize. it's just that our customers use shelving to pause billing on temporarily stopped instances. now we'll have to explain them, that they'll also need to issue resize call to avoid their instance end up running on hosts where we don't want them to be
16:55:09 dansmith oh okay I thought maybe you were shelving proactively
16:56:19 openstackgerrit Lee Yarwood proposed openstack/nova stable/train: libvirt: Ignore DiskNotFound during update_available_resource https://review.opendev.org/711276
16:57:06 openstackgerrit Lee Yarwood proposed openstack/nova stable/stein: libvirt: Ignore DiskNotFound during update_available_resource https://review.opendev.org/711277
16:57:32 openstackgerrit Lee Yarwood proposed openstack/nova stable/rocky: libvirt: Ignore DiskNotFound during update_available_resource https://review.opendev.org/711278
16:58:04 openstackgerrit Lee Yarwood proposed openstack/nova stable/queens: libvirt: Ignore DiskNotFound during update_available_resource https://review.opendev.org/711279
16:58:06 melwitt stephenfin: what made you think https://review.opendev.org/711093 is blocking the gate?
16:58:54 stephenfin melwitt: We're referencing a module that's been deleted so we're broken with the latest version of oslo.db, no?
16:58:54 melwitt it was just a heads up about an upcoming requirements update and should get normal review
16:59:09 stephenfin ah, crap. I didn't realize it was pre-emptive
16:59:25 stephenfin I'll pull it out of the queue
16:59:31 melwitt yeah but I don't think the change to the latest happened yet, it's proposed. this is a standard thing that happens when requirements team looks to bump things
16:59:48 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove oslo_db.sqlalchemy.compat reference https://review.opendev.org/711093
16:59:55 kukacz_ dansmith: no, as a service provider I mostly cannot touch customer instances, they manipulate them themselves
17:00:26 stephenfin melwitt: Gotcha. Yeah, sorry, missed that. Dragged it out ^
17:41:08 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Use domain capabilities to get supported device models https://review.opendev.org/666915
17:41:09 openstackgerrit Stephen Finucane proposed openstack/nova master: Add transform_image_metadata request filter https://review.opendev.org/665775
18:56:50 ozzzo can anyone help me set set pointer_model to None in nova.conf?
18:57:02 openstack Launchpad bug 1866106 in OpenStack Compute (nova) "Can't set "pointer_model = None" in nova.conf" [Undecided,New]
18:57:02 ozzzo it appears to be a bug; I opened https://bugs.launchpad.net/nova/+bug/1866106
18:57:20 ozzzo the help text in nova.conf says to use None or <None> but nova errors on both
18:57:32 ozzzo ERROR nova ConfigFileValueError: Value for option pointer_model is not valid: Valid values are [None, ps2mouse, usbtablet], but found 'None'
18:57:57 ozzzo I tried leaving it blank but that fails also
18:58:29 ozzzo the underlying issue is that I need to not load the USB and PS2 drivers to build large-RAM Centos VMs, because Centos chokes while loading drivers on VMs with over 1064304G RAM
19:06:58 melwitt ozzzo: I agree that looks like a bug. the choice should instead be 'none' (I see several other examples, especially in nova/conf/libvirt.py) and handled accordingly in the code. I think the StrOpt won't ever recognize None as a non-string 'None'
19:07:49 ozzzo ok trying none
19:08:08 melwitt ozzzo: I mean I think you'll need a patch to do it
19:08:15 ozzzo oic ok
19:08:38 melwitt it needs to be fixed in order for you to choose none
19:10:08 melwitt lemme see if I can propose one real quick for you
19:10:23 ozzzo ok cool thank you!
19:10:44 melwitt thanks for opening the bug and letting us know
19:11:02 ozzzo no problem, my users are screaming for giant memory Centos VMs
19:11:03 mriedem the config is coercing None to 'None'
19:11:14 ozzzo I'm trying to get them to use Ironic instead but they don't want to
19:11:45 mriedem seems like that might be a bug in oslo.config rather than nova
19:13:07 ozzzo should I ask in their IRC channel?
19:13:48 bnemec The only way for a config opt to have a None value is for that to be the default and for the opt to be unset.
19:14:14 bnemec So completely absent from the file, not something like "opt="
19:14:18 mriedem bingo https://github.com/openstack/oslo.config/blob/master/oslo_config/types.py#L142
19:14:29 mriedem yeah the default is usbtablet
19:14:34 mriedem so you can't unset it to avoid the default
19:14:53 ozzzo am I on the right track; will setting this to none stop the USB driver from loading?
19:15:12 mriedem so you're looking at what? default being None, but then checking to see if the option is explicitly set to None or default to 'usbtablet' if not set to None explicitly?
19:15:39 ozzzo or is there a better way to not load USB?
19:16:11 mriedem bnemec: couldn't oslo.config just fix this line? https://github.com/openstack/oslo.config/blob/master/oslo_config/types.py#L142
19:16:23 mriedem if value is None and None is a valid choice and not the default, then don't coerce to 'None'
19:18:19 bnemec I don't think it would help. I'm pretty sure the argument parser will never return None, it will return a string "None" anyway.

Earlier   Later