| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-02-26 | |||
| 19:51:19 | openstackgerrit | Lee Yarwood proposed openstack/nova master: DNM - Test stable device rescue tests with BFV instances https://review.opendev.org/710050 | |
| 19:53:41 | lucidguy | sean-k-mooney: By default instances are launched with 40bit cpu memory address space, that does not allow for >1tb memory in an instances. qemu on Ubuntu 18.04 allow to choose a machine architecture that maps the instances address space with the local HV which is 46bits. In the end of the day all I had to do is upgrade to 18.04(Bionic) and add one line to nova.conf on the HV. | |
| 20:08:10 | openstackgerrit | sean mooney proposed openstack/nova master: Provider Config File: YAML file loading and schema validation https://review.opendev.org/673341 | |
| 20:20:20 | sean-k-mooney | lucidguy: ah yes that makes sense | |
| 20:20:40 | sean-k-mooney | intel cpus only recently went to 48bit adress space | |
| 20:21:07 | sean-k-mooney | so im nost surpiesed the same limiation of reduced adress space was present for vms | |
| 20:21:48 | sean-k-mooney | lucidguy: did you fix it by changing the machine type to q35? | |
| 20:22:02 | sean-k-mooney | lucidguy: or did you add something else to the nova.conf | |
| 20:22:11 | sean-k-mooney | for example the cpu_model? | |
| 20:23:25 | sean-k-mooney | also a stackdump is not an approriate way of telling the enduser that you need to change somthing like that | |
| 20:23:46 | sean-k-mooney | i hope they have adressed that in a future version of qemu/kvm | |
| 20:24:40 | sean-k-mooney | gibi: efried: i tried to keep my changes in https://review.opendev.org/#/c/673341/ as minimal as possible while adressing the comments. | |
| 20:25:32 | sean-k-mooney | i will try to get through the other patches in the series tommorow. there were some race condition in the test code that took me a while to figure out | |
| 20:25:48 | sean-k-mooney | they are fixed now | |
| 23:11:23 | efried | sean-k-mooney: Earlier, we were toying with cutting cyborg over to using sdk instead of ksa. We held off because there were a couple more quirks to be ironed out. It's possible sdk would automatically refresh the token for us -- mordred? | |
| 23:15:18 | efried | sean-k-mooney: It's been a minute, but I think on the code side you just have to s/get_ksa_adapter/get_sdk_adapter/ to make the switch. If so, perhaps we could stuff that change in between the series and your tester somehow and see if it fixes the problem. | |
| 23:16:11 | efried | If so, then unit/functional tests would just need small tweaks to make it go. | |
| 23:36:57 | mordred | efried: sdk in general should refresh tokens | |
| 23:37:11 | mordred | efried: however, it's possible there are specifics I should page in | |
| 23:37:18 | mordred | also - we just landed cyborg support in sdk | |
| 23:38:03 | mordred | efried: I'm EOD today - but I'd be happy to interact with folks on it tomorrow to see if we need to do anything | |
| #openstack-nova - 2020-02-27 | |||
| 01:07:54 | openstackgerrit | Brin Zhang proposed openstack/nova master: Add test coverage of existing os-volumes-attachments policies https://review.opendev.org/709929 | |
| 01:31:59 | openstackgerrit | Brin Zhang proposed openstack/nova master: Introduce scope_types in os-volumes-attachments policy https://review.opendev.org/709388 | |
| 02:26:50 | rm_work | gibi: reviewed the routed-network tempest test -- that test needs a bit of cleanup | |
| 06:52:23 | openstackgerrit | Brin Zhang proposed openstack/nova master: Add new default roles in os-volumes-attachments policies https://review.opendev.org/710190 | |
| 08:08:15 | aarents | Hi there, gibi when you will have time for that, can you confirm that https://review.opendev.org/#/c/702368/ is ok for you, I fixed the nits you reported. | |
| 08:22:15 | gibi | rm_work: thank you for the tempest review. I've started working on the pre-filter patch from mriedem | |
| 08:22:26 | gibi | aarents: opening the patch now... | |
| 08:22:28 | rm_work | :thumbsup: | |
| 08:31:27 | gibi | stephenfin: a relatively easy bugfix needs a second code https://review.opendev.org/#/c/702368 | |
| 08:31:39 | gibi | aarents: thanks for the bufix, I'm +2 on it | |
| 08:32:03 | gibi | stephenfin: s/code/core/ // I need more coffeee | |
| 08:32:30 | aarents | gibi: thks | |
| 08:48:54 | lyarwood | kashyap / stephenfin ; https://review.opendev.org/#/c/708745/ - a simple partial fix for the libvirt v6.0.0 qcow2 backing file format issue if you have time to review today. | |
| 08:54:58 | kashyap | lyarwood: Morning, will look | |
| 08:56:21 | kashyap | lyarwood: The discussions upstream turned even more complex; but I think we should go with this fix for now | |
| 08:56:29 | kashyap | Looks good to me | |
| 10:30:19 | openstackgerrit | Johannes Kulik proposed openstack/nova master: Validate id as integer for os-aggregates https://review.opendev.org/710214 | |
| 10:34:37 | jkulik | regarding ^ afaics, osc-lib first tries to get() whatever is supplied to `openstack aggregate show`, which the os-aggregates endpoint doesn't handle well, if it's a name and not an id. | |
| 10:34:53 | jkulik | resulted in too many 500 errors in our environment | |
| 10:51:38 | kashyap | lyarwood: Reviewed; I also posted the upstream libvirt conclusion for selective format probing (and not letting it recurse into multiple levels of backing chains) | |
| 10:51:51 | kashyap | (Read this one: https://www.redhat.com/archives/libvir-list/2020-February/msg01001.html) | |
| 10:58:17 | lyarwood | kashyap: ack thanks | |
| 11:45:30 | openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Use 'import foo from bar' https://review.opendev.org/710235 | |
| 12:01:27 | openstackgerrit | Stephen Finucane proposed openstack/nova master: virt: Remove QEMU_VERSION_REQ_SHARED https://review.opendev.org/710239 | |
| 12:01:27 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_MULTIATTACH https://review.opendev.org/710238 | |
| 14:10:40 | openstackgerrit | Stephen Finucane proposed openstack/nova stable/train: Recalculate 'RequestSpec.numa_topology' on resize https://review.opendev.org/708340 | |
| 14:11:13 | stephenfin | lyarwood: I rebased that onto one of your patches to avoid a merge conflict. Any change you could re +2? ^ | |
| 14:14:13 | lyarwood | stephenfin: done, elod ^ if you have a chance btw. | |
| 14:25:51 | openstackgerrit | Stephen Finucane proposed openstack/os-traits master: setup.cfg: Configure 'python-requires' https://review.opendev.org/704534 | |
| 14:25:52 | openstackgerrit | Stephen Finucane proposed openstack/os-traits master: Switch to hacking 2.x https://review.opendev.org/710275 | |
| 14:25:52 | openstackgerrit | Stephen Finucane proposed openstack/os-traits master: Remove use of six https://review.opendev.org/710274 | |
| 14:25:53 | openstackgerrit | Stephen Finucane proposed openstack/os-resource-classes master: Switch to hacking 2.x https://review.opendev.org/710276 | |
| 14:26:25 | stephenfin | bauzas, gibi, efried: Some dead simple python27 cleanup patches there, if you want the stats ^ | |
| 14:26:50 | bauzas | heh | |
| 14:29:41 | efried | sean-k-mooney: did you see my comments yesterday about ksa->sdk conversion? | |
| 14:33:58 | lyarwood | https://review.opendev.org/#/c/708745/ - For any non-RH cores, this is a simple partial fix for an issue introduced recently in Libvirt v6.0.0. | |
| 14:34:17 | sean-k-mooney | efried: no | |
| 14:34:43 | sean-k-mooney | i was logged off ill look at irc logs unless you want to summerise | |
| 14:34:54 | efried | sean-k-mooney: http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2020-02-26.log.html#t2020-02-26T23:11:23 | |
| 14:35:00 | efried | not too much to summarize | |
| 14:35:59 | sean-k-mooney | ah i see | |
| 14:36:21 | efried | I don't like the idea of un-singleton-ing, which would mean we do the whole Adapter setup with every API call, versus putting in something that will keep the token alive for us. If that thing is converting to sdk, win/win. | |
| 14:36:28 | sean-k-mooney | so ya my theory is that by making it a singolton in the current patch we are not refrshing the token | |
| 14:36:45 | sean-k-mooney | so the fact we were always createing the adapters in other case was masking that | |
| 14:36:53 | efried | yup | |
| 14:37:28 | sean-k-mooney | so unless we do the swich i think the singolton is wrong or at least we would need to add an expiry/token check to it if we kept it | |
| 14:38:18 | sean-k-mooney | i have been using https://review.opendev.org/#/c/679914/ | |
| 14:38:21 | sean-k-mooney | in my testing | |
| 14:38:30 | sean-k-mooney | oh which is now merged cool | |
| 14:38:45 | sean-k-mooney | so that seams to work fine | |
| 14:39:15 | sean-k-mooney | if that has all the feature we need then ya using the sdk i think make sense if it will handel the tokens for us | |
| 14:44:07 | sean-k-mooney | efried: do you know if an update to the series is in the works | |
| 14:44:44 | efried | I don't know, no. | |
| 14:44:52 | sean-k-mooney | ok | |
| 14:45:33 | efried | If there's now real sdk impl (rather than just REST primitive passthrough) that we could switch to, so much the better, though I would argue that should be done later, since it doesn't involve a problem we need to solve immediately. | |
| 14:45:40 | sean-k-mooney | in that case i might just put a testing patch on the top of the chain that swaps the function calls and runs my multi node job to see if it fixes it | |
| 14:46:22 | sean-k-mooney | ya i was thinkig of just doint the s/get_ksa_adapter/get_sdk_adapter/ | |
| 14:46:32 | efried | yeah | |
| 14:46:36 | sean-k-mooney | and see if that works | |
| 14:46:36 | efried | worth a try | |
| 14:46:46 | efried | I don't remember for sure whether that's all it takes... | |
| 14:47:03 | efried | but easy enough to sniff out. | |
| 14:47:18 | sean-k-mooney | if we are basically doing raw request i think it is | |
| 14:47:20 | efried | If you have a live env handy it might make sense to try it out to winnow out any easy problems. | |
| 14:47:30 | sean-k-mooney | if we wanted to use the new proxy function that would be more involed | |
| 14:47:32 | efried | yeah, it wouldn't be wrt the requests, it would be with the setup. | |
| 14:49:17 | sean-k-mooney | did you see i updated https://review.opendev.org/#/c/673341/ yesterday by the way | |
| 14:49:33 | sean-k-mooney | im going to try and do the rest of the cain later today | |
| 14:51:16 | efried | sean-k-mooney: yeah, I was going to wait until all updated to start reviewing, unless you think I should look sooner. | |
| 14:51:48 | sean-k-mooney | am whatever works for you. most of the comments were gibis so i think he is the one that is more pressing | |
| 14:52:03 | sean-k-mooney | that said waiting till they are all done is proably for the best | |
| 14:52:27 | sean-k-mooney | that way you will have less context switching | |
| 14:53:02 | efried | mordred: I think there's not too much context to be missed here. In proposed patch series, nova is talking to cyborg using a raw ksa adapter. I insisted we make that client a singleton, and we're seeing tokens expire after a while (I guess ksa doesn't take care of keeping them fresh). We want to cut over to using sdk anyway, so if sdk handles expiration under the covers, two birds. | |
| 14:53:08 | sean-k-mooney | so ya im just going to grab lunch. when i get back ill quickly do the test patch for the cyborg series and then ill start on the provider.yaml patches | |
| 14:53:18 | efried | ++ | |
| 14:57:53 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Always provide the size in bytes when calling virDomainBlockResize https://review.opendev.org/707590 | |
| 14:58:01 | openstackgerrit | Stephen Finucane proposed openstack/nova master: images: Remove Libvirt specific configurable use from qemu_img_info https://review.opendev.org/707591 | |
| 15:03:38 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_MULTIATTACH https://review.opendev.org/710238 | |
| 15:03:39 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Remove QEMU_VERSION_REQ_SHARED https://review.opendev.org/710239 | |