Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-02-25
10:41:41 openstackgerrit Stephen Finucane proposed openstack/nova master: tox: Integrate mypy https://review.opendev.org/676208
10:41:42 openstackgerrit Stephen Finucane proposed openstack/nova master: WIP: mypy: Add type annotations to top-level modules https://review.opendev.org/705658
10:41:42 openstackgerrit Stephen Finucane proposed openstack/nova master: mypy: Add nova.cmd, nova.conf, nova.console https://review.opendev.org/705657
10:53:29 Tony31 Anyone here?
10:56:24 kashyap Tony31: Just ask your question, someone might answer.
10:56:50 kashyap People live in different timezones. So please be patient, if it isn't answered right away.
11:26:33 openstackgerrit Stephen Finucane proposed openstack/nova master: Fix incorrect vm and task state after build failure race https://review.opendev.org/689388
11:26:33 openstackgerrit Stephen Finucane proposed openstack/nova master: Unplug VIFs as part of cleanup of networks https://review.opendev.org/663382
11:48:27 stephenfin bauzas: Easy +2 here, if you're about https://review.opendev.org/#/c/703146/
11:48:41 bauzas I can, children vacations \o/
11:59:30 openstackgerrit Stephen Finucane proposed openstack/nova master: api: Add microversion 2.82, extra spec validation https://review.opendev.org/708436
11:59:30 openstackgerrit Stephen Finucane proposed openstack/nova master: api: Add framework for extra spec validation https://review.opendev.org/704643
12:44:56 sean-k-mooney bauzas: i commented on https://review.opendev.org/#/c/656885/3 with my vision of how the route networking supprot should be done. i 100% think this needs a spec and i think we should not focus on just routed network but instead on network aware schdeuling instead.
12:46:35 sean-k-mooney we have talked about that before at the ptg but its why im opposed to the poc direction as i think it will not be a good fit as it does not adress the generic problem and only the niech usecase of routed network in stead of network aware scheduling which we have disucess at the ptg a few times
14:26:46 kashyap stephenfin: Hiya ... it's that time of the day (rST quirks):
14:27:12 kashyap ``Broadwell``, ``Broadwell-IBRS``, ``Broadwell-noTSX``, ``Broadwell-noTSX-IBRS`` Intel Core Processor (Broadwell, 2014)
14:27:12 kashyap stephenfin: Is there a way to line-break this long-line?
14:27:24 kashyap stephenfin: Err, let me get a pastebin. It's a definition list
14:29:13 kashyap The first line is 80 lines long (I want to wrap it at 72, but the Sphinx parser complains if you wrap the definition list): https://paste.centos.org/view/4235e78b
14:29:48 kashyap I guess there's no way around it.
14:30:30 stephenfin There is, but it's not nice
14:30:40 stephenfin |Broadwell|
14:30:44 stephenfin definition here
14:30:45 stephenfin
14:31:05 stephenfin .. |Broadwell| replace:: ``Broadwell``,
14:31:11 stephenfin ``Broadwell-IBRS``,
14:31:16 stephenfin ``Broadwell-noTSX``,
14:31:19 stephenfin ...
14:31:31 stephenfin so use substitutions
14:32:50 kashyap .. |qemu_system| replace:: qemu-system-x86_64
14:32:50 kashyap Oh, we already use that replace thingie elsewhere:
14:33:13 stephenfin Yup. Here's the full version http://paste.openstack.org/show/789983/
14:33:33 stephenfin It's not ideal, but it does the job. The alternative is to exceed 80 characters in this case
14:34:21 stephenfin which I think is reasonable for the same reason Bugbear does
14:34:26 stephenfin “it’s like highway speed limits, we won’t bother you if you overdo it by a few km/h”.
14:34:31 stephenfin (from https://black.readthedocs.io/en/stable/the_black_code_style.html)
14:35:12 kashyap stephenfin: Yeah, it's not ideal. Maybe I'll bite the bullet and exceed the length
14:35:23 kashyap What is Bugbear? /me looks
14:36:06 kashyap stephenfin: Hehe, thanks for the assist, as usual. One day, I'll memorize all the quirks and we can compete on who can remember the obscurest quirks of rST :D
14:36:26 kashyap stephenfin: One of the QEMU maintainers calls rST as the "Perl of markup languages" :D
14:36:38 stephenfin :P
14:36:38 stephenfin Bit harsh
14:38:34 kashyap stephenfin: See Paolo's comment in parenthetical there: https://lists.gnu.org/archive/html/qemu-devel/2020-02/msg05612.html
14:39:10 kashyap stephenfin: And you'll enjoy the follow-up (I suspect you already know!) from Peter Maydell on the "why of trailing underscore": https://lists.gnu.org/archive/html/qemu-devel/2020-02/msg05631.html
14:41:49 openstackgerrit Dan Smith proposed openstack/nova master: WIP: Name Enums https://review.opendev.org/708707
15:29:48 openstackgerrit Stephen Finucane proposed openstack/nova master: pytype: Resolve issues with 'nova.virt.vmwareapi' https://review.opendev.org/703148
15:29:48 openstackgerrit Stephen Finucane proposed openstack/nova master: pytype: Resolve issues with 'nova.virt.libvirt' https://review.opendev.org/703147
15:29:49 openstackgerrit Stephen Finucane proposed openstack/nova master: pytype: Resolve issues with 'nova.virt.powervm' https://review.opendev.org/703150
15:29:49 openstackgerrit Stephen Finucane proposed openstack/nova master: pytype: Resolve issues with 'nova.virt.hyperv' https://review.opendev.org/703149
15:29:50 openstackgerrit Stephen Finucane proposed openstack/nova master: pytype: Resolve final issues with 'nova.virt' https://review.opendev.org/703153
15:29:50 openstackgerrit Stephen Finucane proposed openstack/nova master: pytype: Resolve issues with 'nova.virt.xenapi' https://review.opendev.org/703151
15:29:51 openstackgerrit Stephen Finucane proposed openstack/nova master: pytype: Resolve issues with 'nova.cmd', 'nova.console', 'nova.db' https://review.opendev.org/703154
15:44:14 openstackgerrit Stephen Finucane proposed openstack/nova master: Fix incorrect vm and task state after build failure race https://review.opendev.org/689388
15:44:14 openstackgerrit Stephen Finucane proposed openstack/nova master: Unplug VIFs as part of cleanup of networks https://review.opendev.org/663382
16:52:13 rm_work gibi: hey, thanks for taking a look at the routed_segments patch
16:52:27 rm_work I responded a bit, I am hoping it is clearer what the goal is
16:52:49 rm_work especially after sean's latest response on the other routed-networks patch
16:53:31 rm_work that work seems a LONG way off
16:54:22 gibi rm_work: ack, I will check back tomorrow
16:54:24 mriedem gibi: dansmith: be aware https://review.opendev.org/#/c/694428/
16:54:43 gibi mriedem: hi! what is up? :)
16:55:06 gibi mriedem: thanks for the heads up
16:55:41 mriedem if you'd like to avoid a CVE...
16:55:44 mriedem heed my warning!
16:55:53 mriedem ooo booo
16:55:53 dansmith okay yeah I think there's another patch to do this as well, IIRC
16:57:10 mriedem the event reporter stuff passes exc_val through as a kwarg i think which formats the exception message before we store it, something like that - it's been awhile, but that could result in storing sensitive info unlike how instance faults work for non-nova exceptions
16:59:26 gibi no I definitly don't want CVEs
17:02:29 rm_work gibi: cool thanks
17:03:27 rm_work mriedem: coincidentally it's your routed-net patch that I've got a similar CR up for, and am having to justify why/how it's different, lol
17:03:49 rm_work Curious if you'd mind taking a look and giving your 2c
17:04:54 rm_work https://review.opendev.org/#/c/709280/
17:07:04 rm_work Enabling use cases like this one in Octavia: https://review.opendev.org/#/c/706153/
17:07:54 rm_work Or a very simple patch to let live migrate work:
17:08:26 rm_work https://www.irccloud.com/pastebin/L3Y68sS2/live_migrate.patch
17:09:28 rm_work (which if I get any traction on the filter, I'll formalize as a follow-up CR with tests and all)
17:23:08 mriedem rm_work: i wip'ed that patch up sitting in the last denver ptg nearly a year ago and have lost pretty much all context on it
17:23:41 mriedem my gripe with the routed networks feature in neutron for years has been we have no integrated CI job testing it since there are moving parts between nova/placement/neutron
17:24:05 mriedem table stakes (as i think i've said before) for hacking on that feature would be to get a CI job going to make sure that what exists today works before adding more complexity
17:24:13 mriedem but that's my $.02
17:24:22 mriedem which is basically $.00 now
17:28:08 gibi and there is an attempt to add CI coverage to routed-net but https://review.opendev.org/#/c/665155/
17:28:32 openstackgerrit Balazs Gibizer proposed openstack/nova stable/rocky: Avoid circular reference during serialization https://review.opendev.org/709798
17:28:35 gibi but it is going along slowly
17:29:01 mriedem how does that not depend on configuration changes to devstack though?
17:29:15 mriedem i thought there was host aggregate stuff that had to be all synced up, or is that done as part of the test setup?
17:29:56 gibi doen in the tempest test
17:30:01 gibi at least the aggregate part
17:30:42 gibi based on the test doc :)
17:31:08 gibi honestly I still don't know how this feature supposed to work
17:32:25 openstack Launchpad bug 1864678 in oslo.serialization "jsonutils.to_primitive does not follow the protocol required by json.dump" [Undecided,New]
17:32:25 gibi stephenfin: do you have any power over oslo.serialization? I have filed a bug where I might need some support about how we should fix it https://bugs.launchpad.net/oslo.serialization/+bug/1864678
17:33:53 gibi o/
19:28:49 openstackgerrit Merged openstack/nova master: Remove unnecessary parentheses https://review.opendev.org/709652
19:29:03 openstackgerrit Merged openstack/nova master: Functional test for UnexpectedDeletingTaskStateError https://review.opendev.org/689278
19:29:19 openstackgerrit Merged openstack/nova master: Use reasonable name for provider mapping https://review.opendev.org/698735
20:03:59 efried - recheck and merge the dep
20:03:59 efried - merge it
20:03:59 efried - update the commit message to remove the dep
20:03:59 efried prometheanfire, dansmith: https://review.opendev.org/#/c/708707/ seems to be working. Unless there's something else we need to do to it (dansmith?) I assume the process is:

Earlier   Later