| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-02-17 | |||
| 21:41:42 | prometheanfire | efried: well, for me I'm blacklisting on the reqs side, not nova side | |
| 21:41:51 | sean-k-mooney | e.g. they dont leave them open for log | |
| 21:41:54 | sean-k-mooney | *long | |
| 21:43:42 | efried | prometheanfire: I assume we would like to be able to continue following upgrades here, given that trying to fix the transitive deps through all of openstack would be hard and take long. So we should still open an issue for this. Agree? | |
| 21:44:15 | sean-k-mooney | efried: if it broke us it will proably break others | |
| 21:44:21 | sean-k-mooney | so its worth reporting in any case | |
| 21:44:23 | prometheanfire | efried: ya, definitely | |
| 21:46:46 | efried | prometheanfire, sean-k-mooney, johnsom: https://github.com/testing-cabal/mock/issues/487 | |
| 21:47:02 | prometheanfire | watching, thanks | |
| 21:47:14 | prometheanfire | I'll submit a blacklist review to the reqs repo in a few min | |
| 21:54:15 | prometheanfire | submitted and updated the gr update review | |
| 21:54:26 | sean-k-mooney | oh looking at that traceback this looks like our error | |
| 21:55:15 | sean-k-mooney | the reason its passing on python 3.7 is _is_coroutine was likely added by python 3.8 | |
| 21:56:26 | efried | johnsom: want to throw https://zuul.opendev.org/t/openstack/build/c5fd6cadc9bf4b3b9ea81372ef047246/log/job-output.txt#4605 in there? | |
| 21:56:51 | efried | sean-k-mooney: what do you mean passing on py37? It failed locally for me on py37 | |
| 21:57:06 | sean-k-mooney | with unittest.mock | |
| 21:57:08 | johnsom | Yeah, I can | |
| 22:04:18 | sean-k-mooney | efried: basiacly i think we are asserting that that the attibute does not start with _ incorrectly here https://github.com/openstack/oslo.utils/blob/master/oslo_utils/fixture.py#L81-L82 | |
| 22:04:51 | sean-k-mooney | or actully no maybe that is not the issue | |
| 22:05:20 | sean-k-mooney | that is where the exctip is being raised but i have looked at why we are calling that code | |
| 22:05:22 | efried | yeah, the issue is that the wrong `name` is now getting to that point. | |
| 22:05:46 | efried | probably '_AutoSpecMagicMock' as opposed to the name of the actual sentinel. | |
| 22:06:35 | sean-k-mooney | ya | |
| 22:06:47 | sean-k-mooney | so i was wondering is this a change in python 3.8 | |
| 22:06:55 | sean-k-mooney | that they have now backported to mock the lib | |
| 22:07:02 | sean-k-mooney | or is it a mock the lib issue | |
| 22:07:42 | efried | sean-k-mooney: do you have 3.8 installed somewhere? Easy enough to try it out. | |
| 22:08:29 | efried | and run nova.tests.unit.virt.libvirt.test_host.HostTestCase | |
| 22:08:29 | efried | .tox/py38/bin/pip install -U mock | |
| 22:08:29 | efried | Just | |
| 22:08:56 | efried | ...with stock/lib mock | |
| 22:09:51 | sean-k-mooney | mock the lib give you the py38 behavior on all python versions | |
| 22:10:19 | sean-k-mooney | and i might let me check | |
| 22:12:15 | sean-k-mooney | im wonder if its related to https://bugs.python.org/issue39082 or https://bugs.python.org/issue39485 | |
| 23:15:04 | sean-k-mooney | efried: regarding https://review.opendev.org/#/c/702451/10 the conenction to the nova net removal is that stephenfin removed the nova.network.api modules earlier in the series and now image module was the only one with a .api module so stephenfin wrote that patch to make them all consitent | |
| 23:15:20 | sean-k-mooney | efried: but ya it confused the hell out of me too at first | |
| 23:15:56 | sean-k-mooney | also i jsut realised what time it is so o/ night all | |
| #openstack-nova - 2020-02-18 | |||
| 01:13:02 | brinzhang | efried: no, I will guide the patch's owner to complete the remote console with password authentication feature | |
| 01:28:05 | prometheanfire | sqlalchemy.exc.CompileError: PostgreSQL ENUM type requires a name. | |
| 01:28:14 | prometheanfire | I think that's from the alembic update | |
| 01:28:17 | prometheanfire | https://zuul.opendev.org/t/openstack/build/f5cc138068fe4d909d6baf8e85d5405e | |
| 03:11:21 | openstackgerrit | Kevin Zhao proposed openstack/nova master: [Do not Merge] test Arm64 CI https://review.opendev.org/708293 | |
| 03:17:36 | openstackgerrit | Kevin Zhao proposed openstack/nova master: [Do not Merge] test Arm64 CI https://review.opendev.org/708294 | |
| 04:39:50 | openstackgerrit | Merged openstack/nova stable/pike: Use stable constraint for Tempest pinned stable branches https://review.opendev.org/706715 | |
| 06:52:22 | openstackgerrit | Brin Zhang proposed openstack/nova master: FUP Populate the 'updated_at' when aggregate metadata is updated https://review.opendev.org/702790 | |
| 07:10:57 | alex_xu | rosmaita: I think it needn't a microversion | |
| 07:41:14 | openstackgerrit | Kevin Zhao proposed openstack/nova master: [WIP] Add arm64 CI https://review.opendev.org/708102 | |
| 07:48:42 | openstackgerrit | Kevin Zhao proposed openstack/nova master: [WIP] Add arm64 CI https://review.opendev.org/708102 | |
| 07:50:18 | openstackgerrit | Kevin Zhao proposed openstack/nova master: [Do not Merge] test Arm64 CI https://review.opendev.org/708293 | |
| 07:50:46 | openstackgerrit | Kevin Zhao proposed openstack/nova master: [Do not Merge] test Arm64 CI https://review.opendev.org/708294 | |
| 09:04:06 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove unnecessary exception handling, mocks https://review.opendev.org/703973 | |
| 09:04:07 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove unused parameters https://review.opendev.org/703974 | |
| 09:04:07 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove unused nova-network objects https://review.opendev.org/697156 | |
| 09:39:24 | lyarwood | efried: sorry was afk yesterday sick, https://review.opendev.org/#/q/topic:spec/virt-rescue-stable-disk-devices needs to land ahead of https://review.opendev.org/#/q/topic:bp/virt-bfv-instance-rescue - working on the top WIP libvirt change today, it's mostly unit/tempest coverage left to do at this point. | |
| 09:43:36 | kashyap | efried: On that secure boot spec, it's been on the back-burner as I was buried in other stuff, but I definitely want to get it done. | |
| 10:14:01 | brinzhang_ | efried, gibi, stephenfin, alex_xu: Do we have to follow nova runway, it has not been updated for 5 days :). https://etherpad.openstack.org/p/nova-runways-ussuri | |
| 10:20:09 | openstackgerrit | John Garbutt proposed openstack/nova master: WIP: Enforce unified limits using oslo.limit https://review.opendev.org/615180 | |
| 10:39:17 | openstackgerrit | Brin Zhang proposed openstack/nova master: Add new default roles in os-instance-actions policies https://review.opendev.org/706470 | |
| 10:39:19 | openstackgerrit | Ilya Etingof proposed openstack/nova master: Add JSON schema and test for network_data.json https://review.opendev.org/703133 | |
| 10:39:42 | openstackgerrit | John Garbutt proposed openstack/nova master: WIP: Enforce unified limits using oslo.limit https://review.opendev.org/615180 | |
| 10:55:55 | openstackgerrit | Stephen Finucane proposed openstack/nova stable/train: Recalculate 'RequestSpec.numa_topology' on resize https://review.opendev.org/708340 | |
| 11:26:32 | gibi | brinzhang_: good question. let me update the runways | |
| 11:26:50 | sean-k-mooney | efried: dansmith trying to do multi node im hitting some db errors with arq binding http://paste.openstack.org/show/789695/ im going to take a look at the db and see if i can figure out what is going on quickly but at present | |
| 11:26:57 | sean-k-mooney | i cant spawn a vm | |
| 11:27:12 | sean-k-mooney | gibi brinzhang_ we have not really been using runways this cycle | |
| 11:27:32 | sean-k-mooney | not that im against using them we just have not been using them for some reason | |
| 11:34:47 | gibi | brinzhang_, efried, gmann, lyarwood, stephenfin: I've update the runways etherpad | |
| 11:35:21 | gibi | sean-k-mooney: yeah. I've added a topic for the PTG about runways | |
| 11:36:08 | gibi | sean-k-mooney: did cyborg updated the fake driver to report the RP with a unique name? months ago when I looked at it my problem was that both compute node used the same RP name for the fake FPGA resource | |
| 12:14:46 | sean-k-mooney | ah right that could be the issue | |
| 12:14:51 | sean-k-mooney | let me check | |
| 12:15:15 | sean-k-mooney | gibi: also i responded to some of your questions in https://review.opendev.org/#/c/673735/38 | |
| 12:16:36 | sean-k-mooney | gibi: ya that is the issue | |
| 12:16:40 | sean-k-mooney | ther is only 1 rp | |
| 12:17:08 | sean-k-mooney | well there are 3 1 for each compute and then 1 for the fake device | |
| 12:17:17 | sean-k-mooney | so the fake driver is incomplete | |
| 12:18:39 | sean-k-mooney | i also noticed the devstack plugin is incorrect. it does not properly support deploy just the comptue agent like it sugges. it will not create the correct cybog config so the agent will be installed but wont be able to connect to rabbitmq | |
| 12:19:30 | sean-k-mooney | dansmith: so based on the fact that the RP is hardcoded im going to say creating a tempory multi node job will be more work then i had guessed | |
| 12:19:57 | sean-k-mooney | it could still be done but i would have to modify the cyborg code to fix the devstack plugin and correct the hardcoding | |
| 12:24:33 | gibi | sean-k-mooney: ack thanks, I will get back to that patch after I finished with the whole sereies | |
| 12:24:36 | gibi | series | |
| 12:34:17 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Add support for stable device rescue https://review.opendev.org/700812 | |
| 12:34:17 | openstackgerrit | Lee Yarwood proposed openstack/nova master: virt: Provide block_device_info during rescue https://review.opendev.org/700811 | |
| 12:36:46 | gibi | efried, dansmith: I finished reading the cyborg series. The re-schedule is not covered with functional test so I'm not sure it works. I also found other missing test coverage as well | |
| 12:38:15 | rosmaita | alex_xu: thank you | |
| 12:40:21 | openstackgerrit | Lee Yarwood proposed openstack/nova master: DNM test stable rescue tempest/devstack changes https://review.opendev.org/700815 | |
| 12:41:07 | sean-k-mooney | gibi: looking at the fake cyborg driver i dont imediatly see where they are setting the RP name meaning they my be hardcoding it above the dirver meaning im not sure you coudl ever have more then one cyborg rp. ill keep looking but has anyone tested multinode with 2 hosts that have fpgas? | |
| 12:41:46 | openstackgerrit | Luyao Zhong proposed openstack/nova master: bug-fix: Reject live migration with vpmem https://review.opendev.org/708110 | |
| 12:41:47 | openstackgerrit | Luyao Zhong proposed openstack/nova master: support live migration with vpmems https://review.opendev.org/687856 | |
| 12:41:47 | openstackgerrit | Luyao Zhong proposed openstack/nova master: address specific resources cleanup issue https://review.opendev.org/699148 | |
| 12:41:57 | gibi | sean-k-mooney: thanks for the answers in https://review.opendev.org/#/c/673735 much appreciated | |
| 12:42:22 | gibi | sean-k-mooney: I have to reload the context but months ago I was able to found the place where the hard-coding was done | |
| 12:42:44 | sean-k-mooney | the repo is small so it wont take me long to find it | |
| 12:44:27 | sean-k-mooney | i dont think i want to know why the cyborg agent calls ethe cyborg conductor to diff ther ereport data as part of updating the inventory do i... | |
| 12:44:52 | sean-k-mooney | agents shoudl really not do that | |
| 12:45:56 | openstackgerrit | Lee Yarwood proposed openstack/nova master: DNM test stable rescue tempest/devstack changes https://review.opendev.org/700815 | |
| 12:48:35 | sean-k-mooney | gibi: ... so cyborg are doing all the inventory updates via the conductor by haveing the agents inventory the local host then doign an rpc to the conductor which does the diff of the old state to the new state then it updates the placement invtories | |
| 12:49:12 | sean-k-mooney | that is not goign to scale | |
| 12:50:57 | sean-k-mooney | also why are they using the dns_namespace for https://github.com/openstack/cyborg/blob/369abe8dd06aa6648298c3256f444a63ee6268d0/cyborg/conductor/manager.py#L417-L418 | |
| 12:52:14 | gibi | sean-k-mooney: most probably they want to have stable uuids | |