| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-02-17 | |||
| 21:25:45 | sean-k-mooney | to get rid of the dep on mock the lib | |
| 21:25:53 | efried | "just" | |
| 21:25:56 | sean-k-mooney | if we wanted too in the futrue and add a hacking check | |
| 21:26:24 | sean-k-mooney | efried: its hopefully 1 sed command but yes | |
| 21:26:29 | sean-k-mooney | it could explode | |
| 21:26:43 | efried | 384 occurrences. | |
| 21:27:38 | prometheanfire | well, there's a way to find out I guess | |
| 21:28:06 | efried | yeah, working on it. | |
| 21:28:57 | sean-k-mooney | there has been a long standing issue in nova where we cant use self.assertRaises as a context manager in a with statement which im pretty sure is caused by mock the lib by the way whic this might also fix | |
| 21:29:07 | efried | prometheanfire, sean-k-mooney, johnsom: so yeah, that fixes it, at least for the one instance I tried. | |
| 21:29:21 | efried | s/^import mock$/from unittest import mock/ | |
| 21:29:25 | prometheanfire | heh | |
| 21:29:36 | johnsom | Hmmm, so tempting..... grin | |
| 21:29:55 | sean-k-mooney | can you do that for all nova and see if the tests still run | |
| 21:29:59 | johnsom | Yeah, I think I will try that too | |
| 21:30:04 | efried | sean-k-mooney: yeah but I'm not gonna run locally. | |
| 21:30:11 | efried | My laptop will burn a hole to the center of the earth. | |
| 21:30:14 | efried | I'll let zuul do it. | |
| 21:30:19 | sean-k-mooney | ok | |
| 21:30:22 | johnsom | It's a mock revolt. lol | |
| 21:31:01 | sean-k-mooney | if it does have issue i guess we could just do it selectivly to solve the issues we currently have until either mock is fixt or we fix the issues we find | |
| 21:32:01 | efried | sean-k-mooney: the sed command works fine... except for the pep8 requirement to sort imports :P | |
| 21:32:28 | sean-k-mooney | autopep8 might fix that for you | |
| 21:32:50 | sean-k-mooney | unlike black it only fixes the minium amount of stuff to pass pep8 | |
| 21:33:00 | sean-k-mooney | so it does not break the worlds and passes our gate | |
| 21:33:47 | sean-k-mooney | anyway we coudl cross that bridge when we see if it even passes the zuul run | |
| 21:37:22 | efried | prometheanfire: having proven this is a bug in the mock library, are you more convinced that we should blacklist the mock versions? | |
| 21:38:13 | sean-k-mooney | got to love that commit message https://github.com/testing-cabal/mock/commit/9e5e0380626fd3c540aa4799df0e794cf24d16aa | |
| 21:38:34 | prometheanfire | efried: ya, kinda sucks, but ok | |
| 21:38:39 | openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Use stock mock https://review.opendev.org/708262 | |
| 21:38:56 | efried | prometheanfire: if you want to try making your patch dep on ^ ... | |
| 21:39:13 | efried | sean-k-mooney: --^ | |
| 21:39:14 | johnsom | Yeah, octavia seems to pass fine with the native mock | |
| 21:39:39 | efried | o queso we need a bug against mock | |
| 21:40:23 | efried | am I reading this right that there are zero open issues? | |
| 21:40:28 | efried | am I looking at the right repo? | |
| 21:40:44 | sean-k-mooney | and 404 closed | |
| 21:40:58 | johnsom | Zero for that repo | |
| 21:41:13 | johnsom | Though they pull in from the native bugs too | |
| 21:41:40 | sean-k-mooney | i guess they just fix them quickly or close them as wont fix | |
| 21:41:42 | prometheanfire | efried: well, for me I'm blacklisting on the reqs side, not nova side | |
| 21:41:51 | sean-k-mooney | e.g. they dont leave them open for log | |
| 21:41:54 | sean-k-mooney | *long | |
| 21:43:42 | efried | prometheanfire: I assume we would like to be able to continue following upgrades here, given that trying to fix the transitive deps through all of openstack would be hard and take long. So we should still open an issue for this. Agree? | |
| 21:44:15 | sean-k-mooney | efried: if it broke us it will proably break others | |
| 21:44:21 | sean-k-mooney | so its worth reporting in any case | |
| 21:44:23 | prometheanfire | efried: ya, definitely | |
| 21:46:46 | efried | prometheanfire, sean-k-mooney, johnsom: https://github.com/testing-cabal/mock/issues/487 | |
| 21:47:02 | prometheanfire | watching, thanks | |
| 21:47:14 | prometheanfire | I'll submit a blacklist review to the reqs repo in a few min | |
| 21:54:15 | prometheanfire | submitted and updated the gr update review | |
| 21:54:26 | sean-k-mooney | oh looking at that traceback this looks like our error | |
| 21:55:15 | sean-k-mooney | the reason its passing on python 3.7 is _is_coroutine was likely added by python 3.8 | |
| 21:56:26 | efried | johnsom: want to throw https://zuul.opendev.org/t/openstack/build/c5fd6cadc9bf4b3b9ea81372ef047246/log/job-output.txt#4605 in there? | |
| 21:56:51 | efried | sean-k-mooney: what do you mean passing on py37? It failed locally for me on py37 | |
| 21:57:06 | sean-k-mooney | with unittest.mock | |
| 21:57:08 | johnsom | Yeah, I can | |
| 22:04:18 | sean-k-mooney | efried: basiacly i think we are asserting that that the attibute does not start with _ incorrectly here https://github.com/openstack/oslo.utils/blob/master/oslo_utils/fixture.py#L81-L82 | |
| 22:04:51 | sean-k-mooney | or actully no maybe that is not the issue | |
| 22:05:20 | sean-k-mooney | that is where the exctip is being raised but i have looked at why we are calling that code | |
| 22:05:22 | efried | yeah, the issue is that the wrong `name` is now getting to that point. | |
| 22:05:46 | efried | probably '_AutoSpecMagicMock' as opposed to the name of the actual sentinel. | |
| 22:06:35 | sean-k-mooney | ya | |
| 22:06:47 | sean-k-mooney | so i was wondering is this a change in python 3.8 | |
| 22:06:55 | sean-k-mooney | that they have now backported to mock the lib | |
| 22:07:02 | sean-k-mooney | or is it a mock the lib issue | |
| 22:07:42 | efried | sean-k-mooney: do you have 3.8 installed somewhere? Easy enough to try it out. | |
| 22:08:29 | efried | and run nova.tests.unit.virt.libvirt.test_host.HostTestCase | |
| 22:08:29 | efried | .tox/py38/bin/pip install -U mock | |
| 22:08:29 | efried | Just | |
| 22:08:56 | efried | ...with stock/lib mock | |
| 22:09:51 | sean-k-mooney | mock the lib give you the py38 behavior on all python versions | |
| 22:10:19 | sean-k-mooney | and i might let me check | |
| 22:12:15 | sean-k-mooney | im wonder if its related to https://bugs.python.org/issue39082 or https://bugs.python.org/issue39485 | |
| 23:15:04 | sean-k-mooney | efried: regarding https://review.opendev.org/#/c/702451/10 the conenction to the nova net removal is that stephenfin removed the nova.network.api modules earlier in the series and now image module was the only one with a .api module so stephenfin wrote that patch to make them all consitent | |
| 23:15:20 | sean-k-mooney | efried: but ya it confused the hell out of me too at first | |
| 23:15:56 | sean-k-mooney | also i jsut realised what time it is so o/ night all | |
| #openstack-nova - 2020-02-18 | |||
| 01:13:02 | brinzhang | efried: no, I will guide the patch's owner to complete the remote console with password authentication feature | |
| 01:28:05 | prometheanfire | sqlalchemy.exc.CompileError: PostgreSQL ENUM type requires a name. | |
| 01:28:14 | prometheanfire | I think that's from the alembic update | |
| 01:28:17 | prometheanfire | https://zuul.opendev.org/t/openstack/build/f5cc138068fe4d909d6baf8e85d5405e | |
| 03:11:21 | openstackgerrit | Kevin Zhao proposed openstack/nova master: [Do not Merge] test Arm64 CI https://review.opendev.org/708293 | |
| 03:17:36 | openstackgerrit | Kevin Zhao proposed openstack/nova master: [Do not Merge] test Arm64 CI https://review.opendev.org/708294 | |
| 04:39:50 | openstackgerrit | Merged openstack/nova stable/pike: Use stable constraint for Tempest pinned stable branches https://review.opendev.org/706715 | |
| 06:52:22 | openstackgerrit | Brin Zhang proposed openstack/nova master: FUP Populate the 'updated_at' when aggregate metadata is updated https://review.opendev.org/702790 | |
| 07:10:57 | alex_xu | rosmaita: I think it needn't a microversion | |
| 07:41:14 | openstackgerrit | Kevin Zhao proposed openstack/nova master: [WIP] Add arm64 CI https://review.opendev.org/708102 | |
| 07:48:42 | openstackgerrit | Kevin Zhao proposed openstack/nova master: [WIP] Add arm64 CI https://review.opendev.org/708102 | |
| 07:50:18 | openstackgerrit | Kevin Zhao proposed openstack/nova master: [Do not Merge] test Arm64 CI https://review.opendev.org/708293 | |
| 07:50:46 | openstackgerrit | Kevin Zhao proposed openstack/nova master: [Do not Merge] test Arm64 CI https://review.opendev.org/708294 | |
| 09:04:06 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove unnecessary exception handling, mocks https://review.opendev.org/703973 | |
| 09:04:07 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove unused parameters https://review.opendev.org/703974 | |
| 09:04:07 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-net: Remove unused nova-network objects https://review.opendev.org/697156 | |
| 09:39:24 | lyarwood | efried: sorry was afk yesterday sick, https://review.opendev.org/#/q/topic:spec/virt-rescue-stable-disk-devices needs to land ahead of https://review.opendev.org/#/q/topic:bp/virt-bfv-instance-rescue - working on the top WIP libvirt change today, it's mostly unit/tempest coverage left to do at this point. | |
| 09:43:36 | kashyap | efried: On that secure boot spec, it's been on the back-burner as I was buried in other stuff, but I definitely want to get it done. | |
| 10:14:01 | brinzhang_ | efried, gibi, stephenfin, alex_xu: Do we have to follow nova runway, it has not been updated for 5 days :). https://etherpad.openstack.org/p/nova-runways-ussuri | |
| 10:20:09 | openstackgerrit | John Garbutt proposed openstack/nova master: WIP: Enforce unified limits using oslo.limit https://review.opendev.org/615180 | |
| 10:39:17 | openstackgerrit | Brin Zhang proposed openstack/nova master: Add new default roles in os-instance-actions policies https://review.opendev.org/706470 | |
| 10:39:19 | openstackgerrit | Ilya Etingof proposed openstack/nova master: Add JSON schema and test for network_data.json https://review.opendev.org/703133 | |
| 10:39:42 | openstackgerrit | John Garbutt proposed openstack/nova master: WIP: Enforce unified limits using oslo.limit https://review.opendev.org/615180 | |