Posted	Nick	Remark
#openstack-nova - 2020-02-12
18:00:09	stephenfin	Got a link to a build? We're just using flake8 + hacking
18:00:13	sean-k-mooney	if you do _ = 4
18:00:21	sean-k-mooney	i think we will raise an error
18:00:27	stephenfin	yeah, maybe
18:00:33	sean-k-mooney	if you for _ , i in x:
18:00:38	sean-k-mooney	i think it will be fine
18:00:42	stephenfin	yup
18:00:43	sean-k-mooney	or if you do multiple assingment
18:00:48	stephenfin	in my experience, anyway
18:00:58	redrobot	stephenfin, https://zuul.opendev.org/t/openstack/build/342ef93cbf464e01b72564695b2d610d
18:01:04	sean-k-mooney	so _, x = sum_fun()
18:01:39	stephenfin	redrobot: I'm not seeing that issue
18:01:45	stephenfin	I'm seeing this
18:01:46	stephenfin	./nova/tests/unit/cmd/test_baseproxy.py:93:50: E241 multiple spaces after ','
18:01:46	stephenfin	./nova/console/websocketproxy.py:326:32: F632 use ==/!= to compare str, bytes, and int literals
18:02:02	sean-k-mooney	ya same i dont see it compain about _
18:02:38	redrobot	oh d'oh. It's complaining about _ when I run tox -e pep8 locally
18:02:44	redrobot	but also the extra space
18:02:56	redrobot	I'll follow up the patch with the fix for the space and hopefully that'll work.
18:03:09	openstackgerrit	Sylvain Bauza proposed openstack/nova-specs master: Proposes NUMA topology with RPs https://review.opendev.org/552924
18:03:17	stephenfin	redrobot: Ah, yes, this https://review.opendev.org/#/c/679502/10/nova/tests/unit/console/test_websocketproxy.py@642
18:03:21	stephenfin	You don't need that assignment
18:03:29	stephenfin	If you don't want the value, don't assign to anything
18:03:36	stephenfin	so just
18:03:37	stephenfin	websocketproxy.NovaWebSocketProxy(ssl_minimum_version=minver)
18:03:41	stephenfin	instead of
18:03:42	stephenfin	_ = websocketproxy.NovaWebSocketProxy(ssl_minimum_version=minver)
18:03:43	sean-k-mooney	so yes dont do https://review.opendev.org/#/c/679502/10/nova/tests/unit/console/test_websocketproxy.py@631
18:03:55	stephenfin	'zactly ^
18:03:56	sean-k-mooney	that should raise a style error
18:04:33	redrobot	stephenfin, ack, I'll change that
18:04:39	redrobot	thanks for the help, y'all!
18:05:11	sean-k-mooney	no worries
18:05:13	openstackgerrit	Lee Yarwood proposed openstack/nova master: libvirt: Correctly resize encrypted LUKSv1 volumes https://review.opendev.org/706900
18:05:52	bauzas	efried: sean-k-mooney: gibi: dansmith: stephenfin: just wrote the last round of the NUMA/placement spec
18:06:06	bauzas	it's fuckingly 7pm and I'm deprived of meat
18:06:22	openstackgerrit	Douglas Mendizábal proposed openstack/nova master: Allow TLS ciphers/protocols to be configurable for console proxies https://review.opendev.org/679502
18:06:42	sean-k-mooney	bauzas: go get foods hehe
18:06:56	bauzas	to make it clear, I turn-voted into *not* reshaping by default in Ussuri because i think it's important for us to be very conservative and super cautious
18:07:28	bauzas	we will have time to make it mandatory for Victoria and write some nice nova-status command later in Ussuri
18:08:27	bauzas	sean-k-mooney: well, I also have to join a city council meeting since I run for a mayor's list :)
18:09:16	sean-k-mooney	ireland had some interesting political change over the weekend too.
18:09:58	sean-k-mooney	im going to similarly go to the store and get stuff for dinner but ill review it in the next hour or so
18:20:03	gmann	melwitt: stephenfin you can see the jobs running for policy-only changes with proposed change- https://review.opendev.org/#/c/707041/
18:20:48	melwitt	gmann: cool thanks
18:22:32	lyarwood	sean-k-mooney: sorry missed your pings earlier, yeah can you take a look at elod's comments in the first change and address them if you have time this week?
18:22:49	lyarwood	sean-k-mooney: I was just rebasing to get them passing in CI again now that gmann++ fixed up stable/rocky
19:15:52	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing deferred_delete policies https://review.opendev.org/707455
19:31:38	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Fix os-os-deferred-delete policy to be admin_or_owner https://review.opendev.org/707457
19:37:48	sean-k-mooney	lyarwood: ok ya ill take a look at that tomorrow
19:37:58	lyarwood	sean-k-mooney: ack thanks
19:53:30	openstackgerrit	Artom Lifshitz proposed openstack/nova master: tests: work around malformed serial XML https://review.opendev.org/705546
19:53:30	openstackgerrit	Artom Lifshitz proposed openstack/nova master: func tests: move _run_periodics() into own mixin https://review.opendev.org/705545
19:53:31	openstackgerrit	Artom Lifshitz proposed openstack/nova master: Functional tests for NUMA live migration https://review.opendev.org/672595
19:53:33	openstack	bug 1845146 in OpenStack Compute (nova) train "NUMA aware live migration failed when vCPU pin set" [High,Fix committed] https://launchpad.net/bugs/1845146 - Assigned to Dan Smith (danms)
19:53:33	openstackgerrit	Artom Lifshitz proposed openstack/nova master: NUMA LM: Add func test for bug 1845146 https://review.opendev.org/687404
20:12:45	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Correct os-availability-zone policy check_str https://review.opendev.org/706683
20:13:57	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing availability-zone policies https://review.opendev.org/706682
20:22:57	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Fix os-create-backup policy to be admin_or_owner https://review.opendev.org/706727
20:23:08	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing create_backup policies https://review.opendev.org/706726
20:23:22	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in os-create-backup https://review.opendev.org/707038
20:23:35	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-create-backup policies https://review.opendev.org/707039
20:24:41	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing availability-zone policies https://review.opendev.org/706682
20:44:05	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in os-availability-zone https://review.opendev.org/706684
20:53:26	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-availability-zone policies https://review.opendev.org/706686
20:54:04	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Pass the actual target in os-availability-zone policy https://review.opendev.org/706691
21:00:26	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing availability-zone policies https://review.opendev.org/706682
21:05:55	openstackgerrit	Douglas Mendizábal proposed openstack/nova master: Allow TLS ciphers/protocols to be configurable for console proxies https://review.opendev.org/679502
21:10:47	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in os-availability-zone https://review.opendev.org/706684
21:19:07	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-availability-zone policies https://review.opendev.org/706686
21:19:55	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Pass the actual target in os-availability-zone policy https://review.opendev.org/706691
21:29:01	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing deferred_delete policies https://review.opendev.org/707455
21:34:58	openstackgerrit	Corey Bryant proposed openstack/nova master: Monkey patch original current_thread _active https://review.opendev.org/707474
21:38:58	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in os-deferred_delete https://review.opendev.org/707476
22:15:29	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-deferred_delete policies https://review.opendev.org/707485
22:40:45	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Correct os-availability-zone policy check_str https://review.opendev.org/706683
22:41:13	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing availability-zone policies https://review.opendev.org/706682
22:41:22	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing availability-zone policies https://review.opendev.org/706682
22:41:36	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in os-availability-zone https://review.opendev.org/706684
22:41:48	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-availability-zone policies https://review.opendev.org/706686
22:41:59	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Pass the actual target in os-availability-zone policy https://review.opendev.org/706691
#openstack-nova - 2020-02-13
00:05:06	openstackgerrit	Sundar Nadathur proposed openstack/nova master: Pass accelerator requests to each virt driver from compute manager. https://review.opendev.org/698581
00:05:06	openstackgerrit	Sundar Nadathur proposed openstack/nova master: Create and bind Cyborg ARQs. https://review.opendev.org/631244
00:05:07	openstackgerrit	Sundar Nadathur proposed openstack/nova master: Delete ARQs for an instance when the instance is deleted. https://review.opendev.org/673735
00:05:07	openstackgerrit	Sundar Nadathur proposed openstack/nova master: Compose accelerator PCI devices into domain XML in libvirt driver. https://review.opendev.org/631245
00:05:08	openstackgerrit	Sundar Nadathur proposed openstack/nova master: Enable start/stop of instances with accelerators. https://review.opendev.org/699553
00:05:08	openstackgerrit	Sundar Nadathur proposed openstack/nova master: Enable hard/soft reboot with accelerators. https://review.opendev.org/697940
00:05:09	openstackgerrit	Sundar Nadathur proposed openstack/nova master: Bump compute rpcapi version and reduce Cyborg calls. https://review.opendev.org/704227
00:05:09	openstackgerrit	Sundar Nadathur proposed openstack/nova master: Enable and use COMPUTE_ACCELERATORS trait. https://review.opendev.org/699554
00:05:10	openstackgerrit	Sundar Nadathur proposed openstack/nova master: Add cyborg tempest job. https://review.opendev.org/670999
08:15:40	kevinz	Hi Nova, Linaro has donate some machines to Infra team already, node is ready in nodepool. We'd like to enable Arm64 CI for Nova(libvirt driver). So any guidline for me to get involved？
08:15:40	kevinz	Hi Nova, Linaro has donate some machines to Infra team already, node is ready in nodepool. We'd like to enable Arm64 CI for Nova(libvirt driver). So any guidline for me to get involved？
08:21:30	openstack	Launchpad bug 1863058 in OpenStack Compute (nova) "Arm64 CI for Nova" [Undecided,New]
08:21:30	kevinz	create a bug here to track this: https://bugs.launchpad.net/nova/+bug/1863058
08:49:18	lyarwood	kevinz: I guess if these hosts are already in nodepool then we can use them directly without third party CI?
08:49:54	kevinz	lyarwood: hi, yes these machines are now in nodepool.
08:50:05	kevinz	lyarwood: https://opendev.org/openstack/project-config/src/branch/master/nodepool/nl03.openstack.org.yaml#L414
08:51:18	kevinz	And for arm64 nodes, there is another pipeline https://review.opendev.org/#/c/698606
08:51:27	kevinz	due to lacking of nodes
08:51:59	kevinz	called "check-arm64"

Earlier   Later