| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-02-12 | |||
| 17:44:59 | stephenfin | Exactly | |
| 17:45:22 | sean-k-mooney | there is a usecase for keeping the image property by the way | |
| 17:45:32 | sean-k-mooney | we support setting the realtime mask in the image | |
| 17:45:44 | stephenfin | We do, but I think that's wrong | |
| 17:45:45 | sean-k-mooney | so for parity we could support the pinned cpus there too | |
| 17:45:49 | sean-k-mooney | why | |
| 17:45:54 | stephenfin | For the same reasons | |
| 17:46:07 | stephenfin | You boot an N core instance | |
| 17:46:11 | sean-k-mooney | the idea is the vnf vendor will package teh image and expres the requirements in the image properties | |
| 17:46:21 | stephenfin | Right, but they can't express the number of CPUs | |
| 17:46:29 | stephenfin | which is probably also required | |
| 17:46:43 | sean-k-mooney | well the can express a min numa of cpus in the image | |
| 17:47:06 | stephenfin | Via the topology stuff? | |
| 17:47:08 | sean-k-mooney | the same way they can express a min amount of ram or disk | |
| 17:47:10 | stephenfin | That's a bit of hack | |
| 17:47:17 | sean-k-mooney | no | |
| 17:47:23 | sean-k-mooney | one sec | |
| 17:47:27 | sean-k-mooney | medtadef time | |
| 17:47:55 | sean-k-mooney | actully im not sure this is even a metadef it migh be directly on the image | |
| 17:48:30 | stephenfin | Hmm, we do also have 'hw_numa_cpus' there | |
| 17:48:41 | stephenfin | That's wrong too, IMO :( | |
| 17:49:00 | stephenfin | I wonder if we should do this just to be compatible even if it's not a great design though | |
| 17:49:54 | stephenfin | We have a 'img_bittorrent' field on the 'ImageMetaProps' object. Good Lord | |
| 17:50:43 | sean-k-mooney | oh looks like it only has min disk and min ram | |
| 17:50:45 | sean-k-mooney | https://docs.openstack.org/python-openstackclient/pike/cli/command-objects/image.html#image-create | |
| 17:50:59 | sean-k-mooney | stephenfin: its by design | |
| 17:51:12 | sean-k-mooney | again the intent was to allow the image to descibr the toplogy | |
| 17:51:20 | sean-k-mooney | and the flavor to describe the quantity | |
| 17:51:45 | stephenfin | sean-k-mooney: But remember, that's a not a simple list | |
| 17:51:58 | stephenfin | or actually, maybe it is for the image metadata | |
| 17:52:45 | stephenfin | what happens if you create an N node instance that lists M CPUs in the 'hw_numa_cpus' image metadata option? | |
| 17:52:50 | sean-k-mooney | stephenfin: i agree that we should not mix it with the resouces:* syntax | |
| 17:53:28 | stephenfin | yeah, I really don't think we need the image metadata option. If anything, I'd be looking to deprecate the likes of 'hw_numa_cpus' | |
| 17:53:52 | sean-k-mooney | but if we are seting hw_cpu_policy=mixed in the image seting hw_pinned_cpus=1-5 i think is ok | |
| 17:54:07 | sean-k-mooney | stephenfin: i dont think that we shoudl do that | |
| 17:54:22 | sean-k-mooney | we could but its there for a reason | |
| 17:54:27 | stephenfin | so if we boot using a flavor with 4 cores, what happens? | |
| 17:54:30 | sean-k-mooney | partly to prevent falvor explosion | |
| 17:54:30 | stephenfin | or with 8 cores? | |
| 17:55:06 | sean-k-mooney | with 4 course it woudl be rejected by the numa constraint in the api | |
| 17:55:07 | stephenfin | by having image explosion instead? | |
| 17:55:24 | sean-k-mooney | before we even create the instance record | |
| 17:55:55 | sean-k-mooney | stephenfin: for 8 cors 0,6,7 would be un pinned | |
| 17:56:25 | stephenfin | Yeah, that seems wrong to me | |
| 17:56:27 | stephenfin | I'd be okay with a ratio | |
| 17:56:36 | stephenfin | i.e. 3:1 pinned:unpinned | |
| 17:56:44 | stephenfin | because it's a hint | |
| 17:56:45 | sean-k-mooney | right but we said its a list | |
| 17:56:52 | stephenfin | but I don't think anyone's asked for that | |
| 17:57:12 | sean-k-mooney | a ratio is not ok in general | |
| 17:57:12 | stephenfin | has anyone actually said they need the image metadata option? | |
| 17:57:30 | sean-k-mooney | thats a question for huaqiang and alex_xu | |
| 17:57:33 | stephenfin | well we have that in a manner already | |
| 17:57:54 | stephenfin | that's what e.g. the 'hw_cpu_cores' thing is doing | |
| 17:58:02 | stephenfin | the ratio of cores to threads and sockets | |
| 17:58:18 | sean-k-mooney | yes although its not really a raitio | |
| 17:58:24 | sean-k-mooney | it indireclty is | |
| 17:58:27 | sean-k-mooney | but ya | |
| 17:58:53 | stephenfin | a flat number of unpinned cores would also be okay for me | |
| 17:59:06 | redrobot | Hi friends! I have a question about your pep8 gate configuration. | |
| 17:59:08 | sean-k-mooney | its really socket per vm, cores per socket and then threads per core | |
| 17:59:08 | stephenfin | but again, I don't know how much that achieves | |
| 17:59:12 | stephenfin | redrobot: shoot | |
| 17:59:15 | redrobot | Seeing this error right now: | |
| 17:59:17 | redrobot | > F841 local variable '_' is assigned to but never used | |
| 17:59:31 | redrobot | I'm used to _ being used for throwaways in tests | |
| 17:59:47 | redrobot | but I was wondering if y'all handled it differently? | |
| 17:59:52 | stephenfin | Yeah, I thought that was usually ignored | |
| 18:00:04 | sean-k-mooney | it depens on the context i think | |
| 18:00:09 | stephenfin | Got a link to a build? We're just using flake8 + hacking | |
| 18:00:13 | sean-k-mooney | if you do _ = 4 | |
| 18:00:21 | sean-k-mooney | i think we will raise an error | |
| 18:00:27 | stephenfin | yeah, maybe | |
| 18:00:33 | sean-k-mooney | if you for _ , i in x: | |
| 18:00:38 | sean-k-mooney | i think it will be fine | |
| 18:00:42 | stephenfin | yup | |
| 18:00:43 | sean-k-mooney | or if you do multiple assingment | |
| 18:00:48 | stephenfin | in my experience, anyway | |
| 18:00:58 | redrobot | stephenfin, https://zuul.opendev.org/t/openstack/build/342ef93cbf464e01b72564695b2d610d | |
| 18:01:04 | sean-k-mooney | so _, x = sum_fun() | |
| 18:01:39 | stephenfin | redrobot: I'm not seeing that issue | |
| 18:01:45 | stephenfin | I'm seeing this | |
| 18:01:46 | stephenfin | ./nova/tests/unit/cmd/test_baseproxy.py:93:50: E241 multiple spaces after ',' | |
| 18:01:46 | stephenfin | ./nova/console/websocketproxy.py:326:32: F632 use ==/!= to compare str, bytes, and int literals | |
| 18:02:02 | sean-k-mooney | ya same i dont see it compain about _ | |
| 18:02:38 | redrobot | oh d'oh. It's complaining about _ when I run tox -e pep8 locally | |
| 18:02:44 | redrobot | but also the extra space | |
| 18:02:56 | redrobot | I'll follow up the patch with the fix for the space and hopefully that'll work. | |
| 18:03:09 | openstackgerrit | Sylvain Bauza proposed openstack/nova-specs master: Proposes NUMA topology with RPs https://review.opendev.org/552924 | |
| 18:03:17 | stephenfin | redrobot: Ah, yes, this https://review.opendev.org/#/c/679502/10/nova/tests/unit/console/test_websocketproxy.py@642 | |
| 18:03:21 | stephenfin | You don't need that assignment | |
| 18:03:29 | stephenfin | If you don't want the value, don't assign to anything | |
| 18:03:36 | stephenfin | so just | |
| 18:03:37 | stephenfin | websocketproxy.NovaWebSocketProxy(ssl_minimum_version=minver) | |
| 18:03:41 | stephenfin | instead of | |
| 18:03:42 | stephenfin | _ = websocketproxy.NovaWebSocketProxy(ssl_minimum_version=minver) | |
| 18:03:43 | sean-k-mooney | so yes dont do https://review.opendev.org/#/c/679502/10/nova/tests/unit/console/test_websocketproxy.py@631 | |
| 18:03:55 | stephenfin | 'zactly ^ | |
| 18:03:56 | sean-k-mooney | that should raise a style error | |
| 18:04:33 | redrobot | stephenfin, ack, I'll change that | |