| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-02-07 | |||
| 15:36:00 | sean-k-mooney | yes but you still cannot delte the nova vm | |
| 15:36:01 | Sundar | Sure. You are also updating the Cyborg side, right? | |
| 15:36:07 | sean-k-mooney | yep | |
| 15:36:31 | sean-k-mooney | i delete all my repos and confirm it pulle the correct version if i also set CYBORG_REPO and CYBORG_BRANCH | |
| 15:37:04 | Sundar | Could you expand on what you mean by Nova VM? Different from a devstack all-in-1 setup? | |
| 15:37:43 | sean-k-mooney | i mean if i do openstack server delete <uuid of vm with fake cyborg device> then you cant delete it | |
| 15:37:58 | gibi | Sundar: I agree that such refactor could move the focus away from the goal to merge the cyborg integration code to nova. And I understand the time pressure here. I'm fine doing the refactor on top of the series | |
| 15:38:23 | sean-k-mooney | the conductor got an unexpected reponce code form cyborg and the delete failed | |
| 15:38:56 | gibi | Sundar: I'm reviewing the series as we speak | |
| 15:39:56 | sean-k-mooney | Sundar: this could be related to the error handeling you and dansmith were talking about. i did not dig into it as it was late when i tried to delete the vm | |
| 15:40:20 | sean-k-mooney | Sundar: im going to recreate teh env with the latest version and see if the issue is still there | |
| 15:54:36 | Sundar | gibi: Thanks | |
| 15:55:18 | Sundar | sean-k-mooney: Please let me know how it goes. I may get on phone calls once in a while but I'll be around all morning PST. | |
| 15:58:39 | efried | Sundar: The refactor is already "on top" of the series, not folded in the middle. It shouldn't block anything else. | |
| 15:58:54 | efried | (It's on top of a patch that's in the middle, but it's its own tip) | |
| 15:59:22 | efried | I just put it out there to get agreement with dansmith about what the refactor should look like, and to satisfy myself that it could be done without too much trouble, so that I could be okay with the preceding patch as it is. | |
| 15:59:37 | efried | kashyap: ack, in queue | |
| 16:00:09 | kashyap | Thank you. | |
| 16:03:44 | sean-k-mooney | efried: which patch is the refactor https://review.opendev.org/#/c/706083/1 you dont mean https://review.opendev.org/#/c/704227/11 right | |
| 16:03:59 | sean-k-mooney | im planning to deploy https://review.opendev.org/#/c/704227/11 | |
| 16:04:00 | efried | the former | |
| 16:04:05 | sean-k-mooney | cool | |
| 16:05:52 | mriedem | dansmith: +2 on your hidden=null fix in case efried or melwitt want to approve | |
| 16:07:52 | spatel | sean-k-mooney: hey! i have few more question related NUMA, I did lots of testing with erlang and have pretty good result with numa tuning | |
| 16:08:09 | sean-k-mooney | thats good to hear | |
| 16:08:27 | sean-k-mooney | so memory seams to be your bottleneck then | |
| 16:08:35 | spatel | when i create vm with 16vcpu core just running on single numa node then result is freaking good | |
| 16:08:37 | dansmith | mriedem: thanks | |
| 16:09:00 | spatel | but if i create vm with 32vCPU and set numa_node=2 in flavor in that case result is 70% worst | |
| 16:09:49 | spatel | now question is how do i tell openstack to pin down vCPU with pCPU 1-0-1 ? | |
| 16:10:44 | spatel | I do have hw:cpu_policy=dedicated policy but its randomly mapping vCPU <--> pCPU | |
| 16:11:09 | spatel | sean-k-mooney: what do you suggest here? | |
| 16:11:43 | spatel | In short i want to make my VM fully NUMA map like bare metal has. | |
| 16:14:26 | sean-k-mooney | spatel: so it look like the erlang applciation is not numa aware | |
| 16:14:56 | spatel | sean-k-mooney: but if same erlang application i am running on bare metal it does work and result is good | |
| 16:14:59 | sean-k-mooney | meaning it is internally not numa affinitising its memory allocations | |
| 16:16:11 | sean-k-mooney | spatel: wehn you set hw:cpu_policy deicated it does a 1:1 mapping between cores on a virtual numa node to the a host numa node | |
| 16:16:24 | spatel | i thought if somehow openstack pin vcpu0 <--> pcpu0 , vcpu1 <--> pcpu1 so on... that would be great | |
| 16:16:30 | sean-k-mooney | so its not random it is numa aware | |
| 16:16:42 | sean-k-mooney | spatel: no it does not by design | |
| 16:17:05 | spatel | sean-k-mooney: look at this current mapping - http://paste.openstack.org/show/789225/ | |
| 16:17:11 | sean-k-mooney | but it will map all fo the cores in one geust numa node to the a singel numa node on the host | |
| 16:17:45 | sean-k-mooney | thats takeing a long time to load for some reason | |
| 16:18:47 | sean-k-mooney | paste.openstack.org is down for me it seams | |
| 16:19:21 | lyarwood | https://review.opendev.org/#/c/701430/ - trying to get my head around the required api samples for a microversion that changes behaviour but nothing in the request or response, does anyone know what I would need to add here? | |
| 16:19:30 | sean-k-mooney | ok it finally loaded | |
| 16:20:10 | sean-k-mooney | spatel: how many cores to you have on the host | |
| 16:20:54 | sean-k-mooney | im assuming the are 16 core cpus and you have hypter treading enabled? | |
| 16:22:22 | sean-k-mooney | spatel: can you provide the host capablities xml and the full guest xml | |
| 16:22:42 | spatel | Give me few min.. i am on phone.. | |
| 16:24:14 | sean-k-mooney | spatel: ok that xml fragment does not really look correct. | |
| 16:36:46 | efried | dansmith: I can push https://review.opendev.org/#/c/706331/ if you don't plan to reword that reno. | |
| 16:37:03 | dansmith | efried: it makes sense to me and nobody else has suggestions right? | |
| 16:38:21 | efried | dansmith: let me take a real swing at a reword. If I can't come up with something I like, I'll push it. | |
| 16:41:10 | efried | dansmith: do db migrations happen automatically as part of the upgrade process, or do users have to trigger them manually? (Or does it depend on the distro?) | |
| 16:41:24 | dansmith | efried: depends a lot | |
| 16:46:01 | efried | dansmith: done, see what you think. | |
| 16:46:29 | efried | dansmith: for me, the distinction of "apply the fix" versus "install a version that includes the fix" is where the confusion lies. | |
| 16:47:11 | dansmith | I totes don't get the substantive difference between your sentences and mine, but as such I'll be glad to change it.. just a sec | |
| 16:48:18 | efried | mriedem: if you're around -- does my suggestion improve anything IYO? | |
| 16:48:44 | openstackgerrit | Dan Smith proposed openstack/nova master: Fix instance.hidden migration and querying https://review.opendev.org/706331 | |
| 16:48:46 | efried | It becomes hard to see anymore having discussed it to death | |
| 16:49:11 | efried | dansmith: coulda added the link while you were at it :P | |
| 16:49:19 | dansmith | guh, will fix | |
| 16:49:27 | dansmith | working on the patch above this so I wanted to get back to that | |
| 16:50:17 | openstackgerrit | Dan Smith proposed openstack/nova master: Fix instance.hidden migration and querying https://review.opendev.org/706331 | |
| 16:50:26 | dansmith | efried: please check before I roll my tree forward again :) | |
| 16:51:42 | efried | dansmith: I'll build locally to make sure. You may need an extra newline between the paragraph and the link def. Also would be nice to link same from the `fixes` note (you don't need / can't include a second target def, they'll both use the same one) | |
| 16:52:20 | mriedem | you do | |
| 16:52:23 | mriedem | it blows up without that | |
| 16:52:28 | openstackgerrit | Dan Smith proposed openstack/nova master: Fix instance.hidden migration and querying https://review.opendev.org/706331 | |
| 16:52:32 | mriedem | http://rst.ninjs.org/ | |
| 16:52:33 | dansmith | like that? | |
| 16:53:07 | efried | dansmith: add trailing newline on the fixes one | |
| 16:53:15 | efried | s/newline/undescore/ | |
| 16:53:21 | dansmith | "for all you people who have now corrupted their database, I hope you appreciate that we waited quite a while to make sure the bug link was perfect" | |
| 16:53:39 | efried | Yeah, these five minutes are really going to make the difference. | |
| 16:53:47 | dansmith | a trailing newline where | |
| 16:53:50 | efried | If you want to go back to real work, I'll doodle with the formatting and fast approve it. | |
| 16:53:50 | dansmith | ? | |
| 16:54:00 | efried | not a newline, the second bug link is backticked but not underscored. | |
| 16:54:02 | dansmith | no, it's very important to me that I get this right | |
| 16:54:10 | mriedem | you need the .. | |
| 16:54:10 | dansmith | oh dammit | |
| 16:54:10 | openstack | Launchpad bug 1862205 in OpenStack Compute (nova) "Instances not visible when hidden=NULL" [Critical,In progress] - Assigned to Dan Smith (danms) | |
| 16:54:10 | mriedem | .. _bug 1862205: https://launchpad.net/bugs/1862205 | |
| 16:55:00 | openstackgerrit | Dan Smith proposed openstack/nova master: Fix instance.hidden migration and querying https://review.opendev.org/706331 | |
| 16:55:20 | efried | this would be a great time for that fast-reno tool I've been meaning to write. The releasenotes target takes forEVER to build. | |
| 16:55:50 | efried | there, yeah, ps9 looks right to me. | |
| 16:56:14 | dansmith | ttfl | |
| 16:56:40 | stephenfin | efried: We need to stop 'rm -rf' ing the built docs | |
| 16:56:52 | efried | is that what does it? | |
| 16:57:08 | efried | I'll try that | |
| 16:57:26 | mriedem | efried: dansmith: so PS9 might work, but i've seen reno complain about links in weird ways between sections, so we'll see if the link defined in the first section is honored in the second | |
| 16:57:45 | dansmith | mriedem: efried said it was only needed once | |
| 16:57:58 | mriedem | i guess we'll know in a couple of hours :) | |
| 16:58:04 | efried | should be the case, but it depends how reno does its build. | |
| 16:58:07 | stephenfin | Sphinx builds doctrees and reuses those when possible. Unfortunately it occasionally breaks if you e.g. remove a document that previously existed (like by changing to an older branch) | |
| 16:58:13 | stephenfin | probably less on an issue for renos | |
| 17:01:19 | efried | stephenfin: In the specs repo I wrote a tool that would only build one directory at a time. It was a fiddly thing to figure out exactly how to word the sphinx-build command. In this case... if I could restrict it to building just $release.rst it would probably be equivalent. | |