| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-02-06 | |||
| 15:13:42 | sean-k-mooney | so floating ips are not ports and do not normally have port details | |
| 15:13:46 | dansmith | okay just wanted to see what used it and that it was okay with None | |
| 15:14:02 | sean-k-mooney | there is a neutorn extnion to expose the port_details of the prot that they are attached too when attached | |
| 15:14:13 | sean-k-mooney | but its optional | |
| 15:14:19 | sean-k-mooney | apparently | |
| 15:14:35 | stephenfin | mtreinish: https://github.com/testing-cabal/subunit/pull/40 for reference (I think I referenced it the stestr PR) | |
| 15:17:31 | sean-k-mooney | stephenfin: when did we deprecate teh proxy api | |
| 15:18:08 | dansmith | stephenfin: so because this broke the neutron gate, I assume we have tempest tests that actually use this proxy api, right? | |
| 15:18:17 | stephenfin | sean-k-mooney: nova/api/openstack/api_version_request.py tells me 2.36 | |
| 15:18:50 | stephenfin | dansmith: correct. the reason we didn't see it was because we test using ML2-OVS or ML2-LB (I don't know which) in the gate, not ML2-OVN | |
| 15:18:56 | sean-k-mooney | well it was only added to neutron in 2018 | |
| 15:18:57 | sean-k-mooney | https://github.com/openstack/neutron-lib/commit/24a0877d1d234830a36794388bb342d3d91b9230 | |
| 15:19:05 | sean-k-mooney | which is well after we had deprecated it | |
| 15:19:17 | dansmith | stephenfin: yeah I get that. are the tests _testing_ the proxy or using it out of convenience? | |
| 15:19:19 | sean-k-mooney | 2.36 was newton | |
| 15:19:48 | stephenfin | sean-k-mooney: Yup, it's not the proxy API that was wrong, it was how I updated things to stop using nova-network o.vo's | |
| 15:20:29 | sean-k-mooney | stephenfin: what im saying is the proxy api should not conatin that info | |
| 15:20:54 | sean-k-mooney | we deprecated itn in 2016 that extention was only added in 2018 | |
| 15:21:15 | dansmith | sean-k-mooney: I'm guessing we had it in there before via other mechanisms | |
| 15:21:18 | sean-k-mooney | so there should be noting relying on it for fip port details | |
| 15:21:28 | sean-k-mooney | ya proably | |
| 15:21:34 | dansmith | sean-k-mooney: looking at the older code I was originally looking at, it was still putting those things in there but in a different way | |
| 15:21:38 | stephenfin | dansmith: That I don't know. Maybe ralonsoh knows since he had a patch up against neutron to disable the broken job yesterday | |
| 15:21:53 | sean-k-mooney | the correct way to look this up before was you get all the ports attach to the vm then get the fip for each port | |
| 15:22:05 | openstackgerrit | Brin Zhang proposed openstack/nova master: Add SYSTEM_READER role to servers actions API https://review.opendev.org/706179 | |
| 15:22:12 | ralonsoh | stephenfin, yes, we are marking this CI job as non-voting | |
| 15:22:13 | stephenfin | sean-k-mooney: yeah, what dansmith said. We were getting this information by always making a second call to neutron for the ports | |
| 15:22:41 | stephenfin | ralonsoh: Which job is it? dansmith is curious as to what's actually using these deprecated APIs | |
| 15:22:49 | sean-k-mooney | stephenfin: yes which is the correct way to do it if the extention is not available | |
| 15:23:24 | stephenfin | sean-k-mooney: I know. I made a mistake when updating things because I didn't know port_details was optional and figured I should use it | |
| 15:23:31 | dansmith | ralonsoh: job, but specifically which test(s) | |
| 15:23:51 | ralonsoh | dansmith, an example of CI job failing https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_db7/705779/1/check/neutron-ovn-tempest-ovs-release/db7becd/testr_results.html | |
| 15:23:54 | stephenfin | In hindsight, it should have been a separate patch :( | |
| 15:24:09 | ralonsoh | stephenfin, dansmith those ones with exception message | |
| 15:24:11 | ralonsoh | "<class 'nova.exception.PortNotFound'>" | |
| 15:24:28 | dansmith | ralonsoh: okay so some specifically for that api, but also some general ones it looks like | |
| 15:24:54 | stephenfin | dansmith: I assume you're suggesting that the general ones shouldn't be using the proxy APIs? | |
| 15:24:55 | spatel | sean-k-mooney: morning | |
| 15:25:09 | stephenfin | i.e. test_server_basic_ops | |
| 15:25:27 | sean-k-mooney | stephenfin: ya i think the secnairo test shoudl be updated | |
| 15:25:40 | spatel | Could you check this CPU policy for vm - http://paste.openstack.org/show/789225/ | |
| 15:25:46 | dansmith | stephenfin: well, maybe, but it's also maybe interesting that if the alternative is very onerous ... that tells us something | |
| 15:26:18 | sean-k-mooney | the other way is not really that hard. its just more api requests | |
| 15:26:23 | stephenfin | dansmith: that everyone is probably ignoring us and using these deprecated APIs anyway? :) | |
| 15:26:31 | dansmith | stephenfin: like, if the alternative is 20 calls to neutron and a bunch of local mapping, then that may be an indication that we kinda messed up | |
| 15:26:38 | dansmith | stephenfin: indeed | |
| 15:27:20 | stephenfin | less users = less bugs = more time for stephenfin to eat popcorn | |
| 15:29:15 | sean-k-mooney | the old way is just neutron port list device-id=<vm uuid> then you loop over that calling /v2.0/floatingips?port_id=<port uuid>) | |
| 15:30:25 | sean-k-mooney | so you get the port detalis form the orginal call to list all the ports on a vm and then map it to the fip from the second call | |
| 15:30:47 | dansmith | yeah, this is exactly what I'm talking about :) | |
| 15:30:55 | sean-k-mooney | if you know the fip you jsut wrok backward first do a fip show get the port and then do a port show | |
| 15:31:23 | sean-k-mooney | port_details on the fip is a proxy api in neutorn to get info form a different resouce | |
| 15:31:38 | sean-k-mooney | the added it as an optional exteion to make it 1 call | |
| 15:32:02 | sean-k-mooney | but each ml2 driver has to advertise support and ovn did not | |
| 15:32:18 | kashyap | stephenfin: Hehe, figured as much. (And I like the expression) | |
| 15:43:46 | Sundar | sean-k-mooney: Re. your message "that was the latest set that were up at that point", it got updated on Jan 10 to remove the specific exception that you posted: https://review.opendev.org/#/c/698846/2/cyborg/common/nova_client.py. Please rebase if your env is older. Sorry for the trouble. | |
| 15:46:16 | openstackgerrit | Sylvain Bauza proposed openstack/nova-specs master: Proposes NUMA topology with RPs https://review.opendev.org/552924 | |
| 15:46:26 | sean-k-mooney | Sundar: i used the local.conf i posted | |
| 15:46:52 | sean-k-mooney | which was pulling in form a new branch | |
| 15:47:02 | sean-k-mooney | ill double check | |
| 15:47:36 | openstackgerrit | Merged openstack/nova master: libvirt: Rename _is_storage_shared_with to _is_path_shared_with https://review.opendev.org/693337 | |
| 15:48:29 | sean-k-mooney | strang it seam to have checkout out master... | |
| 15:49:00 | openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Merge unnecessary 'NovaProxyRequestHandlerBase' separation https://review.opendev.org/705655 | |
| 15:49:08 | openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Remove 'run_once' helper https://review.opendev.org/705656 | |
| 15:49:14 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tox: Integrate mypy https://review.opendev.org/676208 | |
| 15:49:24 | openstackgerrit | Stephen Finucane proposed openstack/nova master: mypy: Add type annotations to 'nova.pci' https://review.opendev.org/676209 | |
| 15:49:31 | openstackgerrit | Stephen Finucane proposed openstack/nova master: mypy: Add nova.cmd, nova.conf, nova.console https://review.opendev.org/705657 | |
| 15:49:43 | openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: mypy: Add type annotations to top-level modules https://review.opendev.org/705658 | |
| 15:50:04 | sean-k-mooney | Sundar: im using enable_plugin cyborg https://review.opendev.org/openstack/cyborg refs/changes/61/703261/1 | |
| 15:50:17 | sean-k-mooney | that should have checkout the specific version | |
| 15:52:43 | stephenfin | bauzas: Care to do me the honour? https://review.opendev.org/#/c/703796/ | |
| 15:52:51 | bauzas | sure | |
| 15:53:16 | bauzas | sean-k-mooney: efried: others, I'm glad to say I'm eventually done with https://review.opendev.org/552924 | |
| 15:53:18 | sean-k-mooney | Sundar: it looks like there is either a devstack bug or the cybog plugin is nit support the gitref | |
| 15:53:25 | sean-k-mooney | Sundar: https://github.com/openstack/devstack/blob/ae73b23373f8673722fac2fbd349fa2075fda8d6/doc/source/plugins.rst#plugin-interface | |
| 15:53:31 | efried | bauzas: that's what YOU think :P | |
| 15:53:53 | bauzas | honestly, thanks you all | |
| 15:54:16 | bauzas | but I'm dead with this spec :p | |
| 15:54:26 | bauzas | no battery left. | |
| 15:55:39 | Sundar | sean-k-mooney: I think it is the latter: https://opendev.org/openstack/cyborg/src/branch/master/devstack/lib/cyborg#L85 | |
| 15:55:39 | sean-k-mooney | bauzas: https://www.deathwishcoffee.com/ i have a friend that quite likes it | |
| 15:56:03 | bauzas | sean-k-mooney: I've been told that an english tea is *always* black with milk | |
| 15:56:26 | bauzas | can't tell what an english coffee is then | |
| 15:56:44 | sean-k-mooney | Sundar: ok i can just define CYBORG_BRANCH in my local.conf | |
| 15:57:04 | sean-k-mooney | but you actully dont need to and should not clone the git repo in the plugin | |
| 15:57:12 | sean-k-mooney | that is done for you by devstack | |
| 15:58:43 | dansmith | sean-k-mooney: devstack or devstack-gate? | |
| 15:59:23 | sean-k-mooney | bauzas: are you confusing me with an english man becasue as a irish eu citizen i coudl be offended by that. also irish <anything> usally meens add good wiskey | |
| 15:59:47 | sean-k-mooney | *irish <beverage or food item> | |
| 16:00:00 | sean-k-mooney | dansmith: devstack | |
| 16:00:15 | dansmith | sean-k-mooney: the other projects have git_clone calls in their modules | |
| 16:00:55 | sean-k-mooney | so in the gate they are disabled via a diffenert parmater | |
| 16:01:24 | mnaser | ok, i'm absolutely hitting a wall. nova list --all-tenants returns only 11 vms, but i have 1297 vm_state='ACTIVE' instances. instance_mappings are correct in nova_api | |
| 16:01:30 | sean-k-mooney | but the plugin interface specific was designed for devstack to do the clone of the pugin repo | |
| 16:01:34 | mnaser | i double checked the db creds inside nova_api.cell_mappings | |
| 16:01:49 | sean-k-mooney | anyway its not a big deal | |
| 16:02:08 | mnaser | the crazier thing is running something like placement heal allocations only returns 11 instances only, which that is doing objects.InstaceList.... | |
| 16:02:51 | mnaser | so its note even an API level problem, it's in the db layer (i assume objects.* API inside nova-manage commands talks directly to db, not via conductor?) | |
| 16:03:53 | dansmith | mnaser: nova-manage does not talk to conductor | |
| 16:04:08 | mnaser | ok, so that's what i thought as well | |