| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-02-05 | |||
| 13:05:12 | stephenfin | bauzas: oh, whoops https://review.opendev.org/#/c/705760 | |
| 13:05:20 | sean-k-mooney | not in recent times but i had to swap to spice at one point to work around it | |
| 13:05:41 | bauzas | ah | |
| 13:05:47 | bauzas | will look at it in 30 mins | |
| 13:05:53 | stephenfin | perfect, thanks :) | |
| 13:05:56 | sean-k-mooney | mriosfer: anyway hopefully that will help | |
| 13:06:12 | sean-k-mooney | im going to go get lunch | |
| 13:07:26 | mriosfer | yes be sure that yes at least much more than google | |
| 14:15:24 | gibi | stephenfin: I have a question in https://review.opendev.org/#/c/705784/1/nova/network/neutron.py@2662 | |
| 14:24:26 | bauzas | sean-k-mooney: efried: I'm currently writing a new revision for https://review.opendev.org/#/c/552924 given https://etherpad.openstack.org/p/mem_page_size_and_placement | |
| 14:24:40 | bauzas | sean-k-mooney: efried: and I'm a bit afraid about a possible issue | |
| 14:25:13 | bauzas | should we always ask for MEMORY_PAGE_SIZE_SMALL ? | |
| 14:25:37 | bauzas | I mean, if so, we won't get hosts not having NUMA topogilies | |
| 14:25:42 | bauzas | topologies | |
| 14:26:45 | bauzas | eg. a flavor with VCPU=2 and MEMORY_MB=4096 | |
| 14:27:24 | bauzas | (see https://etherpad.openstack.org/p/mem_page_size_and_placement L62) | |
| 14:31:04 | stephenfin | gibi: replied | |
| 14:31:16 | stephenfin | gibi: tl;dr: in theory yes, but I don't think we need to worry about it | |
| 14:31:22 | stephenfin | cos quotas | |
| 14:32:25 | dansmith | stephenfin: bauzas: replied in the neutron fix thing.. I didn't -1 and there was no need to hold it for me, I was just unsure (still am a little) but if it's right and works... | |
| 14:32:29 | gibi | stephenfin: OK, thanks | |
| 14:34:10 | efried | bauzas: Remember, these queries are only for flavors that *do* request a NUMA topology. | |
| 14:34:33 | bauzas | efried: ok, if so I was confused by L62 | |
| 14:34:45 | bauzas | and I agree with you | |
| 14:34:52 | efried | in the spec or the etherpad? | |
| 14:35:01 | bauzas | in the etherpad like I said | |
| 14:35:26 | bauzas | dansmith: ack, like I said, I'm not really a network expert so I was afraid you should have concerns | |
| 14:35:51 | efried | bauzas: Yeah, so best to confirm with sean-k-mooney, but I think if no page size is requested, you want to add MEMORY_PAGE_SIZE_SMALL, because that's the default today. | |
| 14:35:53 | bauzas | you at least know it better than me :) | |
| 14:36:04 | bauzas | efried: that's my point | |
| 14:36:15 | efried | bauzas: And no, you won't land on a host that doesn't have the NUMA split. But you weren't going to land there anyway, because segregation. | |
| 14:36:19 | bauzas | efried: if you don't ask for page sizes, we should call placement with this trait | |
| 14:36:30 | bauzas | we shouldn't* grah | |
| 14:36:30 | efried | yes | |
| 14:36:36 | efried | we *should* | |
| 14:36:42 | efried | because otherwise you might land on huge pages | |
| 14:36:49 | efried | which we don't want. | |
| 14:36:54 | bauzas | efried: then, if so, you won't get other hosts | |
| 14:37:19 | efried | If by "other hosts" you mean flat non-NUMA hosts, that's correct, and that's what we want. | |
| 14:37:21 | bauzas | the ones that don't have this trait, ie. the ones that weren't modified | |
| 14:37:28 | bauzas | right | |
| 14:37:30 | bauzas | but, | |
| 14:37:37 | bauzas | see the problem | |
| 14:37:43 | efried | I don't | |
| 14:37:45 | efried | not yet | |
| 14:37:48 | bauzas | example | |
| 14:37:51 | bauzas | : | |
| 14:38:14 | bauzas | I'm an operator and I don't configure any host for asking a NUMA topology | |
| 14:38:26 | bauzas | so, none of my hosts have this trait | |
| 14:38:34 | bauzas | now, I have existing flavors | |
| 14:38:45 | bauzas | but I upgrade to Ussuri | |
| 14:39:01 | bauzas | and then the scheduler now transforms the Placement call to ask for this trait | |
| 14:39:10 | bauzas | then I will get NoValidHosts | |
| 14:39:12 | stephenfin | dansmith: replied (you read it correctly, yeah) | |
| 14:40:01 | bauzas | efried: I don't see a way to say : ask for this trait for all NUMA hosts, but don't ask for it for the others | |
| 14:41:19 | efried | bauzas: We talked about this yesterday a bit. You're correct: if you upgrade but don't switch your hosts to NUMA-aware, you won't be able to land NUMA flavors. That's as designed. | |
| 14:41:24 | dansmith | stephenfin: can you read my reply just now in that case? | |
| 14:42:22 | sean-k-mooney | efried: i need to sumerise the options for the config option in the spec form the irc conversation and other i had. ill try and do that in about an hour | |
| 14:42:37 | sean-k-mooney | i need to run to the bank now | |
| 14:42:57 | stephenfin | dansmith: I think what's there is correct | |
| 14:43:28 | stephenfin | line 2678 is going to retrieve the list of ports, which will look like this https://docs.openstack.org/api-ref/network/v2/?expanded=list-ports-detail#list-ports | |
| 14:44:22 | bauzas | efried: I'm unclear sorry | |
| 14:44:41 | sean-k-mooney | bauzas: efried if we go with the bool config option one of the out standing question is the default for that value. long term it should default to true. not sure if we should default to true in u or v however | |
| 14:44:42 | efried | bauzas: one way or another, you're going to have to decide which hosts are going to NUMA and which are going to be flat. | |
| 14:44:46 | sean-k-mooney | any brb | |
| 14:44:48 | dansmith | stephenfin: I was going on the blob you put in the comment, but maybe that's wrong? I don't see a nested port_details in he api ref like you have in your blob | |
| 14:44:59 | stephenfin | dansmith: Oh, there isn't one | |
| 14:45:08 | stephenfin | This is something I made up | |
| 14:45:20 | stephenfin | wait | |
| 14:45:46 | bauzas | efried: if we say that this trait is needed *anyway* (eg. even with a standard flavor asking for memory and vcpus), then I'm afraid we would get NoValidHosts for "flat" hosts | |
| 14:46:04 | stephenfin | dansmith: Sorry, confusing myself. I made up the 'network_details' field | |
| 14:46:34 | stephenfin | but the port_details field _is_ returned by the '/v2.0/floatingips' API https://docs.openstack.org/api-ref/network/v2/?expanded=list-ports-detail,list-floating-ips-detail#list-floating-ips | |
| 14:46:47 | bauzas | efried: unless "flat" hosts also have this trait | |
| 14:46:51 | efried | bauzas: we were going to get that anyway. One way or another, with the proposed segregation, NUMA flavors will all & only land on hosts with the NUMA flag on; and flat flavors will all & only land on hosts with the NUMA flag off. | |
| 14:46:58 | dansmith | stephenfin: right, isn't that what you're trying to fake/fill-in here? | |
| 14:47:01 | efried | That's what we *want* | |
| 14:47:14 | bauzas | efried: the latter is not what we agreed | |
| 14:47:14 | stephenfin | port_details, yeah | |
| 14:47:17 | stephenfin | but it's not always there | |
| 14:47:25 | efried | um | |
| 14:47:27 | stephenfin | it's dependent on the extension being present/enabled | |
| 14:47:31 | dansmith | stephenfin: right, so I get that part | |
| 14:47:35 | bauzas | efried: flat flavors will get NoValidHosts | |
| 14:47:47 | bauzas | because we're asking for a trait anyway | |
| 14:48:04 | efried | They will only get NVH if you don't have any flat hosts in your cloud | |
| 14:48:06 | dansmith | stephenfin: the thing I'm asking is whether or not ports[port_id] is equivalent to the port_details field on that api, because according to the example blob in your comment from just now, it should have port_details *inside* it | |
| 14:48:19 | bauzas | efried: no, again | |
| 14:48:23 | bauzas | see L62 | |
| 14:48:25 | dansmith | stephenfin: but I don't see that on the list_ports api-ref, so I think that example blob is wrong about that nesting.. right? | |
| 14:48:39 | bauzas | if we ask for MEMORY_PAGE_SIZE_SMALL, then all flat hosts won't get it | |
| 14:48:50 | sean-k-mooney | bauzas: we wont alway add the trait:numa_node=require trait only if you request numa | |
| 14:48:58 | efried | You only add MEMORY_PAGE_SIZE_SMALL if you're translating a *NUMA* flavor | |
| 14:48:58 | efried | bauzas: ohh, I see the confusion. | |
| 14:49:03 | efried | yeah, what sean-k-mooney said. | |
| 14:49:17 | bauzas | again, L62 is very confusing | |
| 14:49:28 | efried | The etherpad is only talking about what we do for NUMA-aware hosts | |
| 14:49:46 | efried | and yeah, the etherpad is confusing, so we should really write it more cleanly, say, in a spec :P | |
| 14:49:47 | bauzas | there are gaps then that I need to provide | |
| 14:50:03 | bauzas | ok, then we need to trigger exactly when asking for this trait | |
| 14:50:33 | stephenfin | dansmith: Not sure I get you, so apologies if I repeat stuff you already know | |